[PATCH] D60821: [clangd] Emit better error messages when rename fails.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:57 public: + RefactoringResultCollector(DiagnosticsEngine &DE) : Diags(DE) {} void handleError(llvm::Error Err) override { why inject the DE here (and handle mapping error

[PATCH] D60719: Demonstrate how to fix freestanding for memcpy

gchatelet added a comment. In D60719#1470632 , @t.p.northover wrote: > > IIUC freestanding environment should not rely on memcpy being present so my > > take on it was that by "fixing" freestanding I could have my cake and eat > > it too. > > The formal

[PATCH] D60828: [ARM] Fix armv8 features tree and add fp16fml

dnsampaio marked 5 inline comments as done. dnsampaio added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:443 HasLegalHalfType = true; + HW_FP |= HW_FP_SP | HW_FP_DP | HW_FP_HP; + FPU |= VFP4FPU; ostannard wrote: > Is it always correct t

[PATCH] D60857: [clang-tidy] Address post-commit comments

hokein created this revision. hokein added a reviewer: alexfh. Herald added a subscriber: xazax.hun. Herald added a project: clang. hokein updated this revision to Diff 195692. hokein added a comment. Cleanup. Also add a test to verify clang-tidy only apply the first alternative fix. Repositor

[PATCH] D60857: [clang-tidy] Address post-commit comments

hokein updated this revision to Diff 195692. hokein added a comment. Cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60857/new/ https://reviews.llvm.org/D60857 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/test/cla

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

sammccall marked 9 inline comments as done. sammccall added inline comments. Comment at: clangd/Diagnostics.cpp:280 + Main.relatedInformation->push_back(std::move(RelInfo)); +} } ilya-biryukov wrote: > NIT: maybe call `OutFn` and return here to avoid

[PATCH] D60827: [rename] Deduplicate symbol occurrences

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks Comment at: clang-tools-extra/unittests/clangd/ClangdTests.cpp:1160 +TEST_F(ClangdVFSTest, NoDuplicatedTextEditsOnRename) { + MockFSProvider FS; ---

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

sammccall updated this revision to Diff 195694. sammccall marked an inline comment as done. sammccall added a comment. Rebase and address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60267/new/ https://reviews.llvm.org/D60267 Files: cl

[PATCH] D60828: [ARM] Fix armv8 features tree and add fp16fml

dnsampaio planned changes to this revision. dnsampaio added a comment. Waiting for the outcome of D60691 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60828/new/ https://reviews.llvm.org/D60828 ___

[PATCH] D60821: [clangd] Emit better error messages when rename fails.

hokein updated this revision to Diff 195701. hokein marked 4 inline comments as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60821/new/ https://reviews.llvm.org/D60821 Files: clang-tools-extra/cla

[PATCH] D60821: [clangd] Emit better error messages when rename fails.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:57 public: + RefactoringResultCollector(DiagnosticsEngine &DE) : Diags(DE) {} void handleError(llvm::Error Err) override { sammccall wrote: > why inject the DE here (and hand

r358654 - [CUDA][Windows] Restrict long double device functions declarations to Windows

Author: emankov Date: Thu Apr 18 03:08:55 2019 New Revision: 358654 URL: http://llvm.org/viewvc/llvm-project?rev=358654&view=rev Log: [CUDA][Windows] Restrict long double device functions declarations to Windows As agreed in D60220, make long double declarations unobservable on non-windows platf

[PATCH] D60818: [CUDA][Windows] restrict long double device functions declarations to Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rC358654: [CUDA][Windows] Restrict long double device functions declarations to Windows (authored by emankov, committed by ). Changed prior to commit: https://reviews.llvm.org/D60818?vs=195546&id=195704#t

[PATCH] D60853: clang-format converts a keyword macro definition to a macro function

MyDeveloperDay added a comment. LGTM Comment at: clang/lib/Format/UnwrappedLineParser.cpp:808 - if (FormatTok->Tok.getKind() != tok::identifier) { + if (!FormatTok->Tok.getIdentifierInfo()) { IncludeGuard = IG_Rejected; Is this equivalent to saying som

[PATCH] D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro

MyDeveloperDay abandoned this revision. MyDeveloperDay added a comment. Abandoning in favor of D60853: clang-format converts a keyword macro definition to a macro function Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60362/new/

[PATCH] D60821: [clangd] Emit better error messages when rename fails.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! I do think it can be further simplified, but if not then land as-is. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:57 public: + RefactoringResult

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

sammccall updated this revision to Diff 195707. sammccall added a comment. Remove accidental copy/paste in lit test. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60267/new/ https://reviews.llvm.org/D60267 Files: clangd/ClangdLSPServer.cpp clan

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

sammccall updated this revision to Diff 195706. sammccall added a comment. Propagate the capability to Diagnostics, add lit test. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60267/new/ https://reviews.llvm.org/D60267 Files: clangd/ClangdLSPServ

[clang-tools-extra] r358655 - [clangd] Log verbosely (LSP bodies) in lit tests. NFC

Author: sammccall Date: Thu Apr 18 03:32:08 2019 New Revision: 358655 URL: http://llvm.org/viewvc/llvm-project?rev=358655&view=rev Log: [clangd] Log verbosely (LSP bodies) in lit tests. NFC Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp Modified: clang-tools-extra/trunk/clangd/

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

Anastasia added a comment. In D60835#1470805 , @riccibruno wrote: > By the way, I am wondering about how much this is tested. I did look quickly > in `test/PCH` and it appears that there are only 3 (short) tests : > `ocl_types.cl`, `opencl-extensions.cl`

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

kadircet added inline comments. Comment at: clangd/Diagnostics.cpp:271 + if (!Note.AbsFile) { +log("Dropping note from unknown file: {0}", Note); +continue; ilya-biryukov wrote: > Maybe `vlog`? This is what we use for dropped diagnostics, sho

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clangd/Diagnostics.cpp:271 + if (!Note.AbsFile) { +log("Dropping note from unknown file: {0}", Note); +continue; kadircet wrote: > ilya-biryukov wrote: >

[PATCH] D60821: [clangd] Emit better error messages when rename fails.

hokein updated this revision to Diff 195715. hokein marked an inline comment as done. hokein added a comment. Simplify the code further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60821/new/ https://reviews.llvm.org/D60821 Files: clang-tools-

[clang-tools-extra] r358658 - [clangd] Emit better error messages when rename fails.

Author: hokein Date: Thu Apr 18 04:35:22 2019 New Revision: 358658 URL: http://llvm.org/viewvc/llvm-project?rev=358658&view=rev Log: [clangd] Emit better error messages when rename fails. Summary: Currently we emit an unfriendly "clang diagnostic" message when rename fails. This patch makes clan

[PATCH] D60821: [clangd] Emit better error messages when rename fails.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358658: [clangd] Emit better error messages when rename fails. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D60821?vs=195715&id=195717#toc Repository: rCTE

[PATCH] D60627: [MSVC] Use the correct casing of HostX64/HostX86

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60627/new/ https://reviews.llvm.org/D60627 ___ cfe-c

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

sammccall added a comment. Discussed further offline - it's not clear that expressing the flattening as LSP diagnostic -> LSP diagnostic is better than the current Diag -> LSP diagnostic. So that followup probably won't happen, and there isn't that much to be gained from "unifying" the behavio

r358661 - [Sema] Delete unused parameters/variables

Author: maskray Date: Thu Apr 18 05:35:02 2019 New Revision: 358661 URL: http://llvm.org/viewvc/llvm-project?rev=358661&view=rev Log: [Sema] Delete unused parameters/variables Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL: http://llvm.org/viewvc/llv

[PATCH] D60857: [clang-tidy] Address post-commit comments

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/alternative-fixes.cpp:1-7 +// RUN: clang-tidy -checks='-*,llvm-namespace-comment,clang-diagnostic-*' %s -- \ +// RUN: | FileCheck -implicit-check-not='{{warning|error|note}}:' %s + +// Verify clang-tidy

[PATCH] D60857: [clang-tidy] Address post-commit comments

hokein added inline comments. Comment at: clang-tools-extra/test/clang-tidy/alternative-fixes.cpp:1-7 +// RUN: clang-tidy -checks='-*,llvm-namespace-comment,clang-diagnostic-*' %s -- \ +// RUN: | FileCheck -implicit-check-not='{{warning|error|note}}:' %s + +// Verify clang-tidy

[PATCH] D60857: [clang-tidy] Address post-commit comments

hokein updated this revision to Diff 195720. hokein marked an inline comment as done. hokein added a comment. Use check_clang_tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60857/new/ https://reviews.llvm.org/D60857 Files: clang-tools-extra

[PATCH] D60865: [clangd] Use llvm::set_thread_priority in background-index

kadircet created this revision. kadircet added a reviewer: gribozavr. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, krytarowski. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D60865 Files: clangd/T

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

riccibruno added a comment. In D60835#1471498 , @Anastasia wrote: > In D60835#1470805 , @riccibruno > wrote: > > > By the way, I am wondering about how much this is tested. I did look > > quickly in `test/PCH` and

[PATCH] D60867: [clang][CIndex] Use llvm::set_thread_priority

kadircet created this revision. kadircet added reviewers: jkorous, gribozavr. Herald added subscribers: cfe-commits, arphaman, dexonsmith. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D60867 Files: tools/libclang/CIndex.cpp Index: tools/libclang/CIndex.cpp =

r358662 - [MSVC] Use the correct casing of HostX64/HostX86

Author: mstorsjo Date: Thu Apr 18 06:27:31 2019 New Revision: 358662 URL: http://llvm.org/viewvc/llvm-project?rev=358662&view=rev Log: [MSVC] Use the correct casing of HostX64/HostX86 If accessing the MSVC installation root directly on a case sensitive filesystem, these details matter. Different

[PATCH] D60627: [MSVC] Use the correct casing of HostX64/HostX86

This revision was automatically updated to reflect the committed changes. Closed by commit rL358662: [MSVC] Use the correct casing of HostX64/HostX86 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D60857: [clang-tidy] Address post-commit comments

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. There's one more nit. Otherwise good to go. Thanks! Comment at: clang/include/clang/Tooling/Core/Diagnostic.h:97 +/// Get the first fix to apply for this diagnostic. +/// Re

[clang-tools-extra] r358664 - [clangd] Use llvm::set_thread_priority in background-index

Author: kadircet Date: Thu Apr 18 06:46:40 2019 New Revision: 358664 URL: http://llvm.org/viewvc/llvm-project?rev=358664&view=rev Log: [clangd] Use llvm::set_thread_priority in background-index Reviewers: gribozavr Subscribers: krytarowski, ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, jfb

[PATCH] D60865: [clangd] Use llvm::set_thread_priority in background-index

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358664: [clangd] Use llvm::set_thread_priority in background-index (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D60865?vs=195721&id=195730#toc Repository:

r358665 - [clang][CIndex] Use llvm::set_thread_priority

Author: kadircet Date: Thu Apr 18 06:49:20 2019 New Revision: 358665 URL: http://llvm.org/viewvc/llvm-project?rev=358665&view=rev Log: [clang][CIndex] Use llvm::set_thread_priority Reviewers: jkorous, gribozavr Subscribers: dexonsmith, arphaman, cfe-commits Tags: #clang Differential Revision:

[PATCH] D60867: [clang][CIndex] Use llvm::set_thread_priority

This revision was automatically updated to reflect the committed changes. Closed by commit rC358665: [clang][CIndex] Use llvm::set_thread_priority (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D60867?vs=195725&id=195731#toc Repository: rC Clang CHA

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7956 // Map other list items in the map clause which are not captured variables -// but "declare target link" global variables., +// but "declare target link" global variables. for (const

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. >> We could still go for something like the following but accept that some a >> random failure might happen not necessarily on a commit that introduces it? > > I am not sure that this is

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik added a comment. Ping. Ilya? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D60857: [clang-tidy] Address post-commit comments

hokein updated this revision to Diff 195733. hokein added a comment. fix doxygen comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60857/new/ https://reviews.llvm.org/D60857 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-ex

r358666 - [clang-tidy] Address post-commit comments

Author: hokein Date: Thu Apr 18 07:18:14 2019 New Revision: 358666 URL: http://llvm.org/viewvc/llvm-project?rev=358666&view=rev Log: [clang-tidy] Address post-commit comments Summary: Also add a test to verify clang-tidy only apply the first alternative fix. Reviewers: alexfh Subscribers: xazax

[clang-tools-extra] r358666 - [clang-tidy] Address post-commit comments

Author: hokein Date: Thu Apr 18 07:18:14 2019 New Revision: 358666 URL: http://llvm.org/viewvc/llvm-project?rev=358666&view=rev Log: [clang-tidy] Address post-commit comments Summary: Also add a test to verify clang-tidy only apply the first alternative fix. Reviewers: alexfh Subscribers: xazax

[PATCH] D60857: [clang-tidy] Address post-commit comments

This revision was automatically updated to reflect the committed changes. Closed by commit rC358666: [clang-tidy] Address post-commit comments (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D60857?vs=195733&id=195734#toc Repository: rC Clang CHANGES S

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:476 + isa(CNew))) { +SemaRef.Diag(Loc, + diag::err_omp_target_before_requires) ABataev wrote: > DSAStack usually i

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:476 + isa(CNew))) { +SemaRef.Diag(Loc, + diag::err_omp_target_before_requires) gtbercea wrote: > ABataev wrote: > > DSAStack usually is not used for diagnosti

[PATCH] D60868: [clang-format] Fix an assertion failure

alexfh created this revision. alexfh added a reviewer: krasimir. Herald added a project: clang. Before this patch clang-format crashed when trying to issue a diagnostic about an unsupported BOM. See the bug report here: https://bugs.llvm.org/show_bug.cgi?id=26032 Repository: rG LLVM Github M

[PATCH] D60558: [clang-format] Fix indent of trailing raw string param after newline

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60558/new/ https://reviews.llvm.org/D60558 __

[PATCH] D58033: Add option for emitting dbg info for call site parameters

probinson added a comment. In D58033#1470260 , @djtodoro wrote: > @probinson @aprantl Thanks a lot for your comments! > > Let's clarify some things. I'm sorry about the confusion. > > Initial patch for the functionality can be restricted by this option (li

[PATCH] D60827: [rename] Deduplicate symbol occurrences

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/unittests/clangd/ClangdTests.cpp:1160 +TEST_F(ClangdVFSTest, NoDuplicatedTextEditsOnRename) { + MockFSProvider FS; kadircet wrote: > maybe put the test under c

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195739. gtbercea added a comment. - Add const. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/C

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9135 "%0 clause previously used here">; +def err_omp_target_before_requires : Error < + "Target region encountered before requires directive with %0 clause.">; Split the pat

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

jdenny updated this revision to Diff 195742. jdenny added a comment. Clarify the behavior of multiple -verify options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60845/new/ https://reviews.llvm.org/D60845 Files: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h Index: clan

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

jdenny added a comment. Thanks for the accepts. In D60845#1470986 , @NoQ wrote: > In D60845#1470980 , @Charusso wrote: > > > I really like live working examples, I hope not just me. Could you link > > https://gith

r358674 - [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

Author: brunoricci Date: Thu Apr 18 08:13:27 2019 New Revision: 358674 URL: http://llvm.org/viewvc/llvm-project?rev=358674&view=rev Log: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap Sort the elements of Sema::OpenCLTypeExtMap and Sema::OpenCLDeclExtMap by

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

This revision was automatically updated to reflect the committed changes. Closed by commit rL358674: [Serialization] Stable serialization order for OpenCLTypeExtMap and… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[clang-tools-extra] r358675 - [clangd] Support relatedInformation in diagnostics.

Author: sammccall Date: Thu Apr 18 08:17:07 2019 New Revision: 358675 URL: http://llvm.org/viewvc/llvm-project?rev=358675&view=rev Log: [clangd] Support relatedInformation in diagnostics. Summary: We already have the structure internally, we just need to expose it. Reviewers: ilya-biryukov Subs

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358675: [clangd] Support relatedInformation in diagnostics. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SI

[PATCH] D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry

This revision was automatically updated to reflect the committed changes. Closed by commit rL358676: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r358676 - [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry

Author: szelethus Date: Thu Apr 18 08:19:16 2019 New Revision: 358676 URL: http://llvm.org/viewvc/llvm-project?rev=358676&view=rev Log: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry There are barely any lines I haven't changed in these files

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov. Herald added a project: clang. Include insertion in clangd was inserting absolute paths when the include directory was an absolute path with a doub

r358678 - [Sema][NFC] Mark DR705 (Suppressing argument-dependent lookup via parentheses) as done

Author: brunoricci Date: Thu Apr 18 08:34:03 2019 New Revision: 358678 URL: http://llvm.org/viewvc/llvm-project?rev=358678&view=rev Log: [Sema][NFC] Mark DR705 (Suppressing argument-dependent lookup via parentheses) as done It was supported since at least clang 3 so just mark it as done. Modif

r358679 - [Sema][NFC] Mark DR1563 as done (List-initialization and overloaded function disambiguation)

Author: brunoricci Date: Thu Apr 18 08:45:08 2019 New Revision: 358679 URL: http://llvm.org/viewvc/llvm-project?rev=358679&view=rev Log: [Sema][NFC] Mark DR1563 as done (List-initialization and overloaded function disambiguation) It has been supported since at least clang 3.1 so just mark it as

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea created this revision. gtbercea added reviewers: ABataev, AlexEichenberger, caomhin. Herald added subscribers: cfe-commits, jdoerfert, jfb, guansong. Herald added a project: clang. The requires directive containing target related clauses must appear before any target region in the compil

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9136 +def err_omp_target_before_requires : Error < + "Target region encountered before requires directive with %0 clause">; +def note_omp_requires_encountered_target : Note < E

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195762. gtbercea added a comment. Fix test, Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/Ope

[PATCH] D60853: clang-format converts a keyword macro definition to a macro function

owenpan marked 2 inline comments as done. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:808 - if (FormatTok->Tok.getKind() != tok::identifier) { + if (!FormatTok->Tok.getIdentifierInfo()) { IncludeGuard = IG_Rejected; ---

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195768. gtbercea marked an inline comment as done. gtbercea added a comment. - Fix test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKi

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:4207 +DSAStack->hasRequiresDeclWithClause()) && + !CurContext->isDependentContext()) { +// Register target to DSA Stack. ABataev wrote: > Better to check for the dependent context

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195770. gtbercea marked an inline comment as done. gtbercea added a comment. - Fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.t

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195771. gtbercea added a comment. - Fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/OpenMP/r

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9136 +def err_omp_target_before_requires : Error < + "Target region encountered before requires directive with '%0' clause">; +def note_omp_requires_encountered_target : Note <

r358689 - [clang-format] Fix indent of trailing raw string param after newline

Author: krasimir Date: Thu Apr 18 10:14:05 2019 New Revision: 358689 URL: http://llvm.org/viewvc/llvm-project?rev=358689&view=rev Log: [clang-format] Fix indent of trailing raw string param after newline Summary: Currently clang-format uses ContinuationIndent to indent the contents of a raw strin

[PATCH] D60558: [clang-format] Fix indent of trailing raw string param after newline

This revision was automatically updated to reflect the committed changes. Closed by commit rC358689: [clang-format] Fix indent of trailing raw string param after newline (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D60558?vs=194654&id=195772#toc Repo

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Well done! I never managed to track this one down, this was really annoying. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60873/new/ http

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195775. gtbercea added a comment. - Move error check in sema. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

r358691 - [LibTooling] Add Stencil library for format-string style codegen.

Author: ymandel Date: Thu Apr 18 10:23:01 2019 New Revision: 358691 URL: http://llvm.org/viewvc/llvm-project?rev=358691&view=rev Log: [LibTooling] Add Stencil library for format-string style codegen. Summary: This file defines the *Stencil* abstraction: a code-generating object, parameterized by

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358691: [LibTooling] Add Stencil library for format-string style codegen. (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D59371?vs=195606&id=195778#toc Reposito

r358695 - [analyzer][NFC] Prefer binary searches in CheckerRegistry

Author: szelethus Date: Thu Apr 18 10:34:45 2019 New Revision: 358695 URL: http://llvm.org/viewvc/llvm-project?rev=358695&view=rev Log: [analyzer][NFC] Prefer binary searches in CheckerRegistry Differential Revision: https://reviews.llvm.org/D59459 Modified: cfe/trunk/include/clang/StaticAna

r358694 - [analyzer][NFC] Clang-format CheckerRegistry

Author: szelethus Date: Thu Apr 18 10:32:51 2019 New Revision: 358694 URL: http://llvm.org/viewvc/llvm-project?rev=358694&view=rev Log: [analyzer][NFC] Clang-format CheckerRegistry Differential Revision: https://reviews.llvm.org/D59458 Modified: cfe/trunk/include/clang/StaticAnalyzer/Fronten

[clang-tools-extra] r358696 - [CodeComplete] Remove obsolete isOutputBinary().

Author: sammccall Date: Thu Apr 18 10:35:55 2019 New Revision: 358696 URL: http://llvm.org/viewvc/llvm-project?rev=358696&view=rev Log: [CodeComplete] Remove obsolete isOutputBinary(). Summary: It's never set to true. Its only effect would be to set stdout to binary mode. Hopefully we have better

[PATCH] D59458: [analyzer][NFC] Clang-format CheckerRegistry

This revision was automatically updated to reflect the committed changes. Closed by commit rC358694: [analyzer][NFC] Clang-format CheckerRegistry (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59458/new/ https://reviews.llvm.

r358696 - [CodeComplete] Remove obsolete isOutputBinary().

Author: sammccall Date: Thu Apr 18 10:35:55 2019 New Revision: 358696 URL: http://llvm.org/viewvc/llvm-project?rev=358696&view=rev Log: [CodeComplete] Remove obsolete isOutputBinary(). Summary: It's never set to true. Its only effect would be to set stdout to binary mode. Hopefully we have better

[PATCH] D59459: [analyzer][NFC] Prefer binary searches in CheckerRegistry

This revision was automatically updated to reflect the committed changes. Closed by commit rL358695: [analyzer][NFC] Prefer binary searches in CheckerRegistry (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1090 +FI.getReturnInfo().setSRetAfterThis(isInstanceMethod); +FI.getReturnInfo().setInReg(isAArch64 && isIndirectReturn); Based on https://reviews.llvm.org/D60348 -

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195783. akhuang marked 4 inline comments as done. akhuang added a comment. Removed extraneous information from test; changed type to DIType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://revie

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966 + QualType PointeeTy = D.getTypePtr()->getPointeeType(); + llvm::DIType *DI = getOrCreateType(PointeeTy, getOrCreateFile(Loc)); + CI->setMetadata("heapallocsite", DI); hans wrote

r358697 - [LibTooling] Extend Transformer to support multiple simultaneous changes.

Author: ymandel Date: Thu Apr 18 10:52:24 2019 New Revision: 358697 URL: http://llvm.org/viewvc/llvm-project?rev=358697&view=rev Log: [LibTooling] Extend Transformer to support multiple simultaneous changes. Summary: This revision allows users to specify independent changes to multiple (related)

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

This revision was automatically updated to reflect the committed changes. ymandel marked 2 inline comments as done. Closed by commit rL358697: [LibTooling] Extend Transformer to support multiple simultaneous changes. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

dblaikie added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:8623 + } else if (A.hasScope()) { +#define ATTR(A) +#define ATTR_NAMESPACE(A) .Case(#A, false) dblaikie wrote: > Not sure how it's done elsewhere - but I'd sink these #defines down to > immed

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

hintonda added inline comments. Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:77 +Opts["abseil-make-unique.MakeSmartPtrFunction"] = "absl::make_unique"; +Opts["abseil-make-unique.IgnoreListInit"] = true; +return Options; This is defined as `typed

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

aaron.ballman marked 7 inline comments as done. aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:8623 + } else if (A.hasScope()) { +#define ATTR(A) +#define ATTR_NAMESPACE(A) .Case(#A, false) dblaikie wrote: > dblaikie wrote: > > Not su

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

aaron.ballman updated this revision to Diff 195790. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60872/new/ https://reviews.llvm.org/D60872 Files: include/clang/Basic/Dia

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang marked 3 inline comments as done. axzhang added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {} ---

[PATCH] D60163: [ThinLTO] Handle -fno-builtin* options for distributed backends

tejohnson added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60163/new/ https://reviews.llvm.org/D60163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 195791. axzhang added a comment. Simplify tests and fix issues with Options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/modernize/MakeSmartPt

  1   2   >