[PATCH] D60287: [IR] Refactor attribute methods in Function class (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rC357731: [IR] Refactor attribute methods in Function class (NFC) (authored by evandro, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: http

[PATCH] D60279: [CUDA] Implemented _[bi]mma* builtins.

tra updated this revision to Diff 193796. tra added a comment. - Fixed minor issues with parameters of the new builtins: - __imma*_st_c_i32 builtins have 'const int * src' - __bmma_m8n8k128_mma_xor_popc_b1 does not have 'satf' argument. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D60287: [IR] Refactor attribute methods in Function class (NFC)

evandro added a comment. If anyone could give me a tip on how to avoid the review to be collapsed to just the part of whichever repo was hit first by a commit, I'd appreciate it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60287/new/ https://reviews.llvm.org/D

[PATCH] D60279: [CUDA] Implemented _[bi]mma* builtins.

tra updated this revision to Diff 193809. tra added a comment. - Added PTX64 to the list of builtins' constraints. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60279/new/ https://reviews.llvm.org/D60279 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/Basic/Targets/NVP

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore planned changes to this revision. stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:112 + << Message->getMethodDecl() + << FixItHint::CreateReplacement(Mess

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

Hi Stephen, It looks like your change has caused the 'debug-options.c' test to start failing on Darwin. It looks like we emit "-dwarf-version=4" by default, and not 2. Could you please take a look. Here's a link to a latest build on the public LLVM CI that contains the failure: http://lab.llvm.or

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

IIRC, the dwarf version on Darwin depends on the deployment target and is 2 for earlier versions of macOS and and 4 for newer ones (I need to dig through the driver code to determine the exact version). I can take a look at this tomorrow morning. -- adrian > On Apr 4, 2019, at 6:21 PM, Alex L

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

Thanks, for the explanation, it makes sense. It looks like an explicit `darwin14` in one of the non-versioned darwin triples fixes the issue. I will commit the fix right away. Cheers, Alex On Thu, 4 Apr 2019 at 18:24, Adrian Prantl wrote: > IIRC, the dwarf version on Darwin depends on the depl

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

Ah I just saw this. Please feel free to CC me on the fix CL and I will approve it. I didn't realize that the exact specification was missing for that. Thanks, Steve On Thu, Apr 4, 2019 at 6:31 PM Alex L wrote: > > Thanks, for the explanation, it makes sense. It looks like an explicit > `darwin1

[PATCH] D60301: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

ahatanak created this revision. ahatanak added reviewers: steven_wu, dexonsmith, rjmccall. ahatanak added a project: clang. Herald added a subscriber: jkorous. Repository: rC Clang https://reviews.llvm.org/D60301 Files: lib/CodeGen/CGObjC.cpp test/CodeGenObjC/arc-unsafeclaim.m Index: tes

[PATCH] D60301: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

ahatanak abandoned this revision. ahatanak added a comment. I'll write the summary and send the patch again. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60301/new/ https://reviews.llvm.org/D60301 ___ cfe-commits ma

r357740 - [test] Specify an explicit darwin version in a triple in

Author: arphaman Date: Thu Apr 4 18:48:11 2019 New Revision: 357740 URL: http://llvm.org/viewvc/llvm-project?rev=357740&view=rev Log: [test] Specify an explicit darwin version in a triple in `test/Driver/debug-options.c` to ensure that the driver selects the DWARF 2 version as intended by the tes

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

Thanks! I committed the fix in r357740. The test should start passing now. Cheers, Alex On Thu, 4 Apr 2019 at 18:32, Stephen Hines wrote: > Ah I just saw this. Please feel free to CC me on the fix CL and I will > approve it. I didn't realize that the exact specification was missing > for that.

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

ahatanak created this revision. ahatanak added reviewers: steven_wu, dexonsmith, rjmccall. ahatanak added a project: clang. Herald added subscribers: jkorous, kristof.beyls, javed.absar, mehdi_amini. This fixes a bug which causes the ARC contract pass to not insert the assembly marker that is nee

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

ahatanak added a comment. Corresponding llvm patch is here: https://reviews.llvm.org/D60303. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60302/new/ https://reviews.llvm.org/D60302 ___ cfe-commits mailing list cfe-c

[PATCH] D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:364 QualType T = PVD->getType(); - while (const MemRegion *R = S.getAsRegion()) { -if (RegionOfInterest->isSubRegionOf(R) && !isPointerToConst(T)) - return no

[PATCH] D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers.

NoQ updated this revision to Diff 193828. NoQ marked 6 inline comments as done. NoQ added a comment. Address comments. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60107/new/ https://reviews.llvm.org/D60107 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang

[PATCH] D60308: Leave alone the semicolon after the MacroBlockBegin name

owenpan created this revision. owenpan added reviewers: sammccall, klimek, djasper, krasimir. owenpan added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes the bug below. The code: FOO_BEGIN(); FOO_ENTRY FOO_END(); is erroneously formatted to: FOO_BEGIN()

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

lebedev.ri resigned from this revision. lebedev.ri added a comment. Hmm, i suppose this looks good to me now. It would be good to early-exit, but i'm not sure how important that is. Please see D52771 / `clang-tools-extra/trunk/clang-tidy/misc/NonPrivateMemberVari

<    1   2