r357532 - [HIP-Clang] Fat binary should not be produced for non GPU code

Author: aaronenyeshi Date: Tue Apr 2 14:54:41 2019 New Revision: 357532 URL: http://llvm.org/viewvc/llvm-project?rev=357532&view=rev Log: [HIP-Clang] Fat binary should not be produced for non GPU code clang-format the changes to CUDA and HIP fat binary. Reviewers: yaxunl, tra Differential Revi

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

aprantl added a comment. It looks like this may have broken some LLDB data formatters: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22934/ http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22934/testReport/junit/lldb-Suite/functionalities_data-formatter_data-formatter-stl_libcx

[PATCH] D59797: [COFF] Reduce the size of Chunk and SectionChunk, NFC

rnk updated this revision to Diff 193371. rnk added a comment. - last update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59797/new/ https://reviews.llvm.org/D59797 Files: lld/COFF/Chunks.cpp lld/COFF/Chunks.h lld/COFF/ICF.cpp lld/COFF/Ma

[PATCH] D59797: [COFF] Reduce the size of Chunk and SectionChunk, NFC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL357535: [COFF] Reduce the size of Chunk and SectionChunk, NFC (authored by rnk, committed by ). Changed prior to commit:

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

ldionne reopened this revision. ldionne added a comment. This revision is now accepted and ready to land. In D49863#1452126 , @aprantl wrote: > It looks like this may have broken some LLDB data formatters: > http://green.lab.llvm.org/green/view/LLDB/job/l

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 193376. hintonda added a comment. - Renamed and updated docs. - Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files: clang-tools-extra/clang-tidy/l

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-prefer-isa-or-dyn-cast-in-conditionals.rst:6 + + Looks at conditionals and finds cases of ``cast<>``, which will + assert rather than return a null pointer, and ``dyn_cast<>`` where

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda updated this revision to Diff 193379. hintonda added a comment. - Remove spaces in docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato created this revision. allevato added a reviewer: rjmccall. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This change exposes the helper functions that generate ctors/dtors for non-trivial structs so that they can be called from the Swift compiler (see h

[PATCH] D60163: [ThinLTO] Handle -fno-builtin* options for distributed backends

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: kristina, dexonsmith, steven_wu, eraman, inglorion, mehdi_amini. Herald added a project: clang. Without this patch, we were ignoring the -fno-builtin* options for clang invocations performing ThinLTO distr

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. In D59673#143 , @aaronpuchert wrote: > In D59673#1438716 , @dblaikie wrote: > > > Use llvm-dwarfdump rather than llvm-objdump to dump the contents of the > > debug_info section and te

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193388. rnk marked 4 inline comments as done. rnk added a comment. - Add RecordPrefix ctor, remove all dummy RecordLen assignments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193390. rnk marked an inline comment as done. rnk added a comment. - one more change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 Files: lld/COFF/PDB.cpp lldb/source

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:29 +/// Carrying the size separately instead of trusting the size stored in the +/// record prefix provides some extra safety and flexibility. template class CVRecord { agane

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal added a comment. Tim Song suggests that http://eel.is/c++draft/string.require#2 indicates that basic_string actually does need to provide the strong guarantee here. While I think that wording is a mess I think I'll fix our basic_string to do that instead of that part of this change.

[PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM. With a few minor comments: Comment at: llvm/include/llvm/DebugInfo/CodeView/TypeDeserializer.h:122 ~FieldListDeserializer() override { -CVType FieldList; -Fi

[PATCH] D60104: [libcxx] [test] Use ptrdiff_t rather than int in splice_after_range.pass.cpp to avoid narrowing from pointer subtraction to int warnings.

BillyONeal closed this revision. BillyONeal added a comment. Committed r357546 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60104/new/ https://reviews.llvm.org/D60104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D60023: [libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp.

BillyONeal updated this revision to Diff 193393. BillyONeal retitled this revision from "[libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp." to "[libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp.". BillyONeal edited the summary of this revision.

[PATCH] D60023: [libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp.

BillyONeal closed this revision. BillyONeal added a comment. Committed r357545 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60023/new/ https://reviews.llvm.org/D60023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

NoQ added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2208 +} + CFGBlock *CFGBuilder::VisitStmt(Stmt *S, AddStmtChoice asc) { Tyker wrote: > NoQ wrote: > > Tyker wrote: > > > NoQ wrote: > > > > Tyker wrote: > > > > > riccibruno wrote: > > > > > > I d

r357552 - [WebAssembly] Add Emscripten OS definition + small_printf

Author: azakai Date: Tue Apr 2 18:08:35 2019 New Revision: 357552 URL: http://llvm.org/viewvc/llvm-project?rev=357552&view=rev Log: [WebAssembly] Add Emscripten OS definition + small_printf The Emscripten OS provides a definition of __EMSCRIPTEN__, and also that it supports iprintf optimizations

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov updated this revision to Diff 193407. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/ObjCRuntime

[PATCH] D56924: Special case ObjCPropertyDecl for printing

arphaman added a comment. Sorry, I missed the pings. It LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D59797: [COFF] Reduce the size of Chunk and SectionChunk, NFC

MaskRay added a comment. > this reduces the sum of heap allocations ... These numbers exclude memory > mapped files May I ask how you counted the memory usage minus memory mapped files? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59797/new/ https://reviews.llv

r357557 - [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false.

Author: dergachev Date: Tue Apr 2 18:53:40 2019 New Revision: 357557 URL: http://llvm.org/viewvc/llvm-project?rev=357557&view=rev Log: [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false. __builtin_constant_p(x) is a compiler builtin that evaluates to 1 when its argume

[PATCH] D60110: [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357557: [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

NoQ added a comment. Mmm. I'm also pretty pinned down (it's seasonal), so i'm thinking of temporarily reverting :( until one of us gets to fixing the accidental effect on escaping, 'cause it just keeps biting us. Like, i wholeheartedly appreciate the work and i have already noticed a few times

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 193421. Dosi-Dough marked 2 inline comments as done. Dosi-Dough added a comment. added minor style changes and removed unnecessary inline comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ htt

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

xazax.hun added a comment. In D58121#1452483 , @NoQ wrote: > Mmm. I'm also pretty pinned down (it's seasonal), so i'm thinking of > temporarily reverting :( until one of us gets to fixing the accidental effect > on escaping, 'cause it just keeps biting u

[PATCH] D60179: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Instead of tooling::Replacement. To avoid the need to have contents of the file at the caller site. This als

<    1   2