[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d6fb5789fca: Revert "[analyzer] Introduce a simplified API for adding custom path notes." (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D58367?vs=192932&id=192937#toc Re

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore updated this revision to Diff 192938. stephanemoore added a comment. Add test cases with `[super self]` expanded from macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/ https://reviews.llvm.org/D59806 Files: clang-too

Re: r357323 - [analyzer] Introduce a simplified API for adding custom path notes.

Bot detects memory leak probably after this patch http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/30957/steps/check-clang%20asan/logs/stdio = ==22233==ERROR: LeakSanitizer: detected memory leaks Direct leak of

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore marked 3 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:112 + << Message->getMethodDecl() + << FixItHint::CreateReplacement(Message->getSourceRange(), +

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 192939. hintonda added a comment. - Added matcher, and reordered tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files: clang-tools-extra/clang-tidy/llvm/Avo

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda added a comment. In D59802#1448574 , @hintonda wrote: > - Added matcher, and reordered tests. Commandline ate my ticks... ;-( Should be added `isMacroID` matcher. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

r357334 - [lit] Set shlibpath_var on AIX

Author: hubert.reinterpretcast Date: Fri Mar 29 16:33:04 2019 New Revision: 357334 URL: http://llvm.org/viewvc/llvm-project?rev=357334&view=rev Log: [lit] Set shlibpath_var on AIX Summary: When building the `check-all` target on AIX, lit produces ``` warning: unable to inject shared library path

[PATCH] D59741: [lit] Set shlibpath_var on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rC357334: [lit] Set shlibpath_var on AIX (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D59741?vs=192014&id=192942#toc Repository: rC Clang CHAN

Re: r357323 - [analyzer] Introduce a simplified API for adding custom path notes.

Yup, indeed, i reverted it in r357332. Also, nice bot! On 3/29/19 4:14 PM, Vitaly Buka wrote: Bot detects memory leak probably after this patch http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/30957/steps/check-clang%20asan/logs/stdio ==

r357335 - [analyzer] MIGChecker: Add support for more deallocator APIs.

Author: dergachev Date: Fri Mar 29 16:56:53 2019 New Revision: 357335 URL: http://llvm.org/viewvc/llvm-project?rev=357335&view=rev Log: [analyzer] MIGChecker: Add support for more deallocator APIs. Differential Revision: https://reviews.llvm.org/D59914 Modified: cfe/trunk/lib/StaticAnalyzer/

[PATCH] D59914: [analyzer] MIGChecker: Add support for more deallocator APIs.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL357335: [analyzer] MIGChecker: Add support for more deallocator APIs. (authored by dergachev, committed by ). Herald added

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker marked 40 inline comments as done. lewissbaker added a comment. Thanks very much for the detailed review @CaseyCarter! Very much appreciated :) Comment at: include/experimental/__memory:80 +{ +return (__s + __a - 1) & ~(__a - 1); +} CaseyCarter

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ reopened this revision. NoQ added a comment. This revision is now accepted and ready to land. Re-reopen after the Diffusion auto-close. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58367/new/ https://reviews.llvm.org/D58367

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker updated this revision to Diff 192944. lewissbaker marked 6 inline comments as done. lewissbaker added a comment. This updated diff should address most of @CaseyCarter's review comments. For detailed changelog you can find individual changes here https://github.com/lewissbaker/libcxx/

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal created this revision. BillyONeal added reviewers: EricWF, ldionne, mclow.lists. BillyONeal added a project: libc++. Herald added subscribers: jdoerfert, dexonsmith. copy_alloc.pass.cpp contains an allocator that tries to be rebindable; but if it actually does that it fails because the

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

rjmccall added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2025 +ThisPtr = +Builder.CreatePointerBitCastOrAddrSpaceCast(This.getPointer(), NewType); } Anastasia wrote: > I am a bit unsure if `performAddrSpaceCast` should be used, but cons

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

rjmccall added a comment. In D59806#1448537 , @stephanemoore wrote: > In D59806#1447929 , @jordan_rose > wrote: > > > I don't think there's ever a reason to call `[super self]`, and doing so > > through a macro c

[PATCH] D59980: [Attributor] Deduce memory behavior argument attributes

jdoerfert updated this revision to Diff 192961. jdoerfert added a comment. Minor update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59980/new/ https://reviews.llvm.org/D59980 Files: clang/test/CodeGen/arm-vfp16-arguments.c clang/test/CodeGen

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 192962. jdoerfert added a comment. Closed a side-channel through "integers" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: clang/test/CodeGenObjC/os_log.m

<    1   2