[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong accepted this revision. martong added a comment. In D59485#1446950 , @a_sidorin wrote: > Hello Raphael, > I think we should accept this change. I don't see an easy way to merge the > LLDB stuff into ASTImporter; also, this patch provides a good e

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. A few naming alternatives, will update the review after addressing other comments. Comment at: clang/include/clang/Tooling/Syntax/TokenBuffer.h:72 + /// macro or a name, arguments and parentheses o

r357242 - [PowerPC] Add the support for __builtin_setrnd() in clang

Author: zhangkang Date: Fri Mar 29 02:11:52 2019 New Revision: 357242 URL: http://llvm.org/viewvc/llvm-project?rev=357242&view=rev Log: [PowerPC] Add the support for __builtin_setrnd() in clang Summary: PowerPC64/PowerPC64le supports the builtin function __builtin_setrnd to set the floating poin

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

dmgreen added reviewers: olista01, christof. dmgreen added inline comments. Comment at: include/clang/Driver/Options.td:2145 + Flags<[DriverOption,CC1Option]>, + HelpText<"Allow use of CMSE instructions (ARM only)">; Should this say something about compiling

[PATCH] D59725: Additions to creduce script

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. LGTM once the tempfile is deleted. Comment at: clang/utils/creduce-clang-crash.py:208 +print("\nTrying to preprocess the source file...") +# use delete=Fals

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, yaxunl. Herald added subscribers: cfe-commits, ebevhan, kristina. Herald added a project: clang. https://reviews.llvm.org/D53809 fixed wrong address space(assert in debug build) generated for `event_ret` argument. But exa

[PATCH] D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?

Szelethus added a comment. Also, you might as well clang-format the new files, since we already messed with git blame. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59861/new/ https://reviews.llvm.org/D59861 ___ cfe-commits mailing list cf

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

aaron.ballman added a comment. In D59628#1446626 , @slavapestov wrote: > I don't know what the etiquette is around here about pinging reviewers for a > re-review, but this CL is ready for another look. Your feedback is much > appreciated! Thanks for le

[PATCH] D59987: Add support for detection of devtoolset-8

rpopescu created this revision. rpopescu added reviewers: tstellar, fedor.sergeev. rpopescu added a project: clang. Herald added subscribers: cfe-commits, jdoerfert. The current llvm/clang et al. project can be built with the latest developer toolset (devtoolset-8) on RHEL, which provides GCC 8.2

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

aaron.ballman added reviewers: jordan_rose, rjmccall. aaron.ballman added a comment. I think this basically LGTM, but I'd appreciate hearing from someone more well-versed in ObjC before landing this. My primary question is: are there situations where `[super self]` is sensible (if so, how should

[PATCH] D53809: Fix invalid address space generation for clk_event_t

Anastasia added inline comments. Herald added a subscriber: ebevhan. Herald added a project: clang. Comment at: lib/CodeGen/CGBuiltin.cpp:3614 + ClkEvent = ClkEvent->getType()->isIntegerTy() + ? Builder.CreateBitOrPointerCast(ClkEvent, EventPtrTy) +

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D59802#1445566 , @hintonda wrote: > I looked at the IR generated at `-O2`, and found that while `if (isa(y))` > is a modest win over `if (dyn_cast(y)`, `if (dyn_cast_or_nul

[PATCH] D53809: Fix invalid address space generation for clk_event_t

AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3614 + ClkEvent = ClkEvent->getType()->isIntegerTy() + ? Builder.CreateBitOrPointerCast(ClkEvent, EventPtrTy) + : Builder.CreatePointerCast(ClkEvent, EventPtrTy); --

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

Anastasia created this revision. Anastasia added reviewers: rjmccall, brunodefraine. Herald added a subscriber: ebevhan. The example from the bugzilla triggered two issues: 1. In qualification conversion we are creating an address space conversion for non-pointer and non-reference type. 2. We ar

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2025 +ThisPtr = +Builder.CreatePointerBitCastOrAddrSpaceCast(This.getPointer(), NewType); } I am a bit unsure if `performAddrSpaceCast

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 192811. Tyker retitled this revision from "[clang] Adding the Likely Attribute from C++2a to AST" to "[clang] Adding the Likelihood Attribute from C++2a". Tyker added a comment. @aaron.ballman fixed based on feedback. added semantic support for switch statment.

Re: r312851 - Fix ownership of the MemoryBuffer in a FrontendInputFile.

(below) On Fri, Sep 8, 2017 at 9:15 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Sep 8 18:14:04 2017 > New Revision: 312851 > > URL: http://llvm.org/viewvc/llvm-project?rev=312851&view=rev > Log: > Fix ownership of the MemoryBuffer in a Front

[PATCH] D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. I can't see any other uses of the option groups, or any way to put an option into two groups, so this LGTM. I'll commit it for you as before. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. The only real question I have is about returning an error vs an empty transformation in of macros. The rest are just NITs. Thanks for the change! I'll get to the NodeId patch right away :-) Comment

[PATCH] D59987: Add support for detection of devtoolset-8

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59987/new/ https://reviews.llvm.org/D59987 __

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

Szelethus added a comment. Ping^2 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D59329: [LibTooling] Add NodeId, a strong type for AST-matcher node identifiers.

ilya-biryukov added a subscriber: klimek. ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/NodeId.h:29 +public: + explicit NodeId(std::string Id) : Id(std::move(Id)) {} + What are the use-cases for passing a custom id to t

r357250 - [AArch64] Support selecting TPIDR_EL[1-3] as the thread base

Author: olista01 Date: Fri Mar 29 06:32:41 2019 New Revision: 357250 URL: http://llvm.org/viewvc/llvm-project?rev=357250&view=rev Log: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base Add an -mtp=el[0-3] option to select which of the AArch64 thread ID registers will be used for the TL

[PATCH] D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base

This revision was automatically updated to reflect the committed changes. Closed by commit rC357250: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base (authored by olista01, committed by ). Changed prior to commit: https://reviews.llvm.org/D59631?vs=191800&id=192814#toc Repository:

[clang-tools-extra] r357253 - Fix MSVC "not all control paths return a value" warning. NFCI.

Author: rksimon Date: Fri Mar 29 06:43:00 2019 New Revision: 357253 URL: http://llvm.org/viewvc/llvm-project?rev=357253&view=rev Log: Fix MSVC "not all control paths return a value" warning. NFCI. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp Modified: clang-tools-extra/trunk/clangd/

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

snidertm added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:438 +} else if (Feature == "+8msecext") { + if ((CPUProfile != "M" && CPUProfile != "B") || ArchVersion != 8) { +Diags.Report(diag::err_target_unsupported_mcmse) << CPU; dmgree

r357255 - clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252)

Author: hans Date: Fri Mar 29 07:03:34 2019 New Revision: 357255 URL: http://llvm.org/viewvc/llvm-project?rev=357255&view=rev Log: clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252) Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/test/Driver/cl-options.c

[PATCH] D59329: [LibTooling] Add NodeId, a strong type for AST-matcher node identifiers.

ilya-biryukov added a comment. Could you provide the rationale for having `NodeID` vs just using strings for the binds? Is this just a more type-safe way to do the same thing or is that actually required to solve a particular problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59815/new/ https://reviews.llvm.org/D59815 ___ cfe-comm

Re: r357255 - clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252)

Do we still need changes like this now that we have the /clang: switch? On Fri, Mar 29, 2019 at 10:02 AM Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Fri Mar 29 07:03:34 2019 > New Revision: 357255 > > URL: http://llvm.org/viewvc/llvm-project?rev=35725

Re: r357255 - clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252)

I guess it's not really needed, but I'm also not sure how much we want users to have to rely on the /clang: flag. On Fri, Mar 29, 2019 at 3:43 PM Nico Weber via cfe-commits wrote: > > Do we still need changes like this now that we have the /clang: switch? > > On Fri, Mar 29, 2019 at 10:02 AM Hans

[PATCH] D59998: [Sema] Remove unneeded call to LookupResult::resolveKind

trixirt created this revision. trixirt added a reviewer: rjmccall. trixirt added a project: clang. Herald added a subscriber: cfe-commits. >From code inspection it was noticed that CppNamespaceLookup's caller CppLookupName calls LookupResult::resolveKind when CppNamespaceLookup was successful or h

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added a comment. Still have a few comments to address in `TokenCollector` and wrt to naming. But apart from this revision is ready for another round. Comment at: clang/include/clang/Tooling/Syntax/TokenBuffer.h:120 + /// the original source file. The tranformati

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 192839. ilya-biryukov marked 19 inline comments as done and 2 inline comments as done. ilya-biryukov added a comment. - Rename various things. - Update doc comments. - Search tokens in the tests by spelling, not by kind. - Add more tests. - Fix typos. -

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 192844. hintonda marked 3 inline comments as done. hintonda added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files: clang-tools-e

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192845. zbrid added a comment. update with clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/clang/Basic/Builtins.def clang/include/cl

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda added a comment. In D59802#1447560 , @aaron.ballman wrote: > In D59802#1445566 , @hintonda wrote: > > > I looked at the IR generated at `-O2`, and found that while `if > > (isa(y))` is a modest win over `

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

jordan_rose added a comment. I don't think there's ever a reason to call `[super self]`, and doing so through a macro could easily indicate a bug. Diagnostic nitpick: the Objective-C term is "init method", not "initializer". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D59725: Additions to creduce script

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:208 +print("\nTrying to preprocess the source file...") +# use delete=False in case the tmpfile flag causes problems when copying +with tempfile.Nam

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192846. akhuang marked an inline comment as done. akhuang added a comment. Tmpfile was not being removed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: cl

r357275 - [fuchsia] Add clang-doc to Fuchsia distribution

Author: juliehockett Date: Fri Mar 29 09:56:37 2019 New Revision: 357275 URL: http://llvm.org/viewvc/llvm-project?rev=357275&view=rev Log: [fuchsia] Add clang-doc to Fuchsia distribution Differential Revision: https://reviews.llvm.org/D5997 Modified: cfe/trunk/cmake/caches/Fuchsia-stage2.cma

[clang-tools-extra] r357274 - [clang-doc] Build as clang_tool

Author: juliehockett Date: Fri Mar 29 09:56:36 2019 New Revision: 357274 URL: http://llvm.org/viewvc/llvm-project?rev=357274&view=rev Log: [clang-doc] Build as clang_tool Instead of as clang_executable. Differential Revision: https://reviews.llvm.org/D59974 Modified: clang-tools-extra/trunk

[PATCH] D59974: [clang-doc] Build as clang_tool

This revision was automatically updated to reflect the committed changes. Closed by commit rL357274: [clang-doc] Build as clang_tool (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192852. zbrid added a comment. fix test formatting; make target independent intrinsic; add doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/clan

[PATCH] D59975: [fuchsia] Add clang-doc to Fuchsia distribution

juliehockett closed this revision. juliehockett added a comment. Closed and submitted in r357275 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59975/new/ https://reviews.llvm.org/D59975 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

NoQ added a comment. I think the right thing to do here is "look at the immediate macro; while it expands exactly to our original expression, look at what it is an expansion of; write down the last macro we've reached". My code now gives up whenever we stop expanding to the original expression,

[PATCH] D59963: [clang-tidy] Add module for the Linux kernel.

alexfh added a comment. Looks reasonable in general, but we usually add modules with at least one check. Let's do the same here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 __

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 192854. hintonda added a comment. - Improve warning message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files: clang-tools-extra/clang-tidy/llvm/AvoidCastInCond

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192857. zbrid added a comment. remove unnecessary requirement from builtin test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/clang/Basic/Builtin

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked 2 inline comments as done. tmroeder added a comment. In D59963#1447985 , @alexfh wrote: > Looks reasonable in general, but we usually add modules with at least one > check. Let's do the same here. OK, will do. Comment

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 192860. tmroeder added a comment. Changed the module name to linuxkernel as suggested and updated the files to match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963

r357285 - [AMDGPU] Switch default DWARF version to 5

Author: scott.linder Date: Fri Mar 29 10:45:40 2019 New Revision: 357285 URL: http://llvm.org/viewvc/llvm-project?rev=357285&view=rev Log: [AMDGPU] Switch default DWARF version to 5 Effectively reverts r337612. The issues that cropped up with the last attempt appear to have gone away. Differenti

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

This revision was automatically updated to reflect the committed changes. Closed by commit rC357285: [AMDGPU] Switch default DWARF version to 5 (authored by scott.linder, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/ https://reviews.llvm

r357290 - Various fixes and additions to creduce-clang-crash.py

Author: gbiv Date: Fri Mar 29 10:50:43 2019 New Revision: 357290 URL: http://llvm.org/viewvc/llvm-project?rev=357290&view=rev Log: Various fixes and additions to creduce-clang-crash.py Some more additions to the script - mainly reducing the clang args after the creduce run by removing them one by

[PATCH] D59725: Additions to creduce script

This revision was automatically updated to reflect the committed changes. Closed by commit rL357290: Various fixes and additions to creduce-clang-crash.py (authored by gbiv, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Herald added a subscriber: dexonsmith. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192870. zbrid added a comment. remove unnecessary if in x86 slh intrinsic lowering function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/clang/B

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid marked 2 inline comments as done. zbrid added inline comments. Comment at: llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp:614-628 + if (Opcode == X86::SpeculationSafeValue32) { +BuildMI(MBB, NMBBI, DebugLoc(), TII->get(X86::LFENCE)); +++NumInstsIns

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192873. zbrid marked an inline comment as done. zbrid added a comment. actually fix if statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/cl

r357296 - [Driver] Use --warn-shared-textrel for Android.

Author: danalbert Date: Fri Mar 29 11:34:25 2019 New Revision: 357296 URL: http://llvm.org/viewvc/llvm-project?rev=357296&view=rev Log: [Driver] Use --warn-shared-textrel for Android. Android does not allow shared text relocations. Enable the linker warning to detect them by default. Reviewers:

[PATCH] D53344: [Driver] Use --warn-shared-textrel for Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357296: [Driver] Use --warn-shared-textrel for Android. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D53344?vs=169903&id=192874#toc Repository: rC Clang

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I think this is ready. We can adjust the overloads after the fact. I'd like to get the feature in so we can make improvements independently. Comment at: clang/lib/Parse/Pars

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

vsapsai added a comment. Thanks for the review, Aaron. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58659/new/ https://reviews.llvm.org/D58659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

r357298 - [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

Author: vsapsai Date: Fri Mar 29 11:47:07 2019 New Revision: 357298 URL: http://llvm.org/viewvc/llvm-project?rev=357298&view=rev Log: [Sema] Fix assertion when `auto` parameter in lambda has an attribute. Fixes the assertion > no Attr* for AttributedType* > UNREACHABLE executed at llvm-project/cl

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357298: [Sema] Fix assertion when `auto` parameter in lambda has an attribute. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel updated this revision to Diff 192889. ymandel marked an inline comment as done. ymandel added a comment. - Assorted changes in response to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376 F

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

phosek abandoned this revision. phosek added a comment. Herald added a subscriber: libcxx-commits. This was already implemented in D59513 . Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44671/new/ https://reviews.llvm.org/D4467

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. Ping. To be clear, my goal here was not to change the OpenMP behavior. My goal was to fix APSInt behavior. If people feel that the old OpenMP behavior is better somehow, we should surely find another way to implement that. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel marked 19 inline comments as done. ymandel added a comment. Thanks for (more) helpful comments. I think the code is a lot better now than it started out. :) Also, converted `RewriteRule` to a simple struct as per our discussion. Comment at: clang/include/clang/Toolin

r357304 - [Sema] Avoid sending a dependent expression to the constant evaluator.

Author: epilk Date: Fri Mar 29 12:53:41 2019 New Revision: 357304 URL: http://llvm.org/viewvc/llvm-project?rev=357304&view=rev Log: [Sema] Avoid sending a dependent expression to the constant evaluator. Fixes llvm.org/PR41286 Modified: cfe/trunk/lib/Sema/SemaChecking.cpp cfe/trunk/test/S

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

erik.pilkington added a comment. In D58797#1447148 , @phosek wrote: > This is triggering a Clang assertion failure in Fuchsia build: > > clang/lib/AST/ExprConstant.cpp:5032: bool (anonymous > namespace)::ExprEvaluatorBase<(anonymous > namespace)::Point

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. In D58675#1448112 , @rnk wrote: > lgtm > > I think this is ready. We can adjust the overloads after the fact. I'd like > to get the feature in so we can make improvements independently. Ok, so I'm to commit this and fix

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

ABataev added a comment. I'm fine with the changes in the OpenMP tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 ___ cfe-commits mailing list cfe-commits@

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. Thanks. Then the patch just needs someone to review from the ADT side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 ___ cfe-commits

[clang-tools-extra] r357312 - [clang-tidy] Fix PR28406

Author: alexfh Date: Fri Mar 29 13:55:29 2019 New Revision: 357312 URL: http://llvm.org/viewvc/llvm-project?rev=357312&view=rev Log: [clang-tidy] Fix PR28406 Fix the crash resulting from a careless use of getLocWithOffset. At the beginning of a macro expansion it produces an invalid SourceLocatio

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

NoQ updated this revision to Diff 192906. NoQ added a comment. On second thought, dunno. In the scan-build macro preview it wouldn't show you UINT32_MAX anyway. Maybe let's keep this behavior. Cleaned up the patch a little bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59121/new/

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

Charusso added a comment. In D59121#1448367 , @NoQ wrote: > On second thought, dunno. In the scan-build macro preview it wouldn't show > you UINT32_MAX anyway. Maybe let's keep this behavior. > > Cleaned up the patch a little bit. Somehow on the `Assumi

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

NoQ added a comment. In D58573#1437749 , @Szelethus wrote: > Ping, @NoQ, if we settled on `optin.cplusplus`, would you be fine with this > patch? Yup, totally! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ h

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

NoQ added a comment. Mmm, that *is* an `Assuming...` piece, i.e., this is the same code, just the structure of macros is more complicated than usual. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59121/new/ https://reviews.llvm.org/D59121

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

Charusso added a comment. In D59121#1448386 , @NoQ wrote: > Mmm, that *is* an `Assuming...` piece, i.e., this is the same code, just the > structure of macros is more complicated than usual. You told me we would like to see a value when we hover over a

[PATCH] D60013: [WebAssembly] Add mutable globals feature

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, sunfish, hiraditya, jgravelle-google, sbc100. Herald added projects: clang, LLVM. This feature is not actually used for anything in the WebAssembly backend, bu

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert updated this revision to Diff 192916. jdoerfert added a comment. Minor updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 Files: clang/test/CodeGenOpenCL/as_type.cl llvm/include/llvm/Tran

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

NoQ updated this revision to Diff 192917. NoQ added a comment. Also, this is kinda weird. According to my logic, we should have written `Assuming 'i' is equal to 4294967295` because that's what the user will see in the macro popup. However, that's incorrect for the same reason: `i` is an int, w

[PATCH] D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?

NoQ updated this revision to Diff 192919. NoQ added a comment. Cleaned up formatting a bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59861/new/ https://reviews.llvm.org/D59861 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h clang/include/clang/

r357321 - [WebAssembly] Add mutable globals feature

Author: tlively Date: Fri Mar 29 15:00:18 2019 New Revision: 357321 URL: http://llvm.org/viewvc/llvm-project?rev=357321&view=rev Log: [WebAssembly] Add mutable globals feature Summary: This feature is not actually used for anything in the WebAssembly backend, but adding it allows users to get it

[PATCH] D60013: [WebAssembly] Add mutable globals feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL357321: [WebAssembly] Add mutable globals feature (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D60013?vs=192911&id=192925#toc Repository: rL LLVM CHANGES S

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

Charusso accepted this revision. Charusso added a comment. Nice catch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59121/new/ https://reviews.llvm.org/D59121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

r357323 - [analyzer] Introduce a simplified API for adding custom path notes.

Author: dergachev Date: Fri Mar 29 15:21:00 2019 New Revision: 357323 URL: http://llvm.org/viewvc/llvm-project?rev=357323&view=rev Log: [analyzer] Introduce a simplified API for adding custom path notes. Almost all path-sensitive checkers need to tell the user when something specific to that chec

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357323: [analyzer] Introduce a simplified API for adding custom path notes. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D58367?vs=192502&id=192932#toc Repo

r357325 - [analyzer] PR37501: Disable assertion for logical op short circuit evaluation.

Author: dergachev Date: Fri Mar 29 15:43:34 2019 New Revision: 357325 URL: http://llvm.org/viewvc/llvm-project?rev=357325&view=rev Log: [analyzer] PR37501: Disable assertion for logical op short circuit evaluation. The transfer function for the CFG element that represents a logical operation comp

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore added a comment. In D59806#1447929 , @jordan_rose wrote: > I don't think there's ever a reason to call `[super self]`, and doing so > through a macro could easily indicate a bug. Agreed. The only relatively common usage of -[NSObject self

[PATCH] D59857: [analyzer] PR37501: Disable the assertion for reverse-engineering logical op short circuits.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357325: [analyzer] PR37501: Disable assertion for logical op short circuit evaluation. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D59857?vs=192390&id=19293

r357326 - [analyzer] Move taint API from ProgramState to a separate header. NFC.

Author: dergachev Date: Fri Mar 29 15:49:30 2019 New Revision: 357326 URL: http://llvm.org/viewvc/llvm-project?rev=357326&view=rev Log: [analyzer] Move taint API from ProgramState to a separate header. NFC. It is now an inter-checker communication API, similar to the one that connects MallocCheck

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

jordan_rose added a comment. Ooh, I should have remembered "designated initializer". I guess it doesn't matter so much either way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/ https://reviews.llvm.org/D59806

[PATCH] D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?

This revision was automatically updated to reflect the committed changes. Closed by commit rC357326: [analyzer] Move taint API from ProgramState to a separate header. NFC. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D59861?vs=192919&id=192934#toc R

[PATCH] D59901: [analyzer] PR41239: Fix a crash on invalid source location in NoStoreFuncVisitor.

NoQ added a comment. This other example seems to work and looks relatively similar, just with a different checker causing the visitor to be attached. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59901/new/ https://reviews.llvm.org/D59901

r357329 - [analyzer] PR41239: Fix a crash on invalid source location in NoStoreFuncVisitor.

Author: dergachev Date: Fri Mar 29 15:57:49 2019 New Revision: 357329 URL: http://llvm.org/viewvc/llvm-project?rev=357329&view=rev Log: [analyzer] PR41239: Fix a crash on invalid source location in NoStoreFuncVisitor. It turns out that SourceManager::isInSystemHeader() crashes when an invalid so

[PATCH] D59901: [analyzer] PR41239: Fix a crash on invalid source location in NoStoreFuncVisitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357329: [analyzer] PR41239: Fix a crash on invalid source location in… (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

r357332 - Revert "[analyzer] Introduce a simplified API for adding custom path notes."

Author: dergachev Date: Fri Mar 29 16:11:10 2019 New Revision: 357332 URL: http://llvm.org/viewvc/llvm-project?rev=357332&view=rev Log: Revert "[analyzer] Introduce a simplified API for adding custom path notes." This reverts commit r357323. ASan leaks found by a buildbot :) Differential Revisi

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ reopened this revision. NoQ marked an inline comment as done. NoQ added a comment. This revision is now accepted and ready to land. Reverted in rC357332 ! http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/30957/steps/check-clang%20asan/log

  1   2   >