[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

shafik added inline comments. Comment at: lib/AST/ASTImporter.cpp:3418 - for (const auto *Attr : D->attrs()) -ToIndirectField->addAttr(Importer.Import(Attr)); Why is this section of code removed? Repository: rC Clang CHANGES SINCE LAST ACTION https:

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaron.ballman added inline comments. Comment at: test/SemaObjCXX/no-crash-thread-safety-analysis.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety -Wno-objc-root-class %s + aaronpuchert wrote: > jfb wrote: > > aaronpuchert wrote: > > > Test is fine

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. @djasper Do you have any further concerns about this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

lebedev.ri added a comment. In D55170#1436732 , @MyDeveloperDay wrote: > > The cost is financial, as it's developer time, which costs real money to > > companies. In the end, to support this, people like myself who are doing > > this as part of their jo

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

riccibruno added a comment. To expand on the above, if you need to add a few bits to a statement/expression you can use the bit-field classes in `Stmt` (for example: `IfStmtBitfields`). You will also need to update the serialization code in `Serialization/ASTWriterStmt.cpp` and `Serialization/A

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb marked an inline comment as done. jfb added inline comments. Comment at: test/SemaObjCXX/no-crash-thread-safety-analysis.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety -Wno-objc-root-class %s + aaron.ballman wrote: > aaronpuchert wrote: > > j

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaron.ballman added inline comments. Comment at: test/SemaObjCXX/no-crash-thread-safety-analysis.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety -Wno-objc-root-class %s + jfb wrote: > aaron.ballman wrote: > > aaronpuchert wrote: > > > jfb wrote: >

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov added a comment. I've just realized the review is probably missing the latest revision. @ymandel, could you upload the new version? Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:54 +/// boolean expression language for constructing filters. +cla

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov added inline comments. Comment at: clang/unittests/Tooling/TransformerTest.cpp:157 + .as() + .replaceWith(text("REPLACED")) + .because(text("Use size() method directly on string.")); NIT: maybe consider adding overloads for these func

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

mgrang added a comment. In D59279#1439014 , @Szelethus wrote: > In D59279#1438514 , @mgrang wrote: > > > Although, as you rightly pointed out that //ordered// sets of pointers are > > as non-deterministic as //unor

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb marked an inline comment as done. jfb added inline comments. Comment at: test/SemaObjCXX/no-crash-thread-safety-analysis.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety -Wno-objc-root-class %s + aaron.ballman wrote: > jfb wrote: > > aaron.ball

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaron.ballman added inline comments. Comment at: test/SemaObjCXX/no-crash-thread-safety-analysis.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety -Wno-objc-root-class %s + jfb wrote: > aaron.ballman wrote: > > jfb wrote: > > > aaron.ballman wrote:

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/openmp-exception-escape.rst:10-11 +As per the OpenMP specification, structured block is an executable statement, +possibly compound, with a single entry at the top and a single exit at the +bottom. Which means,

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri updated this revision to Diff 191911. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Last few nits. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ https://reviews.llvm.org/D59466 Files: clang-tidy/op

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaronpuchert added inline comments. Comment at: test/SemaObjCXX/no-crash-thread-safety-analysis.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety -Wno-objc-root-class %s + aaron.ballman wrote: > jfb wrote: > > aaron.ballman wrote: > > > jfb wrote: >

[clang-tools-extra] r356788 - [clangd] Call the new ClangTidyCheck::registerPPCallbacks overload

Author: alexfh Date: Fri Mar 22 11:16:51 2019 New Revision: 356788 URL: http://llvm.org/viewvc/llvm-project?rev=356788&view=rev Log: [clangd] Call the new ClangTidyCheck::registerPPCallbacks overload Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/cl

r356789 - IR: Support parsing numeric block ids, and emit them in textual output.

Author: jyknight Date: Fri Mar 22 11:27:13 2019 New Revision: 356789 URL: http://llvm.org/viewvc/llvm-project?rev=356789&view=rev Log: IR: Support parsing numeric block ids, and emit them in textual output. Just as as llvm IR supports explicitly specifying numeric value ids for instructions, and

[PATCH] D58548: IR: Support parsing numeric block ids, and emit them in textual output.

This revision was automatically updated to reflect the committed changes. Closed by commit rC356789: IR: Support parsing numeric block ids, and emit them in textual output. (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D58548?vs=187994&id=191913#toc R

[clang-tools-extra] r356792 - [clang-tidy] anyOf(hasName(..), hasName(..)) -> hasAnyName

Author: alexfh Date: Fri Mar 22 11:37:45 2019 New Revision: 356792 URL: http://llvm.org/viewvc/llvm-project?rev=356792&view=rev Log: [clang-tidy] anyOf(hasName(..), hasName(..)) -> hasAnyName + a minor style fix Modified: clang-tools-extra/trunk/clang-tidy/cert/SetLongJmpCheck.cpp clang-

r356794 - [clang] Add support for Exynos M5 (NFC)

Author: evandro Date: Fri Mar 22 11:44:09 2019 New Revision: 356794 URL: http://llvm.org/viewvc/llvm-project?rev=356794&view=rev Log: [clang] Add support for Exynos M5 (NFC) Add Exynos M5 test cases. Modified: cfe/trunk/test/CodeGen/arm-target-features.c cfe/trunk/test/Driver/aarch64-cpu

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

thakis added inline comments. Comment at: docs/ReleaseNotes.rst:169 +- Add language support for clang-formatting C# files +- Add Microsoft coding style to encapsulate default C# formatting style Shouldn't this be in 'clang-format', not in 'AST Matchers'? Repo

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea added a comment. Thank you both for the feedback. It's good to see that there's an interest to move this forward, I will try to refactor this patch according to Hal's suggestions and see if there are any blockers. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[clang-tools-extra] r356795 - Fix clang-move test.

Author: alexfh Date: Fri Mar 22 11:52:10 2019 New Revision: 356795 URL: http://llvm.org/viewvc/llvm-project?rev=356795&view=rev Log: Fix clang-move test. Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMove

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/openmp-use-default-none.rst:19 + +.. code-block:: c++ + aaron.ballman wrote: > This is a *lot* of example text -- are you sure all of it adds value, or can > some of it be removed? Right, let's

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri updated this revision to Diff 191918. lebedev.ri marked 5 inline comments as done. lebedev.ri added a comment. Make diags less grammatically correct, reduce docs. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57113/new/ https://reviews.ll

[clang-tools-extra] r356796 - [clang-tidy] Move all checks to the new registerPPCallbacks API

Author: alexfh Date: Fri Mar 22 11:58:12 2019 New Revision: 356796 URL: http://llvm.org/viewvc/llvm-project?rev=356796&view=rev Log: [clang-tidy] Move all checks to the new registerPPCallbacks API Modified: clang-tools-extra/trunk/clang-tidy/abseil/StringFindStartswithCheck.cpp clang-tool

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. @lebedev.ri Are we talking about a general ideology of the long term cost to allow any new things in? or to not allow things in this specific case? because in this specific case all the changes are based on what is really a single clause that was already there be

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks for improving the check! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59360/new/ https://reviews.llvm.org/D59360

[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

hintonda added a comment. I took a look at C++ designator restrictions shown here aggregate initialization , and believe it to be orthogonal to this change. Thus, I'd prefer to put that in a separate patch. However, based o

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

BillyONeal abandoned this revision. BillyONeal added a comment. This didn't work out, we'll just skip the tests for MSVC++ for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59621/new/ https://reviews.llvm.org/D59621 ___ cfe-commits mai

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. @MyDeveloperDay Thanks for the approve! I'm not sure what the lingering concerns are, as far as I know there have been no concerns since october of last year. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 _

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. @MyDeveloperDay Thanks for the approve! Yes, this patch has been working for us as we've been using it on an internal fork since I opened the patch. As I mentioned, without this patch clang-format is useless for us in CI. CHANGES SINCE LAST ACTION https://review

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

aaron.ballman accepted this revision. aaron.ballman added a comment. Aside from a docs nit, LGTM! Comment at: docs/clang-tidy/checks/openmp-exception-escape.rst:13 +structured block. If an exception is not caught in the same structured block +it was thrown in, the behaviour is

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a minor diagnostic wording nit. Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:52 + Clause->getDefaultKind()); +diag(Clause->getBeginLoc(), "e

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. In D58797#1438975 , @nickdesaulniers wrote: > This is causing false positive warnings for the Linux kernel: > https://github.com/ClangBuiltLinux/linux/issues/423 > :( > >

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

ldionne added a comment. In D59621#1439870 , @BillyONeal wrote: > This didn't work out, we'll just skip the tests for MSVC++ for now. I'd like to understand what's breaking on MSVC so we can address the problem properly -- but I won't push if you just w

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

asb added a comment. In D59233#1439656 , @hubert.reinterpretcast wrote: > Thanks @xingxue for the review. I will update for the error handling before > committing. Use of report_fatal_error/llvm_unreachable isn't fully consistent within the LLVM codeb

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri added a comment. I'm gonna go with post-commit review here, if @baloghadamsoftware will have any notes, although this now looks rather uncontroversial. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59650/new/ https://reviews.llvm.org/D59

[PATCH] D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration.

jyknight created this revision. jyknight added reviewers: rsmith, arphaman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This case should emit an -Wimplicit-function-declaration warning. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D59711 Files: cl

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri added a comment. In D59466#1439880 , @aaron.ballman wrote: > Aside from a docs nit, LGTM! Thank you for the review! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ https://reviews.llvm

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri added a comment. In D57113#1439890 , @aaron.ballman wrote: > LGTM aside from a minor diagnostic wording nit. Thank you for the review! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57113/new/ h

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaronpuchert added a comment. Creating a new test makes sense to me if it tests things across components. We have such tests for modules, PCH, and templates. There are also separate tests for the attribute parsing, which doesn't work terribly well in ObjC either. I would agree to making a new t

[clang-tools-extra] r356799 - [NFC] ExceptionEscapeCheck: small refactoring

Author: lebedevri Date: Fri Mar 22 12:45:51 2019 New Revision: 356799 URL: http://llvm.org/viewvc/llvm-project?rev=356799&view=rev Log: [NFC] ExceptionEscapeCheck: small refactoring Summary: D59466 wants to analyse the `Stmt`, and `ExceptionEscapeCheck` does not have that as a possible entry poin

[clang-tools-extra] r356800 - [clang-tidy] A new OpenMP module

Author: lebedevri Date: Fri Mar 22 12:46:01 2019 New Revision: 356800 URL: http://llvm.org/viewvc/llvm-project?rev=356800&view=rev Log: [clang-tidy] A new OpenMP module Summary: Just the empty skeleton. Previously reviewed as part of D57113. Reviewers: JonasToth, aaron.ballman, alexfh, xazax.hun

[clang-tools-extra] r356801 - [clang-tidy] openmp-use-default-none - a new check

Author: lebedevri Date: Fri Mar 22 12:46:12 2019 New Revision: 356801 URL: http://llvm.org/viewvc/llvm-project?rev=356801&view=rev Log: [clang-tidy] openmp-use-default-none - a new check Summary: Finds OpenMP directives that are allowed to contain `default` clause, but either don't specify it, or

[clang-tools-extra] r356802 - [clang-tidy] openmp-exception-escape - a new check

Author: lebedevri Date: Fri Mar 22 12:46:25 2019 New Revision: 356802 URL: http://llvm.org/viewvc/llvm-project?rev=356802&view=rev Log: [clang-tidy] openmp-exception-escape - a new check Summary: Finally, we are here! Analyzes OpenMP Structured Blocks and checks that no exception escapes out of

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel marked an inline comment as done. ymandel added a comment. Working on the new version now. Will note with "PTAL" once that's ready. Sorry that wasn't clear in earlier responses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ http

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny created this revision. jdenny added reviewers: ABataev, chandlerc, craig.topper. Herald added subscribers: jdoerfert, dexonsmith, guansong. Herald added a project: LLVM. Without this patch, APSInt inherits APInt::isNegative, which merely checks the sign bit without regard to whether the typ

[PATCH] D57571: [clang-tidy] A new OpenMP module

This revision was automatically updated to reflect the committed changes. Closed by commit rL356800: [clang-tidy] A new OpenMP module (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

nickdesaulniers added a comment. In D58797#1439888 , @erik.pilkington wrote: > Ah, I didn't consider that case. Presumably `st` is configured to have > different sizes based on the target? Yes; sorry I was not clear about that in my example. > I agree

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356802: [clang-tidy] openmp-exception-escape - a new check (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D59466?vs=191911&id=191929#toc Repository: rCTE

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356799: [NFC] ExceptionEscapeCheck: small refactoring (authored by lebedevri, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59650/new/ http

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356801: [clang-tidy] openmp-use-default-none - a new check (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D57113?vs=191918&id=191927#toc Repository: rCTE

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri added a comment. Might warrant test coverage in `llvm/unittest/ADT/APSIntTest.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 ___ cfe-commits m

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 14 inline comments as done. anton-afanasyev added inline comments. Comment at: llvm/lib/IR/LegacyPassManager.cpp:1632-1634 + bool profileTime = llvm::TimeTraceProfilerEnabled(); + if (profileTime) +llvm::TimeTraceProfilerBegin("OptFunction", F.getName

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. In D59712#1439966 , @lebedev.ri wrote: > Might warrant test coverage in `llvm/unittest/ADT/APSIntTest.cpp`. Thanks. I'll work on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev updated this revision to Diff 191934. anton-afanasyev marked 2 inline comments as done. anton-afanasyev added a comment. Updated following @rnk review notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 Files: clang/include/

[PATCH] D59714: [clang-tidy] Separate the check-facing interface

alexfh updated this revision to Diff 191937. alexfh added a comment. - Reverted the part to simplify the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59714/new/ https://reviews.llvm.org/D59714 Files: clang-tools-extra/clang-tidy/CMake

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

rnk added a comment. Other than the lifetime issue, I think this is basically ready. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2014 + llvm::TimeTraceScope TimeScope("InstantiateClass", [&]() { + return Instantiation->getQualifiedNameAsString().c_str(); +}

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny updated this revision to Diff 191938. jdenny added a comment. Extend llvm/unittests/ADT/APSIntTest.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 Files: clang/test/OpenMP/distribute_collapse_

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb added inline comments. Comment at: lib/Analysis/ThreadSafetyCommon.cpp:280 unsigned I = PV->getFunctionScopeIndex(); - -if (Ctx && Ctx->FunArgs && FD == Ctx->AttrDecl->getCanonicalDecl()) { - // Substitute call arguments for references to function parameters -

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb updated this revision to Diff 191939. jfb marked 13 inline comments as done. jfb added a comment. - Almost Never Auto. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59523/new/ https://reviews.llvm.org/D59523 Files: lib/Analysis/ThreadSafetyCommon.cpp tes

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191946. teemperor marked 5 inline comments as done. teemperor added a comment. - Removed unused functions. - Fixed two comments that I missed to update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 File

[PATCH] D59615: [AArch64] When creating SISD intrinsic calls widen scalar args into a zero vectors, not undef

aemerson added a comment. In D59615#1439153 , @t.p.northover wrote: > Did you look into a scalar variant of the intrinsic call instead? These > instructions have non-vector variants (e.g. `sqadd s0, s0, s0`), and that's > actually why the intrinsics exi

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

rsmith added a comment. Thanks, this looks like a good broad direction. I think this patch does not goes far enough yet. Broad comments (partially duplicating some of the specific comments on the patch itself): - form the `DeclSpecUuidDecl` earlier, when parsing the attribute argument - store a

[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

tlively created this revision. tlively added reviewers: sbc100, aheejin. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, dschuff. Herald added a project: clang. This eliminates a linker error the user might otherwise see about how using the 'atomics' feature requires --share

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaronpuchert added a comment. > It's less about the regressions and more about the kind of regressions we're > testing against. But the test also verifies that no diagnostics are omitted (`// expected-no-diagnostics`), so it isn't just a "this doesn't crash" test. Which is why I think it's a n

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb added a comment. In D59523#1440232 , @aaronpuchert wrote: > > It's less about the regressions and more about the kind of regressions > > we're testing against. > > But the test also verifies that no diagnostics are omitted (`// > expected-no-diagnos

[PATCH] D59523: Thread Safety: also look at ObjC methods

delesley accepted this revision. delesley added a comment. This revision is now accepted and ready to land. The if logic does not enhance readability, but I suppose it can't be helped. Looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59523/new/ h

r356817 - [WebAssembly] Make driver -pthread imply linker --shared-memory

Author: tlively Date: Fri Mar 22 15:25:37 2019 New Revision: 356817 URL: http://llvm.org/viewvc/llvm-project?rev=356817&view=rev Log: [WebAssembly] Make driver -pthread imply linker --shared-memory Summary: This eliminates a linker error the user might otherwise see about how using the 'atomics'

[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

This revision was automatically updated to reflect the committed changes. Closed by commit rL356817: [WebAssembly] Make driver -pthread imply linker --shared-memory (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaron.ballman added a comment. In D59523#1440238 , @jfb wrote: > In D59523#1440232 , @aaronpuchert > wrote: > > > > It's less about the regressions and more about the kind of regressions > > > we're testing agains

[PATCH] D59724: IRGen: Remove StructorType; thread GlobalDecl through more code. NFCI.

pcc created this revision. pcc added reviewers: rsmith, rjmccall. Herald added a subscriber: jdoerfert. Herald added a project: clang. This should make it easier to add more structor variants. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D59724 Files: clang/include/clang/AS

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk added a comment. In D57265#1393814 , @fedor.sergeev wrote: > In D57265#1393453 , @vsk wrote: > > > > I'd prefer not adding this kind of state to PassBuilder. SplitColdCode is > > > soemthing that refers to the

[PATCH] D59725: Additions to creduce script

akhuang created this revision. akhuang added reviewers: rnk, george.burgess.iv, arichardson. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some more additions to the script - mainly reducing the clang args after the creduce run

r356821 - [clang-format][NFC] correct the release notes

Author: paulhoad Date: Fri Mar 22 15:47:34 2019 New Revision: 356821 URL: http://llvm.org/viewvc/llvm-project?rev=356821&view=rev Log: [clang-format][NFC] correct the release notes Move the clang-format notes to the correct section Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/tru

[PATCH] D59724: IRGen: Remove StructorType; thread GlobalDecl through more code. NFCI.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59724/new/ https://reviews.llvm.org/D59724 __

[PATCH] D58236: Make address space conversions a bit stricter.

efriedma added a comment. If nobody else agrees with my position on this, I'm not going to continue arguing on the explicit cast behavior. But please add a testcase showing that at least `(global int**)(void*)(local int**)p` works without an error. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb added a comment. In D59523#1440263 , @aaron.ballman wrote: > In D59523#1440238 , @jfb wrote: > > > In D59523#1440232 , @aaronpuchert > > wrote: > > > > > > It's less ab

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb updated this revision to Diff 191968. jfb added a comment. - No verify, no expected. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59523/new/ https://reviews.llvm.org/D59523 Files: lib/Analysis/ThreadSafetyCommon.cpp test/SemaObjCXX/no-crash-thread-safet

r356822 - IRGen: Remove StructorType; thread GlobalDecl through more code. NFCI.

Author: pcc Date: Fri Mar 22 16:05:10 2019 New Revision: 356822 URL: http://llvm.org/viewvc/llvm-project?rev=356822&view=rev Log: IRGen: Remove StructorType; thread GlobalDecl through more code. NFCI. This should make it easier to add more structor variants. Differential Revision: https://review

[PATCH] D59724: IRGen: Remove StructorType; thread GlobalDecl through more code. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356822: IRGen: Remove StructorType; thread GlobalDecl through more code. NFCI. (authored by pcc, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaronpuchert accepted this revision. aaronpuchert added a comment. Alright, go ahead. I don't want this to be held up by such a minor detail. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59523/new/ https://reviews.llvm.org/D59523 _

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert updated this revision to Diff 191984. jdoerfert added a comment. Introduce a ternary mode for parallel regions, fix minor mistakes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59319/new/ https://reviews.llvm.org/D59319 Files: openmp/l

[PATCH] D59418: [OpenMP][Offloading] Extract common functionality

jdoerfert updated this revision to Diff 191985. jdoerfert added a comment. Minor update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59418/new/ https://reviews.llvm.org/D59418 Files: clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp clang/lib/CodeGe

[PATCH] D59328: [OpenMP][Offloading][2/3] Codegen for target regions (TRegions)

jdoerfert updated this revision to Diff 191988. jdoerfert added a comment. Syncronize interface types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59328/new/ https://reviews.llvm.org/D59328 Files: clang/lib/CodeGen/CGOpenMPRuntimeTRegion.cpp

[PATCH] D59421: [OpenMP][Offloading] Allow to build the TRegion interface functions

jdoerfert updated this revision to Diff 191987. jdoerfert added a comment. Actually syncronize interface types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59421/new/ https://reviews.llvm.org/D59421 Files: clang/lib/CodeGen/CGOpenMPRuntimeTarge

[PATCH] D59421: [OpenMP][Offloading] Allow to build the TRegion interface functions

jdoerfert updated this revision to Diff 191986. jdoerfert added a comment. Synchronize interface types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59421/new/ https://reviews.llvm.org/D59421 Files: clang/lib/CodeGen/CGOpenMPRuntimeTarget.cpp

<    1   2