[PATCH] D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h

This revision was automatically updated to reflect the committed changes. Closed by commit rC356423: [X86] Add gcc rotate intrinsics to ia32intrin.h (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D59346?vs=190943&id=191189#toc Repository: rC Clang CH

[PATCH] D58548: IR: Support parsing numeric block ids, and emit them in textual output.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58548/new/ https://reviews.llvm.org/D58548 __

[PATCH] D59516: [analyzer] Make GenericTaintChecker configurable

boga95 created this revision. boga95 added reviewers: NoQ, Szelethus, xazax.hun, dkrupp. boga95 added a project: clang. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. One can pass a configuration file to t

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191192. akhuang added a comment. Modify interestingness test to take file as input CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clan

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

kzhuravl added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7976 + +Name = Twine(Twine(Name) + Twine("one-as")).str(); + } rampitec wrote: > I think subgroup is in the single address space even if sequentially > consistent. I have synced with @t-

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

kzhuravl updated this revision to Diff 191193. kzhuravl marked an inline comment as done. kzhuravl added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59494/new/ https://reviews.llvm.org/D59494 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/TargetIn

r356425 - [MS] Skip vbase construction in abstract class ctors

Author: rnk Date: Mon Mar 18 15:41:50 2019 New Revision: 356425 URL: http://llvm.org/viewvc/llvm-project?rev=356425&view=rev Log: [MS] Skip vbase construction in abstract class ctors As background, when constructing a complete object, virtual bases are constructed first. If an exception is thrown

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore updated this revision to Diff 191198. stephanemoore marked 2 inline comments as done. stephanemoore added a comment. Updated with changes: • Switched to using `| count 0` instead of grep'ing for warnings. • Merged Objective-C and Objective-C++ test cases into single file with multip

[PATCH] D59440: add steps to preprocess file and reduce command line args

rnk added a comment. Aside from the buglet, I'm happy with this, but I wanted to wait until @george.burgess.iv takes a look. Comment at: clang/utils/creduce-clang-crash.py:44 + +def quote_cmd(cmd): + for i, arg in enumerate(cmd): This modifies cmd in place, s

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/google-runtime-int.m:1 +// RUN: clang-tidy -checks=-*,google-runtime-int %s 2>&1 -- -x objective-c | not grep 'warning:\|error:' + aaron.ballman wrote: > We typically use `| count

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191199. akhuang marked an inline comment as done. akhuang added a comment. fixed array copy mistake CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/u

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Mar 15, 2019 at 10:55 AM Aaron Ballman wrote: > > Ping. > I apologize for the extraordinarily delays here. I've now posted a patch to address the review comments here: https://reviews.llvm.org/D59520 Dan ___ cfe-commits mailing list cfe-commi

[PATCH] D59520: [WebAssembly] Address review comments on r352930

sunfish created this revision. sunfish added a reviewer: aaron.ballman. Herald added subscribers: aheejin, jgravelle-google, sbc100, dschuff. Herald added a project: clang. This patch addresses the review comments on r352930: - Removes redundant diagnostic checking code - Removes errnoneous use o

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

b-sumner added a comment. Comment at: lib/CodeGen/TargetInfo.cpp:7976 + +Name = Twine(Twine(Name) + Twine("one-as")).str(); + } kzhuravl wrote: > rampitec wrote: > > I think subgroup is in the single address space even if sequentially > > consistent. > I

r356427 - Thread safety analysis: Add note for unlock kind mismatch

Author: aaronpuchert Date: Mon Mar 18 16:26:54 2019 New Revision: 356427 URL: http://llvm.org/viewvc/llvm-project?rev=356427&view=rev Log: Thread safety analysis: Add note for unlock kind mismatch Summary: Similar to D56967, we add the existing diag::note_locked_here to tell the user where we saw

[PATCH] D59455: Thread safety analysis: Add note for unlock kind mismatch

This revision was automatically updated to reflect the committed changes. Closed by commit rC356427: Thread safety analysis: Add note for unlock kind mismatch (authored by aaronpuchert, committed by ). Changed prior to commit: https://reviews.llvm.org/D59455?vs=190968&id=191207#toc Repository:

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

rampitec added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7976 + +Name = Twine(Twine(Name) + Twine("one-as")).str(); + } b-sumner wrote: > kzhuravl wrote: > > rampitec wrote: > > > I think subgroup is in the single address space even if sequenti

Re: r311065 - Further refactoring of the constant emitter. NFC.

On 18 Mar 2019, at 18:05, John McCall wrote: On 18 Mar 2019, at 15:38, Don Hinton wrote: Hi John: I found this investigating the cast assert noted here: http://lists.llvm.org/pipermail/cfe-dev/2019-March/061685.html I subsequently did quick grep and found a number of cases in clang+llvm (d

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb created this revision. jfb added reviewers: dexonsmith, erik.pilkington. Herald added subscribers: cfe-commits, jdoerfert, jkorous. Herald added a project: clang. jfb added a comment. It seems weird how both do pretty similar things and e.g. duplicate `getParamDecl`. The repro I have is 20M,

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb added a comment. It seems weird how both do pretty similar things and e.g. duplicate `getParamDecl`. The repro I have is 20M, creduce chokes on it, and manually reducing failed to repro... ☹️ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59523/new/ https:/

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

mclow.lists added a comment. Herald added a project: LLVM. I have a bug report - https://bugs.llvm.org/show_bug.cgi?id=41131 - that says that we can reduce the number of calls in __libcpp_locale_guard from 10 to 2 by calling: `setlocale(LC_ALL, ...)` . Was this considered when this patch was cr

[PATCH] D59523: Thread Safety: also look at ObjC methods

erik.pilkington added a comment. I don't understand this code at all, but what about `BlockDecl`? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59523/new/ https://reviews.llvm.org/D59523 ___ cfe-commits mailing list

r356430 - Minor renaming as suggested in review [NFC]

Author: aaronpuchert Date: Mon Mar 18 17:14:46 2019 New Revision: 356430 URL: http://llvm.org/viewvc/llvm-project?rev=356430&view=rev Log: Minor renaming as suggested in review [NFC] See D59455. Modified: cfe/trunk/include/clang/Analysis/Analyses/ThreadSafety.h cfe/trunk/lib/Sema/Analysi

[PATCH] D59455: Thread safety analysis: Add note for unlock kind mismatch

aaronpuchert marked 4 inline comments as done. aaronpuchert added inline comments. Comment at: include/clang/Analysis/Analyses/ThreadSafety.h:127 + SourceLocation LocLocked, SourceLocation Loc) {}

Re: r356222 - [analyzer] Support C++17 aggregates with bases without constructors.

On Fri, Mar 15, 2019 at 1:21 AM Artem Dergachev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dergachev > Date: Thu Mar 14 17:22:59 2019 > New Revision: 356222 > > URL: http://llvm.org/viewvc/llvm-project?rev=356222&view=rev > Log: > [analyzer] Support C++17 aggregates with bases

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

b-sumner added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7976 + +Name = Twine(Twine(Name) + Twine("one-as")).str(); + } rampitec wrote: > b-sumner wrote: > > kzhuravl wrote: > > > rampitec wrote: > > > > I think subgroup is in the single addres

[PATCH] D59523: Thread Safety: also look at ObjC methods

jfb added a comment. In D59523#1434121 , @erik.pilkington wrote: > I don't understand this code at all, but what about `BlockDecl`? Agreed that it has `getParamDecl` as well, and the context would fit. It just seems weird how stuff is repeated, Iw as h

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59494/new/ https://reviews.llvm.org/D59494 ___ cfe-commits mailing list cfe-commi

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191217. akhuang marked 2 inline comments as done. akhuang added a comment. Fixed typo where it was writing the abspath of the file to the interestingness test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440

[PATCH] D57230: [analyzer] Toning down invalidation a bit

NoQ added a comment. Herald added a subscriber: Charusso. Hmm, here's another one: struct ListInfo { struct ListInfo *next; }; struct X { struct ListInfo li; int i; }; void list_add(struct ListInfo *list, struct ListInfo *item); void foo(struct ListInfo *list) {

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore updated this revision to Diff 191219. stephanemoore added a comment. Remove redundant specification of `-x objective-c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59336/new/ https://reviews.llvm.org/D59336 Files: clang-tools-ex

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:106-117 + # Check that an empty file is not interesting + # file_to_reduce is hardcoded into the test, so this is a roundabout + # way to run it on an empty

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore marked 3 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/google-runtime-int.m:1 +// RUN: clang-tidy -checks=-*,google-runtime-int %s 2>&1 -- -x objective-c | not grep 'warning:\|error:' +

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaronpuchert added a comment. > It should consider both because the attributes can be used on Objective-C as > well. Well, it's not really supported that well though. There are known bugs like https://bugs.llvm.org/show_bug.cgi?id=38892, and I don't really have the time to fix that. (You're fr

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

alexfh created this revision. alexfh added reviewers: gribozavr, usaxena95, sammccall. Herald added subscribers: jdoerfert, kbarton, xazax.hun, mgorny, nemanjai. Herald added a project: clang. Add a way to expand modular headers for PPCallbacks. Checks can opt-in for this expansion by overriding t

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

alexfh updated this revision to Diff 191227. alexfh added a comment. - Fix a typo in the comment. Rearrange paragraphs to make the comment more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59528/new/ https://reviews.llvm.org/D59528 Fil

[PATCH] D59529: Refactor cast<>'s in if conditionals, which can only assert on failure.

e branch can never be taken. In some cases, the fix is to replace cast<> with dyn_cast<>. While others required the removal of the conditional and some minor refactoring. A discussion can be seen here: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190318/265044.html Repos

r356433 - Factor out repeated code parsing and concatenating header-names from

Author: rsmith Date: Mon Mar 18 18:51:19 2019 New Revision: 356433 URL: http://llvm.org/viewvc/llvm-project?rev=356433&view=rev Log: Factor out repeated code parsing and concatenating header-names from tokens. We now actually form an angled_string_literal token for a header name by concatenation

r356432 - Don't apply the include depth limit until we actually decide to enter

Author: rsmith Date: Mon Mar 18 18:51:17 2019 New Revision: 356432 URL: http://llvm.org/viewvc/llvm-project?rev=356432&view=rev Log: Don't apply the include depth limit until we actually decide to enter the file. NFC unless a skipped #include is found at the final permitted #include level. Modif

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

alexfh updated this revision to Diff 191230. alexfh added a comment. - Fix naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59528/new/ https://reviews.llvm.org/D59528 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/cl

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 191233. bernhardmgruber marked 7 inline comments as done and 2 inline comments as done. bernhardmgruber added a comment. - extracting specifiers from the return type if it consists of a multitoken built-in type, and preprending it to 'auto'. - extende

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber marked an inline comment as not done. bernhardmgruber added a comment. Thank you for the rich feedback @aaron.ballman. I found a solution which seems to work for many of my test cases. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:274 + + if

[PATCH] D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main.

jyu2 added a comment. In D58160#1433458 , @rnk wrote: > lgtm Thank you so much Reid! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58160/new/ https://reviews.llvm.org/D58160 ___

[PATCH] D57464: Generalize method overloading on addr spaces to C++

rjmccall added a comment. Sorry, I've gotten trapped under a backlog and haven't had time to think much about this. I don't want to block progress here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57464/new/ https://reviews.llvm.org/D57464

[PATCH] D59367: [Sema] Adjust address space of operands in remaining builtin operators

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This patch LGTM. You might consider adding tests for weird cases like class types with conversion operators to reference types. To a certain extent that sort of thing is unimplementable

[PATCH] D59529: Refactor cast<>'s in if conditionals, which can only assert on failure.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59529/new/ https://reviews.llvm.org/D59529 ___ c

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

aheejin added a comment. In D59448#1433607 , @dschuff wrote: > LGTM; I wonder if it makes sense to have predefined macro for the C++ tag (or > perhaps just a regular macro for use in libcxxabi?) The only place the `throw` builtin will be used in within

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

aheejin added a comment. In D59448#1433622 , @craig.topper wrote: > Shouldn't the definition in BuiltinsWebAssembly.def be updated to include an > 'I' in the type string so that this will be properly diagnosed in the > frontend? Done. Thank you for ch

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

aheejin updated this revision to Diff 191240. aheejin added a comment. - Add `I` to `wasm.throw` builtin's tag argument Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59448/new/ https://reviews.llvm.org/D59448 Files: include/clang/Basic/BuiltinsWebAssembly.def

r356436 - [WebAssembly] Change wasm.throw's first argument to an immediate

Author: aheejin Date: Mon Mar 18 21:58:59 2019 New Revision: 356436 URL: http://llvm.org/viewvc/llvm-project?rev=356436&view=rev Log: [WebAssembly] Change wasm.throw's first argument to an immediate Summary: `wasm.throw` builtin's first 'tag' argument should be an immediate index into the event s

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

This revision was automatically updated to reflect the committed changes. Closed by commit rC356436: [WebAssembly] Change wasm.throw's first argument to an immediate (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D59448?vs=191240&id=191241#toc Repositor

r356441 - Refactor cast<>'s in if conditionals, which can only assert on failure.

m.org/pipermail/cfe-commits/Week-of-Mon-20190318/265044.html Differential Revision: https://reviews.llvm.org/D59529 Modified: cfe/trunk/lib/AST/ASTImporter.cpp cfe/trunk/lib/AST/DeclBase.cpp cfe/trunk/lib/CodeGen/CGExprConstant.cpp cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp cfe/trunk

[PATCH] D59529: Refactor cast<>'s in if conditionals, which can only assert on failure.

This revision was automatically updated to reflect the committed changes. Closed by commit rC356441: Refactor cast<>'s in if conditionals, which can only assert on failure. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D59529?vs=191228&id=191248#toc Re

<    1   2