[PATCH] D59196: [NFC][clang][PCH] ASTStmtReader::VisitStmt(): fixup faulty assert.

riccibruno added a comment. In D59196#1431473 , @lebedev.ri wrote: > In D59196#1429393 , @riccibruno > wrote: > > > I am not an expert in the serialization code (just did some modifications), > > but this seems re

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

riccibruno added inline comments. Comment at: include/clang/AST/Stmt.h:100 unsigned sClass : 8; +unsigned IsOMPStructuredBlock : 1; }; What about a comment explaining the purpose of this bit ? Comment at: include/clang/AST/StmtOpenM

[PATCH] D59196: [NFC][clang][PCH] ASTStmtReader::VisitStmt(): fixup faulty assert.

lebedev.ri abandoned this revision. lebedev.ri added a comment. In D59196#1431531 , @riccibruno wrote: > In D59196#1431473 , @lebedev.ri > wrote: > > > In D59196#1429393 , @

[PATCH] D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good to me. Let's wait for @jyknight though. Comment at: lib/Headers/ia32intrin.h:120 + +#ifndef _MSC_VER +/* Select the correct function based on the size of long. */ --

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:274 + /// Prerequisite: Executable Directive must not be Standalone directive. + Stmt *getStructuredBlock() const; }; riccibruno wrote: > This is not const-correct. The const-qualifie

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

reuk added a comment. @MyDeveloperDay I'm not sure you built this branch. Perhaps you applied this patch to an older version of the repo. For me, SpaceBeforeCpp11BracedListOptions is defined at Format.h:1570. This builds fine for me, on macOS 10.14 with Xcode 10.1's clang. I just rebased onto

[PATCH] D57835: Fix -ftime-report with -x ir

fedor.sergeev added a comment. In D57835#1387622 , @arsenm wrote: > I partially solved the problem with double printing the reports. It's from > this in cc1_main: > > // If any timers were active but haven't been destroyed yet, print theirp > // resu

[PATCH] D57835: Fix -ftime-report with -x ir

fedor.sergeev added inline comments. Comment at: test/Frontend/ftime-report-bitcode.ll:1 +; RUN: %clang_cc1 -triple x86_64-apple-darwin10 -ftime-report -emit-obj -o /dev/null %s 2>&1 | FileCheck %s + Can you, please, test -fexperimental-new-pass-manager mode as

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast added subscribers: asb, majnemer, lhames. hubert.reinterpretcast added a comment. @asb @lhames @majnemer, based on D36826 , I believe that your guidance would be helpful here regarding the use of `llvm_unreachable`, `report_fatal_error`, an

[PATCH] D58757: Add a version of the pass_object_size attribute that works with builtin_dynamic_object_size

erik.pilkington updated this revision to Diff 190917. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58757/new/ https://reviews.llvm.org/D58757 Files: clang/include/clang/Basic/

[PATCH] D58757: Add a version of the pass_object_size attribute that works with builtin_dynamic_object_size

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1570 +def PassDynamicObjectSize : InheritableParamAttr { + let Spellings = [Clang<"pass_dynamic_object_size">]; + let Args = [IntArgument<"Type">]; aaron.ballman wrote: > Why u

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang created this revision. akhuang added reviewers: rnk, george.burgess.iv. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. -try to preprocess the file before reducing -try to remove some command line arguments -now requires a

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

efriedma added a comment. Anyone looking at updating the datalayout for other platforms? (If nobody is looking at all, I'll try to find some time next week, I guess.) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57335/new/ https://reviews.llvm.org/D57335 ___

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 190929. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py ==

[PATCH] D59406: [analyzer] Teach scan-build to find /usr/bin/clang when installed in /usr/local/bin/

NoQ added a comment. This should indeed take care of our relatively tricky macOS use-case! I'm a bit worried for unexpected consequences on some of the more exotic linux setups - who knows what `../..` is supposed to contain. Maybe restrict this lookup to Darwin somehow? - And i guess let's eve

[PATCH] D59406: [analyzer] Teach scan-build to find /usr/bin/clang when installed in /usr/local/bin/

dcoughlin added a comment. That's a good point. I've updated the patch to look for 'xcrun' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59406/new/ https://reviews.llvm.org/D59406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D59406: [analyzer] Teach scan-build to find /usr/bin/clang when installed in /usr/local/bin/

dcoughlin updated this revision to Diff 190931. dcoughlin edited the summary of this revision. dcoughlin added a comment. Herald added a subscriber: jdoerfert. Update to restrict the new behavior to when Xcode is present. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59406/new/ https://

[PATCH] D59406: [analyzer] Teach scan-build to find /usr/bin/clang when installed in /usr/local/bin/

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59406/new/ https://reviews.llvm.org/D59406 ___ cfe-commits mailing list cfe-commits@lists.l

r356308 - [analyzer] Teach scan-build to find clang when installed in /usr/local/bin/

Author: dcoughlin Date: Fri Mar 15 18:01:29 2019 New Revision: 356308 URL: http://llvm.org/viewvc/llvm-project?rev=356308&view=rev Log: [analyzer] Teach scan-build to find clang when installed in /usr/local/bin/ Change scan-build to support the scenario where scan-build is installed in $TOOLCHAIN

[PATCH] D59406: [analyzer] Teach scan-build to find /usr/bin/clang when installed in /usr/local/bin/

This revision was automatically updated to reflect the committed changes. Closed by commit rL356308: [analyzer] Teach scan-build to find clang when installed in /usr/local/bin/ (authored by dcoughlin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay updated this revision to Diff 190936. MaskRay added a comment. Reflow string literal Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59296/new/ https://reviews.llvm.org/D59296 Files: docs/pp-trace.rst pp-trace/PPCallbacksTracker.cpp pp-

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay updated this revision to Diff 190935. MaskRay added a comment. Reflow comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59296/new/ https://reviews.llvm.org/D59296 Files: docs/pp-trace.rst pp-trace/PPCallbacksTracker.cpp pp-trace/

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

thakis added a comment. In D58418#1431399 , @jkorous wrote: > In D58418#1430630 , @thakis wrote: > > > In D58418#1430490 , @jkorous wrote: > > > > > In D58418#1430160

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay updated this revision to Diff 190937. MaskRay marked an inline comment as done. MaskRay added a comment. Update ReleaseNotes.rst Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59296/new/ https://reviews.llvm.org/D59296 Files: docs/ReleaseN

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay added a comment. In D59296#1430813 , @aaron.ballman wrote: > I think the release notes should be updated to mention that a > previously-supported option has been removed and that there's a new option > available as a replacement; I don't think w

r356307 - hello, clang

Author: charusso Date: Fri Mar 15 16:44:35 2019 New Revision: 356307 URL: http://llvm.org/viewvc/llvm-project?rev=356307&view=rev Log: hello, clang Test commit with head and body. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h Modified: cfe/trunk/include/cl

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. In D54978#1431430 , @mikhail.ramalho wrote: > Sorry for the massive delay, but I just updated the `FindZ3` script to > retrieve the version from the lib. I changed it to use `try_run` instead of > `try_compile` so we can get the ve

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. The only relevant commit that I can find is https://github.com/Z3Prover/z3/commit/2cb4223979cc94e2ebc4e49a9e83adbdcd2b6979 , but it first landed in z3 4.6.0. It looks like it's specific to CMake though, so is it different if you use the python build? I haven't tried the CM

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. In D54978#1431786 , @ddcc wrote: > In D54978#1431430 , @mikhail.ramalho > wrote: > > > Sorry for the massive delay, but I just updated the `FindZ3` script to > > retrieve the versi

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. In D54978#1431788 , @ddcc wrote: > The only relevant commit that I can find is > https://github.com/Z3Prover/z3/commit/2cb4223979cc94e2ebc4e49a9e83adbdcd2b6979 > , but it first landed in z3 4.6.0. It looks like it's speci

[PATCH] D59446: CodeGen: Preserve packed attribute in constStructWithPadding.

pcc created this revision. pcc added reviewers: jfb, glider. Herald added a project: clang. Otherwise the object may have an incorrect size due to tail padding. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D59446 Files: clang/lib/CodeGen/CGDecl.cpp clang/test/CodeGenCXX/a

[PATCH] D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h

craig.topper updated this revision to Diff 190943. craig.topper added a comment. Add comments based on rnk's review Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59346/new/ https://reviews.llvm.org/D59346 Files: lib/Headers/ia32intrin.h test/CodeGen/rot-intr

r356317 - [WebAssembly] Use rethrow intrinsic in the rethrow block

Author: aheejin Date: Fri Mar 15 22:39:12 2019 New Revision: 356317 URL: http://llvm.org/viewvc/llvm-project?rev=356317&view=rev Log: [WebAssembly] Use rethrow intrinsic in the rethrow block Summary: Because in wasm we merge all catch clauses into one big catchpad, in case none of the types in ca

[PATCH] D59353: [WebAssembly] Use rethrow intrinsic in the rethrow block

This revision was automatically updated to reflect the committed changes. Closed by commit rC356317: [WebAssembly] Use rethrow intrinsic in the rethrow block (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D59353?vs=190587&id=190947#toc Repository: rC

<    1   2