[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

kadircet added a comment. Hi Nathan, I would also suggest splitting up current changes so that we can start reviewing them, which might result in other changes in your planned changes and help reduce duplicate work both on our and your side. Also please have a look at D59083

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

kadircet updated this revision to Diff 189817. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59083/new/ https://reviews.llvm.org/D59083 Files: clangd/CodeComp

r355668 - [clang][Index] Mark references from Constructors and Destructors to class as NameReference

Author: kadircet Date: Fri Mar 8 00:30:20 2019 New Revision: 355668 URL: http://llvm.org/viewvc/llvm-project?rev=355668&view=rev Log: [clang][Index] Mark references from Constructors and Destructors to class as NameReference Summary: In current indexing logic we get references to class itself w

[PATCH] D58814: [clang][Index] Mark references from Constructors and Destructors to class as NameReference

This revision was automatically updated to reflect the committed changes. Closed by commit rC355668: [clang][Index] Mark references from Constructors and Destructors to class as… (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58814?vs=189703&id=189818#

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet updated this revision to Diff 189819. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59086/new/ https://reviews.llvm.org/D59086 Files: clangd/GlobalCo

[clang-tools-extra] r355669 - [clangd] Adjust compile commands to be applicable for tooling

Author: kadircet Date: Fri Mar 8 00:38:25 2019 New Revision: 355669 URL: http://llvm.org/viewvc/llvm-project?rev=355669&view=rev Log: [clangd] Adjust compile commands to be applicable for tooling Summary: As can be seen in https://github.com/llvm-mirror/clang/blob/master/lib/Tooling/Tooling.cpp

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

This revision was automatically updated to reflect the committed changes. Closed by commit rL355669: [clangd] Adjust compile commands to be applicable for tooling (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM C

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clangd/CodeComplete.cpp:1613 }; + // We only complete symbol's name, which is same as the class template in the + // case of template specializations. which is the same as the nam

r355670 - Add another test for r354937 that came up in PR40890

Author: hans Date: Fri Mar 8 01:01:10 2019 New Revision: 355670 URL: http://llvm.org/viewvc/llvm-project?rev=355670&view=rev Log: Add another test for r354937 that came up in PR40890 Modified: cfe/trunk/test/CodeGen/x86-64-inline-asm.c Modified: cfe/trunk/test/CodeGen/x86-64-inline-asm.c UR

[PATCH] D59055: [analyzer] Prepare generic taint checker for new sources

boga95 added a comment. Yes, they do. Thanks for the review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59055/new/ https://reviews.llvm.org/D59055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

Re: r354937 - Fix inline assembler constraint validation

Merged to release_80 in r355673. On Wed, Feb 27, 2019 at 1:40 AM Joerg Sonnenberger via cfe-commits wrote: > > Author: joerg > Date: Tue Feb 26 16:40:59 2019 > New Revision: 354937 > > URL: http://llvm.org/viewvc/llvm-project?rev=354937&view=rev > Log: > Fix inline assembler constraint validation

Re: r355491 - Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

Merged to release_80 in r355674. On Wed, Mar 6, 2019 at 11:25 AM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Wed Mar 6 02:26:19 2019 > New Revision: 355491 > > URL: http://llvm.org/viewvc/llvm-project?rev=355491&view=rev > Log: > Inline asm constraints: allow ICE-like pointers

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske updated this revision to Diff 189824. balazske added a comment. Rebase (old patch applied without changes). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53757/new/ https://reviews.llvm.org/D53757 Files: lib/AST/ASTImporter.cpp Index: lib/AST/ASTImpo

[PATCH] D59092: [clangd] Deduplicate Refs on the fly.

hokein updated this revision to Diff 189825. hokein marked 2 inline comments as done. hokein added a comment. Add comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59092/new/ https://reviews.llvm.org/D59092 Files: clangd/index/Ref.cpp cla

[clang-tools-extra] r355676 - [clangd] Deduplicate Refs on the fly.

Author: hokein Date: Fri Mar 8 01:26:30 2019 New Revision: 355676 URL: http://llvm.org/viewvc/llvm-project?rev=355676&view=rev Log: [clangd] Deduplicate Refs on the fly. Summary: Currently, we only do deduplication when we flush final results. We may have huge duplications (refs from headers) du

[PATCH] D59092: [clangd] Deduplicate Refs on the fly.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355676: [clangd] Deduplicate Refs on the fly. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D59092?vs=189825&id=189826#toc Repository: rCTE Clang Tools Extr

[PATCH] D59055: [analyzer] Prepare generic taint checker for new sources

Szelethus accepted this revision. Szelethus added a comment. Cheers! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59055/new/ https://reviews.llvm.org/D59055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske added a comment. This is the next part of the changes for error handling. D53818 was for `ASTImporter` functions only, this is for `ASTNodeImporter` (the `Import_New` functions are not used at many places directly because mostly the few import template

Re: r355489 - clang-cl: Parse /Qspectre and a few other missing options (PR40964)

Merged to release_80 in r355677. On Wed, Mar 6, 2019 at 10:37 AM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Wed Mar 6 01:38:04 2019 > New Revision: 355489 > > URL: http://llvm.org/viewvc/llvm-project?rev=355489&view=rev > Log: > clang-cl: Parse /Qspectre and a few other missin

[PATCH] D59084: [clangd] Remove ./ and ../ in the file paths

kadircet updated this revision to Diff 189828. kadircet added a comment. Herald added a subscriber: jdoerfert. - Add tests Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59084/new/ https://reviews.llvm.org/D59084 Files: clangd/index/Background.cpp

[PATCH] D59128: [clangd] Redirect clangd page.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59128 Files: docs/clangd.rst Index: docs/cla

r355678 - [clang][Tooling] Delete dots and dotdots when generating absolute paths

Author: kadircet Date: Fri Mar 8 01:42:04 2019 New Revision: 355678 URL: http://llvm.org/viewvc/llvm-project?rev=355678&view=rev Log: [clang][Tooling] Delete dots and dotdots when generating absolute paths Summary: GetAllFiles interface returns absolute paths, but keeps dots and dot dots. This p

[PATCH] D59079: [clang][Tooling] Delete dots and dotdots when generating absolute paths

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rL355678: [clang][Tooling] Delete dots and dotdots when generating absolute paths (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong updated this revision to Diff 189830. martong edited the summary of this revision. martong added a comment. Herald added a project: clang. Rebase to master. There was a conflict in the tests, in ASTImporterTest.cpp. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Uhh, it's such a chore to work on these things -- You can really feel that the preprocessor must've been the first thing implemented in clang. Unfortunately, you really have to

[PATCH] D58815: [clangd] Make sure constructors do not reference class

kadircet updated this revision to Diff 189831. kadircet added a comment. - Make use of NameReference symbol role Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58815/new/ https://reviews.llvm.org/D58815 Files: clangd/XRefs.cpp clangd/index/Symbo

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong commandeered this revision. martong edited reviewers, added: a_sidorin; removed: martong. martong added a comment. This revision now requires review to proceed. Herald added subscribers: gamesh411, dkrupp. @a_sidorin Aleksei, If you don't mind, I am going to investigate this further with

[PATCH] D58815: [clangd] Make sure constructors do not reference class

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clangd/XRefs.cpp:160 +if (Roles & static_cast(index::SymbolRole::NameReference)) + return true; if (Loc == SearchedLocation) { Maybe add a blank line so that it is clear

[PATCH] D59128: [clangd] Redirect clangd page.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Fancy! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59128/new/ https://reviews.llvm.org/D59128

[PATCH] D58815: [clangd] Make sure constructors do not reference class

kadircet updated this revision to Diff 189832. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58815/new/ https://reviews.llvm.org/D58815 Files: clangd/XRefs.cp

[clang-tools-extra] r355679 - [clangd] Make sure constructors do not reference class

Author: kadircet Date: Fri Mar 8 01:54:37 2019 New Revision: 355679 URL: http://llvm.org/viewvc/llvm-project?rev=355679&view=rev Log: [clangd] Make sure constructors do not reference class Reviewers: gribozavr Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #c

[PATCH] D58815: [clangd] Make sure constructors do not reference class

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355679: [clangd] Make sure constructors do not reference class (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58815?vs=189832&id=189833#toc Repository: rC

[PATCH] D59128: [clangd] Redirect clangd page.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355680: [clangd] Redirect clangd page. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D59128?vs=189827&id=189834#toc Repository: rCTE Clang Tools Extra CHAN

[clang-tools-extra] r355680 - [clangd] Redirect clangd page.

Author: hokein Date: Fri Mar 8 01:56:42 2019 New Revision: 355680 URL: http://llvm.org/viewvc/llvm-project?rev=355680&view=rev Log: [clangd] Redirect clangd page. Reviewers: gribozavr Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Different

[clang-tools-extra] r355681 - [clangd] Remove ./ and ../ in the file paths

Author: kadircet Date: Fri Mar 8 01:57:33 2019 New Revision: 355681 URL: http://llvm.org/viewvc/llvm-project?rev=355681&view=rev Log: [clangd] Remove ./ and ../ in the file paths Reviewers: hokein Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differe

[PATCH] D59084: [clangd] Remove ./ and ../ in the file paths

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355681: [clangd] Remove ./ and ../ in the file paths (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D59084?vs=189828&id=189835#toc Repository: rCTE Clang T

r355682 - clang-cl : Parse all /d2 options

Author: hans Date: Fri Mar 8 02:00:42 2019 New Revision: 355682 URL: http://llvm.org/viewvc/llvm-project?rev=355682&view=rev Log: clang-cl : Parse all /d2 options We will now warn about such options being unused, which is better than the current "no such file or directory: '/d2foo'" errors. Not

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay updated this revision to Diff 189837. MyDeveloperDay added a comment. Add missing Format.h from the review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59087/new/ https://reviews.llvm.org/D59087 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Forma

r355683 - [clang][Index] Fix msan failure

Author: kadircet Date: Fri Mar 8 02:18:40 2019 New Revision: 355683 URL: http://llvm.org/viewvc/llvm-project?rev=355683&view=rev Log: [clang][Index] Fix msan failure Modified: cfe/trunk/unittests/Index/IndexTests.cpp Modified: cfe/trunk/unittests/Index/IndexTests.cpp URL: http://llvm.org/v

[PATCH] D58749: [index-while-building] IndexRecordHasher

kadircet added inline comments. Comment at: clang/lib/Index/IndexRecordHasher.h:41 + /// Returns hash for all declaration occurences in \c Record. + llvm::hash_code hashRecord(const FileIndexRecord &Record); + llvm::hash_code hash(const Decl *D); Why expose ha

r355685 - [IR][ARM] Add function pointer alignment to datalayout

Author: michaelplatings Date: Fri Mar 8 02:44:06 2019 New Revision: 355685 URL: http://llvm.org/viewvc/llvm-project?rev=355685&view=rev Log: [IR][ARM] Add function pointer alignment to datalayout Use this feature to fix a bug on ARM where 4 byte alignment is incorrectly assumed. Differential Re

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

carwil added a comment. In D59094#1421893 , @efriedma wrote: > Not sure how to write a testcase off the top of my head... have you tried > homogeneous aggregates with more than two elements? Good catch! Seems like if we surpass "isHomogeneousAggregateSm

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

Higuoxing added inline comments. Comment at: clang/include/clang/Format/Format.h:247 + /// When used in conjuction with ``AllowShortIfIfStatementsOnASingleLine`` + /// then when ``true``, ``if (a) return;`` can be put on a single even when Small nit: ``` Al

[libunwind] r355691 - Creating release candidate rc4 from release_800 branch

Author: hans Date: Fri Mar 8 04:20:49 2019 New Revision: 355691 URL: http://llvm.org/viewvc/llvm-project?rev=355691&view=rev Log: Creating release candidate rc4 from release_800 branch Added: libunwind/tags/RELEASE_800/rc4/ - copied from r355690, libunwind/branches/release_80/ ___

[libclc] r355691 - Creating release candidate rc4 from release_800 branch

Author: hans Date: Fri Mar 8 04:20:49 2019 New Revision: 355691 URL: http://llvm.org/viewvc/llvm-project?rev=355691&view=rev Log: Creating release candidate rc4 from release_800 branch Added: libclc/tags/RELEASE_800/rc4/ - copied from r355690, libclc/branches/release_80/ _

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5975-5977 +if ((!ND.isExternallyVisible() && + (!isAnonymousNS || !(VD && VD->hasInit( || + (VD && VD->isStaticLocal())) { aaron.ballman wrote: > This used to unconditionally warn

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam updated this revision to Diff 189843. zahiraam marked 10 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 Files: lib/Sema/SemaDecl.cpp test/CodeGen/dllexport-1.c test/Sema/dllexport-1.cpp test/Sema/dllexpor

RE: r355322 - Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.

You’re right, GCC has these in a header as a #define. This patch didn’t interfere with that and was causing some other failures for us as a result. If its OK, I’d prefer to revert ONLY the enable on Linux mode at the moment, the long-int fix WAS valuable as well. From: James Y Knight [mailto:

[PATCH] D59132: [clangd] Add TOC section to clangd doc.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59132 Files: docs/clangd/Extensions.rst docs

[PATCH] D58897: [ASTImporter] Make ODR error handling configurable

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58897/new/ https://reviews.llvm.org/D58897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58668/new/ https://reviews.llvm.org/D58668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D55358: [ASTImporter] Fix import of NestedNameSpecifierLoc.

martong added a reviewer: a_sidorin. martong added a comment. Herald added a reviewer: martong. Herald added a subscriber: jdoerfert. Herald added a project: clang. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55358/new/ https://reviews.llvm.org/D55358 _

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

kallehuttunen added a comment. I found this checker to be useful in the code base I initially developed it for, but the usage of comparison operators there is pretty much limited to comparing simple aggregate types. It's true that this checker can produce lots of false positives, maybe too much

[PATCH] D59105: [RFC] Create an Arbitrary Precision Integer Type.

erichkeane marked 7 inline comments as done. erichkeane added a comment. Thank you @rsmith for the quick review! I really appreciate it. In D59105#1422088 , @rsmith wrote: > In principle, I think an extension in this space seems reasonable and useful. >

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay updated this revision to Diff 189854. MyDeveloperDay added a comment. Fix spelling typo in documentation and comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59087/new/ https://reviews.llvm.org/D59087 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/c

[PATCH] D59134: [ASTImporter] Remove obsolete function ImportTemplateParameterList.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. The ASTNodeImporter::ImportTemplateParameterList is replaced by

r355697 - Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms."

Author: erichkeane Date: Fri Mar 8 07:10:05 2019 New Revision: 355697 URL: http://llvm.org/viewvc/llvm-project?rev=355697&view=rev Log: Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms." This reverts commit 24400dafe16716f28cd0e7e5fa6e004c0e50686a. Removed: cfe/trunk/test/CodeGe

r355698 - Re-fix _lrotl/_lrotr to always take Long, no matter the platform.

Author: erichkeane Date: Fri Mar 8 07:10:07 2019 New Revision: 355698 URL: http://llvm.org/viewvc/llvm-project?rev=355698&view=rev Log: Re-fix _lrotl/_lrotr to always take Long, no matter the platform. r355322 fixed this, however is being reverted due to concerns with enabling it in other modes.

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

thorsten-klein created this revision. thorsten-klein added reviewers: aaron.ballman, klimek, alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed issue of not considering HeaderFilter which resulted in findings although they should be filtered out. Patch by Thorste

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

kallehuttunen added a comment. Another idea that came to my mind would be to enable this check only for annotated types. So warning for missing field access would be only given for types that have for example `[[clang::annotate("value type")]]` annotation. Possibly other kinds of checks could b

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

thorsten-klein updated this revision to Diff 189859. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59135/new/ https://reviews.llvm.org/D59135 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp Index: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp ==

r355700 - Use {{.*}} in test case to match the type of wide string literals.

Author: ahatanak Date: Fri Mar 8 07:20:12 2019 New Revision: 355700 URL: http://llvm.org/viewvc/llvm-project?rev=355700&view=rev Log: Use {{.*}} in test case to match the type of wide string literals. The type of wide string literals varies depending on the target. Modified: cfe/trunk/test/

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

aaron.ballman added a comment. Can you add test coverage that demonstrates the fix behaves as expected? Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:454-455 + StringRef FileName(Loc.printToString(Loc.getManager())); + if(getHeaderFilter()->match(Fi

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

thorsten-klein added a comment. Hello, Can you please support how to do that? :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59135/new/ https://reviews.llvm.org/D59135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

aaron.ballman added a comment. In D59135#1422781 , @thorsten-klein wrote: > Hello, > Can you please support how to do that? :-) All of the tests live in extra\test\clang-tidy\, so you'd add a file in there. I believe `file-filter.cpp` does stuff with

[clang-tools-extra] r355702 - [clang-tidy] NFC: Negate the name and semantics of the isNotInMacro function.

Author: hwright Date: Fri Mar 8 07:37:15 2019 New Revision: 355702 URL: http://llvm.org/viewvc/llvm-project?rev=355702&view=rev Log: [clang-tidy] NFC: Negate the name and semantics of the isNotInMacro function. This function is always used in a context where its result was also negated, which ma

[PATCH] D58930: Add XCOFF triple object format type for AIX

sfertile accepted this revision. sfertile added a comment. LGTM. Comment at: llvm/lib/MC/MCContext.cpp:165 +case MCObjectFileInfo::IsXCOFF: + // TODO: Need to implement class MCSymbolXCOFF. + break; jasonliu wrote: > sfertile wrote: > > jasonliu w

r355703 - [analyzer] Use the new infrastructure of expressing taint propagation, NFC

Author: szelethus Date: Fri Mar 8 07:47:56 2019 New Revision: 355703 URL: http://llvm.org/viewvc/llvm-project?rev=355703&view=rev Log: [analyzer] Use the new infrastructure of expressing taint propagation, NFC In D55734, we implemented a far more general way of describing taint propagation rules

[PATCH] D59055: [analyzer] Prepare generic taint checker for new sources

This revision was automatically updated to reflect the committed changes. Closed by commit rC355703: [analyzer] Use the new infrastructure of expressing taint propagation, NFC (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D590

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

Charusso requested changes to this revision. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1985 bool partOfParentMacro = false; +StringRef PName = ""; if (ParentEx->getBeginLoc().isMacroID()) { `Pa

r355704 - [analyzer] Emit an error rather than assert on invalid checker option input

Author: szelethus Date: Fri Mar 8 08:00:42 2019 New Revision: 355704 URL: http://llvm.org/viewvc/llvm-project?rev=355704&view=rev Log: [analyzer] Emit an error rather than assert on invalid checker option input Asserting on invalid input isn't very nice, hence the patch to emit an error instead.

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

This revision was automatically updated to reflect the committed changes. Closed by commit rC355704: [analyzer] Emit an error rather than assert on invalid checker option input (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57

[PATCH] D59048: Add AIX Target Info

sfertile added inline comments. Comment at: clang/test/Preprocessor/init.c:6420 +// PPC64-AIX:#define _LONG_LONG 1 +// PPC64-AIX:#define _POWER 1 +// PPC64-AIX:#define __64BIT__ 1 hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > > apaprocki wrote:

[PATCH] D58977: [clang-tidy] Add the abseil-time-comparison check

hwright added inline comments. Comment at: clang-tidy/abseil/TimeComparisonCheck.cpp:23 + auto Matcher = + binaryOperator(anyOf(hasOperatorName(">"), hasOperatorName(">="), + hasOperatorName("=="), hasOperatorName("<="), ioeric wro

[PATCH] D58977: [clang-tidy] Add the abseil-time-comparison check

hwright updated this revision to Diff 189862. hwright marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58977/new/ https://reviews.llvm.org/D58977 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/TimeComp

r355705 - [analyzer] Fix infinite recursion in printing macros

Author: szelethus Date: Fri Mar 8 08:26:29 2019 New Revision: 355705 URL: http://llvm.org/viewvc/llvm-project?rev=355705&view=rev Log: [analyzer] Fix infinite recursion in printing macros In the commited testfile, macro expansion (the one implemented for the plist output) runs into an infinite r

[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL355705: [analyzer] Fix infinite recursion in printing macros (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D57662: [clang-tidy] Parallelize clang-tidy-diff.py

zinovy.nis added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

thorsten-klein added a comment. Sorry for delay. I am currently not able to build master (Error: "sort" is not a member of "llvm"). And if I try to build 6.0.1-rc3 I can build clang-tidy but I am not able to build corresponding unittests "ClangTidyTests". I will try to solve as soon as possible.

[PATCH] D58216: Support attribute used in member funcs of class templates II

davezarzycki added a comment. I've got a patch pending for Swift. That being said, the clang diagnostics leave something to be desired. If `__attribute__((used))` on definitions is sloppy at best or wrong at worst, then that should have a warning/error. Want a bug report? Or does one exist alre

[PATCH] D59038: [8.0 Regression] Fix handling of `__builtin_constant_p` inside the enable_if attribute.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, and I think this is safe enough to take for Clang 8. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59038/new/ https://reviews.llvm.org/D59038

[PATCH] D59038: [8.0 Regression] Fix handling of `__builtin_constant_p` inside the enable_if attribute.

hans added a comment. In D59038#1422890 , @rsmith wrote: > LGTM, and I think this is safe enough to take for Clang 8. Do you think the severity is high enough to spin another release candidate? My concern is that since this didn't show up in testing unt

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler added a comment. I definitely understand how the diagnostic can be confusing. However, it's the same diagnostic gcc provides too, so gcc users wouldn't be surprised. But you're right this can be improved by at least mentioning the attribute used in the diagnostic message. There's no bu

[PATCH] D58216: Support attribute used in member funcs of class templates II

davezarzycki added a comment. https://bugs.llvm.org/show_bug.cgi?id=41016 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58216/new/ https://reviews.llvm.org/D58216 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D59038: [8.0 Regression] Fix handling of `__builtin_constant_p` inside the enable_if attribute.

EricWF updated this revision to Diff 189888. EricWF added a comment. - Fix regressions inside template parameters, case statements, and enumerators. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59038/new/ https://reviews.llvm.org/D59038 Files: lib/AST/ExprConstant.cpp test/SemaCXX

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

sigatrev added a comment. This implementation doesn't track the push/pop stack, it just verifies the synax is valid and moves on. I modeled it after the PragmaWarningHandler which does the same, and thought it would be fine in this case since the only accepted value is a no-op. CHANGES SINCE

[PATCH] D59038: [8.0 Regression] Fix handling of `__builtin_constant_p` inside the enable_if attribute.

EricWF added a comment. In D59038#1422905 , @hans wrote: > In D59038#1422890 , @rsmith wrote: > > > LGTM, and I think this is safe enough to take for Clang 8. > > > Do you think the severity is high enough to spin a

[PATCH] D59048: Add AIX Target Info

andusy updated this revision to Diff 189890. andusy added a comment. Herald added a subscriber: javed.absar. - Updated comments - Added testing for `UseZeroLengthBitfieldAlignment` - Defined `_THREAD_SAFE ` when `-pthread` is enabled - Check for definition of `__LP64__ ` and `_LP64 ` macros CH

[PATCH] D59048: Add AIX Target Info

andusy marked 7 inline comments as done. andusy added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:641 +} + } + hubert.reinterpretcast wrote: > D18360 sets `_THREAD_SAFE` to `1` when `-pthread` is specified. I believe > that to be correc

[PATCH] D59048: Add AIX Target Info

andusy marked 2 inline comments as done. andusy added inline comments. Comment at: clang/test/CodeGen/arm-aapcs-zerolength-bitfield.c:5 +// RUN: %clang_cc1 -triple powerpc-ibm-aix7.1.0.0 %s -verify +// expected-no-diagnostics This file is pending a name change.

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added a comment. @jasonliu, you have had a number of patches committed into the project already (D22698 , D22702 , D34649 ). Please go ahead with requesting commit access, a

[PATCH] D56928: Support attribute used in member funcs of class templates

phosek added a comment. Herald added a project: clang. This broke the 2-stage LTO build of LLVM, the error is: ld.lld: /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/IR/Constants.cpp:995: static llvm::Constant *llvm::ConstantArray::getImpl(llvm::ArrayType *, ArrayRef): Assert

Re: r355627 - Recommit "Support attribute used in member funcs of class templates"

This seems to have broke the 2-stage LTO build of LLVM, the error is: ld.lld: /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/IR/Constants.cpp:995: static llvm::Constant *llvm::ConstantArray::getImpl(llvm::ArrayType *, ArrayRef): Assertion `V[i]->getType() == Ty->getElementType() &&

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 189905. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 Files: docs/analyzer/checkers.rst include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL355720: [Analyzer] Checker for non-determinism caused by sorting of pointer-like… (authored by mgrang, committed by ). Her

r355720 - [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Author: mgrang Date: Fri Mar 8 12:13:53 2019 New Revision: 355720 URL: http://llvm.org/viewvc/llvm-project?rev=355720&view=rev Log: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements Summary: Added a new category of checkers for non-determinism. Added a checker fo

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

thakis accepted this revision. thakis added a comment. Ah ok, then I agree this doesn't need serialization yet :) It'd be nice to at least diag that the stack use is valid (also for the warning stack), but it doesn't have to be in this change. CHANGES SINCE LAST ACTION https://reviews.llvm.o

r355721 - Revert "Recommit "Support attribute used in member funcs of class templates""

Author: rafauler Date: Fri Mar 8 12:23:57 2019 New Revision: 355721 URL: http://llvm.org/viewvc/llvm-project?rev=355721&view=rev Log: Revert "Recommit "Support attribute used in member funcs of class templates"" There is nontrivial bug caused in lld that I need to further investigate. Meanwhile,

r355725 - Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/"

Author: ormris Date: Fri Mar 8 12:33:55 2019 New Revision: 355725 URL: http://llvm.org/viewvc/llvm-project?rev=355725&view=rev Log: Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/" This broke the windows bots. This reverts commit 28302c66d2586074f77497d5dc4eac7182b6

[libunwind] r355725 - Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/"

Author: ormris Date: Fri Mar 8 12:33:55 2019 New Revision: 355725 URL: http://llvm.org/viewvc/llvm-project?rev=355725&view=rev Log: Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/" This broke the windows bots. This reverts commit 28302c66d2586074f77497d5dc4eac7182b6

  1   2   >