[PATCH] D58862: [cmake] Create exports for umbrella library targets

2019-03-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added a subscriber: mgorny. Herald added projects: clang, LLVM. When using the umbrella llvm-libraries and clang-libraries targets, we should export all library targets, otherwise they'll be part of our distribution but

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-03-01 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. This looks good, but could you also add an entry in the ReleaseNotes for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 ___ cfe

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-03-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai updated this revision to Diff 188988. smeenai added a comment. Release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-e

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-03-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. I added an entry to the release notes. The release notes change only covers the changes in this diff. My plan is to land this, wait for a few days (so that users of the target get broken in an obvious way), and then add the new install-clang-headers target (for installi

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-03-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In D58791#1415496 , @tstellar wrote: > This looks good, but could you also add an entry in the ReleaseNotes for this. Will do – thanks for the reminder :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-03-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai updated this revision to Diff 189014. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-extra/te

<    1   2