[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

This revision was automatically updated to reflect the committed changes. Closed by commit rL354924: [MS] Don't emit coverage for deleting dtors (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r354925 - [OPENMP]Delay emission for unsupported va_arg expression.

Author: abataev Date: Tue Feb 26 12:52:16 2019 New Revision: 354925 URL: http://llvm.org/viewvc/llvm-project?rev=354925&view=rev Log: [OPENMP]Delay emission for unsupported va_arg expression. If the OpenMP device is NVPTX and va_arg is used, delay emission of the error for va_arg unless it is use

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

NoQ added a comment. Herald added a subscriber: Charusso. In D46421#1382017 , @martong wrote: > > I think you should change back to getInit() > > I am not entirely sure about this because the initalizer may not be attached > to the canonical decl. `getIni

[PATCH] D57590: [ASTImporter] Improve import of FileID.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM I don't see any LLDB test regressions but I would prefer another reviewer as well. I am going to be modifying this soon to fix some issues w/ handling built-ins. Repository: rC Clang

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57716/new/ https://reviews.llvm.org/D57716 ___ cfe-commits mailing list cfe-commits@lists.

r354928 - [OPENMP][CUDA]Do not emit warnings for variables in late-reported asm

Author: abataev Date: Tue Feb 26 13:51:16 2019 New Revision: 354928 URL: http://llvm.org/viewvc/llvm-project?rev=354928&view=rev Log: [OPENMP][CUDA]Do not emit warnings for variables in late-reported asm statements. If the assembler instruction is not generated and the delayed diagnostic is emitt

[PATCH] D57590: [ASTImporter] Improve import of FileID.

a_sidorin added a comment. Hi Gabor, Sorry, missed the patch. It looks mostly good, but do we have any test for this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57590/new/ https://reviews.llvm.org/D57590 ___ cfe-c

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thanks for the fixes! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494 ___

[PATCH] D58518: [HIP] change kernel stub name

tra accepted this revision. tra added subscribers: jyknight, bkramer. tra added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CodeGenModule.cpp:1059 +FD->hasAttr()) + MangledName = MangledName + ".stub"; +

[PATCH] D57460: [WIP] Prototype a generic kernel offloading interface

jdoerfert updated this revision to Diff 188458. jdoerfert added a comment. Herald added projects: clang, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits. Cleaned up clang part and interface. LLVM part still needs work Repository: rG LLVM Github Monorepo CHANG

[PATCH] D57460: [WIP] Prototype a generic kernel offloading interface

jdoerfert added a comment. I updated the patch with one that has a clean clang and runtime integration. It passes all but one OpenMP V&V test suite test (developed as part of ECP by U Del and others). The LLVM optimization gives us 30% speedup on the rodinia3.1/nw (Needleman Wunsch) benchmark (

[PATCH] D57460: [WIP] Prototype a generic kernel offloading interface

jdoerfert updated this revision to Diff 188460. jdoerfert added a comment. Remove leftover debug msgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57460/new/ https://reviews.llvm.org/D57460 Files: clang/lib/CodeGen/CGOpenMPRuntime.h clang/lib

[PATCH] D57460: [WIP] Prototype a generic kernel offloading interface

jdoerfert updated this revision to Diff 188462. jdoerfert added a comment. Remove more unneeded changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57460/new/ https://reviews.llvm.org/D57460 Files: clang/lib/CodeGen/CGOpenMPRuntimeTRegion.cpp

[PATCH] D57460: [WIP] Prototype a generic kernel offloading interface

jdoerfert updated this revision to Diff 188461. jdoerfert added a comment. Remove unneeded changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57460/new/ https://reviews.llvm.org/D57460 Files: clang/lib/CodeGen/CGOpenMPRuntimeTRegion.cpp cla

r354929 - [CUDA][HIP] Check calling convention based on function target

Author: yaxunl Date: Tue Feb 26 14:24:49 2019 New Revision: 354929 URL: http://llvm.org/viewvc/llvm-project?rev=354929&view=rev Log: [CUDA][HIP] Check calling convention based on function target MSVC header files using vectorcall to differentiate overloaded functions, which causes failure for AMD

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

This revision was automatically updated to reflect the committed changes. Closed by commit rC354929: [CUDA][HIP] Check calling convention based on function target (authored by yaxunl, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Maybe update at least some of the tests using these targets to additionally run with the new pass manager explicitly enabled via flag? Comment at: clang/lib/

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM Thanks for looking into this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57628/new/ https://reviews.llvm.org/D57628 ___ cfe-c

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Probably worth sending an email to llvmdev noting that the datalayout is changing before you merge this, so a wider audience can review the IR aspects of the change. Otherwise LGTM Repo

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

jkorous added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:266 +auto *NewAttrTy = cast(T.getTypePtr()); +for (TypeAttrPair &A : AttrsForTypes) { + if (A.first == AttrTy) Do you think it would make sense to terminate the loop e

[PATCH] D58600: [clangd] Emit source to Diagnostic.

jkorous added inline comments. Comment at: clangd/Diagnostics.cpp:381 LastDiag = Diag(); +LastDiag->ID = Info.getID(); FillDiagBase(*LastDiag); Nit - is this really intended to be part of this patch? Comment at: clangd/Diagnostics

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai added a comment. In D58147#1398094 , @rjmccall wrote: > Okay. Is it acceptable for the annotation to simply disappear in this case? > I don't really understand the purposes of annotations well enough to judge. Looks like it is acceptable. The

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

ahatanak updated this revision to Diff 188472. ahatanak marked an inline comment as done. ahatanak added a comment. Call `IgnoreParens` on the LHS too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58514/new/ https://reviews.llvm.org/D58514 Files: include/clan

r354899 - [X86] AMD znver2 enablement

Author: ggopala Date: Tue Feb 26 09:15:36 2019 New Revision: 354899 URL: http://llvm.org/viewvc/llvm-project?rev=354899&view=rev Log: [X86] AMD znver2 enablement This patch enables the following 1) AMD family 17h "znver2" tune flag (-march, -mcpu). 2) ISAs that are enabled for "znver2" architect

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge added a comment. I think this is ready to continue to be reviewed :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 ___ cfe-commits mailing list cfe-com

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58649: Fix inline assembler constraint validation

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Nice find! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58649/new/ https://reviews.llvm.org/D58649 ___ cfe-commits mailing list cfe

[PATCH] D58649: Fix inline assembler constraint validation

efriedma added inline comments. Comment at: include/clang/Basic/TargetInfo.h:860 + if (!ImmSet.empty()) +return ImmSet.count(Value.getZExtValue()) != 0; + return !ImmRange.isConstrained || (Value.sge(ImmRange.Min) && Value.sle(ImmRange.Max)); I

r354937 - Fix inline assembler constraint validation

Author: joerg Date: Tue Feb 26 16:40:59 2019 New Revision: 354937 URL: http://llvm.org/viewvc/llvm-project?rev=354937&view=rev Log: Fix inline assembler constraint validation The current constraint logic is both too lax and too strict. It fails for input outside the [INT_MIN..INT_MAX] range, but

[PATCH] D58649: Fix inline assembler constraint validation

This revision was automatically updated to reflect the committed changes. Closed by commit rL354937: Fix inline assembler constraint validation (authored by joerg, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

r354942 - [index] Improve indexing support for MSPropertyDecl.

Author: vsapsai Date: Tue Feb 26 17:04:53 2019 New Revision: 354942 URL: http://llvm.org/viewvc/llvm-project?rev=354942&view=rev Log: [index] Improve indexing support for MSPropertyDecl. Currently the symbol for MSPropertyDecl has kind `SymbolKind::Unknown` which can trip up various indexing tool

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354942: [index] Improve indexing support for MSPropertyDecl. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

vsapsai added a comment. Thanks for reviewing the change! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57628/new/ https://reviews.llvm.org/D57628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

r354946 - [index] Fixup for r354942. Specify target in test to achieve stable mangling.

Author: vsapsai Date: Tue Feb 26 17:37:43 2019 New Revision: 354946 URL: http://llvm.org/viewvc/llvm-project?rev=354946&view=rev Log: [index] Fixup for r354942. Specify target in test to achieve stable mangling. Modified: cfe/trunk/test/Index/ms-property.cpp Modified: cfe/trunk/test/Index/ms

r354948 - [HIP] change kernel stub name

Author: yaxunl Date: Tue Feb 26 18:02:52 2019 New Revision: 354948 URL: http://llvm.org/viewvc/llvm-project?rev=354948&view=rev Log: [HIP] change kernel stub name Add .stub to kernel stub function name so that it is different from kernel name in device code. This is necessary to let debugger find

[PATCH] D58518: [HIP] change kernel stub name

This revision was automatically updated to reflect the committed changes. Closed by commit rL354948: [HIP] change kernel stub name (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D58518

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

jkorous requested changes to this revision. jkorous added a comment. This revision now requires changes to proceed. Hi @comex, I totally missed this! Thanks for the patch. I am not entirely happy about this dependency though. I am trying to split off the only parts of clangDaemon that XpcTranspor

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Reconsidered - let's fix the build first and I can finish my patch tomorrow. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58089/new/ https://r

[clang-tools-extra] r354949 - [clangd] Library dependencies in XPC

Author: jkorous Date: Tue Feb 26 18:37:44 2019 New Revision: 354949 URL: http://llvm.org/viewvc/llvm-project?rev=354949&view=rev Log: [clangd] Library dependencies in XPC Patch by Nicholas Allegra Differential Revision: https://reviews.llvm.org/D58089 Modified: clang-tools-extra/trunk/clang

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354949: [clangd] Library dependencies in XPC (authored by jkorous, committed by ). Changed prior to commit: https://reviews.llvm.org/D58089?vs=186369&id=188494#toc Repository: rCTE Clang Tools Extr

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar updated this revision to Diff 188500. tstellar added a comment. Use macros instead of functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https://reviews.llvm.org/D58537 Files: clang/lib/Headers/CMakeLists.txt Index: c

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar added a comment. In D58537#1411657 , @tstellar wrote: > Use macros instead of functions. I mean "Use functions instead of macros." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https:/

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

rjmccall added a comment. A couple tweaks, but otherwise LGTM. Comment at: clang/include/clang/AST/OperationKinds.def:203 +/// CK_FixedPointToIntegral - Fixed point to an integral. +///(int) 2.0k This is super-picky, but please either just say "integral"

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58514/new/ https://reviews.llvm.org/D58514 ___ c

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Well, it won't have a guarantee that it won't see unused annotations, but alright, I'm fine with this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58147/new/ https://reviews.ll

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. In D56411#1410598 , @yaxunl wrote: > In D56411#1410153 , @rjmccall wrote: > > > In D56411#1406212

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4620 const TargetInfo &TI = Context.getTargetInfo(); - TargetInfo::CallingConvCheckResult A = TI.checkCallingConvention(CC); + auto *Aux = Context.getAuxTargetInfo(); + if (LangOpts.CUDA) { --

<    1   2