[PATCH] D58612: Use std::atomic<> for static counters.

ilya-biryukov added a comment. In D58612#1408831 , @riccibruno wrote: > Hmm. These are not the only static variables which are used for statistics > (eg: in `DeclBase.cpp`). Would it make sense instead to keep all of the > statistics in the AST context (

[PATCH] D58612: Use std::atomic<> for static counters.

riccibruno added a comment. In D58612#1408836 , @ilya-biryukov wrote: > In D58612#1408831 , @riccibruno > wrote: > > > Hmm. These are not the only static variables which are used for statistics > > (eg: in `DeclB

[PATCH] D58612: Use std::atomic<> for static counters.

ilya-biryukov added a comment. In D58612#1408839 , @riccibruno wrote: > I don't know how hard it would be to do this, but I would like to argue that > this should be done even if it require some refactoring. These static > variables used for stats are ki

[PATCH] D58612: Use std::atomic<> for static counters.

riccibruno added a comment. In D58612#1408843 , @ilya-biryukov wrote: > In D58612#1408839 , @riccibruno > wrote: > > > I don't know how hard it would be to do this, but I would like to argue > > that this should

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno added a comment. It looks better now as far as I can see. I like the idea of aliasing `SanitizerKind` to `SanitizerMasks<>;`. Comment at: include/clang/Basic/Sanitizers.h:133 // bit positions. enum SanitizerOrdinal : uint64_t { #define SANITIZER(NAME, ID) SO_##ID

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

alexfh added inline comments. Comment at: clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp:45 + const auto* RHS = BinOp->getRHS()->IgnoreParenImpCasts(); + // & , mask is a compile time constant. + Expr::EvalResult RHSVal; What about ` & `?

[PATCH] D58612: Use std::atomic<> for static counters.

alexfh updated this revision to Diff 188163. alexfh added a comment. Make the counters non-static members of ASTContext. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58612/new/ https://reviews.llvm.org/D58612 Files: clang/include/clang/AST/ASTC

[PATCH] D58612: Use std::atomic<> for static counters.

alexfh added a comment. In D58612#1408845 , @riccibruno wrote: > In D58612#1408843 , @ilya-biryukov > wrote: > > > In D58612#1408839 , @riccibruno > > wrote: > > > > > I do

[PATCH] D58612: Use std::atomic<> for static counters.

riccibruno added a comment. Okay, but what about the other similar uses of static members which have the same problem ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58612/new/ https://reviews.llvm.org/D58612 ___

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet updated this revision to Diff 188165. courbet marked 3 inline comments as done. courbet added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 Files: clang-tidy/

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet added a comment. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

riccibruno added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11292 +} + +/// Argument's value might be modified, so update the info. Hmm, I don't think that this will work. Suppose that you have an expression like `(a, b) += c` You want to mark `b` as mo

r354789 - [AArch64] Add support for Cortex-A76 and Cortex-A76AE

Author: lukecheeseman Date: Mon Feb 25 07:11:31 2019 New Revision: 354789 URL: http://llvm.org/viewvc/llvm-project?rev=354789&view=rev Log: [AArch64] Add support for Cortex-A76 and Cortex-A76AE - Add LLVM backend support for Cortex-A76 and Cortex-A76AE - Documentation can be found at https://de

[PATCH] D57764: [AArch64] Add Cortex-A76 and Cortex-A76AE Support

This revision was automatically updated to reflect the committed changes. Closed by commit rL354789: [AArch64] Add support for Cortex-A76 and Cortex-A76AE (authored by LukeCheeseman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58612: Use std::atomic<> for static counters.

alexfh added a comment. In D58612#1408942 , @riccibruno wrote: > Okay, but what about the other similar uses of static members which have the > same problem ? Do you have any example in mind? I've only seen TSan warnings for these counters, nothing els

[PATCH] D58623: [AMDGPU] Allow using integral non-type template parameters

hliao created this revision. hliao added reviewers: kzhuravl, yaxunl. Herald added subscribers: cfe-commits, jdoerfert, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely. Herald added a project: clang. - Allow using integral non-type template parameters in the following attributes __attribute__((

[PATCH] D58341: [clangd] Index UsingDecls

kadircet updated this revision to Diff 188170. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341 Files: unittests/clang

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 188171. kadircet added a comment. - Add SymbolSubKind for UsingDeclarations Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/D58340 Files: include/clang/Index/IndexSymbol.h lib/Index/Ind

[PATCH] D58612: Use std::atomic<> for static counters.

riccibruno added a comment. In D58612#1408991 , @alexfh wrote: > In D58612#1408942 , @riccibruno > wrote: > > > Okay, but what about the other similar uses of static members which have > > the same problem ? > > >

[PATCH] D58623: [AMDGPU] Allow using integral non-type template parameters

hliao added a comment. non-type template parameter is used in these attributes in one of major workload. In addition, it also revises the constexpr support by allowing lvalue. The diagnostic message is refined too by pointing out which parameter violates the requirement of constant integer. Pre

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 188175. pgousseau added a comment. Keep `enum SanitizerOrdinal` as it was inside `SanitizerKind` namespace, fix comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.t

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked 2 inline comments as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:54 + static constexpr bool + checkBitPos(const SanitizerKind::SanitizerOrdinal &Pos) { +return Pos < kNumBits; riccibruno wrote: > `San

[PATCH] D56539: [clangd] Drop documentation in static index if symbols are not indexed for completion.

hokein updated this revision to Diff 188176. hokein marked an inline comment as done. hokein added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. Rebase and address comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

hans added inline comments. Comment at: docs/ReleaseNotes.rst:228 -OpenCL C Language Changes in Clang +OpenCL Language Changes in Clang -- Anastasia wrote: > Anastasia wrote: > > AlexeySotkin wrote: > > > AlexeySotkin wrote: > >

[PATCH] D58612: Use std::atomic<> for static counters.

alexfh added a comment. In D58612#1409024 , @riccibruno wrote: > In D58612#1408991 , @alexfh wrote: > > > In D58612#1408942 , @riccibruno > > wrote: > > > > > Okay, but what

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

emilio marked 2 inline comments as done. emilio added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:1695 +CXType RT = clang_getResultType(T); +if (RT.kind != CXType_Invalid) + PrintSingleTypeSize(RT, " [resulttype=%s] [resulttypekind=%s]",

[PATCH] D58612: Use std::atomic<> for static counters.

riccibruno accepted this revision. riccibruno added a comment. This revision is now accepted and ready to land. Sounds good. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58612/new/ https://reviews.llvm.org/D58612 _

[clang-tools-extra] r354792 - [clangd] Drop documentation in static index if symbols are not indexed for completion.

Author: hokein Date: Mon Feb 25 08:00:00 2019 New Revision: 354792 URL: http://llvm.org/viewvc/llvm-project?rev=354792&view=rev Log: [clangd] Drop documentation in static index if symbols are not indexed for completion. Summary: This is a further optimization of r350803, we drop docs in static i

[PATCH] D42645: New simple Checker for mmap calls

alexfh added inline comments. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. Comment at: cfe/trunk/lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:31-33 + static int ProtWrite; + static int ProtExec; + static int ProtRead; Can these b

[PATCH] D58612: Use std::atomic<> for static counters.

ilya-biryukov added a comment. Awesome, I was also surprised it's so easy to convert them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58612/new/ https://reviews.llvm.org/D58612 ___ cfe-commits maili

[PATCH] D56539: [clangd] Drop documentation in static index if symbols are not indexed for completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354792: [clangd] Drop documentation in static index if symbols are not indexed for… (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D56539?vs=188176&id=188180#to

[PATCH] D58627: [git] Add top-level .gitignore

hliao created this revision. hliao added reviewers: kzhuravl, yaxunl. hliao added a project: clang. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. [D56411 ] Temp solution fixing CUDA template issue - template with overloadable ke

[PATCH] D58627: [git] Add top-level .gitignore

hliao abandoned this revision. hliao added a comment. by mistake, Ctrl-C is not fast enough to stop it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58627/new/ https://reviews.llvm.org/D58627 ___ cfe-

[PATCH] D58612: Use std::atomic<> for static counters.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58612/new/ https://reviews.llvm.org/D58612 ___ cfe-commits mailing list cfe-comm

r354795 - Make static counters in ASTContext non-static.

Author: alexfh Date: Mon Feb 25 08:08:46 2019 New Revision: 354795 URL: http://llvm.org/viewvc/llvm-project?rev=354795&view=rev Log: Make static counters in ASTContext non-static. Summary: Fixes a data race and makes it possible to run clang-based tools in multithreaded environment with TSan. Re

[PATCH] D58612: Use std::atomic<> for static counters.

riccibruno added a comment. (With a commit message which actually reflect the change of course) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58612/new/ https://reviews.llvm.org/D58612 ___ cfe-commits

[PATCH] D58612: Use std::atomic<> for static counters.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354795: Make static counters in ASTContext non-static. (authored by alexfh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings updated this revision to Diff 188184. michaelplatings added a comment. Herald added subscribers: cfe-commits, jdoerfert, mgorny, dschuff. Herald added projects: clang, LLVM. Hi @efriedma, sorry for the delayed response. I've added the features you asked for to DataLayout. It is int

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. Herald added a reviewer: martong. Ping. Please raise your objections if you have any until the 4th of March (that date we are going to commit if there are no objections). Also, please let us know if you find this deadline too strict. Repository: rC Clang CHANGES SI

[PATCH] D58612: Use std::atomic<> for static counters.

alexfh added a comment. > In D58612#1409024 , @riccibruno > wrote: > >> ... >> For example in `DeclBase.cpp` >> >> #define DECL(DERIVED, BASE) static int n##DERIVED##s = 0; >> #define ABSTRACT_DECL(DECL) >> #include "clang/AST/DeclNodes.inc" >> >>

[PATCH] D58612: Use std::atomic<> for static counters.

riccibruno added a comment. In D58612#1409215 , @alexfh wrote: > > In D58612#1409024 , @riccibruno > > wrote: > > > >> ... > >> For example in `DeclBase.cpp` > >> > >> #define DECL(DERIVED, BASE) static int n##

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rL354799: Release notes for OpenCL (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D58504?vs=

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

Anastasia added a comment. Committed to the release branch r354799. FYI, I did a couple of formatting changes and typo fixes. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58504/new/ https://reviews.llvm.org/D58504 _

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings marked 4 inline comments as done. michaelplatings added inline comments. Comment at: llvm/lib/IR/ConstantFold.cpp:1087 + if (GVAlign == 0U && isa(GV)) +GVAlign = 4U; efriedma wrote: > Using "4" as a default is dangerous; on

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. This is fixing one of the issues reported in the bug: https://bugs.llvm.org/show_bug.cgi?id=40778 https://reviews.llvm.org/D58634 Files: lib/CodeGen/CGCall.cpp test/CodeGenOpenCLCXX/addrspace-references.cl Inde

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:4067 + IRFuncTy->getParamType(FirstIRArg)->isPointerTy()) +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getPa

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

Anastasia added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:1695 +CXType RT = clang_getResultType(T); +if (RT.kind != CXType_Invalid) + PrintSingleTypeSize(RT, " [resulttype=%s] [resulttypekind=%s]", emilio wrote: > Anastasia

[PATCH] D58612: Make the static counters in ASTContext non-static

alexfh added a comment. In D58612#1409216 , @riccibruno wrote: > In D58612#1409215 , @alexfh wrote: > > > > In D58612#1409024 , @riccibruno > > > wrote: > > > > > >> ... >

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 188213. dgoldman added a comment. - Remove (class extension) as it's no longer needed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp unittests/AST/NamedD

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. In D56924#1407836 , @arphaman wrote: > Please add a test that covers the '(class extension)' output as well. Removed the `(class extension)` output as the property getter if statement should now handle this. Repository: rC

[PATCH] D58638: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier

lildmh created this revision. lildmh added reviewers: ABataev, hfinkel, Meinersbur, kkwli0. lildmh added a project: OpenMP. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch implements the parsing and sema support for OpenMP from clause with pot

[PATCH] D58638: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58638/new/ https://reviews.llvm.org/D58638 ___ cfe-commits ma

r354806 - [analyzer] Fix infinite recursion in printing macros

Author: szelethus Date: Mon Feb 25 10:49:42 2019 New Revision: 354806 URL: http://llvm.org/viewvc/llvm-project?rev=354806&view=rev Log: [analyzer] Fix infinite recursion in printing macros #define f(y) x #define x f(x) int main() { x; } This example results a compilation error since "x" in the f

[PATCH] D57892: [analyzer] Fix macro printer crash when macro comes from another translation unit

This revision was automatically updated to reflect the committed changes. Closed by commit rL354806: [analyzer] Fix infinite recursion in printing macros (authored by Szelethus, committed by ). Herald added subscribers: llvm-commits, Charusso. Herald added a project: LLVM. Changed prior to commit

[PATCH] D57892: [analyzer] Fix macro printer crash when macro comes from another translation unit

Szelethus added a comment. Whoops, incorrect commit title and description. Anyways, the committed code and the revision number is OK... Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57892/new/ https://reviews.llvm.org/D57892 ___

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188224. tmroeder added a comment. Changed to use llvm::find. Given the disagreement about the destructuring assignment, I didn't make that change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.ll

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

ilya-biryukov updated this revision to Diff 188225. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Check in the middle and at the end of identifiers. - Add a test for the second parameter and a class member function Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

ilya-biryukov added inline comments. Comment at: clang/include/clang/Sema/Sema.h:294 + /// function_ref, clients should make sure all calls to get() with the same + /// location happen while function_ref is alive. + void enterFunctionArgument(SourceLocation Tok, --

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

ilya-biryukov updated this revision to Diff 188226. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58541/new/ https://reviews.llvm.org/D58541 Files: clang

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:494 default: assert(false && "unhnalded unary op"); return QualType(); xbolva00 wrote: > Typo? Fixed it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D58556: [LibTooling] Add "smart" retrieval of AST-node source to FixIt library

ilya-biryukov added a comment. Thanks, the APIs totally make sense. And seem to fit into the other functions we have in `FixIt.h`, although the name of the file is somewhat misleading. Mostly comments about naming and one comment about the necessity of using matchers from my side. ===

r354812 - Revert "Make static counters in ASTContext non-static."

Author: vlad.tsyrklevich Date: Mon Feb 25 11:53:13 2019 New Revision: 354812 URL: http://llvm.org/viewvc/llvm-project?rev=354812&view=rev Log: Revert "Make static counters in ASTContext non-static." This reverts commit r354795, I suspect it is causing test failures on MSan sanitizer bots. Modifi

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 188232. mgrang set the repository for this revision to rC Clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 Files: docs/analyzer/checkers.rst include/clang/StaticAnalyzer/Checke

[PATCH] D56933: [Tooling][RFC] Introduce Stencil library to simplify source code generation in refactorings.

lebedev.ri added subscribers: ilya-biryukov, gribozavr, lebedev.ri. lebedev.ri added a comment. See also: https://lists.llvm.org/pipermail/cfe-dev/2019-February/061414.html How are these two RFC's/API's supposed to interact/coexist/etc? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In D50488#1407884 , @Szelethus wrote: > In D50488#1405094 , @mgrang wrote: > > > So I was able compile a couple of C++ code bases through csa-testbench. I > > built cppcheck and tinyxml2 wit

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang marked an inline comment as done. mgrang added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:97 +def NonDeterminismAlpha : Package<"nondeterminism">, ParentPackage; + Szelethus wrote: > Hmmm, okay, so your checker ks C++

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In D50488#1407975 , @Szelethus wrote: > But, as a work-in-progress alpha checker, the direction is set and looks > great. Please let @NoQ have the final say. Thanks a lot @Szelethus! I will wait for @NoQ 's comments. Repository

Re: [PATCH] D56933: [Tooling][RFC] Introduce Stencil library to simplify source code generation in refactorings.

We're working out the details, but the intent is that the Tree-transformation library would support the implementation of Transformer. That is, this library is targeted at a lower-level/more advanced user than Transformer. Currently, Transformer is implemented directly on the clang AST API, but we

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert updated this revision to Diff 188238. jdoerfert marked 3 inline comments as done. jdoerfert added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/ https://reviews.llvm.org/D58091 Files: clang/include

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert added a comment. I did address the comments but I will wait until I hear back on the "warning vs warning + note question". In D58091#1397586 , @jyknight wrote: > I think this warning (-Wbuiltin-requires-header) doesn't really make sense as > i

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

efriedma added a subscriber: hfinkel. efriedma added a comment. Chandler, when you have a chance, can you look at the LangRef changes, since you put some thought into the design? I think the DataLayout/LangRef changes look correct. I agree it isn't necessary to fix every target in the initial p

Re: r354795 - Make static counters in ASTContext non-static.

I've reverted this commit in r354812, it was causing MSan failures like http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/29886/steps/check-clang%20msan/logs/stdio Though these error reports don't clearly implicate this change, from your change it seems like the failure is occurr

<    1   2