[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. > There is a revision to solve this problem here: D58065 > . I guess your input, as someone who didn't > participate in the checker dependency related patch reviews would be > invaluable, in terms of whether my description is understandab

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

aemerson added a comment. In D58320#1402254 , @peter.smith wrote: > The implementation changes in the Darwin toolchain look fine to me, although > with respect to the command line option I think Petr Hosek's message on > cfe-dev is interesting: > > > GCC

r354417 - CMake: Fix stand-alone clang builds since r353268

Author: tstellar Date: Tue Feb 19 17:11:05 2019 New Revision: 354417 URL: http://llvm.org/viewvc/llvm-project?rev=354417&view=rev Log: CMake: Fix stand-alone clang builds since r353268 Summary: Handle the case where LLVM_MAIN_SRC_DIR is not set and also use LLVM_CMAKE_DIR for locating installed c

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous created this revision. jkorous added reviewers: arphaman, dexonsmith, akyrtzi, nathawes, yvvan. Herald added subscribers: cfe-commits, jdoerfert, jfb, mgorny. Herald added a project: clang. This patch contains implementation of DirectoryWatcher from github.com/apple/swift-clang We are st

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

This revision was automatically updated to reflect the committed changes. Closed by commit rL354417: CMake: Fix stand-alone clang builds since r353268 (authored by tstellar, committed by ). Changed prior to commit: https://reviews.llvm.org/D58204?vs=186769&id=187473#toc Repository: rL LLVM

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Based on the -dev discussion, update once the target machine differences are addressed by mimicing the way the legacy PM works, which will hopefully restrict this similarly to

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

chandlerc added a comment. In D58375#1403144 , @efriedma wrote: > I can understand why tests that use -O1 or -O2 would produce different > results with the new pass manager, but it looks like not all the tests are > like that. Do you know why those test

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 added a comment. In D57497#1394137 , @efriedma wrote: > > Did you mean declare as a target feature in RISCV.td or I misunderstanding > > something? > > That's sort of the right idea, but I don't think it works in this context > because we aren'

[PATCH] D58424: [NewPM] Add other sanitizers at O0

leonardchan created this revision. leonardchan added reviewers: chandlerc, philip.pfaffe, fedor.sergeev. leonardchan added a project: clang. This allows for MSan and TSan to be used without optimizations required. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58424 Files: c

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

NoQ added a comment. I'll take a closer look in a few days, sorry for the delays! The progress you're making is fantastic and i really appreciate your work, but i have an urgent piece of work of my own to deal with this week. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53076/new/ ht

[PATCH] D58424: [NewPM] Add other sanitizers at O0

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58424/new/ https://reviews.llvm.org/D58424 _

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek updated this revision to Diff 187493. Herald added a subscriber: mstorsjo. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58375/new/ https://reviews.llvm.org/D58375 Files: clang/test/CMakeLists.txt clang/test/CodeGen/aarch64-neon-across.c clang/test/Co

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ updated this revision to Diff 187497. NoQ marked 13 inline comments as done. NoQ added a comment. Fxd, thx! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58365/new/ https://reviews.llvm.org/D58365 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1310 +def MIGServerRoutine : InheritableAttr { + let Spellings = [Clang<"mig_server_routine">]; aaron.ballman wrote: > Should this be limited to specific targets, or is this a general con

[PATCH] D58366: [analyzer] MIGChecker: Make use of the server routine annotation.

NoQ updated this revision to Diff 187498. NoQ added a comment. Rebase due to an update in D58365 - namely, add support for Objective-C messages and blocks that are now allowed to wear the attribute. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58366/n

[PATCH] D58366: [analyzer] MIGChecker: Make use of the server routine annotation.

NoQ updated this revision to Diff 187501. NoQ added a comment. Whoops - make sure that the Objective-C test does actually test something. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58366/new/ https://reviews.llvm.org/D58366 Files: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ updated this revision to Diff 187502. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58368/new/ https://reviews.llvm.org/D58368 Files: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp clang/test/Analysis/mig.mm Index: clang/test/Analysis/mig.mm

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek added a comment. In D58375#1403144 , @efriedma wrote: > I can understand why tests that use -O1 or -O2 would produce different > results with the new pass manager, but it looks like not all the tests are > like that. Do you know why those tests a

[PATCH] D58392: [analyzer] MIGChecker: Fix false negatives for releases in automatic destructors.

NoQ updated this revision to Diff 187503. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58392/new/ https://reviews.llvm.org/D58392 Files: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp clang/test/Analysis/mig.mm Index: clang/test/Analysis/mig.mm ===

r354431 - [NewPM] Add other sanitizers at O0

Author: leonardchan Date: Tue Feb 19 19:50:11 2019 New Revision: 354431 URL: http://llvm.org/viewvc/llvm-project?rev=354431&view=rev Log: [NewPM] Add other sanitizers at O0 This allows for MSan and TSan to be used without optimizations required. Differential Revision: https://reviews.llvm.org/D5

[PATCH] D58397: [analyzer] MIGChecker: Pour more data into the checker.

NoQ updated this revision to Diff 187505. NoQ added a comment. Rebase. Fix behavior when the return code is not constrained enough. Test the C++11 attribute syntax (just in case). Update comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58397/new/ https://reviews.llvm.org/D58397

[PATCH] D58424: [NewPM] Add other sanitizers at O0

This revision was automatically updated to reflect the committed changes. Closed by commit rL354431: [NewPM] Add other sanitizers at O0 (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me as long as Aaron is happy with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58365/new/ https://reviews.llvm.org/D58365

r354432 - Remove test on incompatible mpis target.

Author: leonardchan Date: Tue Feb 19 20:35:28 2019 New Revision: 354432 URL: http://llvm.org/viewvc/llvm-project?rev=354432&view=rev Log: Remove test on incompatible mpis target. Modified: cfe/trunk/test/Driver/msan.c Modified: cfe/trunk/test/Driver/msan.c URL: http://llvm.org/viewvc/llvm-p

[PATCH] D58366: [analyzer] MIGChecker: Make use of the server routine annotation.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Analysis/mig.mm:2 +// RUN: %clang_analyze_cc1 -w -analyzer-checker=core,alpha.osx.MIG\ +// RUN:-fblocks -verify %s --

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

stephanemoore updated this revision to Diff 187512. stephanemoore added a comment. Added licensing preamble to stdio.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58095/new/ https://reviews.llvm.org/D58095 Files: clang-tools-extra/clang-tidy/g

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

stephanemoore marked 4 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/Inputs/Headers/stdio.h:1 +#ifndef _STDIO_H_ +#define _STDIO_H_ aaron.ballman wrote: > aaron.ballman wrote: > > stephanemoore wrote:

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me. I have some a minor diagnostic wording suggestion in line. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:109 +llvm::raw_svector_ost

r354435 - Limit new PM tests to X86 registered targets.

Author: leonardchan Date: Tue Feb 19 21:07:14 2019 New Revision: 354435 URL: http://llvm.org/viewvc/llvm-project?rev=354435&view=rev Log: Limit new PM tests to X86 registered targets. Modified: cfe/trunk/test/Driver/msan.c cfe/trunk/test/Driver/tsan.c Modified: cfe/trunk/test/Driver/msan

[PATCH] D58392: [analyzer] MIGChecker: Fix false negatives for releases in automatic destructors.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Oh, interesting. I'm glad you thought of this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58392/new/ https://reviews.llvm.org/D58392 __

[PATCH] D58397: [analyzer] MIGChecker: Pour more data into the checker.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Aah, MIG_NO_REPLY. LGTM. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:42 + std::vector> Deallocators = { +#define CALL(required_args, deallocated_arg,

<    1   2