[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58254/new/ https://reviews.llvm.org/D58254 ___ cfe-commits mailing list

[PATCH] D58269: [clang] Add build and install targets for clang libraries

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added a subscriber: mgorny. Herald added a project: clang. This is modeled after the existing llvm-libraries target. It's a convenient way to include all clang libraries in a distribution. This differs slightly from the

[PATCH] D58269: [clang] Add build and install targets for clang libraries

smeenai updated this revision to Diff 186957. smeenai added a comment. Fix condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58269/new/ https://reviews.llvm.org/D58269 Files: clang/CMakeLists.txt clang/cmake/modules/AddClang.cmake Inde

[PATCH] D58269: [clang] Add build and install targets for clang libraries

smeenai added a comment. A couple of things I noticed while writing this patch: - clang guards its install target creation with `CMAKE_CONFIGURATION_TYPES`, whereas LLVM uses `LLVM_ENABLE_IDE`. Should clang be switched over to be consistent with LLVM? - I realize we create the `install-clang-li

r354097 - Revert "Fix implementation of [temp.local]p4."

Author: thegameg Date: Thu Feb 14 19:06:15 2019 New Revision: 354097 URL: http://llvm.org/viewvc/llvm-project?rev=354097&view=rev Log: Revert "Fix implementation of [temp.local]p4." This reverts commit 40bd10b770813bd1471d46f514545437516aa4ba. This seems to now emit an error when building the sa

Re: r354091 - Fix implementation of [temp.local]p4.

I reverted this temporarily in r354097. > On Feb 14, 2019, at 6:35 PM, Francis Visoiu Mistrih > wrote: > > Hi Richard, > > This seems to now emit an error when building the sanitizer tests: > http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/53965/consoleFull > >

[PATCH] D58268: [clang] Create install targets for non-shared libraries

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58268/new/ https://reviews.llvm.org/D58268 ___

[PATCH] D58269: [clang] Add build and install targets for clang libraries

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58269/new/ https://reviews.llvm.org/D58269 ___

[PATCH] D58164: Block+lambda: allow reference capture

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. Sorry, I was misunderstanding the problem. I was trying to understand why the crash goes away if I change the generic lambda to a non-generic one. What I found was that, when the lambda is

[PATCH] D58164: Block+lambda: allow reference capture

ahatanak requested changes to this revision. ahatanak added a comment. This revision now requires changes to proceed. Sorry, I didn't mean to accept this yet. I think this is something that is better fixed in Sema. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 186963. steleman added a comment. Addressed comments from Renato: - Diagnostic for unsupported argument to -fveclib= is now: error: unsupported option '' for target '' - Added check and diagnostic for SVML on non-Intel ISA's. Repository: rC Clang

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

r354102 - [Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop

Author: sammccall Date: Thu Feb 14 23:16:11 2019 New Revision: 354102 URL: http://llvm.org/viewvc/llvm-project?rev=354102&view=rev Log: [Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop Summary: The idea is that the code here isn't written, so doesn't indicate a bug.

[PATCH] D58134: [Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop

This revision was automatically updated to reflect the committed changes. Closed by commit rL354102: [Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repos

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma added a comment. I think this is in good shape. Comment at: lib/Sema/JumpDiagnostics.cpp:675 + // asm-goto. + //if (!IsAsmGoto && IndirectJumpTargets.empty()) { + if (JumpTargets.empty()) { Commented-out code? We probably don't need a diagnostic fo

<    1   2