[PATCH] D57797: Variable auto-init: fix __block initialization

jfb marked 5 inline comments as done. jfb added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1642 CharUnits Size = getContext().getTypeSizeInChars(type); if (!Size.isZero()) { rjmccall wrote: > Does this check handle flexible arrays on zero-siz

[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, alexfh, JonasToth. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The modernize-use-default-member-init check crashes when trying to create an assignment value for a value-initi

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, mgrang, szepet, whisperity. Herald added a project: clang. Here we go guys

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

rupprecht added a comment. Herald added a project: clang. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56943/new/ https://reviews.llvm.org/D56943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, kristof.beyls, whisperity, javed.absar. Herald added a project: cla

r353350 - Revert "[analyzer] Remove the "postponed" hack, deal with derived symbols..."

Author: dergachev Date: Wed Feb 6 15:56:43 2019 New Revision: 353350 URL: http://llvm.org/viewvc/llvm-project?rev=353350&view=rev Log: Revert "[analyzer] Remove the "postponed" hack, deal with derived symbols..." This reverts commit r341722. The "postponed" mechanism turns out to be necessary i

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Herald added a project: clang. Validate whether the op

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek added a comment. In D56305#1363417 , @carwil wrote: > Hi, we're currently working on similar functionality for the ARM backend, so > I got pointed to take a look at this patch. > Looks good to me, I quite like the tablegen improvements, but agree

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek updated this revision to Diff 185667. phosek marked 2 inline comments as done. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56305/new/ https://reviews.llvm.org/D56305 Fil

[PATCH] D57797: Variable auto-init: fix __block initialization

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1643 CharUnits Size = getContext().getTypeSizeInChars(type); if (!Size.isZero()) { switch (trivialAutoVarInit) { jfb wrote: > rjmccall wrote: > > Can't you just drill to the byref

r353353 - [analyzer] Canonicalize declarations within variable regions.

Author: dergachev Date: Wed Feb 6 16:30:20 2019 New Revision: 353353 URL: http://llvm.org/viewvc/llvm-project?rev=353353&view=rev Log: [analyzer] Canonicalize declarations within variable regions. Memory region that correspond to a variable is identified by the variable's declaration and, in cas

[PATCH] D57619: [analyzer] Canonicalize variable declarations in VarRegion objects.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353353: [analyzer] Canonicalize declarations within variable regions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. This looks reasonable to me but I don't have strong opinions on refactoring gtest tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57322/new/ https://revi

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though I am by no means a gtest expert. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57322/new/ https://reviews.llvm.org/D57322 ___ cfe-comm

r353355 - [opaque pointer types] Pass through function types for TLS

Author: jyknight Date: Wed Feb 6 17:14:17 2019 New Revision: 353355 URL: http://llvm.org/viewvc/llvm-project?rev=353355&view=rev Log: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls. Differential Revision: https://reviews.llvm.org/D57801 Mod

[PATCH] D57801: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353355: [opaque pointer types] Pass through function types for TLS (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D57801?vs=185467&id=185677#toc Repository:

r353356 - [opaque pointer types] Make EmitCall pass Function Types to

Author: jyknight Date: Wed Feb 6 17:15:41 2019 New Revision: 353356 URL: http://llvm.org/viewvc/llvm-project?rev=353356&view=rev Log: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke. Also, remove the getFunctionType() function from CGCallee, since it accesses the po

[PATCH] D57804: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353356: [opaque pointer types] Make EmitCall pass Function Types to (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D57804?vs=185476&id=185678#toc Repository:

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

sammccall commandeered this revision. sammccall edited reviewers, added: ilya-biryukov; removed: sammccall. sammccall added a comment. (Grabbing this as discussed offline) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 ___

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

sammccall updated this revision to Diff 185690. sammccall added a comment. Herald added a project: clang. Update matching to use Inputs.ASTSelection. Cover some more cases of names (I think?) Handle under-qualified names as well as unqualified ones. The main benefit of this is it's a step closer

r353370 - Generalised the SMT state constraints

Author: mramalho Date: Wed Feb 6 19:17:36 2019 New Revision: 353370 URL: http://llvm.org/viewvc/llvm-project?rev=353370&view=rev Log: Generalised the SMT state constraints This patch moves the ConstraintSMT definition to the SMTConstraintManager header to make it easier to move the Z3 backend a

r353371 - Got rid of the `Z3ConstraintManager` class

Author: mramalho Date: Wed Feb 6 19:18:10 2019 New Revision: 353371 URL: http://llvm.org/viewvc/llvm-project?rev=353371&view=rev Log: Got rid of the `Z3ConstraintManager` class Now, instead of passing the reference to a shared_ptr, we pass the shared_ptr instead. I've also removed the check if

r353372 - Moved the whole SMT API to a single file. NFC.

Author: mramalho Date: Wed Feb 6 19:18:21 2019 New Revision: 353372 URL: http://llvm.org/viewvc/llvm-project?rev=353372&view=rev Log: Moved the whole SMT API to a single file. NFC. There is no advantage in having them in separate files, I doubt some will ever use them separately. This also mak

[PATCH] D54976: [analyzer] Got rid of the `Z3ConstraintManager` class

This revision was automatically updated to reflect the committed changes. Closed by commit rC353371: Got rid of the `Z3ConstraintManager` class (authored by mramalho, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.

[PATCH] D54977: [analyzer] Moved the whole SMT API to a single file. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353372: Moved the whole SMT API to a single file. NFC. (authored by mramalho, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://revi

r353373 - Move the SMT API to LLVM

Author: mramalho Date: Wed Feb 6 19:19:45 2019 New Revision: 353373 URL: http://llvm.org/viewvc/llvm-project?rev=353373&view=rev Log: Move the SMT API to LLVM Moved everything SMT-related to LLVM and updated the cmake scripts. Differential Revision: https://reviews.llvm.org/D54978 Added: c

[PATCH] D54978: Move the SMT API to LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rC353373: Move the SMT API to LLVM (authored by mramalho, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54978?vs

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100. Herald added a project: clang. In wasm, we always use '-matomics' when we use '-pthread'. This will make users type one less option and options will be m

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

aheejin updated this revision to Diff 185700. aheejin added a comment. - Small fix Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files: lib/Frontend/CompilerInvocation.cpp test/Driver/wasm32-unknown-unknown.cpp te

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

kristina added a comment. The patch itself looks sound. However given that you have a specific use case in mind (TableGen files) could you provide supplementary coverage for that specific use case (unit tests for formatting `td` syntax using `format::getLLVMStyle(format::FormatStyle::LK_TableGe

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. If this is a target flag in GCC, shouldn't we make it a LLVM Target feature and pass it as -mattr, just like done for mrelax? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

kees added a comment. In D56571#1386973 , @kees wrote: > Not sure if this is the fault of the LLVM half or the Clang half, but I'm > seeing mis-compilations in the current patches (llvm > ca1e713fdd4fab5273b36ba6f292a844fca4cb2d with D53765 >

[PATCH] D54978: Move the SMT API to LLVM

lebedev.ri added subscribers: mehdi_amini, lebedev.ri. lebedev.ri added a comment. Looks like this (all all other related Z3 reviews - D54975 , D54976 , D54977 ) review has completely omitted cfe-c

[PATCH] D57838: [clang-cl] support /Oy- on aarch64

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57838/new/ https://reviews.llvm.org/D57838 ___ cfe-commit

<    1   2