[PATCH] D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept

JonasToth added a comment. In D57108#1369161 , @lebedev.ri wrote: > Hmm, i think this diff is incorrect. Doesn't it also include the changes from > D57100 ? yup, needs constant rebasing, i will do a final rebase once th

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth updated this revision to Diff 183489. JonasToth marked an inline comment as done. JonasToth added a comment. - revert the option configuration change for comma/semicolon Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/ https://revi

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth marked 2 inline comments as done. JonasToth added a comment. Reverted the changes. Maybe the comma thingie will just stay as is ;) Comment at: clang-tidy/utils/ExceptionAnalyzer.h:25 +/// give the possibility of an exception. +class ExceptionAnalyzer { +public: --

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth updated this revision to Diff 183490. JonasToth added a comment. - revert doc change as well Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/ https://reviews.llvm.org/D57100 Files: clang-tidy/bugprone/ExceptionEscapeCheck.cpp

[PATCH] D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept

JonasToth updated this revision to Diff 183491. JonasToth added a comment. - rebase to latest patch Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57108/new/ https://reviews.llvm.org/D57108 Files: clang-tidy/bugprone/ExceptionEscapeCheck.cpp cla

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

ebevhan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:437 + // DEFAULT-NEXT: [[RES:%[a-z0-9]+]] = trunc i39 [[SATMIN]] to i16 + // DEFAULT-NEXT: store i16 [[RES]], i16* %sat_sa, align 2 + leonardchan wrote: > ebevhan wrote: >

[PATCH] D57015: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI

This revision was automatically updated to reflect the committed changes. Closed by commit rC352177: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI (authored by asl, committed by ). Changed prior to commit: https://reviews.llvm.org/D57015?vs=182784&id=183492#toc Repository: rC Cla

r352177 - [MSP430] Ajust f32/f64 alignment according to MSP430 EABI

Author: asl Date: Fri Jan 25 00:51:53 2019 New Revision: 352177 URL: http://llvm.org/viewvc/llvm-project?rev=352177&view=rev Log: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI Patch by Kristina Bessonova! Differential Revision: https://reviews.llvm.org/D57015 Added: cfe/trunk/te

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

philip.pfaffe accepted this revision. philip.pfaffe added a comment. This revision is now accepted and ready to land. It would be good to check, since the bots won't! Otherwise this looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 _

[PATCH] D56925: Do not use frame pointer by default for MSP430

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Patch fails to apply. Please rebase. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56925/new/ https://reviews.llvm.org/D56925 __

[PATCH] D56936: Fix handling of overriden methods during ASTImport

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Shafik, thanks for addressing the comments. This looks good to me now! Comment at: lib/AST/ASTImporter.cpp:3042 + if (FoundByLookup) { +if (auto *MD = dyn_cast(Found

r352181 - Disable PIC/PIE for MSP430 target by default.

Author: asl Date: Fri Jan 25 01:41:20 2019 New Revision: 352181 URL: http://llvm.org/viewvc/llvm-project?rev=352181&view=rev Log: Disable PIC/PIE for MSP430 target by default. Relocatable code generation is meaningless on MSP430, as the platform is too small to use shared libraries. Patch by Dm

[PATCH] D56927: Disable PIC/PIE for MSP430 target

This revision was automatically updated to reflect the committed changes. Closed by commit rC352181: Disable PIC/PIE for MSP430 target by default. (authored by asl, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D

[PATCH] D56936: Fix handling of overriden methods during ASTImport

balazske added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:2312 + cxxMethodDecl(hasName("f"), hasParent(cxxRecordDecl(hasName("B"; + auto BFPIsDefP = cxxMethodDecl( + hasName("f"), hasParent(cxxRecordDecl(hasName("B"))), isDefinition());

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

ebevhan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:141 + (RHSType->isFixedPointType() && + LHSType->isFixedPointOrIntegerType()); +} Can't it just be `LHSType->isFixedPointType() || RHSType->isFixedPointType

[clang-tools-extra] r352183 - [clang-tidy] Add check for underscores in googletest names.

Author: hokein Date: Fri Jan 25 02:03:49 2019 New Revision: 352183 URL: http://llvm.org/viewvc/llvm-project?rev=352183&view=rev Log: [clang-tidy] Add check for underscores in googletest names. Summary: Adds a clang-tidy warning for underscores in googletest names. Patch by Kar Epker! Reviewers:

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

This revision was automatically updated to reflect the committed changes. Closed by commit rL352183: [clang-tidy] Add check for underscores in googletest names. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56424

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

hokein added a comment. In D56424#1370461 , @karepker wrote: > Rebasing against master. > > Not sure if re-arc diffing this is necessary, but I hope it doesn't hurt. Didn't notice that you don't have commit access, committed in rL352183

[PATCH] D56581: [ASTImporter] Set the described template if not set

martong added a comment. @shafik Ok, I'll take a look into the regression soon. What are exactly gmodules? Is it macOS only? Do you have a description or some docs about it? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56581/new/ https://reviews.llvm.org/D56581

[clang-tools-extra] r352184 - [clangd] Log clang-tidy configuration, NFC

Author: hokein Date: Fri Jan 25 02:14:27 2019 New Revision: 352184 URL: http://llvm.org/viewvc/llvm-project?rev=352184&view=rev Log: [clangd] Log clang-tidy configuration, NFC Summary: This is used for debugging purpose. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous,

[PATCH] D57057: [clangd] Log clang-tidy configuration, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL352184: [clangd] Log clang-tidy configuration, NFC (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

SjoerdMeijer added inline comments. Comment at: include/clang/Basic/TargetInfo.h:66 bool HasFloat128; + bool HasFloat16; unsigned char PointerWidth, PointerAlign; I think this is the same as `HasLegalHalfType`, and we can (re)use that. Or, at least, don'

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationAdditionCheck.cpp:22 +void DurationAdditionCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + binaryOperator(hasOperatorName("+"), This whole file is structurally sim

r352186 - Revert r352181 as it's breaking the bots

Author: asl Date: Fri Jan 25 02:35:35 2019 New Revision: 352186 URL: http://llvm.org/viewvc/llvm-project?rev=352186&view=rev Log: Revert r352181 as it's breaking the bots Removed: cfe/trunk/test/CodeGen/msp430-reloc.c Modified: cfe/trunk/lib/Driver/ToolChains/MSP430.h Modified: cfe/trunk

[PATCH] D56927: Disable PIC/PIE for MSP430 target

asl reopened this revision. asl added a comment. This revision is now accepted and ready to land. The patch was reverted – the test requires fully configured msp430 configuration and therefore was breaking the bots. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D57060: [NFC][Clang] Add driver tests for sb and predres

pbarrio accepted this revision. pbarrio added a comment. This revision is now accepted and ready to land. Same idea as https://reviews.llvm.org/D54961 but for two other command line options. Approved! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57060/new/ http

[PATCH] D56927: Disable PIC/PIE for MSP430 target

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Please make sure the test passes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927 _

[PATCH] D57223: [Tooling] Handle #pragma once header guard in include insertion.

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D57223 Files: lib/Tooling/Inclusions/HeaderIncludes.cpp unittests/Tooling/HeaderIncludesTest.cpp Index: unittests/Tooling/HeaderInclu

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ioeric added a comment. Friendly ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56903/new/ https://reviews.llvm.org/D56903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ioeric updated this revision to Diff 183507. ioeric added a comment. - minor touch on documentation. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56903/new/ https://reviews.llvm.org/D56903 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ioeric updated this revision to Diff 183509. ioeric added a comment. - Rebase correctly Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56903/new/ https://reviews.llvm.org/D56903 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp clangd/Clang

r352192 - Fix "control reaches end of non-void function" warning. NFCI.

Author: rksimon Date: Fri Jan 25 03:36:51 2019 New Revision: 352192 URL: http://llvm.org/viewvc/llvm-project?rev=352192&view=rev Log: Fix "control reaches end of non-void function" warning. NFCI. Modified: cfe/trunk/lib/AST/ExprObjC.cpp Modified: cfe/trunk/lib/AST/ExprObjC.cpp URL: http://l

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

ebevhan created this revision. ebevhan added reviewers: leonardchan, rjmccall. Herald added a subscriber: cfe-commits. ebevhan marked an inline comment as done. ebevhan added inline comments. Comment at: include/clang/Serialization/ASTBitCodes.h:1637 + /// A FixedPointLitera

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

ebevhan marked an inline comment as done. ebevhan added inline comments. Comment at: include/clang/Serialization/ASTBitCodes.h:1637 + /// A FixedPointLiteral record. + EXPR_FIXEDPOINT_LITERAL, + I'm unsure if this is the right location for a new code. T

[PATCH] D57228: [clangd] Make USRs for macros to be position independent

kadircet created this revision. kadircet added a reviewer: jkorous. Herald added subscribers: cfe-commits, arphaman, MaskRay, ioeric, ilya-biryukov. USRs for macros were not cannonical due to usage of cursor location instead of definition location. Repository: rCTE Clang Tools Extra https://r

[PATCH] D57230: [analyzer] Toning down invalidation a bit

xazax.hun created this revision. xazax.hun added reviewers: dergachev.a, george.karpenkov, Szelethus. xazax.hun added a project: clang. Herald added subscribers: gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. This is a patch for the fo

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. During import of a global variable with external visibility the lookup will find variables (with the same na

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 183523. martong added a comment. - Remove old style import in case of FoundArray Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 Files: include/clang/AST/ASTImporter.h lib/AST/AST

[PATCH] D57235: [AST] Add structural eq tests for template args

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. New tests added to verify equivalency of templates when their parameters are different. Repository: rC Clang https://reviews.llvm.org/D5723

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno marked 2 inline comments as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5103 +using reference = AssociationTy; +using pointer = AssociationTy; +AssociationIteratorTy() = default; dblaikie wrote: > aaron.ball

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

JonasToth added inline comments. Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:51 +///instead of the actual OpenMPClauseKind. +AST_MATCHER_P(OMPExecutableDirective, isAllowedToContainClause, + OpenMPClauseKind, CKind) { Why is this re

[PATCH] D57230: [analyzer] Toning down invalidation a bit

Szelethus accepted this revision. Szelethus edited reviewers, added: NoQ; removed: dergachev.a. Szelethus added a subscriber: NoQ. Szelethus added a comment. This revision is now accepted and ready to land. Let's also have a link to your cfe-dev mail in this patch: http://lists.llvm.org/pipermail

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

alexfh added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matchers::internal::Matcher, The

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. This patch unifies all those tests which check the correctness of the redecl chains. Previously we had sever

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

ABataev added inline comments. Comment at: test/clang-tidy/openmp-use-default-none.cpp:26 +void t2() { +#pragma omp parallel default(none) + ; JonasToth wrote: > AFAIK `default(private)` should exist as well, please add tests for the other > kinds, too. No, onl

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. In D57104#1369751 , @riccibruno wrote: > Cleanup the patch by factoring out the NFC changes. > > @steveire This should be much clearer now. I'd like to apply this patch locally, but I think the removed parts are not in the repo

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri marked 4 inline comments as done. lebedev.ri added inline comments. Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:51 +///instead of the actual OpenMPClauseKind. +AST_MATCHER_P(OMPExecutableDirective, isAllowedToContainClause, + OpenMPClause

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri marked 4 inline comments as done and an inline comment as not done. lebedev.ri added a comment. @JonasToth thanks for taking a look BTW! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57113/new/ https://reviews.llvm.org/D57113 _

[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

riccibruno created this revision. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Various cleanups to GenericSelectionExpr, factored out of D57104 . In particular: 1. Move the friend declaration to the top. 2. Introduce a constant `Resu

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

hwright updated this revision to Diff 183531. hwright added a comment. Sort release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57185/new/ https://reviews.llvm.org/D57185 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/Dura

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

ABataev added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); lildmh wrote: > ABataev wrote: > > lildmh wrote: > > > ABataev wrote: > > >

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno added a comment. In D57104#1371161 , @steveire wrote: > In D57104#1369751 , @riccibruno > wrote: > > > Cleanup the patch by factoring out the NFC changes. > > > > @steveire This should be much clearer no

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5103 +using reference = AssociationTy; +using pointer = AssociationTy; +AssociationIteratorTy() = default; riccibruno wrote: > dblaikie wrote: > > aaron.ballman wrote: > > > ric

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

ABataev added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include "clang/Basic/OpenMPKinds.def" Well, I thi

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

JonasToth added inline comments. Comment at: docs/clang-tidy/checks/openmp-use-default-none.rst:12 +being implicitly determined, and thus forces developer to be explicit about the +desired data scoping for each variable. + If I understand correctly the issue is m

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. Can you elaborate a bit in what sense this decouples ARCMT from the analyzer? Can CLANG_ENABLE_STATIC_ANALYZER now be set independently of CLANG_ENABLE_ARCMT? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57127/new/ https://reviews.llvm.o

[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: include/clang/AST/Expr.h:5095 + + Expr *getAssocExpr(unsigned i) { +return cast(SubExprs[AssocExprStartIndex + i]); If y

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); ABataev wrote: > lildmh wrote: > > ABataev wrote: > > > lildmh wrote: > > > >

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only used by tooling-like things (static analyzer, arcmigrate). Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri marked an inline comment as done. lebedev.ri added a comment. @ABataev Thank you for taking a look! Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(

[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5095 + + Expr *getAssocExpr(unsigned i) { +return cast(SubExprs[AssocExprStartIndex + i]); aaron.ballman wrote: > If you wanted to fix up `i`

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

ABataev added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include "clang/Basic/OpenMPKinds.def" lebedev.ri

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

ABataev added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include "clang/Basic/OpenMPKinds.def" ABataev wro

[PATCH] D57060: [NFC][Clang] Add driver tests for sb and predres

This revision was automatically updated to reflect the committed changes. Closed by commit rC352203: [NFC][Clang] Add driver tests for sb and predres (authored by dnsampaio, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57060/new/ https://reviews.l

r352203 - [NFC][Clang] Add driver tests for sb and predres

Author: dnsampaio Date: Fri Jan 25 06:57:22 2019 New Revision: 352203 URL: http://llvm.org/viewvc/llvm-project?rev=352203&view=rev Log: [NFC][Clang] Add driver tests for sb and predres Add tests that arguments for enabling/disabling sb and predres are correctly being or not passed by the driver.

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

JonasToth added inline comments. Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:113 +void UseDefaultNoneCheck::registerMatchers(MatchFinder *Finder) { + // If OpenMP is not enabled, don't register the check, it won't find anything. + if (!getLangOpts().OpenMP) -

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

ABataev added inline comments. Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:113 +void UseDefaultNoneCheck::registerMatchers(MatchFinder *Finder) { + // If OpenMP is not enabled, don't register the check, it won't find anything. + if (!getLangOpts().OpenMP) ---

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

erichkeane marked 5 inline comments as done. erichkeane added inline comments. Comment at: include/clang/Basic/TargetInfo.h:66 bool HasFloat128; + bool HasFloat16; unsigned char PointerWidth, PointerAlign; SjoerdMeijer wrote: > I think this is the same as

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

erichkeane updated this revision to Diff 183536. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57188/new/ https://reviews.llvm.org/D57188 Files: docs/LanguageExtensions.rst include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets/AArch64.cpp lib/Basic/Targets

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/openmp-use-default-none.rst:12 +being implicitly determined, and thus forces developer to be explicit about the +desired data scoping for each variable. + ---

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matchers::internal::Matcher, --

[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5095 + + Expr *getAssocExpr(unsigned i) { +return cast(SubExprs[AssocExprStartIndex + i]); riccibruno wrote: > aaron.ballman wrote: > > If you wanted to fix up `i` to be `Idx` or somet

[clang-tools-extra] r352205 - [clangd] NFC: fix clang-tidy warnings.

Author: hokein Date: Fri Jan 25 07:14:03 2019 New Revision: 352205 URL: http://llvm.org/viewvc/llvm-project?rev=352205&view=rev Log: [clangd] NFC: fix clang-tidy warnings. Most are about llvm code style violation (found via readability-identifier-naming check). Modified: clang-tools-extra/tr

[PATCH] D57064: [Sema] Improve a -Warray-bounds diagnostic

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2092 + Optional getTypeSizeInCharsIfKnown(QualType Ty) const { +if (Ty->isIncompleteType() || Ty->isDependentType()) + return None; erik.pilkington wrote: > aaron.ball

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

hwright updated this revision to Diff 183539. hwright marked 11 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57185/new/ https://reviews.llvm.org/D57185 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/Duratio

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

hwright added inline comments. Comment at: clang-tidy/abseil/DurationAdditionCheck.cpp:22 +void DurationAdditionCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + binaryOperator(hasOperatorName("+"), JonasToth wrote: > This whole file is

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

JonasToth added inline comments. Comment at: docs/clang-tidy/checks/openmp-use-default-none.rst:12 +being implicitly determined, and thus forces developer to be explicit about the +desired data scoping for each variable. + lebedev.ri wrote: > JonasToth wrote: > >

[PATCH] D56925: Do not use frame pointer by default for MSP430

krisb added inline comments. Comment at: test/CodeGen/msp430-fp-elim.c:16 +{ + asm volatile ("calla r4"); +} This test as it is will fail after integrated assembler will be turned on by default (see https://reviews.llvm.org/D56787). Since `calla` instruct

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationAdditionCheck.cpp:22 +void DurationAdditionCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + binaryOperator(hasOperatorName("+"), hwright wrote: > JonasToth wrote: >

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri marked 2 inline comments as not done. lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/openmp-use-default-none.rst:12 +being implicitly determined, and thus forces developer to be explicit about the +desired data scoping for each variable. + ---

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Just a bunch of nits, up to you to work out how/whether to address. One substantive issue around classes defined outside headers - will chat offline. Comment at: clan

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

hwright marked 2 inline comments as done. hwright added inline comments. Comment at: test/clang-tidy/abseil-duration-addition.cpp:84 +#undef PLUS_FIVE +} JonasToth wrote: > a view template test-cases would be good to have. I'm not sure I know that terminology; do

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

JonasToth added inline comments. Comment at: test/clang-tidy/abseil-duration-addition.cpp:84 +#undef PLUS_FIVE +} hwright wrote: > JonasToth wrote: > > a view template test-cases would be good to have. > I'm not sure I know that terminology; do you have an exampl

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno updated this revision to Diff 183552. riccibruno marked 10 inline comments as done. riccibruno added a comment. Moved back to an input iterator. Addressed Aaron's remaining comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57106/new/ https://revi

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5103 +using reference = AssociationTy; +using pointer = AssociationTy; +AssociationIteratorTy() = default; aaron.ballman wrote: > riccibruno wrote: > > dblaikie wrote: > > > aaron.

[PATCH] D57242: [RISCV] Specify MaxAtomicInlineWidth for RISC-V

lewis-revill created this revision. lewis-revill added a reviewer: asb. Herald added subscribers: cfe-commits, jocewei, PkmX, jfb, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. This

[PATCH] D56267: [clangd] Interfaces for writing code actions

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Protocol.cpp:425 +const llvm::StringLiteral ExecuteCommandParams::CLANGD_APPLY_TWEAK = +"clangd.applyCodeAction"; + ---

r352219 - Allow 'static' storage specifier on an out-of-line member function template

Author: erichkeane Date: Fri Jan 25 09:01:42 2019 New Revision: 352219 URL: http://llvm.org/viewvc/llvm-project?rev=352219&view=rev Log: Allow 'static' storage specifier on an out-of-line member function template declaration in MSVCCompat mode Microsoft compiler permits the use of 'static' storag

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

balazske added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:2523 + Decl *ToTU = ToAST->getASTContext().getTranslationUnitDecl(); + cast(ToTU)->dumpDeclContext(); + ASSERT_EQ(DeclCounter().match(ToTU, functionDecl(hasName("f"))), Is this dump

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a subscriber: scanon. rjmccall added a comment. This LGTM with one minor revision; feel free to commit with that. For follow-up commit consideration: @scanon, do we want to support `_Float16` anywhere else? Do we need to lock down an ABI here for i386/x86_64 in advance of those

[PATCH] D57220: Test fix for isViableInline remark message

anemet accepted this revision. anemet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57220/new/ https://reviews.llvm.org/D57220 ___ cfe-commits ma

r352221 - Disable _Float16 for non ARM/SPIR Targets

Author: erichkeane Date: Fri Jan 25 09:27:57 2019 New Revision: 352221 URL: http://llvm.org/viewvc/llvm-project?rev=352221&view=rev Log: Disable _Float16 for non ARM/SPIR Targets As Discussed here: http://lists.llvm.org/pipermail/llvm-dev/2019-January/129543.html There are problems exposing the

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

rjmccall added inline comments. Comment at: include/clang/Serialization/ASTBitCodes.h:1637 + /// A FixedPointLiteral record. + EXPR_FIXEDPOINT_LITERAL, + ebevhan wrote: > I'm unsure if this is the right location for a new code. This will bump down > al

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

scanon added a subscriber: ab. scanon added a comment. > do we want to support _Float16 anywhere else? ARM is the only in-tree target with a defined ABI that I'm aware of. > Do we need to lock down an ABI here for i386/x86_64 in advance of those gears > turning in the outer world? We definitel

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL352221: Disable _Float16 for non ARM/SPIR Targets (authored by erichkeane, committed by ). Herald added a subscriber: llvm

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added inline comments. Comment at: docs/LanguageExtensions.rst:484 +- SPIR +``_Float16`` will be supported on more targets as they define ABIs for them. + rjmccall wrote: > "them" should be "it" here. Sorry, apparently Phabricator was sitting on a commen

[PATCH] D52839: Inform AST's UnaryOperator of FENV_ACCESS

kpn added a comment. In D52839#1263794 , @rsmith wrote: > > 2. Track the FP environment somewhere more transient, probably on the `Scope` > object. When parsing an operator, store the environment on the expression, > and when performing a `TreeTransf

r352222 - Fix incorrect indent from r352221

Author: erichkeane Date: Fri Jan 25 09:39:57 2019 New Revision: 35 URL: http://llvm.org/viewvc/llvm-project?rev=35&view=rev Log: Fix incorrect indent from r352221 Change-Id: I0a7b1443eb6912ef7bea1a4cf2f696fc01726557 Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk

[PATCH] D56581: [ASTImporter] Set the described template if not set

shafik added a subscriber: aprantl. shafik added a comment. I don't believe it is directly related to modules but that it just triggers the issue because it may be bringing in more. You can find a description here https://clang.llvm.org/docs/CommandGuide/clang.html#cmdoption-g and @aprantl poin

[PATCH] D56998: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics.

craig.topper added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56998/new/ https://reviews.llvm.org/D56998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

  1   2   >