[PATCH] D56936: Fix handling of overriden methods during ASTImport

balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:3046 +if (!D->doesThisDeclarationHaveABody()) + return cast(const_cast(FoundByLookup)); +else { The `cast` should not be needed here (and is not done at the other return

[PATCH] D57001: [libunwind] Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__

mstorsjo created this revision. mstorsjo added reviewers: joerg, compnerd, mclow.lists, EricWF, ldionne. Herald added subscribers: libcxx-commits, kristof.beyls, krytarowski, javed.absar, aprantl. The existing typedef of unw_fpreg_t to uint64_t might work and be correct for the ARM_EHABI case, b

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

Szelethus added a comment. Cheers, this is as good as it gets! IRL we also mentioned making a unipage for each checker which would be awesome (and would require a lot of tedious work), but as a start, I'd much prefer browsing through this doc than the current one. Very much appreciated! I won'

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

xazax.hun added a comment. In D35068#1361902 , @Szelethus wrote: > In D35068#1069880 , @koldaniel wrote: > > > I've evaluated this checker on LLVM+Clang, there were only a few (about 15) > > warnings, because of t

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

xazax.hun added a comment. To add an analogy, Clang Tidy will not require C++ Core Guidelines related checks to be evaluated on projects that are not following the guidelines as the results are meaningless for those projects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ ht

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Sorry for the delay, I was OOO last week. The check looks good. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/ https://reviews.llvm.org

Re: [libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

Hi Asiri, Did you fix the issue when building libcxx and libcxxabi use LLVM's libunwind? http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20170206/184841.html I experienced the similar issue: CMake Error at projects/libcxxabi/src/CMakeLists.txt:163 (target_link_libraries):   Target "

[PATCH] D57004: [docs] Add release notes for notable things I've contributed since last release

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans. Repository: rC Clang https://reviews.llvm.org/D57004 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/Release

[PATCH] D57004: [docs] Add release notes for notable things I've contributed since last release

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: docs/ReleaseNotes.rst:190 +- For MinGW, clang now produces vtables and RTTI for dllexported classes + without key functions. + This comment doesn't really say much for the cas

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Yup, I'm sold on that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.org/D35068 ___ cfe-commits ma

r351731 - Fix typos throughout the license files that somehow I and my reviewers

Author: chandlerc Date: Mon Jan 21 01:52:34 2019 New Revision: 351731 URL: http://llvm.org/viewvc/llvm-project?rev=351731&view=rev Log: Fix typos throughout the license files that somehow I and my reviewers all missed! Thanks to Alex Bradbury for pointing this out, and the fact that I never added

[libclc] r351731 - Fix typos throughout the license files that somehow I and my reviewers

Author: chandlerc Date: Mon Jan 21 01:52:34 2019 New Revision: 351731 URL: http://llvm.org/viewvc/llvm-project?rev=351731&view=rev Log: Fix typos throughout the license files that somehow I and my reviewers all missed! Thanks to Alex Bradbury for pointing this out, and the fact that I never added

[libunwind] r351731 - Fix typos throughout the license files that somehow I and my reviewers

Author: chandlerc Date: Mon Jan 21 01:52:34 2019 New Revision: 351731 URL: http://llvm.org/viewvc/llvm-project?rev=351731&view=rev Log: Fix typos throughout the license files that somehow I and my reviewers all missed! Thanks to Alex Bradbury for pointing this out, and the fact that I never added

[clang-tools-extra] r351731 - Fix typos throughout the license files that somehow I and my reviewers

Author: chandlerc Date: Mon Jan 21 01:52:34 2019 New Revision: 351731 URL: http://llvm.org/viewvc/llvm-project?rev=351731&view=rev Log: Fix typos throughout the license files that somehow I and my reviewers all missed! Thanks to Alex Bradbury for pointing this out, and the fact that I never added

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

ilya-biryukov added a comment. LGTM to unbreak the tests on *BSD, but could you please leave a comment? It would probably be best to take `argv[0]` into account on *BSD systems as well (possibly only if `clang` could not be found). At least if that's the behaviour on **all** other systems. Rep

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

ilya-biryukov added inline comments. Comment at: test/Tooling/clang-check-mac-libcxx-fixed-compilation-db.cpp:15 +// RUN: -stdlib=libc++ -target x86_64-apple-darwin \ +// RUN: -ccc-install-dir %t/mock-libcxx/bin #include Could you leave a comment this i

[PATCH] D56902: [clang-tidy] Use getStripPluginsAdjuster

This revision was automatically updated to reflect the committed changes. Closed by commit rL351738: [clang-tidy] Use getStripPluginsAdjuster (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D51178: [ASTImporter] Add test for importing anonymous namespaces.

teemperor updated this revision to Diff 182761. teemperor added a comment. - Added a comment that the using directives are created by Sema. Also sorry for the late update :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51178/new/ https://reviews.llvm.org/D51178 Files: test/Import/c

[clang-tools-extra] r351738 - [clang-tidy] Use getStripPluginsAdjuster

Author: kadircet Date: Mon Jan 21 02:10:18 2019 New Revision: 351738 URL: http://llvm.org/viewvc/llvm-project?rev=351738&view=rev Log: [clang-tidy] Use getStripPluginsAdjuster Summary: See rC351531 for the introduction of getStripPluginsAdjuster. Reviewers: alexfh Subscribers: xazax.hun, cfe-co

r351739 - [ASTImporter] Add test for importing anonymous namespaces.

Author: teemperor Date: Mon Jan 21 02:14:31 2019 New Revision: 351739 URL: http://llvm.org/viewvc/llvm-project?rev=351739&view=rev Log: [ASTImporter] Add test for importing anonymous namespaces. Reviewers: a.sidorin, a_sidorin Reviewed By: a_sidorin Subscribers: a_sidorin, martong, cfe-commits

[PATCH] D51178: [ASTImporter] Add test for importing anonymous namespaces.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351739: [ASTImporter] Add test for importing anonymous namespaces. (authored by teemperor, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51178/new/ https:/

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 +void AdjustArguments(tooling::CompileCommand &Cmd, + const std::string &ResourceDir) { + // Strip plugin related command line arguments. Clangd does ilya-bir

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

kadircet updated this revision to Diff 182765. kadircet marked 3 inline comments as done. kadircet added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 Files: clangd/ClangdLSPS

r351740 - [AArch64] Use LL for 64-bit intrinsic arguments

Author: sam_parker Date: Mon Jan 21 03:01:05 2019 New Revision: 351740 URL: http://llvm.org/viewvc/llvm-project?rev=351740&view=rev Log: [AArch64] Use LL for 64-bit intrinsic arguments The ACLE states that 64-bit crc32, wsr, rsr and rbit operands are uint64_t so we should have the clang builtin m

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL351740: [AArch64] Use LL for 64-bit intrinsic arguments (authored by sam_parker, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56852?vs=1824

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny added a comment. In D56976#1365001 , @ilya-biryukov wrote: > LGTM to unbreak the tests on *BSD, but could you please leave a comment? > It would probably be best to take `argv[0]` into account on *BSD systems as > well (possibly only if `clang` c

[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

hokein updated this revision to Diff 182768. hokein marked 7 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55256/new/ https://reviews.llvm.org/D55256 Files: clangd/ClangdLS

[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

hokein added inline comments. Comment at: clangd/ClangdLSPServer.h:132 - RealFileSystemProvider FSProvider; /// Options used for code completion sammccall wrote: > ilya-biryukov wrote: > > Could we instead call `getRealFS()` when we try to initialize a clan

[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

sammccall accepted this revision. sammccall added inline comments. Comment at: clangd/tool/ClangdMain.cpp:204 +static llvm::cl::opt ClangTidyChecks( +"clang-tidy-checks", hokein wrote: > sammccall wrote: > > Maybe add a TODO or FIXME to respect .clang-tidy

[PATCH] D56917: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: unittests/Analysis/ExprMutationAnalyzerTest.cpp:1112 +TEST(ExprMutationAnalyzerTest, ReproduceFailure11) { + const std::string Reproducer = -

[PATCH] D56267: [clangd] Interfaces for writing code actions

sammccall added a comment. Can live with `applyTweak` etc, though it makes me sad. Comment at: clangd/refactor/Tweak.h:40 + struct Selection { +static llvm::Optional create(llvm::StringRef File, +llvm::StringRef Code, ---

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb created this revision. krisb added reviewers: asl, aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D57012 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp Index: lib/Sema/SemaDeclAttr.cpp ==

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

ilya-biryukov added a comment. In D56976#1365087 , @mgorny wrote: > Actually, it works on other systems because they don't use `argv[0]`. The > problem is in compilation db code using getMainExecutable() in ctor without > passing the real argv to it. B

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

ilya-biryukov added a comment. Was confused about your comment, so it works on other systems because they don't rely on `argv[0]` to get the path to main executable. Got you. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56976/new/ https://reviews.llvm.org/D5697

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

aaron.ballman edited reviewers, added: rsmith; removed: llvm-commits, doug.gregor. aaron.ballman added a comment. > Pre-C++17 standards don't have this requirement; however, they don't forbid > the conversion functions to have this specification either. This change happened as a result of DR 17

[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

hokein updated this revision to Diff 182778. hokein marked 5 inline comments as done. hokein added a comment. Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55256/new/ https://reviews.llvm.org/D55256 Files: clangd/ClangdLSPServer

[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

hokein added inline comments. Comment at: clangd/tool/ClangdMain.cpp:438 + auto OverrideClangTidyOptions = tidy::ClangTidyOptions::getDefaults(); + if (!ClangTidyChecks.empty()) +OverrideClangTidyOptions.Checks = ClangTidyChecks; sammccall wrote: > This pre

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

loskutov updated this revision to Diff 182779. loskutov added a comment. Fixed the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992 Files: clang/lib/Sema/SemaLambda.cpp Index: clang/lib/Sema/SemaLambda.cpp ===

[PATCH] D56961: NFC: Move GenericSelectionExpr dump to NodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56961/new/ https://reviews.llvm.org/D56961 ___

[PATCH] D56917: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers

JonasToth updated this revision to Diff 182780. JonasToth added a comment. - use only the small reproducer Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56917/new/ https://reviews.llvm.org/D56917 Files: unittests/Analysis/ExprMutationAnalyzerTest.cpp Index:

[PATCH] D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few small cosmetic changes. Comment at: lib/AST/ASTDumper.cpp:1463-1464 +NodeDumper.Visit(A); +const TypeSourceInfo *TSI = A.getTypeSourceIn

r351743 - [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers

Author: jonastoth Date: Mon Jan 21 05:26:18 2019 New Revision: 351743 URL: http://llvm.org/viewvc/llvm-project?rev=351743&view=rev Log: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers Summary: This patch adds two unit-tests that are the result of reducing a crashing TU

[PATCH] D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor

aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:1476-1477 for (unsigned I = 0, N = E->getNumAssocs(); I != N; ++I) { -dumpChild([=] { - const auto Assoc = E->getAssociation(I); - const TypeSourceInfo *TSI = Assoc.getTypeSourceInfo(); -

[PATCH] D56917: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers

This revision was automatically updated to reflect the committed changes. Closed by commit rL351743: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LA

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], Rather than gin these objects up on demand every time they're n

[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.h:132 - RealFileSystemProvider FSProvider; /// Options used for code completion hokein wrote: > sammccall wrote: > > ilya-biryukov wrote: > > > Could we instead call `getRealFS()` when

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

ilya-biryukov added a comment. @dgoldman, do you have commit access or should I land this for you? Comment at: clangd/index/SymbolCollector.cpp:375 + // not a NamedDecl. + const NamedDecl *OriginalDecl = dyn_cast(ASTNode.OrigD); + if (!OriginalDecl) NIT: use

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

loskutov updated this revision to Diff 182782. loskutov marked an inline comment as done. loskutov added a comment. Uploaded an updated diff instead of a diff-from-previous-diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992 Files: clang/lib/

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

loskutov updated this revision to Diff 182783. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992 Files: clang/lib/Sema/SemaLambda.cpp clang/test/AST/ast-dump-expr.cpp clang/test/CXX/expr/expr.prim/expr.prim.lambda/p9.cpp Index: clang/test/CX

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

aaron.ballman added a comment. Test case? Or does one already cover this crash? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 ___ cfe-commits mailing list cfe-

[PATCH] D56946: [Documentation] Use HTTPS whenever possible in Clang

sylvestre.ledru added a comment. Did you test all url? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56946/new/ https://reviews.llvm.org/D56946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], aaron.ballman wrote: > Ra

[PATCH] D57015: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI

krisb created this revision. krisb added a reviewer: asl. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D57015 Files: lib/Basic/Targets/MSP430.h test/CodeGen/msp430-align.c test/Preprocessor/init.c Index: test/Preprocessor/init.c

r351744 - [NFC] Fix comparison warning issues by MSVC

Author: jdoerfert Date: Mon Jan 21 06:23:46 2019 New Revision: 351744 URL: http://llvm.org/viewvc/llvm-project?rev=351744&view=rev Log: [NFC] Fix comparison warning issues by MSVC Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp URL: http://llvm.or

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny marked an inline comment as done. mgorny added a comment. In D56976#1365190 , @ilya-biryukov wrote: > Was confused about your comment, so it works on other systems because they > don't rely on `argv[0]` to get the path to main executable. Got you.

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny updated this revision to Diff 182785. mgorny added a comment. Added a comment as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56976/new/ https://reviews.llvm.org/D56976 Files: test/Tooling/clang-check-mac-libcxx-fixed-compilation-db.cpp Index: test/Tooling/clang-

[PATCH] D56946: [Documentation] Use HTTPS whenever possible in Clang

Eugene.Zelenko added a comment. Yes, I tested all URLs, but I think independent testing will not be excessive. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56946/new/ https://reviews.llvm.org/D56946 ___ cfe-commits

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], steveire wrote: > aaron.ballman wrote: > > Rather than gin thes

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the DR status page and a nit with the test's RUN line, this LGTM. Thank you for working on this -- do you need me to commit on your behalf? If so, are you aware of the

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

ebevhan added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9825 +if (Result.isSigned() && !DstSigned) { + Overflow = Result < 0 || Result.ugt(DstMax); +} else if (Result.isUnsigned() && DstSigned) { leonardchan wrote: > ebevhan wrote:

r351746 - [Analyzer] Remove extra blank line from Iterator Checker (test commit)

Author: baloghadamsoftware Date: Mon Jan 21 07:31:23 2019 New Revision: 351746 URL: http://llvm.org/viewvc/llvm-project?rev=351746&view=rev Log: [Analyzer] Remove extra blank line from Iterator Checker (test commit) Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/IteratorChecker.cpp Modifie

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

ilya-biryukov added a comment. Good point, @aaron.ballman! @dgoldman, could you please add a test case? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 ___ cfe-c

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], aaron.ballman wrote: > st

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a suggested edit for the docs (which look great, btw!). Comment at: include/clang/Basic/AttrDocs.td:1252 + +For platforms like ``watchOS`` and ``tvOS`` whose availability attributes can +be implici

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

loskutov updated this revision to Diff 182792. loskutov edited the summary of this revision. loskutov added a comment. Reflected the change in cxx_dr_status.html and specified `-std=c++17` for the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

loskutov marked an inline comment as done. loskutov added a comment. Yes, I'm not able to commit by myself, so it would be nice if you did that. Apache 2.0 with LLVM Exceptions is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56945/new/ https://reviews.llvm.org/D56945 __

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], steveire wrote: > aaron.ballman wrote: > > steveire wrote: > >

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/GlobalCompilationDatabase.cpp:24 +void AdjustArguments(tooling::CompileCommand &Cmd, + const std::string &ResourceDi

r351747 - [OpenCL] Allow address spaces as method qualifiers.

Author: stulova Date: Mon Jan 21 08:01:38 2019 New Revision: 351747 URL: http://llvm.org/viewvc/llvm-project?rev=351747&view=rev Log: [OpenCL] Allow address spaces as method qualifiers. Methods can now be qualified with address spaces to prevent undesirable conversions to generic or to provide cu

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.cpp:1030 auto &FrontendOpts = CI->getFrontendOpts(); FrontendOpts.DisableFree = false; FrontendOpts.SkipFunctionBodies = true; remove this line, `buildCompilerInvocation` handles this f

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rC351747: [OpenCL] Allow address spaces as method qualifiers. (authored by stulova, committed by ). Herald added a subscriber: ebevhan. Changed prior to commit: https://reviews.llvm.org/D55850?vs=182496&i

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia added a comment. After rebase I had to modify the following test: Index: test/SemaOpenCLCXX/address_space_overloading.cl === --- test/SemaOpenCLCXX/address_space_overloading.cl (revision 351746) +++ test/SemaOpenC

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ioeric updated this revision to Diff 182796. ioeric added a comment. - add comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56903/new/ https://reviews.llvm.org/D56903 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp clangd/ClangdUni

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric created this revision. ioeric added a reviewer: sammccall. This adds include-fixer feature into clangd based on D56903 . Clangd now captures diagnostics caused by typos and attach include insertion fixes to potentially fix the typo. Repository: rCTE Cla

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 182799. ioeric added a comment. - revert unintended change Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp clan

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 182800. ioeric added a comment. - Rebase on D56903 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/ClangdUnit.cpp cla

[PATCH] D56936: Fix handling of overriden methods during ASTImport

martong added a comment. Hi Shafik, thank you for this patch! Generally it looks quite okay to me, but I have a few minor comments. Comment at: lib/AST/ASTImporter.cpp:3049 + // Import the body of D and attach that to FoundByLookup. + // This should probably

[PATCH] D56936: Fix handling of overriden methods during ASTImport

martong added a comment. > @martong the only issue is that I am seeing a regression on > Analysis/ctu-main.cpp when I run check-clang. I am going to look into it but > if you have any insights that would be helpful. I am looking into it and will come back with what I have found. CHANGES SINCE

r351749 - Regenerating the C++ DR status page from the latest Core issues list.

Author: aaronballman Date: Mon Jan 21 08:21:14 2019 New Revision: 351749 URL: http://llvm.org/viewvc/llvm-project?rev=351749&view=rev Log: Regenerating the C++ DR status page from the latest Core issues list. Modified: cfe/trunk/www/cxx_dr_status.html

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

ilya-biryukov added a reviewer: sammccall. ilya-biryukov added a comment. Adding Sam as a reviewer, IIRC we used to have `buildCompilerInvocation` here and he was the one who inlined it. I would personally LGTM this change (with the two comments fixed), but Sam might have a different opinion on

r351750 - Mark the lambda function pointer conversion operator as noexcept.

Author: aaronballman Date: Mon Jan 21 08:25:08 2019 New Revision: 351750 URL: http://llvm.org/viewvc/llvm-project?rev=351750&view=rev Log: Mark the lambda function pointer conversion operator as noexcept. This implements CWG DR 1722 and fixes PR40309. Patch by Ignat Loskutov. Added: cfe/trun

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

ebevhan added a comment. I'm a bit late to the party here, it was an older patch so I wasn't watching this one. I get a bit miffed when address space related features get locked behind langoptions that aren't strictly address spaces. I know that there are currently a couple code snippets which

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

aaron.ballman closed this revision. aaron.ballman added a comment. I needed to make some minor alterations to your patch. The CXX DR status page is automatically generated and I didn't remember that. I went and added an additional test case and did the automated DR regeneration. I've commit in

[clang-tools-extra] r351751 - [clang-tidy] Work around http://llvm.org/PR40392

Author: alexfh Date: Mon Jan 21 08:26:54 2019 New Revision: 351751 URL: http://llvm.org/viewvc/llvm-project?rev=351751&view=rev Log: [clang-tidy] Work around http://llvm.org/PR40392 The readability-else-after-return check should be smarter about cases where the variable defined in the condition i

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a commenting nit, thank you for the cleanup! Comment at: lib/Sema/SemaDeclAttr.cpp:5620 +S.Diag(D->getLocation(), diag::warn_interrupt_attri

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote: >

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

sammccall added a comment. In D56860#1365432 , @ilya-biryukov wrote: > Adding Sam as a reviewer, IIRC we used to have `buildCompilerInvocation` here > and he was the one who inlined it. > I would personally LGTM this change (with the two comments fixed)

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

riccibruno added a comment. Some small additional remarks if you are already modifying this class. Comment at: include/clang/AST/Expr.h:5021 unsigned NumAssocs, ResultIndex; SourceLocation GenericLoc, DefaultLoc, RParenLoc; It is possible to stuff one `

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56976/new/ https://reviews.llvm.org/D56976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

r351752 - [test] Pass -ccc-install-dir in mac compilation db test

Author: mgorny Date: Mon Jan 21 09:05:43 2019 New Revision: 351752 URL: http://llvm.org/viewvc/llvm-project?rev=351752&view=rev Log: [test] Pass -ccc-install-dir in mac compilation db test Pass -ccc-install-dir explicitly as the compilation database code does not pass argv[0] to getMainExecutable

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

This revision was automatically updated to reflect the committed changes. Closed by commit rL351752: [test] Pass -ccc-install-dir in mac compilation db test (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56976?vs=

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

sammccall added a comment. This looks pretty good! My main concern is latency (and variability of latency) in practice. Particularly: - we should avoid paying for fuzzyfind and fetching hundreds of results when we want exact-match - limit the damage in degenerate cases: should we limit to e.g.

LLVM buildmaster will restart tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a naming convention nit. Comment at: lib/Analysis/ThreadSafety.cpp:984 StringRef DiagKind) const { -if (!FSet.findLock(FactMan,

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl updated this revision to Diff 182815. yaxunl added a comment. separate layout controlling flags to a base class for TargetInfo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56318/new/ https://reviews.llvm.org/D56318 Files: include/clang/Basic/TargetInfo.h lib/Basic/TargetIn

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl added a comment. In D56318#1355705 , @rjmccall wrote: > It's pretty unfortunate that all these fields have to be individually called > out like this. Can you move all these basic layout fields into a separate > `struct` (which can be a secondary

[PATCH] D57032: [SemaCXX] Param diagnostic matches overload logic

modocache created this revision. modocache added a reviewer: rsmith. Given the following test program: class C { public: int A(int a, int& b); }; int C::A(const int a, int b) { return a * b; } Clang would produce an error message that correctly diagnosed the redeclaration of

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1360010 , @rjmccall wrote: > I think the diagnostic should come during instantiation when you find an > evaluated use of a host function within a device function. It seems the body of function template is checked only d

[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. Thanks for the review! I'll commit this when I have commit access again, which is waiting for my employer's approval to the relicensing. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:1693 +

  1   2   >