r351579 - [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

2019-01-18 Thread Vladimir Stefanovic via cfe-commits
Author: vstefanovic Date: Fri Jan 18 11:54:51 2019 New Revision: 351579 URL: http://llvm.org/viewvc/llvm-project?rev=351579&view=rev Log: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls' These two options enable/disable emission of R_{MICRO}MIPS_JALR fixups along with PIC calls. The linker

[PATCH] D56925: Do not use frame pointer by default for MSP430

2019-01-18 Thread Dmitry Mikushin via Phabricator via cfe-commits
dmikushin created this revision. Herald added a subscriber: cfe-commits. dmikushin added a reviewer: asl. > 3.3.9 Frame Pointer > MSP430 does not use a frame pointer. This effectively limits a single call > frame to 0x7fff bytes, which is the minimum SP offset supported by any > instruction We

[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

2019-01-18 Thread Vladimir Stefanovic via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351579: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls' (authored by vstefanovic, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56878

r351580 - [OPENMP][DOCS] Release notes/OpenMP support updates, NFC.

2019-01-18 Thread Kelvin Li via cfe-commits
Author: kli Date: Fri Jan 18 11:57:37 2019 New Revision: 351580 URL: http://llvm.org/viewvc/llvm-project?rev=351580&view=rev Log: [OPENMP][DOCS] Release notes/OpenMP support updates, NFC. Differential Revision: https://reviews.llvm.org/D56733 Modified: cfe/trunk/docs/OpenMPSupport.rst cf

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

2019-01-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351580: [OPENMP][DOCS] Release notes/OpenMP support updates, NFC. (authored by kli, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56733?vs=1

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

2019-01-18 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman, JonasToth, MyDeveloperDay, juliehockett, lebedev.ri. Eugene.Zelenko added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, kbarton, nemanjai. Repository: rCTE Clang Tools Extr

[PATCH] D56905: [libunwind] [SjLj] Don't use __declspec(thread) in MinGW mode

2019-01-18 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. Sigh. At least we've got a macro wrapping this; we only have to pore over this once. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56905/new/ https://reviews.llvm.org/D56905 __

[PATCH] D56927: Disable PIC/PIE for MSP430 target

2019-01-18 Thread Dmitry Mikushin via Phabricator via cfe-commits
dmikushin created this revision. dmikushin added a reviewer: asl. Herald added a subscriber: cfe-commits. Relocatable code generation is meaningless on MSP430, as the platform is too small to use shared libraries. Repository: rC Clang https://reviews.llvm.org/D56927 Files: lib/Driver/Tool

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

2019-01-18 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. very good idea. This reminds me, that i wanted to fix the hicpp links, as they restructured their website. thanks ;) Changes LGTM! Repository: rCTE Clang Tools Extra CHANGES SINCE LA

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

2019-01-18 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: llvm-svn.src/tools/clang/tools/extra/docs/clang-tidy/checks/cppcoreguidelines-avoid-goto.rst:11 from the CppCoreGuidelines and -`6.3.1 from High Integrity C++

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

2019-01-18 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. the closest I can see is https://www.perforce.com/resources/qac/high-integrity-cpp-coding-standard#statements which take you to section 6 of the standard, but I see no id or name tags to get you to 6.3.1 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[PATCH] D56928: Support attribute used in member funcs of class templates

2019-01-18 Thread Rafael Auler via Phabricator via cfe-commits
rafauler created this revision. rafauler added reviewers: rsmith, ldionne. As PR17480 describes, clang does not support the used attribute for member functions of class templates. This means that if the member function is not used, its definition is never instantiated. This patch changes clang to

[PATCH] D56928: Support attribute used in member funcs of class templates

2019-01-18 Thread Rafael Auler via Phabricator via cfe-commits
rafauler updated this revision to Diff 182581. rafauler added a comment. Removing facebook tags Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56928/new/ https://reviews.llvm.org/D56928 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp test/CodeGenCXX/attr-used

[libunwind] r351587 - [SjLj] Don't use __declspec(thread) in MinGW mode

2019-01-18 Thread Martin Storsjo via cfe-commits
Author: mstorsjo Date: Fri Jan 18 12:31:12 2019 New Revision: 351587 URL: http://llvm.org/viewvc/llvm-project?rev=351587&view=rev Log: [SjLj] Don't use __declspec(thread) in MinGW mode GCC and Clang in MinGW mode don't support __declspec(thread), which after expanding macros ends up as __attribut

[PATCH] D56905: [libunwind] [SjLj] Don't use __declspec(thread) in MinGW mode

2019-01-18 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351587: [SjLj] Don't use __declspec(thread) in MinGW mode (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit: https://reviews.llvm.org/D5690

r351588 - Fix MSVC "not all control paths return a value" warning. NFCI.

2019-01-18 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Jan 18 12:40:35 2019 New Revision: 351588 URL: http://llvm.org/viewvc/llvm-project?rev=351588&view=rev Log: Fix MSVC "not all control paths return a value" warning. NFCI. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

2019-01-18 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. In D56926#1363648 , @MyDeveloperDay wrote: > the closest I can see is > > https://www.perforce.com/resources/qac/high-integrity-cpp-coding-standard#statements > > which take you to section 6 of the standard, but I see no id or n

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

2019-01-18 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko updated this revision to Diff 182590. Eugene.Zelenko added a comment. Don't use HTTPS for www.codingstandard.com Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56926/new/ https://reviews.llvm.org/D56926 Files: llvm-svn.src/tools/cla

r351593 - [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

2019-01-18 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Jan 18 13:04:25 2019 New Revision: 351593 URL: http://llvm.org/viewvc/llvm-project?rev=351593&view=rev Log: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation This patch includes logic for constant expression evaluation of fixed point addit

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

2019-01-18 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC351593: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D55868?vs=181897&id=18259

[PATCH] D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors.

2019-01-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Nope, it doesn't seem to skew results at all. I hope my testing machinery is actually working :/ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56823/new/ https://reviews.llvm.org/D56823 ___ cfe-

r351595 - [Sema] Suppress a warning about a forward-declared fixed enum in C mode

2019-01-18 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Fri Jan 18 13:33:23 2019 New Revision: 351595 URL: http://llvm.org/viewvc/llvm-project?rev=351595&view=rev Log: [Sema] Suppress a warning about a forward-declared fixed enum in C mode As of r343360, we support fixed-enums in C. This lead to some warnings in project headers whe

[PATCH] D56932: [Driver] [NetBSD] Pass default library search paths to linker

2019-01-18 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: krytarowski, joerg, ruiu, chandlerc, rsmith. Pass library search paths to linker as -L options, similarly to how other toolchain drivers do it. This fixes compatibility with vanilla LLD. Bug report: https://bugs.llvm.org/show_bug.cgi?id=33155

[PATCH] D56879: [Sema] Suppress a warning about a forward-declared fixed enum in C mode

2019-01-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC351595: [Sema] Suppress a warning about a forward-declared fixed enum in C mode (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56879?vs=182548&id=182597#toc Repo

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

2019-01-18 Thread Russell McClellan via Phabricator via cfe-commits
russellmcc added a comment. Thanks for the feedback! This actually isn't a new formatting option, rather it's fixing a bug where clang-format would change lines outside of the line range asked for by the user. This was preventing us from using clang-format in an automated setting. CHANGES S

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

2019-01-18 Thread Russell McClellan via Phabricator via cfe-commits
russellmcc added a comment. Thanks for the feedback! Does this mean that this won't be accepted? In my opinion, without these extra options, `AllowAllParametersOfDeclarationOnNextLine` is a very strange option. I don't think I'm the only one who feels this way, based on the stack overflow q

[PATCH] D56933: [Tooling][RFC] Introduce Stencil library to simplify source code generation in refactorings.

2019-01-18 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. Herald added subscribers: cfe-commits, jfb. REQUEST FOR COMMENT: this is not intended (yet) as a proper revision. It complements the design document for Transformer: https://docs.google.com/document/d/1ppw0RhjwsrbBcHYhI85pe6ISDbA6r5d00ot3N8cQWeQ/edit?usp=sharing Th

r351597 - [ASTDump] Mark variadic declarations with a tag instead of child node

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 13:38:30 2019 New Revision: 351597 URL: http://llvm.org/viewvc/llvm-project?rev=351597&view=rev Log: [ASTDump] Mark variadic declarations with a tag instead of child node Summary: This makes it easier to separate traversal of the AST from output generation. Revi

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

2019-01-18 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. Thanks, do you need someone to commit this for you? Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:492 + auto MatchesX = cxxMemberCallExpr(on(hasType(cxxRecordDecl(hasName("X"); + EXPECT_TRUE(notMatches(Snippet1, MatchesX));

[PATCH] D56751: [ASTDump] Mark variadic declarations with a tag instead of child node

2019-01-18 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC351597: [ASTDump] Mark variadic declarations with a tag instead of child node (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56751?vs=181904&id=182598#toc Rep

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

2019-01-18 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added a comment. This seems pretty reasonable to me. I agree that a more general mechanism to override #pca (/implicit) attributes would be pretty useful, but I guess there is no need to jump the gun on that. Comment at: include/clang/Sema/Sema.h:2471 +///

r351600 - [ASTDump] Mark BlockDecls which capture this with a tag

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 13:55:24 2019 New Revision: 351600 URL: http://llvm.org/viewvc/llvm-project?rev=351600&view=rev Log: [ASTDump] Mark BlockDecls which capture this with a tag Summary: Removal of the child node makes it easier to separate traversal from output generation. Reviewer

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

2019-01-18 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351600: [ASTDump] Mark BlockDecls which capture this with a tag (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

r351601 - [ASTDump] Mark null params with a tag rather than a child node

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:00:16 2019 New Revision: 351601 URL: http://llvm.org/viewvc/llvm-project?rev=351601&view=rev Log: [ASTDump] Mark null params with a tag rather than a child node Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

2019-01-18 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351601: [ASTDump] Mark null params with a tag rather than a child node (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D56936: Fix handling of overriden methods during ASTImport

2019-01-18 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik created this revision. shafik added reviewers: martong, teemperor, balazske, aaron.ballman. Herald added a subscriber: rnkovacs. When importing classes we may add a CXXMethodDecl more than once to a CXXRecordDecl. This patch will fix the cases we currently know about and handle both the c

[PATCH] D56936: Fix handling of overriden methods during ASTImport

2019-01-18 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. @martong the only issue is that I am seeing a regression on `Analysis/ctu-main.cpp` when I run `check-clang`. I am going to look into it but if you have any insights that would be helpful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56936/new/ https://reviews

r351606 - [ASTDump] Add test for current AST dump behavior

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:15:13 2019 New Revision: 351606 URL: http://llvm.org/viewvc/llvm-project?rev=351606&view=rev Log: [ASTDump] Add test for current AST dump behavior Added: cfe/trunk/test/AST/ast-dump-undeserialized.cpp Added: cfe/trunk/test/AST/ast-dump-undeserialized.cpp

r351604 - [ASTDump] NFC: Remove redundant condition

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:15:05 2019 New Revision: 351604 URL: http://llvm.org/viewvc/llvm-project?rev=351604&view=rev Log: [ASTDump] NFC: Remove redundant condition These conditions are duplicated from the dumpDeclContext function called within the if(). This is presumably an attempt

r351603 - [ASTDump] NFC: Remove non-needed braces

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:14:59 2019 New Revision: 351603 URL: http://llvm.org/viewvc/llvm-project?rev=351603&view=rev Log: [ASTDump] NFC: Remove non-needed braces Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/viewvc/llvm

r351605 - [ASTDump] NFC: Move variable into if() statement

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:15:09 2019 New Revision: 351605 URL: http://llvm.org/viewvc/llvm-project?rev=351605&view=rev Log: [ASTDump] NFC: Move variable into if() statement Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/vi

[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

2019-01-18 Thread Simon Dardis via Phabricator via cfe-commits
sdardis added inline comments. Comment at: cfe/trunk/include/clang/Driver/Options.td:2423 + Group, + HelpText<"Try turning PIC calls (j{al}r{c} $25) into direct calls " + "(MIPS only)">, Flags<[HelpHidden]>; I think this help text could be a little better. Ins

[PATCH] D56829: Move decl context dumping to TextNodeDumper

2019-01-18 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 182607. steveire marked an inline comment as done. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56829/new/ https://reviews.llvm.org/D56829 Files: lib/AST/ASTDumper.cpp lib/AST/TextNodeD

[PATCH] D56899: [analyzer] pr37688: Fix a crash on trying to evaluate a deleted destructor of a union.

2019-01-18 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. The code is fine, but I obviously would prefer a proper fix in a CFG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56899/new/ https://revie

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

2019-01-18 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 182608. arphaman marked 3 inline comments as done. arphaman added a comment. - Add documentation and expand a comment as suggested by Aaron. - Address Erik's comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56892/new/

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

2019-01-18 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D56892#1363089 , @aaron.ballman wrote: > I think the documentation for the attribute should be updated to explain this > new behavior, otherwise this will be a very inexplicable feature to users. Done > One question I have

r351609 - [analyzer] Do not try to body-farm Objective-C properties with custom accessors.

2019-01-18 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Jan 18 14:52:13 2019 New Revision: 351609 URL: http://llvm.org/viewvc/llvm-project?rev=351609&view=rev Log: [analyzer] Do not try to body-farm Objective-C properties with custom accessors. If a property is defined with a custom getter, we should not behave as if the ge

[PATCH] D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors.

2019-01-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC351609: [analyzer] Do not try to body-farm Objective-C properties with custom accessors. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

2019-01-18 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56892/new/ https://reviews.llvm.org/D56892 ___

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

2019-01-18 Thread Aleksei Sidorin via Phabricator via cfe-commits
a_sidorin added a comment. Hi Shafik, Please find my answers inline. Comment at: lib/AST/ASTImporter.cpp:3243 + + if (R) { +CXXDestructorDecl *ToDtor = cast(*R); shafik wrote: > a_sidorin wrote: > > It's better to move this code to VisitFunctionDecl to kee

r351610 - [analyzer] pr37688: Fix a crash upon evaluating a deleted destructor of a union.

2019-01-18 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Jan 18 15:05:07 2019 New Revision: 351610 URL: http://llvm.org/viewvc/llvm-project?rev=351610&view=rev Log: [analyzer] pr37688: Fix a crash upon evaluating a deleted destructor of a union. Add a defensive check against an invalid destructor in the CFG. Unions with fie

[PATCH] D56899: [analyzer] pr37688: Fix a crash on trying to evaluate a deleted destructor of a union.

2019-01-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351610: [analyzer] pr37688: Fix a crash upon evaluating a deleted destructor of a union. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D45978: dllexport const variables must have external linkage.

2019-01-18 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I still feel like there has to be a more uniform way to handle this. Basically anything with __declspec(dllexport) on it is effectively upgraded to external linkage. Comment at: lib/Sema/SemaDeclAttr.cpp:6491 + if (auto *VD = dyn_cast(D)) { +if (getL

[PATCH] D56829: Move decl context dumping to TextNodeDumper

2019-01-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! At some point, we may want to revisit how we dump `TranslationUnitDecl` to make it a bit less inscrutable (I have no idea what those "invalid sloc" strings are telling me). At that point, we may want to turn `` into `unde

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

2019-01-18 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore created this revision. stephanemoore added reviewers: benhamilton, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. The `Acronyms` and `IncludeDefaultAcronyms` options were deprecated in https://reviews.llvm.org/D51832. These options can be removed. Tested by running

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

2019-01-18 Thread Chris Kennelly via Phabricator via cfe-commits
ckennelly added a comment. In D55741#1361040 , @jwakely wrote: > I'd be happy to restrict this to > C++17 only (which is automatically the > case when using G++ because there's no `-fdestroying-delete` to enable it, > you only get it with `-std=c++2a`,

[PATCH] D56946: [Documentation] Use HTTPS whenever possible in Clang

2019-01-18 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: sylvestre.ledru, hans. Eugene.Zelenko added a project: clang. Repository: rC Clang https://reviews.llvm.org/D56946 Files: llvm-svn.src/tools/clang/docs/AutomaticReferenceCounting.rst llvm-svn.src/tools/clang/docs/ClangFo

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

2019-01-18 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:248 +- The `Acronyms` and `IncludeDefaultAcronyms` options for the + :doc:`objc-property-declaration` Please rebase from trunk and use :option: prefix for options.. Comm

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

2019-01-18 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore updated this revision to Diff 182660. stephanemoore marked 2 inline comments as done. stephanemoore added a comment. Use :option: prefix for options in release notes. Add missing space in check reference in release notes. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACT

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

2019-01-18 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351629: Emit !callback metadata and introduce the callback attribute (authored by jdoerfert, committed by ). Changed prior to commit: https://reviews.llvm.org/D55483?vs=181631&id=182665#toc Repository:

[clang-tools-extra] r351631 - Install new LLVM license structure and new developer policy.

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631&view=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects i

[libunwind] r351631 - Install new LLVM license structure and new developer policy.

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631&view=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects i

[libclc] r351631 - Install new LLVM license structure and new developer policy.

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631&view=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects i

r351631 - Install new LLVM license structure and new developer policy.

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631&view=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects i

r351632 - Update some code used in our visual studio plugins to use linux file

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:29:07 2019 New Revision: 351632 URL: http://llvm.org/viewvc/llvm-project?rev=351632&view=rev Log: Update some code used in our visual studio plugins to use linux file endings. We already used them in some cases, and this makes things consistent. This will also

[clang-tools-extra] r351632 - Update some code used in our visual studio plugins to use linux file

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:29:07 2019 New Revision: 351632 URL: http://llvm.org/viewvc/llvm-project?rev=351632&view=rev Log: Update some code used in our visual studio plugins to use linux file endings. We already used them in some cases, and this makes things consistent. This will also

[clang-tools-extra] r351634 - Convert two more files that were using Windows line endings and remove

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:36:08 2019 New Revision: 351634 URL: http://llvm.org/viewvc/llvm-project?rev=351634&view=rev Log: Convert two more files that were using Windows line endings and remove a stray single '\r' from one file. These are the last line ending issues I can find in the

r351633 - Remove random windows line endings that snuck into the middle of this

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:36:00 2019 New Revision: 351633 URL: http://llvm.org/viewvc/llvm-project?rev=351633&view=rev Log: Remove random windows line endings that snuck into the middle of this code. Modified: cfe/trunk/lib/Lex/PPDirectives.cpp Modified: cfe/trunk/lib/Lex/PPDirec

r351634 - Convert two more files that were using Windows line endings and remove

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:36:08 2019 New Revision: 351634 URL: http://llvm.org/viewvc/llvm-project?rev=351634&view=rev Log: Convert two more files that were using Windows line endings and remove a stray single '\r' from one file. These are the last line ending issues I can find in the

<    1   2