[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @jhibbits sorry for not answering earlier, I was occupied with NY holidays, and then had a lot of stuff on the road. Trying to sync to your latest changes, I merged the updated https://reviews.llvm.org/D54583 in my local copy with your fixes to libcall expansion. From

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

jwakely added a comment. I'd be happy to restrict this to > C++17 only (which is automatically the case when using G++ because there's no `-fdestroying-delete` to enable it, you only get it with `-std=c++2a`, `-std=gnu++2a` etc.) Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

[PATCH] D56829: Move decl context dumping to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Only an obscure case is moved. Repository: rC Clang https://reviews.llvm.org/D56829 Files: lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper.cp

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

On Wed, Jan 16, 2019 at 7:46 PM Greg Bedwell wrote: > > > > Unfortunately this trips up a variety of buildbots: > > Platform REQUIRES added in r351360, please do revert & fix if this test is > > supposed to work elsewhere. > > Looks like the test fail just made it into the release-8.0.0 branch by

Re: r351340 - [MSP430] Fix msp430-toolchain.c on Windows (added in r351228)

Merged to 8.0 in r351420. On Wed, Jan 16, 2019 at 2:32 PM Anton Korobeynikov via cfe-commits wrote: > > Author: asl > Date: Wed Jan 16 05:28:30 2019 > New Revision: 351340 > > URL: http://llvm.org/viewvc/llvm-project?rev=351340&view=rev > Log: > [MSP430] Fix msp430-toolchain.c on Windows (added i

[PATCH] D56267: [clangd] Interfaces for writing code actions

sammccall added a comment. (Mostly just comments on Tweak, I think the comments on other parts still apply) Comment at: clangd/SourceCode.h:58 +/// Return the file location, corresponding to \p P. Note that one should take +/// care to avoid comparing the result with expansio

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille added a comment. @rsmith up! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D55782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D56830: Prototype for include-fixer workflow in clangd. [NOT FOR REVIEW]

ioeric created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56830 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Dia

r351423 - [NewPM] Add -fsanitize={memory,thread} handling to clang

Author: pfaffe Date: Thu Jan 17 02:10:47 2019 New Revision: 351423 URL: http://llvm.org/viewvc/llvm-project?rev=351423&view=rev Log: [NewPM] Add -fsanitize={memory,thread} handling to clang Summary: This is the missing bit to drive thread and memory sanitizers through clang using the new PassMan

[PATCH] D56831: [NewPM] Add -fsanitize={memory, thread} handling to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC351423: [NewPM] Add -fsanitize={memory,thread} handling to clang (authored by pfaffe, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D56831?vs=

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

abeserminji created this revision. abeserminji added reviewers: petarj, atanasyan, MatzeB, mstojanovic. Herald added subscribers: jfb, arichardson, sdardis, srhines. When executing test-suite tests with -static option, we get stdthreadbug test to fail. Sometimes it segfault, sometimes it gets stu

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added subscribers: donat.nagy, Szelethus, rnkovacs, baloghadamsoftware. LGTM! Any objections to commit this? I think this is quiet coding guideline specific check which is useful

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina added a comment. @Eugene.Zelenko @alexfh Thank you! How should I proceed with the revision now? Do I get it right from https://llvm.org/docs/Phabricator.html#committing-a-change, that without commit access, I need to ask for committing the changes for me? CHANGES SINCE LAST A

[PATCH] D56841: [clangd] Filter out plugin related flags.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Some projects make use of clang plugins when building, but clangd is not aware of those plugins therefore can't work with the same compile command ar

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

atanasyan added a comment. Now I'm not sure that we really need to make this code more complicated. As to the `stdthreadbug` test case, maybe we can just exclude this test if LDFLAGS contains the `-static` option. As to this patch, is it possible to implement the following algorithm? Will it b

[PATCH] D56841: [clangd] Filter out plugin related flags.

ioeric added inline comments. Comment at: clangd/ClangdUnit.cpp:429 + const auto &CommandLine = Inputs.CompileCommand.CommandLine; + for (size_t I = 0, E = CommandLine.size(); I != E; I++) { +// According to https://clang.llvm.org/docs/ClangPlugins.html Thi

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

Anastasia updated this revision to Diff 182245. Anastasia added a comment. Improved test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56735/new/ https://reviews.llvm.org/D56735 Files: lib/Sema/SemaOverload.cpp test/SemaOpenCLCXX/address_space_overloading.cl Index: test/SemaOpen

[PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

mskvortsov added a reviewer: asl. mskvortsov added a subscriber: asl. mskvortsov added a comment. @asl The change enables to build newlib. Could you commit this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24461/new/ https://reviews.llvm.org/D24461 _

[PATCH] D56841: [clangd] Filter out plugin related flags.

ilya-biryukov added subscribers: sammccall, klimek. ilya-biryukov added a comment. LG, just a few comments. Supporting compiler plugins in clangd is non-trivial and we don't support them so far, so filtering out the options make sense. It feels these helper belong in the Tooling library, that wo

[PATCH] D56445: [Sema] Teach Clang that aligned allocation is not supported with macosx10.13

hans added a comment. This (I think) caused a bunch of libc++ tests to start failing during testing of the newly created 8.0 branch on my machine, see https://bugs.llvm.org/show_bug.cgi?id=40354 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56445/new/ https://re

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

kadircet added a comment. That really looks awesome, thanks! One general comment: I am not really sure if the handling done in `ParseCastExpression` is extensive enough. But IIUC, this should not cause any regressions, rather should result in missing preferred types just as before this patch ?

[PATCH] D56829: Move decl context dumping to TextNodeDumper

aaron.ballman added a comment. It appears we have no test coverage for this case -- can you introduce some? Comment at: lib/AST/ASTDumper.cpp:506-507 if (!isa(*D) && !isa(*D)) { auto DC = dyn_cast(D); - if (DC && - (DC->hasExternalLexicalStorage() || -

[PATCH] D56841: [clangd] Filter out plugin related flags.

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:429 + const auto &CommandLine = Inputs.CompileCommand.CommandLine; + for (size_t I = 0, E = CommandLine.size(); I != E; I++) { +// According to https://clang.llvm.org/docs/ClangPlugins.html -

Re: r351344 - [MSP430] Improve support of 'interrupt' attribute

Merged to 8.0 in r351441. On Wed, Jan 16, 2019 at 2:47 PM Anton Korobeynikov via cfe-commits wrote: > > Author: asl > Date: Wed Jan 16 05:44:01 2019 > New Revision: 351344 > > URL: http://llvm.org/viewvc/llvm-project?rev=351344&view=rev > Log: > [MSP430] Improve support of 'interrupt' attribute >

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov added a comment. Thanks for a quick response, @kadircet! Leaving some first comments, will address the rest later. In D56723#1361366 , @kadircet wrote: > One general comment: I am not really sure if the handling done in > `ParseCastExpressi

[PATCH] D56841: [clangd] Filter out plugin related flags.

ioeric added inline comments. Comment at: clangd/ClangdUnit.cpp:429 + const auto &CommandLine = Inputs.CompileCommand.CommandLine; + for (size_t I = 0, E = CommandLine.size(); I != E; I++) { +// According to https://clang.llvm.org/docs/ClangPlugins.html ily

[PATCH] D56841: [clangd] Filter out plugin related flags.

kadircet marked 3 inline comments as done. kadircet added a comment. It seems like the most relevant place in tooling is ArgumentsAdjuster as @ioeric pointed out. Happy to move it to there if @sammccall and @klimek agrees as well. As a side note `ArgumentsAdjuster`s unfortunately causes a copy

[PATCH] D56841: [clangd] Filter out plugin related flags.

kadircet updated this revision to Diff 182260. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 Files: clangd/ClangdUn

[PATCH] D56841: [clangd] Filter out plugin related flags.

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:429 + const auto &CommandLine = Inputs.CompileCommand.CommandLine; + for (size_t I = 0, E = CommandLine.size(); I != E; I++) { +// According to https://clang.llvm.org/docs/ClangPlugins.html -

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

ymandel added a comment. In D56786#1360706 , @steveire wrote: > It seems that you update docs for existing matchers without changing those > matchers. You could put all of that in one patch. > > Then, you seem to add some tests for existing matches. You c

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

lebedev.ri added subscribers: cfe-commits, lebedev.ri. lebedev.ri added a comment. Please always subscribe lists. The reviews that happen without lists are null and void. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56849/new/ https://reviews.llvm.org/D56849

[PATCH] D56850: [ASTMatchers] Add tests for assorted `CXXMemberCallExpr` matchers.

lebedev.ri added subscribers: cfe-commits, lebedev.ri. lebedev.ri added a comment. Please always subscribe lists. The reviews that happen without lists are null and void. Is this testing pre-existing behavior, and thus NFC? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

lebedev.ri added subscribers: cfe-commits, lebedev.ri. lebedev.ri added a comment. Please always subscribe lists. The reviews that happen without lists are null and void. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56851/new/ https://reviews.llvm.org/D56851

RE: r349201 - Add extension to always default-initialize nullptr_t.

Hi Richard- I finally got a chance to take a look at this patch and run it through the nullptr_t tests that we have, and it seems to solve the problem I was attempting. It would be my preference to commit this. I currently have my existing tests (from the previous patch) and am happy with the

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel added a comment. In D56850#1361436 , @lebedev.ri wrote: > Please always subscribe lists. > The reviews that happen without lists are null and void. Thanks for updating my diffs with the relevant list. Noted for next time. > Is this testing pre-

[PATCH] D56829: Move decl context dumping to TextNodeDumper

steveire marked an inline comment as done. steveire added a comment. I don't know what C++ code results in the `undeserialized declarations` output. Can you suggest some? Comment at: lib/AST/ASTDumper.cpp:519-520 - (DC->hasExternalLexicalStorage() || - (Dese

[PATCH] D56852: [AArch64] Use LLU for 64-bit crc32 arguments

samparker created this revision. samparker added a reviewer: t.p.northover. Herald added subscribers: kristof.beyls, javed.absar. The ACLE states that 64-bit crc32 operands are uint64_t so we should have the clang builtin match this description - which is what we already do for AArch32. https:/

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

steveire added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:475 + auto MatchesType = cxxMemberCallExpr(on(hasType(cxxRecordDecl(hasName("X"); + EXPECT_TRUE(matches( + R"cc( Could you add a test which uses the s

[PATCH] D56829: Move decl context dumping to TextNodeDumper

aaron.ballman added a comment. In D56829#1361465 , @steveire wrote: > I don't know what C++ code results in the `undeserialized declarations` > output. Can you suggest some? I haven't the foggiest idea. I'd recommend doing an svn blame to see what comm

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

steveire added a comment. Should this one now be closed? The 'Add Action...' dropdown has an action for that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56786/new/ https://reviews.llvm.org/D56786 ___ cfe-commits

[PATCH] D56841: [clangd] Filter out plugin related flags.

klimek added a comment. In D56841#1361395 , @kadircet wrote: > It seems like the most relevant place in tooling is ArgumentsAdjuster as > @ioeric pointed out. Happy to move it to there if @sammccall and @klimek > agrees as well. > > As a side note `Argum

[PATCH] D56841: [clangd] Filter out plugin related flags.

sammccall added a comment. In D56841#1361395 , @kadircet wrote: > It seems like the most relevant place in tooling is ArgumentsAdjuster as > @ioeric pointed out. Happy to move it to there if @sammccall and @klimek > agrees as well. > > As a side note `Ar

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 182272. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Build tweaks as an object library. To make sure linker does not optimize away global constructors. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 182273. ilya-biryukov added a comment. - Rebase after parent change Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clangd/SourceCode.cpp clangd/SourceC

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182274. ilya-biryukov added a comment. - Rebase after parent change Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clangd/refactor/tweaks/CMakeLists.txt

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov updated this revision to Diff 182276. ilya-biryukov added a comment. - Rebase after parent change Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56612/new/ https://reviews.llvm.org/D56612 Files: clangd/AST.cpp clangd/AST.h clangd

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov added a comment. Haven't yet addressed all the comments, but switched to use the "object library" (i.e. a collection of .o files) to make sure linker does not optimize away global ctors required by registry. Comment at: clangd/refactor/Tweak.cpp:38 +namespace {

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

steveire added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:4823 + matches "x.m", but not "m" +memberExpr(hasObjectExpression(hasType(pointsTo( + cxxRecordDecl(hasName("X")) If we're going to put such examples and details into the

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia updated this revision to Diff 182281. Anastasia marked an inline comment as done. Anastasia added a comment. - Removed else case in DiagnoseMultipleAddrSpaceAttributes - Added extra test to check correctness of addr space for 'this' when statically used in a class scope. CHANGES SINCE

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

ufna added a comment. @krasimir BeforeHash style is widely used for Unreal Engine 4 based projects development. I was looking for this option too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52150/new/ https://reviews.llvm.org/D52150 ___

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

abeserminji added a comment. I am not sure if -static option passed as --cflag to lnt runtest enters the LDFLAGS. I guess it doesn't. But if there is a way to check which options are passed as --cflags, we might be able to add -Wl, -whole-archive -lpthread -Wl -no-whole-archive only in case wh

[PATCH] D56841: [clangd] Filter out plugin related flags.

kadircet added a comment. clang-tidy also has the same fix in place, https://reviews.llvm.org/D18806 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 ___ cfe-comm

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6170 + } +} + } rjmccall wrote: > Does this not need to diagnose redundant qualifiers? Why is this path > required in addition

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia updated this revision to Diff 182282. Anastasia added a comment. - Fixed typo in FIXME CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55850/new/ https://reviews.llvm.org/D55850 Files: include/clang/AST/Type.h include/clang/Sema/ParsedAttr.h lib/Parse/ParseDecl.cpp lib/

[PATCH] D56841: [clangd] Filter out plugin related flags.

ilya-biryukov added a comment. In D56841#1361492 , @klimek wrote: > (I know, I know, I'm not a big help) That's fine, mostly wanted to hear your opinion :-) > That said, if we can find a nice abstraction to pull out, I'm generally in > favor :) Eric s

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:642 - if (!D->param_begin() && D->getNumParams()) -dumpChild([=] { OS << ">"; }); - else -for (const ParmVarDecl *Parameter : D->parameters()) + if (D->param_begin() || !D->ge

r351449 - CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

Author: asl Date: Thu Jan 17 07:21:55 2019 New Revision: 351449 URL: http://llvm.org/viewvc/llvm-project?rev=351449&view=rev Log: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds llvm.flt.rounds returns an i32, but the builtin expects an integer. On targets where integers are n

[PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

This revision was automatically updated to reflect the committed changes. Closed by commit rL351449: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds (authored by asl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D2

[PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

asl accepted this revision. asl added a comment. Committed, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24461/new/ https://reviews.llvm.org/D24461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D56841: [clangd] Filter out plugin related flags.

kadircet planned changes to this revision. kadircet marked an inline comment as done. kadircet added a comment. Moving stripper to tooling. Comment at: clangd/ClangdUnit.cpp:433 +// +if (I + 4 < E && CommandLine[I] == "-Xclang" && +(CommandLine[I + 1] == "-load

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

aaron.ballman added a comment. Some minor nits, but this is a good improvement! Comment at: clang/docs/LibASTMatchersReference.html:4823 + matches "x.m", but not "m" +memberExpr(hasObjectExpression(hasType(pointsTo( + cxxRecordDecl(hasName("X")) stevei

[PATCH] D56856: [tooling] Add a new argument adjuster for deleting plugin related command line args

kadircet created this revision. kadircet added reviewers: ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, ioeric. Currently both clangd and clang-tidy makes use of this mechanism so putting it into tooling so that all tools can make use of it. Repository: rC Clang https://rev

Re: r350768 - [ObjC] Allow the use of implemented unavailable methods from within

For the archives, here's said patch: https://reviews.llvm.org/D56816 (Thanks!) On Wed, Jan 16, 2019 at 5:26 PM Alex L wrote: > Hi, > > We are planning to fix this issue by not checking if the method is > defined. I will post a patch this week. > > Cheers, > Alex > > On Fri, 11 Jan 2019 at 10:26

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 182295. ymandel added a comment. Extended test for matcher `on`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 Files: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp Index: clang/unittests/ASTM

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:475 + auto MatchesType = cxxMemberCallExpr(on(hasType(cxxRecordDecl(hasName("X"); + EXPECT_TRUE(matches( + R"cc( -

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 182299. ymandel added a comment. Respond to comments; fix mistake (revealed by test). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56849/new/ https://reviews.llvm.org/D56849 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AS

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 182301. ymandel marked 2 inline comments as done. ymandel added a comment. Update HTML docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56849/new/ https://reviews.llvm.org/D56849 Files: clang/docs/LibASTMatchersReference.html clang/include/c

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

ymandel marked 4 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2905 +/// cxxMemberCallExpr(on(callExpr())) +/// matches `(g()).m()` /// aaron.ballman wrote: > Missing a full stop. also fixed m

[PATCH] D56856: [tooling] Add a new argument adjuster for deleting plugin related command line args

ilya-biryukov added inline comments. Comment at: include/clang/Tooling/ArgumentsAdjusters.h:69 +/// Gets an argument adjuster which strips plugin related command line +/// arguments. Maybe put the function before `combineAdjusters`? The latter is a function tha

[PATCH] D56856: [tooling] Add a new argument adjuster for deleting plugin related command line args

ilya-biryukov added a comment. Just a few NITs from my side, LG when fixed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56856/new/ https://reviews.llvm.org/D56856 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56860 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 182315. ilya-biryukov marked 9 inline comments as done. ilya-biryukov added a comment. - Remove intermediate StringMap, use registry directly - Rename codeAction to codeTweak in ClangdServer - Rename a helper to get position to sourceLocationInMainFile -

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 182316. ilya-biryukov added a comment. - Update to reflect changes in parent revision Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clangd/SourceCode.cp

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182317. ilya-biryukov added a comment. - Update to reflect changes in parent revision Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clangd/refactor/twea

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov updated this revision to Diff 182318. ilya-biryukov added a comment. - Update to reflect changes in parent revision Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56612/new/ https://reviews.llvm.org/D56612 Files: clangd/AST.cpp cla

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56802/new/ https://reviews.llvm.org/D56802 ___ cfe-commits mailing list cfe-commi

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 182320. ilya-biryukov added a comment. - Remove the header file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clangd/SourceCode.cpp clangd/SourceCode.

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov updated this revision to Diff 182322. ilya-biryukov added a comment. - Remove the header file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56612/new/ https://reviews.llvm.org/D56612 Files: clangd/AST.cpp clangd/AST.h clangd/ref

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182321. ilya-biryukov added a comment. - Remove the header file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clangd/refactor/tweaks/CMakeLists.txt cl

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:346 + {ExecuteCommandParams::CLANGD_APPLY_FIX_COMMAND, + ExecuteCommandParams::CLANGD_APPLY_CODE_ACTION}}, }}, sammccall wrote: > Seems a

[PATCH] D56856: [tooling] Add a new argument adjuster for deleting plugin related command line args

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM after the nits are fixed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56856/new/ https://reviews.llvm.org/D56856 ___

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Please, in the future, make sure you post full-context patches. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53928/new/ https://reviews.llvm.org/D5392

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov added a comment. This should be ready for another round of review. Let me know if I missed any of the older comments. There are two more things that I'd like to do before this lands: - go through the docs again and update/simplify them to make sure they're in sync with the new int

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

scott.linder added a comment. I think we need the option to be in the driver, not just -cc1. We are moving towards the clang driver being the authority on how we do offline compilation for AMDGPU, and hiding this in cc1 doesn't help us. I also don't think this is unreasonable to expose in gener

r351457 - TLS: Respect visibility for thread_local variables on Darwin (PR40327)

Author: vlad.tsyrklevich Date: Thu Jan 17 09:53:45 2019 New Revision: 351457 URL: http://llvm.org/viewvc/llvm-project?rev=351457&view=rev Log: TLS: Respect visibility for thread_local variables on Darwin (PR40327) Summary: Teach clang to mark thread wrappers for thread_local variables with hidden

[PATCH] D56818: TLS: Respect visibility for thread_local variables on Darwin (PR40327)

This revision was automatically updated to reflect the committed changes. Closed by commit rC351457: TLS: Respect visibility for thread_local variables on Darwin (PR40327) (authored by vlad.tsyrklevich, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://rev

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Hi @vit9696 , This looks to be caused by using 128-bit long double on the platform. Does linux really use 128-bit long doubles on ppc32? FreeBSD uses 64-bit long double, so compiling that with '-target powerpc-gnu-freebsd' works fine. I'm not sure how to handle the

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus accepted this revision. Szelethus added a comment. Overall I think this looks great, thanks! I left some inlines that would be nice to fix before commiting, but all of them are minor nits. Would it be possible for you to commit the clang-formatting and the actual logic separately?

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus added inline comments. Comment at: test/Analysis/security-syntax-checks.m:253 + FILE *file; + sprintf(buf, "a"); // expected-warning{{Call to function 'sprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Actually I am not sure about Linux, since this is bare metal, and I just used what fited. However, it does not look like 128-bit or 64-bit long doubles are related. I retried to compile the test case with powerpc-gnu-freebsd target (and even made a compile-time assertio

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Hi @vit9696 it does crash with the linux target (powerpc-gnu-linux), but is fine with powerpc-gnu-freebsd. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754 _

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

This revision was automatically updated to reflect the committed changes. Closed by commit rC351459: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D56816?vs=182191&id=182334#toc

r351459 - [ObjC] Follow-up r350768 and allow the use of unavailable methods that are

Author: arphaman Date: Thu Jan 17 10:12:45 2019 New Revision: 351459 URL: http://llvm.org/viewvc/llvm-project?rev=351459&view=rev Log: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context This commit extends

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. In D35068#811436 , @NoQ wrote: > I wonder how noisy this check is - did you test it on large codebases? > Because these functions are po

Re: r351459 - [ObjC] Follow-up r350768 and allow the use of unavailable methods that are

Hi Hans, Could you please cherry-pick this change into the release branch? Cheers, Alex On Thu, 17 Jan 2019 at 10:16, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Thu Jan 17 10:12:45 2019 > New Revision: 351459 > > URL: http://llvm.org/viewvc/llvm-

r351461 - [CodeGenObjC] Use a constant value for non-fragile ivar offsets when possible

Author: epilk Date: Thu Jan 17 10:18:53 2019 New Revision: 351461 URL: http://llvm.org/viewvc/llvm-project?rev=351461&view=rev Log: [CodeGenObjC] Use a constant value for non-fragile ivar offsets when possible If a class inherits from NSObject and has an implementation, then we can assume that iv

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC351461: [CodeGenObjC] Use a constant value for non-fragile ivar offsets when possible (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56802?vs=182214&id=182336#toc

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. You are right, had to modify it like this to get the crash with FreeBSD triple: void f1(long double v, void *a) { } void f2(void* v, __builtin_va_list arg) { f1(__builtin_va_arg(arg, long double), 0); } Repository: rC Clang CHANGES SINCE LAST ACTIO

[clang-tools-extra] r351463 - [Documentation] Add a chapter about Clang-tidy integrations.

Author: eugenezelenko Date: Thu Jan 17 10:31:34 2019 New Revision: 351463 URL: http://llvm.org/viewvc/llvm-project?rev=351463&view=rev Log: [Documentation] Add a chapter about Clang-tidy integrations. Patch by Marina Kalashina. Differential Revision: https://reviews.llvm.org/D54945 Added: c

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

This revision was automatically updated to reflect the committed changes. Closed by commit rL351463: [Documentation] Add a chapter about Clang-tidy integrations. (authored by eugenezelenko, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

  1   2   >