r351294 - [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03

2019-01-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jan 15 18:34:36 2019 New Revision: 351294 URL: http://llvm.org/viewvc/llvm-project?rev=351294&view=rev Log: [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03 When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t as an unscoped

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

2019-01-15 Thread Dan McGregor via Phabricator via cfe-commits
dankm updated this revision to Diff 181964. dankm marked an inline comment as done. dankm added a comment. Enforce path mapping. This requires LLVM review D56769 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

2019-01-15 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. It's an interesting idea at least, and it does seem like there ought to be some way to express it, at least internally. A `-cc1` option is fine for your purposes, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53153/new/ https://reviews.llvm.org/D53153

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

2019-01-15 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D56411#1352602 , @yaxunl wrote: > In D56411#1352332 , @rjmccall wrote: > > > This patch still doesn't make any sense. You don't need to do any special > > validation when passing a fun

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

2019-01-15 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Wow, thanks for the cleanups. This is much easier to read as a consequence. And sorry it took a while to get you another round of review. Comments below. Com

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

2019-01-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF marked 10 inline comments as done. EricWF added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template argument deduction for %0 that has no user-de

r351298 - [WebAssembly] COWS has been renamed to WASI.

2019-01-15 Thread Dan Gohman via cfe-commits
Author: djg Date: Tue Jan 15 21:23:57 2019 New Revision: 351298 URL: http://llvm.org/viewvc/llvm-project?rev=351298&view=rev Log: [WebAssembly] COWS has been renamed to WASI. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/Driver/wasm-toolchain.c cfe/trunk/test/Driver/wasm-to

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

2019-01-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 181972. EricWF added a comment. Address review comments. - Use "%0 maybe not intend to support ctad" like warning text. - Add note about suppression. - Rename `-Wimplicit-ctad` -> `-Wctad-maybe-unsupported` (Perhaps it should be `-Wctad-maybe-unintended`?) A

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

2019-01-15 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 181973. jyu2 marked an inline comment as done. jyu2 added a comment. Change error message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h inclu

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

2019-01-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 181974. EricWF added a comment. Add the requested tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55500/new/ https://reviews.llvm.org/D55500 Files: include/clang/Basic/Builtins.def lib/AST/ExprConstant.cpp lib/Basic/Builtins.cpp test/Co

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

2019-01-15 Thread Ali Tamur via Phabricator via cfe-commits
tamur added a comment. This patch seems to have broken the compilation. I get the following error on a linux platform: [12/14] Linking CXX executable bin/clangd FAILED: bin/clangd : && /usr/local/google/home/tamur/src/llvm/2018_nov_12/llvm/Stable/bin/clang++ -fPIC -fvisibility-inlines-hidden -

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

2019-01-15 Thread Akira Hatanaka via cfe-commits
Yes, the behavior of the compiler doesn’t match what’s explained in the documentation anymore.Please take a look at the attached patch, which updates the documentation. trivial-abi-docs.patch Description: Binary data CC’ing a couple more people who commented on the original patch.On Jan 10, 2019,

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

2019-01-15 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. In D56731#1359190 , @rsmith wrote: > we need to keep in mind while making that decision that a warning that is > either off-by-default or turned off by nearly everyone delivers much less > value Agreed. I would expect the D

r351301 - [X86] Correct the type string for __builtin_ia32_gathersiv16sf to make the indices an integer type not an FP type.

2019-01-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Tue Jan 15 23:17:14 2019 New Revision: 351301 URL: http://llvm.org/viewvc/llvm-project?rev=351301&view=rev Log: [X86] Correct the type string for __builtin_ia32_gathersiv16sf to make the indices an integer type not an FP type. The element count and width remain the same. Th

[PATCH] D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move.

2019-01-15 Thread Martin Böhme via Phabricator via cfe-commits
mboehme added a comment. In D56585#1358477 , @JonasToth wrote: > LGTM, is there a bug report for this issue? If yes please close that too :) Thanks for the reminder! This was a bug that was reported internally, so there is no LLVM bug for this. Reposi

r351302 - [SEH] Pass the frame pointer from SEH finally to finally functions

2019-01-15 Thread Sanjin Sijaric via cfe-commits
Author: ssijaric Date: Tue Jan 15 23:39:44 2019 New Revision: 351302 URL: http://llvm.org/viewvc/llvm-project?rev=351302&view=rev Log: [SEH] Pass the frame pointer from SEH finally to finally functions Pass the frame pointer that the first finally block receives onto the nested finally block, ins

[PATCH] D56463: [SEH] Pass the frame pointer from SEH finally to finally functions

2019-01-15 Thread Sanjin Sijaric via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC351302: [SEH] Pass the frame pointer from SEH finally to finally functions (authored by ssijaric, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56463/new/

[clang-tools-extra] r351303 - [clang-tidy] Treat references to smart pointers correctly in use-after-move.

2019-01-15 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Tue Jan 15 23:53:25 2019 New Revision: 351303 URL: http://llvm.org/viewvc/llvm-project?rev=351303&view=rev Log: [clang-tidy] Treat references to smart pointers correctly in use-after-move. Summary: Previously, we weren't recognizing these as smart pointers and thus weren't a

[PATCH] D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move.

2019-01-15 Thread Martin Böhme via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351303: [clang-tidy] Treat references to smart pointers correctly in use-after-move. (authored by mboehme, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAS

<    1   2   3