[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added inline comments. Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:161 + { +// Though types are different, initialization can be done with `memcpy`. +int32_t array[1] = {-1}; Quuxplusone wrote

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56405/new/ https://reviews.llvm.org/D56405 ___

r350573 - NFC: Replace asserts with if() in SourceLocation accessors

Author: steveire Date: Mon Jan 7 13:57:30 2019 New Revision: 350573 URL: http://llvm.org/viewvc/llvm-project?rev=350573&view=rev Log: NFC: Replace asserts with if() in SourceLocation accessors Summary: Nowhere else in the AST classes assert on these kinds of accessors. This way, we can call the

[PATCH] D56354: [AST] Replace asserts with if() in SourceLocation accessors

This revision was automatically updated to reflect the committed changes. Closed by commit rL350573: NFC: Replace asserts with if() in SourceLocation accessors (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5635

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. If a kernel template has a function as its template parameter, a device function should be allowed as template argument since a kernel can call a device function. However, currently if the kernel template is instantiated in a ho

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, arphaman, guansong. Change the strategy for computing loop index variables after collapsing a loop nest via the collapse clause by replacing the expensive remainder operation with m

[PATCH] D56354: [AST] Replace asserts with if() in SourceLocation accessors

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/NestedNameSpecifier.cpp:465 TypeLoc NestedNameSpecifierLoc::getTypeLoc() const { - assert((Qualifier->getKind() == NestedNameSpecifier::TypeSpec || - Qualifier->getKind() ==

[PATCH] D56415: NFC: Port QueryParser to StringRef

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. There is no reason for it to not be a StringRef. Making it one simplifies existing code, and makes follow-up features easier. Repository: rCTE Clang Tools Extra https://reviews.l

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai updated this revision to Diff 180577. vsapsai added a comment. - Test initializing vector of pointers with array of pointers of convertible type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48342/new/ https://reviews.llvm.org/D48342 Files: libcxx/include/memory libcxx/t

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

Quuxplusone added inline comments. Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:161 + { +// Though types are different, initialization can be done with `memcpy`. +int32_t array[1] = {-1}; vsapsai wrote

[PATCH] D56050: [Sema] Diagnose array access preceding the array bounds even when the base type is incomplete.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56050/new/ https://reviews.llvm.org/D56050 ___ cfe-commit

Re: r350572 - Add a __has_feature check for namespaces on #pragma clang attribute.

On Mon, 7 Jan 2019 at 13:57, Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: epilk > Date: Mon Jan 7 13:54:00 2019 > New Revision: 350572 > > URL: http://llvm.org/viewvc/llvm-project?rev=350572&view=rev > Log: > Add a __has_feature check for namespaces on #pragma cl

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL350583: [libcxx] Optimize vectors construction of trivial types from an iterator range… (authored by vsapsai, committed by

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added inline comments. Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:161 + { +// Though types are different, initialization can be done with `memcpy`. +int32_t array[1] = {-1}; Quuxplusone wrote

Re: r350572 - Add a __has_feature check for namespaces on #pragma clang attribute.

On 1/7/19 3:51 PM, Richard Smith wrote: On Mon, 7 Jan 2019 at 13:57, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: epilk Date: Mon Jan  7 13:54:00 2019 New Revision: 350572 URL: http://llvm.org/viewvc/llvm-project?rev=350572&view=rev Lo

[clang-tools-extra] r350584 - ReleaseNotes: Update with my clang-query contributions this cycle

Author: steveire Date: Mon Jan 7 16:09:34 2019 New Revision: 350584 URL: http://llvm.org/viewvc/llvm-project?rev=350584&view=rev Log: ReleaseNotes: Update with my clang-query contributions this cycle Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/d

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

riccibruno added a comment. > Okay. That comment seems reasonable. Glad to hear you're on top of it. :) I guess that means I can land this as is ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56367/new/ https://reviews.llvm.org/D56367 ___

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

rsmith added inline comments. Comment at: include/clang/AST/ASTContext.h:279 + /// A cache mapping a function declaration to its human-readable function or + /// file name. Comment seems out of date: the key here is a string rather than a function declaratio

r350585 - Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor

Author: epilk Date: Mon Jan 7 16:21:05 2019 New Revision: 350585 URL: http://llvm.org/viewvc/llvm-project?rev=350585&view=rev Log: Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor -Wdelete-non-virtual-dtor previously controlled two diagnostics: 1) calling a non-virtual dto

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

This revision was automatically updated to reflect the committed changes. Closed by commit rC350585: Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56405?vs=180532&id=180584#toc Repo

Re: r350572 - Add a __has_feature check for namespaces on #pragma clang attribute.

On Mon, 7 Jan 2019 at 16:12, Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 1/7/19 3:51 PM, Richard Smith wrote: > > On Mon, 7 Jan 2019 at 13:57, Erik Pilkington via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: epilk >> Date: Mon Jan 7 13:54:00 2019 >

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

bruno added inline comments. Comment at: include/clang/Basic/Builtins.def:759 +// Random C++ builtins. +LANGBUILTIN(__builtin_is_constant_evaluated, "b", "ncu", CXX_LANG) + EricWF wrote: > EricWF wrote: > > bruno wrote: > > > Name bikeshedding : perhaps the built

Buildbot numbers for the week of 12/23/2018 - 12/29/2018

Hello everyone, Below are some buildbot numbers for the week of 12/23/2018 - 12/29/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the last week of 12/30/2018 - 01/05/2019

Hello everyone, Below are some buildbot numbers for the last week of 12/30/2018 - 01/05/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNonVirtualDtor : DiagGroup<"delete-non-virtual-dtor">; +def DeleteAbstractNonVirtualDtor : DiagGroup<"delete-abstract-non-virtual-dtor", +

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNonVirtualDtor : DiagGroup<"delete-non-virtual-dtor">; +def DeleteAbstractNonVirtualDtor : DiagGroup<"delete-abstract-non-virtual-dtor", +

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNonVirtualDtor : DiagGroup<"delete-non-virtual-dtor">; +def DeleteAbstractNonVirtualDtor : DiagGroup<"delete-abstract-non-virtual-dtor", +

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

ahatanak updated this revision to Diff 180593. ahatanak added a comment. Make `deduceVarTypeFromInitializer` and `DeduceVariableDeclarationType` return the new initialization expression and use it in `Sema::AddInitializerToDecl`. Add a test case that tests lambda capture with an initializer. R

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 180596. bernhardmgruber marked 31 inline comments as done. bernhardmgruber added a comment. Fixed most of the issues pointed out by @JonasToth and added a few more tests. The tests with data member pointers currently fail and I will investiage this.

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:33 + const TypeSourceInfo *TSI = F.getTypeSourceInfo(); + assert(TSI); + const FunctionTypeLoc FTL = JonasToth wrote: > Please add an error-msg to the assertion

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF updated this revision to Diff 180597. EricWF marked 4 inline comments as done. EricWF added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37035/new/ https://reviews.llvm.org/D37035 Files: docs/LanguageExtensions.rst include/clang/AST/ASTCo

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF marked 18 inline comments as done. EricWF added a comment. Mark more review comments as done. Comment at: lib/AST/Expr.cpp:2026-2027 + // human readable name. + if (IdentifierInfo *II = FD->getDeclName().getAsIdentifierInfo()) +return MkStr(II->getNameS

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber added a comment. @JonasToth Do you really think I should drop the extra information on why I could not provide a FixIt? If truly yes, than I would like to keep them as comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160

[PATCH] D56415: NFC: Port QueryParser to StringRef

kristina added a reviewer: kristina. kristina added a comment. LGTM aside from one comment. Comment at: clang-query/QueryParser.cpp:36 + if (Line.front() == '#') { +Line = {}; return StringRef(); I don't think this is the best way of handling it, in f

[PATCH] D56424: Add check for underscores in googletest names.

karepker created this revision. karepker added a reviewer: hokein. Herald added a subscriber: mgorny. Adds a clang-tidy warning for underscores in googletest names. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56424 Files: clang-tidy/google/AvoidUnderscoreInGoogletestNameCh

[PATCH] D56424: Add check for underscores in googletest names.

karepker updated this revision to Diff 180603. karepker added a comment. Clean up comments in test file. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/ https://reviews.llvm.org/D56424 Files: clang-tidy/google/AvoidUnderscoreInGoogletest

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

kristina added a comment. Ping for author? This is one of the changes I'd like to see through, though the complexity here can be massively reduced as stated above. I wouldn't mind opening a new diff if the author is away with just a change in PPMacroExpansion and a testcase (which should probab

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yeah, LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56367/new/ https://reviews.llvm.org/D56367 ___ cfe

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

rjmccall added inline comments. Comment at: lib/Sema/SemaLambda.cpp:793 + else +Args = Init; + Please maintain the original order here, even though I suspect it doesn't matter: if this is direct-initialization, use the arguments, otherwise use either `Dedu

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

rjmccall added a comment. Oh, and please update the commit message to primarily talk about the changes to placeholder checking. You can discuss the impact on the repeated-use-of-weak warning in a follow-up paragraph. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org

r350612 - [ASTMatchers] Improve assert message for broken parent map.

Author: sammccall Date: Mon Jan 7 23:29:46 2019 New Revision: 350612 URL: http://llvm.org/viewvc/llvm-project?rev=350612&view=rev Log: [ASTMatchers] Improve assert message for broken parent map. Summary: This assert catches places where the AST (as seen by RecursiveASTVisitor) becomes disconnect

[PATCH] D56395: [ASTMatchers] Improve assert message for broken parent map.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350612: [ASTMatchers] Improve assert message for broken parent map. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION http

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

lebedev.ri added a comment. In D56424#1349218 , @karepker wrote: > Clean up comments in test file. For reference, what documentation sources did you read when creating the review itseft? I thought it was documented that an appropriate category (`[clang-

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. Sema won't necessarily have resolved a template decl when parsing a template argument list, so trying to propagate that decl down to indicate that we're resolving a template argument is not a good approach. I was going to suggest recording that we're within a template

<    1   2