[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

a_sidorin added subscribers: bruno, aaron.ballman, rsmith. a_sidorin added a comment. Hello Endre. I agree that it doesn't make sense to have 'errors' in AST merging tools, and the changes for ASTImporter part are welcome. However, I don't feel so positive to modules support changes and I don't

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

krytarowski added a comment. It was disabled on NetBSD for the same reason - GNU strip(1) is breaking: http://netbsd.org/~kamil/llvm/strip.txt Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56047/new/ https://reviews.llvm.org/D56047 ___

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

a_sidorin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:156 +bool isDestinationArgument(unsigned ArgNum) const { + return (std::find(DstArgs.begin(), DstArgs.end(), ArgNum) != + DstArgs.end()); llvm::

[PATCH] D55280: [CTU] Make loadExternalAST return with non nullptr on success

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor, Yes, this looks good. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55280/new/ https://reviews.llvm.org/D55280 _

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, would it be possible to also include https://bugs.gentoo.org/667854 in the commit message for reference? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

chandlerc requested changes to this revision. chandlerc added inline comments. This revision now requires changes to proceed. Comment at: lib/CodeGen/CGCall.cpp:1739 FuncAttrs.addAttribute("no-frame-pointer-elim", "true"); - FuncAttrs.addAttribute("no-frame-pointer-el

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

boga95 updated this revision to Diff 179436. boga95 marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index: lib/StaticAnalyzer/Checkers/GenericTaintChec

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

JonasToth added inline comments. Comment at: clang-tidy/readability/DuplicatedAccessSpecifiersCheck.cpp:51 + diag(ASDecl->getLocation(), "duplicated access specifier") + << MatchedDecl + << FixItHint::CreateRemoval(ASDecl->getSourceRange()); ---

[PATCH] D56054: [gn build] Add build files for clang/tools/{clang-diff,clang-import-test,diagtool and clang/lib/Tooling, clang/lib/Tooling/ASTDiff

This revision was automatically updated to reflect the committed changes. Closed by commit rL350024: [gn build] Add build files for clang/tools/{clang-diff,clang-import-test… (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D56055: [gn build] Add build files for clang/tools/{clang-refactor, clang-rename}, clang/utils/hmaptool, clang/lib/Tooling/Refactoring

This revision was automatically updated to reflect the committed changes. Closed by commit rL350025: [gn build] Add build files for clang/tools/{clang-refactor,clang-rename}… (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D56056: [gn build] Add build files for clang/tools/{arcmt-test, clang-check, clang-func-mapping}

This revision was automatically updated to reflect the committed changes. Closed by commit rL350026: [gn build] Add build files for clang/tools/{arcmt-test,clang-check,clang-func… (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman added a reviewer: tonic. aaron.ballman added a subscriber: tonic. aaron.ballman added a comment. Adding @tonic as a reviewer, who may have suggestions on how to improve the documentation wording. Comment at: include/clang/Basic/AttrDocs.td:2655 + dependence viol

r350028 - [Driver] Disable -faddrsig on Gentoo by default

Author: mgorny Date: Sun Dec 23 07:07:26 2018 New Revision: 350028 URL: http://llvm.org/viewvc/llvm-project?rev=350028&view=rev Log: [Driver] Disable -faddrsig on Gentoo by default Gentoo supports combining clang toolchain with GNU binutils, and many users actually do that. As -faddrsig is not s

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

mgorny added a comment. In D56047#1340337 , @phosek wrote: > LGTM, would it be possible to also include https://bugs.gentoo.org/667854 in > the commit message for reference? Done, and thanks for the review. Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D56024: [clang] [Distro] Support detecting Gentoo

This revision was automatically updated to reflect the committed changes. Closed by commit rL350027: [Distro] Support detecting Gentoo (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56024?vs=179413&id=179441#toc

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL350028: [Driver] Disable -faddrsig on Gentoo by default (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56047?vs=179415&i

r350027 - [Distro] Support detecting Gentoo

Author: mgorny Date: Sun Dec 23 07:07:19 2018 New Revision: 350027 URL: http://llvm.org/viewvc/llvm-project?rev=350027&view=rev Log: [Distro] Support detecting Gentoo Add support for distinguishing plain Gentoo distribution, and a unit test for it. This is going to be used to introduce distro-sp

[PATCH] D56000: [compiler-rt] [xray] Disable alignas() for thread_local objects on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL350029: [xray] Disable alignas() for thread_local objects on NetBSD (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D56000?vs

[PATCH] D56049: [compiler-rt] [xray] Detect MPROTECT and error out when it's enabled (on NetBSD)

This revision was automatically updated to reflect the committed changes. Closed by commit rL350030: [xray] Detect MPROTECT and error out when it's enabled (on NetBSD) (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D5

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 179445. MyDeveloperDay added a comment. - Rebase - Add a couple of extra test cases to ensure we don't add the NO_DISCARD macro when a clang or gcc attribute is present - Ping to ask code owners to review and possibly commit if happy. CHANGES SINCE L

[PATCH] D56059: [gn build] Add build files for clang/tools/{c-arcmt-test, c-index-test} and their dependency clang/tools/libclang

thakis created this revision. thakis added a reviewer: phosek. Herald added a subscriber: arphaman. libclang is somewhat incomplete. It's just enough to get check-clang to pass, but that requires it to be pretty complete. The biggest thing is that it's not built as a shared library on Linux. The

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

tabloid.adroit updated this revision to Diff 179447. tabloid.adroit marked an inline comment as done. tabloid.adroit added a comment. - update test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55915/new/ https://reviews.llvm.org/D55915 Files: lib/CodeGen/CGCa

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

tabloid.adroit marked 2 inline comments as done. tabloid.adroit added a comment. Thanks for the review! Comments inline. Comment at: lib/CodeGen/CGCall.cpp:1739 FuncAttrs.addAttribute("no-frame-pointer-elim", "true"); - FuncAttrs.addAttribute("no-frame-pointer-elim-

[PATCH] D56061: [clang-tools-extra] [clangd] Fix detecting atomics in stand-alone builds

mgorny created this revision. mgorny added reviewers: bkramer, sdardis, sammccall, ilya-biryukov. Herald added subscribers: kadircet, jfb, arphaman, jkorous, MaskRay, ioeric. Include CheckAtomic CMake module from LLVM in order to detect support for atomics when building stand-alone. Otherwise, th

[clang-tools-extra] r350037 - [clangd] Delete trailing ; NFC

Author: maskray Date: Sun Dec 23 14:20:34 2018 New Revision: 350037 URL: http://llvm.org/viewvc/llvm-project?rev=350037&view=rev Log: [clangd] Delete trailing ; NFC Modified: clang-tools-extra/trunk/clangd/TUScheduler.h Modified: clang-tools-extra/trunk/clangd/TUScheduler.h URL: http://llvm

[PATCH] D47817: [compiler-rt] [sanitizer_common] Fix using libtirpc on Linux

mgorny updated this revision to Diff 179453. mgorny retitled this revision from "[sanitizer_common] Fix using libtirpc on Linux" to "[compiler-rt] [sanitizer_common] Fix using libtirpc on Linux". mgorny edited the summary of this revision. mgorny added a reviewer: Lekensteyn. mgorny added a commen

[PATCH] D47819: [compiler-rt] [test] Support using libtirpc on Linux

mgorny updated this revision to Diff 179454. mgorny retitled this revision from "[test] Support using libtirpc on Linux" to "[compiler-rt] [test] Support using libtirpc on Linux". mgorny edited the summary of this revision. mgorny added a reviewer: Lekensteyn. mgorny set the repository for this re

[PATCH] D47817: [compiler-rt] [sanitizer_common] Fix using libtirpc on Linux

Lekensteyn added a comment. There appears to be other definitions for HAVE_TIRPC_RPC_XDR_H in lib/sanitizer_common/sanitizer_platform.h lib/sanitizer_common/sanitizer_platform_limits_freebsd.cc While at it, perhaps the `#if HAVE_FOO` could be replaced by `#ifdef HAVE_FOO`? CHANGES SINCE LAST AC

[PATCH] D47819: [compiler-rt] [test] Support using libtirpc on Linux

mgorny updated this revision to Diff 179455. mgorny added a comment. Fix bug in previous patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47819/new/ https://reviews.llvm.org/D47819 Files: cmake/base-config-ix.cmake lib/sanitizer_common/CMakeLists.txt test/msan/lit.cfg test/

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

brad added a comment. I've been told there is no desire to make gnu the default on OpenBSD. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 ___ cfe-commits mailing list cfe-co

[PATCH] D56062: [compiler-rt] [test] Detect glibc-2.27+ and XFAIL appropriate tests

mgorny created this revision. mgorny added reviewers: eugenis, kcc, samsonov, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, dberris. XFAIL the tests known to fail with glibc-2.27+. This takes away the burden of handling known failures from users, and ensures that we will be verb

[clang-tools-extra] r350040 - [clangd] Delete stray semicolon. NFC

Author: maskray Date: Sun Dec 23 19:19:53 2018 New Revision: 350040 URL: http://llvm.org/viewvc/llvm-project?rev=350040&view=rev Log: [clangd] Delete stray semicolon. NFC Modified: clang-tools-extra/trunk/clangd/Function.h Modified: clang-tools-extra/trunk/clangd/Function.h URL: http://llvm

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina added a comment. @alexfh Just for me to be sure, should there be the following structure in http://clang.llvm.org/extra/index.html: Clang-Tidy The list of clang-tidy checks Using clang-tidy Suppressing Undesired Diagnostics Clang-tidy Integrated (separate page) Getting