[PATCH] D54604: Automatic variable initialization

dexonsmith added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:412 + "Enable it at your own peril for benchmarking purpose only with " + "-enable-trivial-auto-var-init-zero-knowning-it-will-be-removed-from-clang">; + s/knowning/knowi

[PATCH] D55443: [test] Capture stderr from 'tar --version' call as well

krytarowski resigned from this revision. krytarowski added a comment. Herald added a subscriber: krytarowski. I don't feel enough comfortable with this Python code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55443/new/ https://reviews.llvm.org/D55443 __

[PATCH] D54604: Automatic variable initialization

jfb updated this revision to Diff 177341. jfb added a comment. - Fix typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54604/new/ https://reviews.llvm.org/D54604 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/Diagno

r348665 - [tests] Fix the FileManagerTest getVirtualFile test on Windows

Author: stella.stamenova Date: Fri Dec 7 15:50:05 2018 New Revision: 348665 URL: http://llvm.org/viewvc/llvm-project?rev=348665&view=rev Log: [tests] Fix the FileManagerTest getVirtualFile test on Windows Summary: The test passes on Windows only when it is executed on the C: drive. If the build

[PATCH] D55451: [tests] Fix the FileManagerTest getVirtualFile test on Windows

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC348665: [tests] Fix the FileManagerTest getVirtualFile test on Windows (authored by stella.stamenova, committed by ). Rep

[clang-tools-extra] r348666 - [Documentation] Alphabetical order in new checks list.

Author: eugenezelenko Date: Fri Dec 7 16:07:34 2018 New Revision: 348666 URL: http://llvm.org/viewvc/llvm-project?rev=348666&view=rev Log: [Documentation] Alphabetical order in new checks list. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/Re

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese, dblaikie, vsapsai, sammccall, rsmith, bruno. Herald added subscribers: jkorous, mgorny. This patch introduces a dependency directives source minimizer to clang that minimizes header and source files to the minimum n

[PATCH] D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions

erik.pilkington added a comment. LGTM, but you should probably let @rsmith have the final word! Comment at: lib/Sema/SemaDeclCXX.cpp:1916-1919 +for (Stmt *SubStmt : S->children()) + if (SubStmt && + !CheckConstexprFunctionStmt(SemaRef, Dcl, SubStmt, ReturnStmt

[PATCH] D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions

aaron.ballman added a comment. Some minor nits from the peanut gallery. Comment at: lib/AST/ExprConstant.cpp:4278 + case Stmt::CXXTryStmtClass: +// Evaluate try blocks by evaluating all sub statements +return EvaluateStmt(Result, Info, cast(S)->getTryBlock(), Case); -

[PATCH] D55455: Remove stat cache chaining as it's no longer needed after PTH support has been removed

arphaman added a comment. In D55455#1323836 , @dexonsmith wrote: > This patch LGTM, but before committing I suggest sending an RFC to cfe-dev > and waiting a few days. I posted to `cfe-dev` to check if there are any objections. Repository: rC Clang

[PATCH] D55456: [CUDA] added missing 'inline' for the functions defined in the header.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. jlebar@ LGTM'ed via email. Landed in rL348662 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55456/new/ https://reviews.llvm.org/D55456 ___

r348675 - Stop tracking retain count of OSObject after escape to void * / other primitive types

Author: george.karpenkov Date: Fri Dec 7 17:18:40 2018 New Revision: 348675 URL: http://llvm.org/viewvc/llvm-project?rev=348675&view=rev Log: Stop tracking retain count of OSObject after escape to void * / other primitive types Escaping to void * / uint64_t / others non-OSObject * should stop t

[PATCH] D55465: Stop tracking retain count of OSObject after escape to void * / other primitive types

This revision was automatically updated to reflect the committed changes. Closed by commit rC348675: Stop tracking retain count of OSObject after escape to void * / other primitive… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: h

[PATCH] D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions

bruno updated this revision to Diff 177367. bruno marked an inline comment as done. bruno added a comment. Address @aaron.ballman and @erik.pilkington reviews. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55097/new/ https://reviews.llvm.org/D55097 Files: include/clang/Basic/Diagnost

[PATCH] D55468: Use zip_longest for list comparisons.

Meinersbur created this revision. Meinersbur added reviewers: dblaikie, hfinkel. Use zip_longest in two locations that compare iterator ranges. zip_longest allows the iteration using a range-based for-loop and to be symmetric over both ranges instead of prioritizing one over the other. In that l

r348685 - Move diagnostic enums into Basic.

Author: rtrieu Date: Fri Dec 7 21:05:03 2018 New Revision: 348685 URL: http://llvm.org/viewvc/llvm-project?rev=348685&view=rev Log: Move diagnostic enums into Basic. Move enums from */*Diagnostic.h to Basic/Diagnostic*.h. Basic/AllDiagnostics.h needs all the enums and moving the sources to Basi

[PATCH] D55470: Cpp11 Braced List Style Ignores BAS_AlwaysBreak

jgehrig created this revision. jgehrig added a project: clang. Herald added a subscriber: cfe-commits. First patch attempt :) I've noticed that clang-format does not honor the BAS_AlwaysBreak when Cpp11BracedListStyle is set. This seems like a bug, as BAS_DontAlign will change the line continua

r348687 - Convert some ObjC msgSends to runtime calls.

Author: pete Date: Fri Dec 7 21:13:50 2018 New Revision: 348687 URL: http://llvm.org/viewvc/llvm-project?rev=348687&view=rev Log: Convert some ObjC msgSends to runtime calls. It is faster to directly call the ObjC runtime for methods such as alloc/allocWithZone instead of sending a message to t

[libunwind] r348699 - Creating release candidate rc3 from release_701 branch

Author: tstellar Date: Fri Dec 7 21:19:40 2018 New Revision: 348699 URL: http://llvm.org/viewvc/llvm-project?rev=348699&view=rev Log: Creating release candidate rc3 from release_701 branch Added: libunwind/tags/RELEASE_701/rc3/ (props changed) - copied from r348698, libunwind/branche

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete added a comment. In D55349#1323926 , @rjmccall wrote: > LGTM. Thanks for the review! Landed in r348687. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55349/new/ https://reviews.llvm.org/D55349 _

<    1   2   3