[PATCH] D55415: Revert removal of tidy plugin support from libclang

yvvan created this revision. yvvan added reviewers: bkramer, arphaman, nik. Herald added subscribers: kadircet, jkorous, ioeric, javed.absar, ilya-biryukov. libclang has nothing to do with clangd so I don't see why having the last one is the reason to remove features from libclang. Especially wit

[PATCH] D55415: Revert removal of tidy plugin support from libclang

yvvan updated this revision to Diff 177134. yvvan added a comment. Herald added a subscriber: mgorny. I generated the wrong diff. This is the proper one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/ https://reviews.llvm.org/D55415 Files: tools/libclang/CIndex.cpp tools/

r348569 - Fix thunks returning memptrs via sret by emitting also scalar return values directly in sret slot (PR39901)

Author: hans Date: Fri Dec 7 00:17:26 2018 New Revision: 348569 URL: http://llvm.org/viewvc/llvm-project?rev=348569&view=rev Log: Fix thunks returning memptrs via sret by emitting also scalar return values directly in sret slot (PR39901) Thunks that return member pointers via sret are broken du

[PATCH] D55371: Fix thunks returning memptrs via sret by emitting also scalar return values directly in sret slot (PR39901)

This revision was automatically updated to reflect the committed changes. Closed by commit rL348569: Fix thunks returning memptrs via sret by emitting also scalar return values… (authored by hans, committed by ). Changed prior to commit: https://reviews.llvm.org/D55371?vs=176971&id=177135#toc

[PATCH] D55415: Revert removal of tidy plugin support from libclang

nik added a comment. +1 as this seems to fix the regression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/ https://reviews.llvm.org/D55415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D55415: Revert removal of tidy plugin support from libclang

yvvan added a comment. We can also add an extra variable for it if you care about build time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/ https://reviews.llvm.org/D55415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D55192: [PowerPC] VSX register support for inline assembly

This revision was automatically updated to reflect the committed changes. Closed by commit rC348572: [PowerPC] VSX register support for inline assembly (authored by ZhangKang, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D55192?vs=177

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet marked an inline comment as done. courbet added inline comments. Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed due to requirement '1 == 2' "N is not 2!"}} T<1> t1

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad marked an inline comment as done. romanovvlad added a comment. Could you merge it? I have no rights to do it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 ___ cfe-commits mailing list

[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds

ArnaudBienner added a comment. I found the commit: [1] which links to a related discussion [2] but there isn't much details. I wasn't sure if there was other discussions. I will try to build Firefox with this change, and see how it goes (just need to find some time to do it). I'll keep you poste

[PATCH] D55417: [clangd] Change diskbackedstorage to be atomic

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric. There was a chance that multiple clangd instances could try to write same shard, in which case we would get a malformed file most likely. This p

[PATCH] D55417: [clangd] Change diskbackedstorage to be atomic

kadircet updated this revision to Diff 177146. kadircet added a comment. - Fix returns Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55417/new/ https://reviews.llvm.org/D55417 Files: clangd/index/BackgroundIndexStorage.cpp Index: clangd/index/B

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

hokein accepted this revision. hokein added subscribers: astrelni, ahedberg. hokein added a comment. This revision is now accepted and ready to land. The check looks good from my side, except one nit. > I assume I've got the right reviewers here, but I've also been sending a > bunch of stuff you

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

lebedev.ri added a comment. Please always upload all patches with the full context (`-U9`) Comment at: clang-tidy/abseil/DurationRewriter.cpp:35 +getInverseForScale(DurationScale Scale) { + static const std::unordered_map> https://llvm.org/docs/Programmers

[PATCH] D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'

hokein added a subscriber: hwright. hokein added a comment. + @hwright who have implemented a bunch of `absl-duration-*` checks, you might be interested in this as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53830/new/ https://reviews.llvm.org/D53830

[PATCH] D55417: [clangd] Change diskbackedstorage to be atomic

ilya-biryukov added a comment. NIT: I believe we're missing a hyphen in the change description, i.e. it should be `disk-backed`. Comment at: clangd/index/BackgroundIndexStorage.cpp:76 +// Write to a temporary file first. +llvm::SmallString<64> TempPath; +int FD; --

[PATCH] D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand

rogfer01 abandoned this revision. rogfer01 added a comment. Upstream recently amended the ABI spec so it looks to me this is not going to be needed. CHANGES SINCE LAST ACTION https://reviews.llvm.o

r348582 - Add a AArch64 triple to tiny codemodel test.

Author: dmgreen Date: Fri Dec 7 03:16:03 2018 New Revision: 348582 URL: http://llvm.org/viewvc/llvm-project?rev=348582&view=rev Log: Add a AArch64 triple to tiny codemodel test. Most other targets do not support the tiny code model. Modified: cfe/trunk/test/CodeGen/codemodels.c Modified:

[clang-tools-extra] r348583 - [clang-tidy] Remove duplicated getText implementation, NFC

Author: hokein Date: Fri Dec 7 03:25:37 2018 New Revision: 348583 URL: http://llvm.org/viewvc/llvm-project?rev=348583&view=rev Log: [clang-tidy] Remove duplicated getText implementation, NFC Modified: clang-tools-extra/trunk/clang-tidy/readability/RedundantStringCStrCheck.cpp Modified: cla

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen marked an inline comment as done. devnexen added inline comments. Comment at: test/Analysis/string.c:1405-1406 + clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}} + bzero(str + 2, 2); + clang_analyzer_eval(strlen(str) == 0); // expected-warning{{FALSE

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC, martong. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, jfb, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a reviewer: teemperor. S

[PATCH] D55425: [analyzer] Split unix.API up to UnixAPIMisuseChecker and UnixAPIPortabilityChecker

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, jfb, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. The actual implementation of `unix.API` featu

[PATCH] D55131: [CTU] Add more lit tests and better error handling

martong marked 2 inline comments as done. martong added inline comments. Comment at: test/Analysis/ctu-main.c:4 +// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o %t/ctudir2/ctu-other.c.ast %S/Inputs/ctu-other.c +// RUN: cp %S/Inputs/externalFnMap2.txt %t/ctudir2/exter

[PATCH] D55131: [CTU] Add more lit tests and better error handling

martong updated this revision to Diff 177170. martong marked an inline comment as done. martong added a comment. - Rename externalFnMap files Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55131/new/ https://reviews.llvm.org/D55131 Files: lib/CrossTU/CrossTrans

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

ilya-biryukov added inline comments. Comment at: clangd/index/Background.cpp:202 std::lock_guard Lock(QueueMu); -Queue.push_back(std::move(T)); +if (Priority == ThreadPriority::Low) { + Queue.push_back(Bind( kadircet wrote: > ilya-biryukov wrote

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen updated this revision to Diff 177171. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/string.c Index: test/Analysis/string.c

[PATCH] D55133: [CTU] Add statistics

This revision was automatically updated to reflect the committed changes. Closed by commit rL348584: [CTU] Add statistics (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55133?vs=176655&id=177173#toc Repository:

r348584 - [CTU] Add statistics

Author: martong Date: Fri Dec 7 03:55:22 2018 New Revision: 348584 URL: http://llvm.org/viewvc/llvm-project?rev=348584&view=rev Log: [CTU] Add statistics Reviewers: xazax.hun, a_sidorin Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits Differential Revision: https://reviews.llvm

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. In D48116#1144732 , @ilya-biryukov wrote: > Have you considered doing the same filtering in ASTUnit's > `StoredDiagnosticConsumer`? It should not be more difficult and allows to > avoid changing the clang's diagnostic interfaces. Th

[PATCH] D55133: [CTU] Add statistics

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:171 loadExternalAST(LookupFnName, CrossTUDir, IndexName); - if (!ASTUnitOrError) + if (!ASTUnitOrError) { return ASTUnitOrError.takeError(); ---

r348572 - [PowerPC] VSX register support for inline assembly

Author: zhangkang Date: Fri Dec 7 00:58:12 2018 New Revision: 348572 URL: http://llvm.org/viewvc/llvm-project?rev=348572&view=rev Log: [PowerPC] VSX register support for inline assembly Summary: The patch is to add the VSX register support for inline assembly. After this patch, we can use VSX r

[PATCH] D55132: [CTU] Add asserts to protect invariants

This revision was automatically updated to reflect the committed changes. Closed by commit rL348586: [CTU] Add asserts to protect invariants (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55132?vs=176151&id=17717

r348586 - [CTU] Add asserts to protect invariants

Author: martong Date: Fri Dec 7 04:21:43 2018 New Revision: 348586 URL: http://llvm.org/viewvc/llvm-project?rev=348586&view=rev Log: [CTU] Add asserts to protect invariants Reviewers: xazax.hun, a_sidorin Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits Differential Revision: h

r348587 - [CTU] Eliminate race condition in CTU lit tests

Author: martong Date: Fri Dec 7 04:29:02 2018 New Revision: 348587 URL: http://llvm.org/viewvc/llvm-project?rev=348587&view=rev Log: [CTU] Eliminate race condition in CTU lit tests Summary: We plan to introduce additional CTU related lit test. Since lit may run the tests in parallel, it is not s

[PATCH] D55129: [CTU] Eliminate race condition in CTU lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL348587: [CTU] Eliminate race condition in CTU lit tests (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.ll

r348588 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Fri Dec 7 04:35:15 2018 New Revision: 348588 URL: http://llvm.org/viewvc/llvm-project?rev=348588&view=rev Log: Adding tests for -ast-dump; NFC. This adds tests for various statements in C. Modified: cfe/trunk/test/AST/ast-dump-stmt.c Modified: cfe/trunk/test/AST/

Re: r348469 - Make test resistant to line numbers changing

On Thu, Dec 6, 2018 at 5:55 PM Stephen Kelly wrote: > > > On 06/12/2018 12:45, Aaron Ballman wrote: > > On Thu, Dec 6, 2018 at 4:25 AM Stephen Kelly via cfe-commits > > wrote: > >> Author: steveire > >> Date: Thu Dec 6 01:22:12 2018 > >> New Revision: 348469 > >> > >> URL: http://llvm.org/viewvc

Re: r348471 - Add test for ObjC generics

On Thu, Dec 6, 2018 at 6:29 PM Stephen Kelly wrote: > > > On 06/12/2018 12:48, Aaron Ballman wrote: > > On Thu, Dec 6, 2018 at 4:26 AM Stephen Kelly via cfe-commits > > wrote: > >> Author: steveire > >> Date: Thu Dec 6 01:23:59 2018 > >> New Revision: 348471 > >> > >> URL: http://llvm.org/viewvc

[PATCH] D55393: Re-order content of template parameter dumps

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: test/AST/ast-dump-decl.cpp:330-331 // CHECK-NEXT: TemplateTypeParmDecl -// CHECK-NEXT: TemplateArgument type 'int' // CHECK-NE

[PATCH] D55417: [clangd] Change disk-backed storage to be atomic

kadircet updated this revision to Diff 177181. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55417/new/ https://reviews.llvm.org/D55417 Files: clangd/index/Ba

[PATCH] D55083: Re-arrange content in FunctionDecl dump

aaron.ballman added inline comments. Comment at: test/AST/ast-dump-decl.cpp:217 // CHECK-NEXT: ParmVarDecl +// CHECK-NEXT: TemplateArgument // CHECK-NEXT: CompoundStmt I find this ordering to be confusing, especially because the template argument i

r348589 - [unittests] Merge the PrintedStmtCXX..Matches functions (NFC)

Author: hamzasood Date: Fri Dec 7 04:55:01 2018 New Revision: 348589 URL: http://llvm.org/viewvc/llvm-project?rev=348589&view=rev Log: [unittests] Merge the PrintedStmtCXX..Matches functions (NFC) This was reviewed as part of https://reviews.llvm.org/D36527 Modified: cfe/trunk/unittests/AST

[PATCH] D55394: Re-order type param children of ObjC nodes

aaron.ballman added reviewers: ABataev, rsmith. aaron.ballman added a comment. I don't know enough about ObjC to feel comfortable saying whether this is a reasonable reordering or not, so adding some reviewers. Comment at: test/AST/ast-dump-decl.m:90 // CHECK-NEXT: -ObjCPro

[PATCH] D55393: Re-order content of template parameter dumps

steveire marked an inline comment as done. steveire added inline comments. Comment at: test/AST/ast-dump-decl.cpp:330-331 // CHECK-NEXT: TemplateTypeParmDecl -// CHECK-NEXT: TemplateArgument type 'int' // CHECK-NEXT: inherited from TemplateTypeParm 0x{{[^ ]*}} 'T' +//

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

JonasToth added a comment. Please upload the patch with full context. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

JonasToth added a comment. Please upload with full context. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55410/new/ https://reviews.llvm.org/D55410 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D55409: [clang-tidy] check for using declarations not in an anonymous namespace when there exists one

JonasToth added a comment. Please upload with full context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55409/new/ https://reviews.llvm.org/D55409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D55135: [CTU][Analyzer]Add DisplayCTUProgress analyzer switch

xazax.hun accepted this revision. xazax.hun added a comment. While Static Analyzer is the only client of CTU library at the moment, we might have more in the future. I would not use the phrase `ANALYZE` in the log message. Once this is resolved the rest looks good. Repository: rC Clang CHA

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

carwil created this revision. carwil added a project: clang. Herald added a subscriber: cfe-commits. Improve the description of these command line options by providing specific heuristic information, as outlined for the ssp function attribute(s) in LLVM's documentation. Repository: rC Clang

[PATCH] D55331: [CodeComplete] Fix assertion failure

This revision was automatically updated to reflect the committed changes. Closed by commit rL348590: [CodeComplete] Fix assertion failure (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55331?vs=176836&id=177187

r348590 - [CodeComplete] Fix assertion failure

Author: ibiryukov Date: Fri Dec 7 05:17:52 2018 New Revision: 348590 URL: http://llvm.org/viewvc/llvm-project?rev=348590&view=rev Log: [CodeComplete] Fix assertion failure Summary: ...that fires when running completion inside an argument of UnresolvedMemberExpr (see the added test). The asserti

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:202 std::lock_guard Lock(QueueMu); -Queue.push_back(std::move(T)); +if (Priority == ThreadPriority::Low) { + Queue.push_back(Bind( ilya-biryukov wrote: > kadircet wrote: > >

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

Szelethus updated this revision to Diff 177182. Szelethus retitled this revision from "[analyzer][WIP] Reimplement dependencies between checkers" to "[analyzer] Reimplement dependencies between checkers". Szelethus edited the summary of this revision. Szelethus added reviewers: MTC, baloghadamsoft

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet updated this revision to Diff 177188. kadircet marked 3 inline comments as done. kadircet added a comment. - Move priority change logic to runner - Change storage for tasks from deque to list, since we only pop from front but we might end up adding into middle. Repository: rCTE Clang

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

Szelethus updated this revision to Diff 177189. Szelethus added a comment. - Register the checker after it's dependencies (accidentally left this change in the next branch). This implies that `unix.MallocChecker:Optimistic` is no longer a thing, and is now called ųnix.DynamicMemoryModeling:Optim

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

Szelethus requested review of this revision. Szelethus added a comment. Please take a second look, this is a pretty important to get right. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54438/new/ https://reviews.llvm.org/D54438 ___ cfe-com

[PATCH] D55393: Re-order content of template parameter dumps

aaron.ballman added inline comments. Comment at: test/AST/ast-dump-decl.cpp:330-331 // CHECK-NEXT: TemplateTypeParmDecl -// CHECK-NEXT: TemplateArgument type 'int' // CHECK-NEXT: inherited from TemplateTypeParm 0x{{[^ ]*}} 'T' +// CHECK-NEXT: TemplateArgument type

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

Szelethus requested review of this revision. Szelethus added a comment. Marking this patch as non-accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51866/new/ https://reviews.llvm.org/D51866 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

Szelethus added a comment. The checker file changes in this patch are pretty boring, here are those that don't always return true in `shouldRegister`: - `CastSizeChecker` - `GTestChecker` - `NSAutoreleasePoolChecker` - `ObjCAtSyncChecker` Repository: rC Clang CHANGES SINCE LAST ACTION htt

[PATCH] D55191: [clangd] Refine the way of checking a declaration is referenced by the written code.

hokein updated this revision to Diff 177190. hokein marked 4 inline comments as done. hokein added a comment. Update based on our offline discussion. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55191/new/ https://reviews.llvm.org/D55191 Files:

[PATCH] D55191: [clangd] Refine the way of checking a declaration is referenced by the written code.

hokein added a comment. > What are the cases we're trying to filter out? Only implicit constructor or > anything else? I think implicit constructor is the only case we care about. We also looked through the caller implementation of `handleDeclOccurence`, it is safe to assume it. ===

[PATCH] D55429: [analyzer] Add CheckerManager::getChecker that asserts on non-registered checkers, assert on registering already registered checkers

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Title says it all, this is pretty important. Whil

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

lebedev.ri added a comment. Please linewrap to 80 col. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55428/new/ https://reviews.llvm.org/D55428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

ilya-biryukov added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:432 +def err_pp_including_mainfile_for_preamble : Error< + "main file cannot be included recursively for preamble">, DefaultFatal; def err_pp_empty_filename : Error<"empty filename">; ---

[PATCH] D55359: [clangd] Avoid emitting Queued status when we are able to acquire the Barrier.

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:644 + std::unique_lock Lock(Barrier, std::try_to_lock); + if (Lock.owns_lock()) { +ExecuteAction(); Maybe simplify the code a bit? ``` // Replacing these two lines: // emit

[PATCH] D55431: [CodeComplete] Set preferred type to bool on conditions

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Repository: rC Clang https://reviews.llvm.org/D55431 Files: lib/Sema/CodeCompleteConsumer.cpp lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/preferred-type.cpp Index: test/CodeCompletion/preferred-type.cp

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

steveire added a comment. Would it make sense to make this a generic non-abseil check? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55410/new/ https://reviews.llvm.org/D55410 ___ cfe-commits mailing li

[PATCH] D54672: clang-include-fixer.el: support remote files

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54672/new/ https://reviews.llvm.org/D54672 ___ cf

[PATCH] D55135: [CTU][Analyzer]Add DisplayCTUProgress analyzer switch

martong marked an inline comment as done. martong added a comment. > While Static Analyzer is the only client of CTU library at the moment, we > might have more in the future. I would not use the phrase ANALYZE in the log > message. Once this is resolved the rest looks good. Ok, I removed the "

[PATCH] D55135: [CTU][Analyzer]Add DisplayCTUProgress analyzer switch

martong updated this revision to Diff 177204. martong added a comment. - Remove 'ANALYZE ' prefix from the log message Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55135/new/ https://reviews.llvm.org/D55135 Files: include/clang/CrossTU/CrossTranslationUnit.h

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

lebedev.ri added inline comments. Comment at: clang-tidy/abseil/AliasFreeHeadersCheck.cpp:22 + // Match all using declarations in header files. + Finder->addMatcher(usingDecl(isExpansionInFileMatching(".*\\.h.*")).bind("x"), +this); Relevant: ``` $ clang-t

[PATCH] D55431: [CodeComplete] Set preferred type to bool on conditions

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55431/new/ https://reviews.llvm.org/D55431 ___ cfe-commit

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: alexfh, stephenkelly, curdeius, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Adds a checker to clang-tidy to warn when a non void const member function, taking only parameters passed by value or cons

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

lebedev.ri added a comment. Have you evaluated this on some major C++ projects yet? I suspect this will have pretty low SNR. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55433/new/ https://reviews.llvm.org/D55433

r348594 - [CTU] Add DisplayCTUProgress analyzer switch

Author: martong Date: Fri Dec 7 06:56:02 2018 New Revision: 348594 URL: http://llvm.org/viewvc/llvm-project?rev=348594&view=rev Log: [CTU] Add DisplayCTUProgress analyzer switch Summary: With a new switch we may be able to print to stderr if a new TU is being loaded during CTU. This is very imp

[PATCH] D55135: [CTU][Analyzer]Add DisplayCTUProgress analyzer switch

This revision was automatically updated to reflect the committed changes. Closed by commit rL348594: [CTU] Add DisplayCTUProgress analyzer switch (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55135?vs=177204&id=

r348595 - Revert "Multiversioning- Ensure all MV functions are emitted."

Author: erichkeane Date: Fri Dec 7 06:56:50 2018 New Revision: 348595 URL: http://llvm.org/viewvc/llvm-project?rev=348595&view=rev Log: Revert "Multiversioning- Ensure all MV functions are emitted." This reverts commit 65df29f9318ac13a633c0ce13b2b0bccf06e79ca. AS suggested by @rsmith here: http

r348596 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Fri Dec 7 06:57:07 2018 New Revision: 348596 URL: http://llvm.org/viewvc/llvm-project?rev=348596&view=rev Log: Adding tests for -ast-dump; NFC. This adds tests for various statements in C++ that are not covered by C. Modified: cfe/trunk/test/AST/ast-dump-stmt.cpp

[PATCH] D55395: Re-order content in OMPDeclareReductionDecl dump

ABataev added a comment. In D55395#1322431 , @rsmith wrote: > In D55395#1322244 , @ABataev wrote: > > > This is wrong, the original implementation is correct and should not be > > changed. > > > The original implem

[PATCH] D55415: Revert removal of tidy plugin support from libclang

bkramer added a comment. I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it be

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

Quuxplusone added inline comments. Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed due to requirement '1 == 2' "N is not 2!"}} T<1> t1; // expected-note {{in instantiation

r348598 - Fix spelling of WINDOWS in a test

Author: erichkeane Date: Fri Dec 7 07:06:43 2018 New Revision: 348598 URL: http://llvm.org/viewvc/llvm-project?rev=348598&view=rev Log: Fix spelling of WINDOWS in a test Change-Id: I232515655359f14308e1c5509c4b7db96d1fafcb Modified: cfe/trunk/test/CodeGen/attr-target-mv.c Modified: cfe/tru

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1323106 , @lebedev.ri wrote: > Have you evaluated this on some major C++ projects yet? > I suspect this may have pretty low SNR. Internally yes (on millions of lines), but you are correct high noise level, howe

[PATCH] D55415: Revert removal of tidy plugin support from libclang

yvvan added a comment. In D55415#1323120 , @bkramer wrote: > I'd be interested in hearing how this is used. I added this feature as an > experiment a while back but it simply didn't work as I envisioned it to. Some > checks do work but the overall latenc

r348599 - Add an explicit triple to this test to prevent failures due to size_t differences.

Author: aaronballman Date: Fri Dec 7 07:13:51 2018 New Revision: 348599 URL: http://llvm.org/viewvc/llvm-project?rev=348599&view=rev Log: Add an explicit triple to this test to prevent failures due to size_t differences. Modified: cfe/trunk/test/AST/ast-dump-stmt.cpp Modified: cfe/trunk/te

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. Hi @alexfh, I have attached the compilation database for `MPlayer-1.3.0`.F7659818: compile_commands.json As can be seen, the paths are relative. To answer your comments I need more time. I do not remember the exact details. I will pre

[PATCH] D55134: [CTU] Add triple/lang mismatch handling

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55134/new/ https://reviews.llvm.org/D55134 ___ cfe-commi

[PATCH] D55085: Avoid emitting redundant or unusable directories in DIFile metadata entries

davezarzycki added a comment. Hello @aprantl, This change broke the test suite when building in /tmp (tmpfs) on Linux: FAIL: Clang :: CodeGen/debug-info-abspath.c (5676 of 44360) - TEST 'Clang :: CodeGen/debug-info-abspath.c' FAILED Script: --- : 'RUN: at line 1'; /

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

aaron.ballman added inline comments. Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed due to requirement '1 == 2' "N is not 2!"}} T<1> t1; // expected-note {{in instantiatio

r348600 - Make CPUDispatch resolver emit dependent functions.

Author: erichkeane Date: Fri Dec 7 07:31:23 2018 New Revision: 348600 URL: http://llvm.org/viewvc/llvm-project?rev=348600&view=rev Log: Make CPUDispatch resolver emit dependent functions. Inline cpu_specific versions referenced before the cpu_dispatch function weren't properly emitted, since the

[PATCH] D55131: [CTU] Add more lit tests and better error handling

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55131/new/ https://reviews.llvm.org/D55131 ___ cfe-commi

[PATCH] D55437: [Index] Index declarations in lambda expression.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, ioeric. This fixes clangd couldn't find references for lambda parameters. Repository: rC Clang https://reviews.llvm.org/D55437 Files: lib/Index/IndexBody.cpp test/Index/cxx

[PATCH] D55359: [clangd] Avoid emitting Queued status when we are able to acquire the Barrier.

hokein updated this revision to Diff 177220. hokein marked 2 inline comments as done. hokein added a comment. Address review comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55359/new/ https://reviews.llvm.org/D55359 Files: clangd/TUSchedul

r348603 - [unittests] Add C++17 and C++2a support to the tooling tests

Author: hamzasood Date: Fri Dec 7 07:46:29 2018 New Revision: 348603 URL: http://llvm.org/viewvc/llvm-project?rev=348603&view=rev Log: [unittests] Add C++17 and C++2a support to the tooling tests Modified: cfe/trunk/unittests/Tooling/TestVisitor.h Modified: cfe/trunk/unittests/Tooling/TestV

[PATCH] D55438: Assert on conflicting fixes for -fix option

Ka-Ka created this revision. Herald added a subscriber: cfe-commits. Changed the assert and corresponding warning message for conflicting fixes to only trigger if clang-tidy is run with -fix or -fix-errors. The Fix and FixErrors variables are now passed as parameters when creating respective objec

[PATCH] D55359: [clangd] Avoid emitting Queued status when we are able to acquire the Barrier.

hokein added inline comments. Comment at: clangd/TUScheduler.cpp:644 + std::unique_lock Lock(Barrier, std::try_to_lock); + if (Lock.owns_lock()) { +ExecuteAction(); ilya-biryukov wrote: > Maybe simplify the code a bit? > ``` > // Replacing these

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood updated this revision to Diff 177221. hamzasood added a comment. - Committed the test framework changes separately as r348589 and r348603. - Correctly cleanup the lambda scope if an error in encountered while parsing the template parameters. - Replaced getExplicitTemplateParameterCount

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Herald added a subscriber: jkorous. 1. Just to make sure I understand; this patch has nothing to do with https://reviews.llvm.org/D48342, they are entirely orthogonal. Is this corre

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood marked 6 inline comments as done. hamzasood added inline comments. Comment at: lib/AST/DeclPrinter.cpp:107-108 -void printTemplateParameters(const TemplateParameterList *Params); +void printTemplateParameters(const TemplateParameterList *Params, +

r348605 - [CTU] Add more lit tests and better error handling

Author: martong Date: Fri Dec 7 08:05:58 2018 New Revision: 348605 URL: http://llvm.org/viewvc/llvm-project?rev=348605&view=rev Log: [CTU] Add more lit tests and better error handling Summary: Adding some more CTU list tests. E.g. to check if a construct is unsupported. We also slightly modify t

  1   2   3   >