[PATCH] D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧

This revision was automatically updated to reflect the committed changes. Closed by commit rL348331: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary… (authored by stephanemoore, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D54872: [clangd] Add ability to not use -resource-dir at all

malaperle added a comment. It doesn't seem like there is any difference in how -resource-dir and /imsvc are handled: they are all added as -internal-isystem In MSVCToolChain::AddClangSystemIncludeArgs (MSCV.cpp): if (!DriverArgs.hasArg(options::OPT_nobuiltininc)) { AddSystemIncludeWithSub

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall added a subscriber: akyrtzi. rjmccall added a comment. I have a lot of comments about various things that need to be fixed, but I just want to take a moment to say that this is a tremendously impressive patch: given only some very high-level directions, you've done a great job figuring

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Although this also fixes bugs with unaligned pointers that you might consider adding tests for. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/

[PATCH] D55289: [analyzer] MoveChecker Pt.5: Improve invalidation policies.

a_sidorin added a comment. Hi Artem, The change looks fine, just some nits. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:537 +const MemRegion *ThisRegion = nullptr; +if (const auto *IC = dyn_cast_or_null(Call)) + ThisRegion = IC->getCXXThisVal().getAsReg

Re: [cfe-dev] r347339 - [clang][Parse] Diagnose useless null statements / empty init-statements

On Wed, Dec 5, 2018 at 4:07 AM Artem Dergachev via cfe-commits wrote: > > > > On 12/4/18 5:04 PM, George Karpenkov via cfe-dev wrote: > > > >> On Dec 4, 2018, at 4:47 PM, Aaron Ballman wrote: > >> > >> On Tue, Dec 4, 2018 at 7:35 PM George Karpenkov > >> wrote: > >>> Hi Roman, Hi. > >>> I’m ag

[PATCH] D21508: Diagnose friend function template redefinitions

sepavloff updated this revision to Diff 176763. sepavloff added a comment. Updated patch The fix for https://bugs.llvm.org/show_bug.cgi?id=39742 put a test case, which is not a valid code. The error is detected with this patch, tests are updated accordingly. Repository: rC Clang CHANGES SINC

<    1   2   3