[PATCH] D54437: [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54437/new/ https://reviews.llvm.org/D54437 ___ cfe-commits mailing

[PATCH] D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈

stephanemoore added a comment. In D55101#1315294 , @benhamilton wrote: > > Would you be okay with landing this fix and if we get any further reports > > for Objective-C++ sources then we can suppress it in all C++/Objective-C++ > > sources? I think there

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

eugenis requested changes to this revision. eugenis added a comment. This revision now requires changes to proceed. Sorry for the delay. This is wrong, static linking is NOT supported. You could be confusing it with static linking of asan runtime library to an executable - that is and has always

[PATCH] D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list

vsk created this revision. vsk added reviewers: ributzka, steven_wu, calixte, marco-c. Make sure that symbols needed to implement runtime support for gcov are exported when using an export list on Darwin. Without the clang driver exporting these symbols, the linker hides them, resulting in tapi v

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

NoQ added a comment. Huh, gotcha :) The nomenclature is mostly correct, just feels weird. Super-region of a region is a larger region. Sub-region is a smaller region. Base region is the largest non-memspace superregion, so it's a //larger// region. Derived class object is a large object. Base

[PATCH] D55137: Honor -fdebug-prefix-map when creating function names for the debug info.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: test/CodeGenCXX/debug-prefix-map-lambda.cpp:7 + // CHECK: !DISubprogram(name: "b<(lambda at + // CHECK-SAME: /SOURCE_ROOT/debug-prefix-map-lambda.cpp + // CHECK-SAME: [[@LINE

r348060 - Honor -fdebug-prefix-map when creating function names for the debug info.

Author: adrian Date: Fri Nov 30 16:24:27 2018 New Revision: 348060 URL: http://llvm.org/viewvc/llvm-project?rev=348060&view=rev Log: Honor -fdebug-prefix-map when creating function names for the debug info. This adds a callback to PrintingPolicy to allow CGDebugInfo to remap file paths according

[PATCH] D55137: Honor -fdebug-prefix-map when creating function names for the debug info.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348060: Honor -fdebug-prefix-map when creating function names for the debug info. (authored by adrian, committed by ). Changed prior to commit: https://reviews.llvm.org/D55137?vs=176194&id=176225#toc R

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay. Wow. Cool. Thanks. I heard that previously there was an explicit desire to avoid doxygen comments in checkers because they're quite useless because the checker is usually all in one file and d

[PATCH] D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list

ributzka added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:1037 if (hasExportSymbolDirective(Args)) { -addExportedSymbol(CmdArgs, "___llvm_profile_filename"); -addExportedSymbol(CmdArgs, "___llvm_profile_raw_version"); -addExportedSymbol(Cmd

[PATCH] D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list

vsk marked an inline comment as done. vsk added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:1037 if (hasExportSymbolDirective(Args)) { -addExportedSymbol(CmdArgs, "___llvm_profile_filename"); -addExportedSymbol(CmdArgs, "___llvm_profile_raw_vers

[PATCH] D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list

ributzka accepted this revision. ributzka added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55151/new/ https://reviews.llvm.org/D55151 ___ cfe-commits mailing list cfe-commi

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, nice catch! It seems that the `ReportDoubleDelete()` thing was never used for reporting double-delete, but it was used for some strange check when a destructor is called. Is that old code e

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

Quuxplusone added a comment. Looks fine to me; please don't let //me// block this any further. :) Someone else, e.g. @aaron.ballman, should be the one to accept it, though. Comment at: include/clang/AST/NestedNameSpecifier.h:220 + void print(raw_ostream &OS, const PrintingPol

r348062 - Relax test to also work on Windows.

Author: adrian Date: Fri Nov 30 17:30:00 2018 New Revision: 348062 URL: http://llvm.org/viewvc/llvm-project?rev=348062&view=rev Log: Relax test to also work on Windows. Modified: cfe/trunk/test/CodeGenCXX/debug-prefix-map-lambda.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-prefix-map-lambda

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song added a comment. F7630900: clang-crash-x86-2.tar @scott.linder Actually clang can get source for remapped files. I just uploaded another test tarball which may help you debug the issue. The test script is changed as well since recent llvm/clang r

[PATCH] D55007: [Analyzer] Constraint Manager - Calculate Effective Range for Differences

NoQ added a comment. Is it an option to canonicalize the expression so that `B - A` was never stored in the first place? I.e., do this range intersection at the moment of writing the range, not at the moment of reading the range. This could be implemented by, say, comparing symbol IDs for `A` a

r348065 - [Basic] Move DiagnosticsEngine::dump from .h to .cpp

Author: maskray Date: Fri Nov 30 17:43:05 2018 New Revision: 348065 URL: http://llvm.org/viewvc/llvm-project?rev=348065&view=rev Log: [Basic] Move DiagnosticsEngine::dump from .h to .cpp The two LLVM_DUMP_METHOD methods have a undefined reference on clang::DiagnosticsEngine::DiagStateMap::dump.

[clang-tools-extra] r348066 - [clangd] Recommit the "AnyScope" changes in requests.json by rCTE347753 (reverted by rCTE347792)

Author: maskray Date: Fri Nov 30 17:57:15 2018 New Revision: 348066 URL: http://llvm.org/viewvc/llvm-project?rev=348066&view=rev Log: [clangd] Recommit the "AnyScope" changes in requests.json by rCTE347753 (reverted by rCTE347792) This fixes IndexBenchmark tests. Modified: clang-tools-extra

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

EricWF marked 2 inline comments as done. EricWF added a comment. @jyknight wrote: > And then use that to determine whether to add float128 to the union? Note that `max_align_t` isn't a union of these types, but a struct containing all of them. This seems like a bug to me, but it's what GNU hap

[PATCH] D55159: Lex: Fix bug in __BASE_FILE__ implementation.

pcc created this revision. pcc added a reviewer: rsmith. Herald added a subscriber: llvm-commits. __BASE_FILE__ previously expanded to "" instead of the name of the main source file in files included using -include. Also added test coverage for __BASE_FILE__ since there doesn't seem to be any.

<    1   2   3