[PATCH] D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD

2018-11-29 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. @rsmith this is on the non-determinism issue we discussed offline. Do you have any concerns with this approach? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54923/new/ https://reviews.llvm.org/D54923 ___ cfe-commits

r347953 - [analyzer] Fix the "Zombie Symbols" bug.

2018-11-29 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Nov 29 19:27:50 2018 New Revision: 347953 URL: http://llvm.org/viewvc/llvm-project?rev=347953&view=rev Log: [analyzer] Fix the "Zombie Symbols" bug. It's an old bug that consists in stale references to symbols remaining in the GDM if they disappear from other program s

[PATCH] D18860: [analyzer] Fix the "Zombie symbols" issue.

2018-11-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347953: [analyzer] Fix the "Zombie Symbols" bug. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18860/new/ https://reviews.llvm.org/

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

2018-11-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347954: [analyzer] Nullability: Don't detect post factum violation on concrete values. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

r347954 - [analyzer] Nullability: Don't detect post factum violation on concrete values.

2018-11-29 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Nov 29 19:39:58 2018 New Revision: 347954 URL: http://llvm.org/viewvc/llvm-project?rev=347954&view=rev Log: [analyzer] Nullability: Don't detect post factum violation on concrete values. The checker suppresses warnings on paths on which a nonnull value is assumed to be

[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

2018-11-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2383-2384 + if (RS == OldRS) +return; + Szelethus wrote: > Hmmm, I guess we return here because if `RegionState` is unchanged, so should > be `ReallocPairs` and `FreeRetu

r347955 - [analyzer] MallocChecker: Avoid redundant transitions.

2018-11-29 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Nov 29 19:52:42 2018 New Revision: 347955 URL: http://llvm.org/viewvc/llvm-project?rev=347955&view=rev Log: [analyzer] MallocChecker: Avoid redundant transitions. Don't generate a checker-tagged node unconditionally on the first checkDeadSymbols callback when no pointe

[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

2018-11-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347955: [analyzer] MallocChecker: Avoid redundant transitions. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D54013?vs=172629&id=176030#toc Repository: rC

[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

2018-11-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ marked an inline comment as done. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2383-2384 + if (RS == OldRS) +return; + NoQ wrote: > Szelethus wrote: > > Hmmm, I guess we return here because if `RegionState` is un

[PATCH] D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules

2018-11-29 Thread Andrew Gallagher via Phabricator via cfe-commits
andrewjcg marked 2 inline comments as done. andrewjcg added a comment. > I don't think we need to change the serialization format for this: a > serialized path beginning with / is already treated as absolute and any other > path is already treated as relative, so we don't need a flag to carry th

r347956 - Revert r344580 "[analyzer] Nullability: Don't detect post factum violation..."

2018-11-29 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Nov 29 20:26:17 2018 New Revision: 347956 URL: http://llvm.org/viewvc/llvm-project?rev=347956&view=rev Log: Revert r344580 "[analyzer] Nullability: Don't detect post factum violation..." Fails under ASan! Removed: cfe/trunk/test/Analysis/nullability-arc.mm Mod

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

2018-11-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ reopened this revision. NoQ added a comment. This revision is now accepted and ready to land. Reverted as rC347956 due to http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/26658 - will have a look tomorrow. Repository: rC Clang CHAN

<    1   2   3