[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan updated this revision to Diff 175635. yvvan added a comment. VFS is moved to llvm in 8.0, update the diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54995/new/ https://reviews.llvm.org/D54995 Files: include/llvm/Support/MemoryBuffer.h include/llvm/Support/VirtualFileSystem

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan created this revision. yvvan added reviewers: ilya-biryukov, Dmitry.Kozhevnikov. There are reported cases of non-system files being locked by libclang on Windows (and likely by other clients as well). I tried to solve that with https://reviews.llvm.org/D47460 but it might be not the only i

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

Hi Jan, This code doesn't compile with clang 3.6.0: ../tools/clang/tools/extra/clangd/Protocol.cpp:456:10: error: no viable conversion from 'json::Object' to 'llvm::json::Value' return result; ^~ ../include/llvm/Support/JSON.h:291:3: note: candidate constructor not viable: no k

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

On Wed, 28 Nov 2018 at 09:56, Mikael Holmén via cfe-commits wrote: > > Hi Jan, > > This code doesn't compile with clang 3.6.0: And broke ARM bots, logs available here: http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/5582/steps/build%20stage%201/logs/stdio Cheers, Yvan > ../too

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175638. courbet marked 5 inline comments as done. courbet edited the summary of this revision. courbet added a comment. Address Aaron's comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.o

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet marked an inline comment as done. courbet added a comment. Thanks for the comments. Comment at: lib/Sema/SemaTemplate.cpp:3070 +// and returns true. +static bool prettyPrintTypeTrait(const NestedNameSpecifier *const NNS, + llvm::raw_strin

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. I don't think isVolatile is the right default at the FileManager level, even on Windows. E.g. memory mapping is probably optimal for compiler, even though it definitely

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

martong added a subscriber: teemperor. martong added a comment. Hi @shafik , Thank you for your review. I have removed the call of `getPrimaryContext`. Fortunately, we already have one patch for the `getPrimaryContext` related changes, made by @teemperor : https://reviews.llvm.org/D54898 . I h

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

martong updated this revision to Diff 175639. martong marked an inline comment as done. martong added a comment. - Remove call of 'getPrimaryContext' Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53755/new/ https://reviews.llvm.org/D53755 Files: include/clang/

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan added a comment. @ilya-biryukov I have the reported evidence but didn't yet have time to investigate myself. This is probably caused by our upgrade to Clang-7 which shows that we can't rely on the aimed fixes like the one I mention (D47460 ). Another opti

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

balazske added a comment. It is really "ugly" thing to have a Import_New and a Import for the same functionality. Without these a single large patch would have been needed for clang and another smaller one for LLDB that must be committed "at the same time". Now 1 dependent patch is under review

Re: r345099 - [analyzer] Trust summaries for OSObject::retain and OSObject::release

Hi, On 11/27/18 12:23 AM, George Karpenkov wrote: > The error is indeed strange. > The body is declared as > >   LazyDeclStmtPtr Body; > > where > > using LazyDeclStmtPtr = >     LazyOffsetPtr; > > where > > template Offset)> > struct LazyOffsetPtr { >   mutable uint64_t Ptr = 0; > (…) >

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

Thanks for the notice and sorry for the delay! I somehow missed the failure mails before I went offline yesterday. I am just running tests on my fix now and hopefully pushing shortly. Since I didn’t know we are using old compilers for these builds I am now curious why. Is that intentional? For

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong marked 4 inline comments as done. martong added inline comments. Comment at: include/clang/AST/DeclContextInternals.h:125-129 + bool containsInVector(const NamedDecl *D) { +assert(getAsVector() && "Must have a vector at this point"); +DeclsTy &Vec = *getAsVector(

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong updated this revision to Diff 175641. martong marked 2 inline comments as done. martong added a comment. - Remove containsInVector Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53655/new/ https://reviews.llvm.org/D53655 Files: docs/LibASTMatchersRefere

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong added a comment. @aaron.ballman Thanks for your review. I have updated the patch to remove `containsInVector`. > This seems mostly reasonable to me, but @rsmith is more well-versed in this > area and may have further comments. You should give him a few days to chime > in before committ

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

On 11/28/18 11:09 AM, Jan Korous wrote: > Thanks for the notice and sorry for the delay! I somehow missed the > failure mails before I went offline yesterday. > > I am just running tests on my fix now and hopefully pushing shortly. > > Since I didn’t know we are using old compilers for these b

[PATCH] D54845: [clangd] Canonicalize file path in URIForFile.

ioeric added a comment. In D54845#1309589 , @sammccall wrote: > Mostly just places that should be updated HintPath -> TUPath. Changing the > whole codebase doesn't seem important, but in places that are touched... As chatted offline, `URIForFile` is clo

[clang-tools-extra] r347737 - [clangd] Bump vscode-clangd v0.0.7

Author: hokein Date: Wed Nov 28 02:23:15 2018 New Revision: 347737 URL: http://llvm.org/viewvc/llvm-project?rev=347737&view=rev Log: [clangd] Bump vscode-clangd v0.0.7 Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json Modified: clang-tools-extra/trunk/clangd/clients

[clang-tools-extra] r347738 - [clangd] Fix backward-compatibility - follow-up to textDocument/SymbolInfo

Author: jkorous Date: Wed Nov 28 02:24:07 2018 New Revision: 347738 URL: http://llvm.org/viewvc/llvm-project?rev=347738&view=rev Log: [clangd] Fix backward-compatibility - follow-up to textDocument/SymbolInfo Apparently clang 3.6 couldn't build the preceding patch. Modified: clang-tools-extr

[PATCH] D54952: [clangd] DO NOT SUBMIT. Draft interfaces for build system integration.

klimek added inline comments. Comment at: clangd/BuildSystem.h:29 +/// Default compilation database used by clangd, based on the build system. +class Integration : public GlobalCompilationDatabase { +public: 'Integration' is a bit of a weird name, as it doesn't t

Re: Dumping AST information to other formats

On 27/11/2018 09:49, Stephen Kelly via cfe-commits wrote: On 26/11/2018 19:20, Aaron Ballman via cfe-commits wrote: Once upon a time, there was -ast-print-xml. This -cc1 option was dropped because it was frequently out of sync with the AST data. It is right to ask: why would JSON, etc be any dif

[clang-tools-extra] r347739 - [clangd] Canonicalize file path in URIForFile.

Author: ioeric Date: Wed Nov 28 02:30:42 2018 New Revision: 347739 URL: http://llvm.org/viewvc/llvm-project?rev=347739&view=rev Log: [clangd] Canonicalize file path in URIForFile. Summary: File paths in URIForFile can come from index or local AST. Path from index goes through URI transformation a

[PATCH] D54845: [clangd] Canonicalize file path in URIForFile.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347739: [clangd] Canonicalize file path in URIForFile. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D54845?vs=175466&id=175642#toc Repository: rCTE Clang T

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

martong added a comment. > I didn't actually see this comment get addressed other than to say it won't > be a problem in practice, which I'm not certain I agree with. Was there a > reason why this got commit before finding out if the reviewer with the > concern agrees with your rationale? FWIW,

[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

hokein added a comment. Just made a new release v0.0.7, please try to use it (it works on my machine). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54781/new/ https://reviews.llvm.org/D54781 ___ cfe-commits mailing l

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael updated this revision to Diff 175646. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54862/new/ https://reviews.llvm.org/D54862 Files: lib/AST/DeclCXX.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CGExprCXX.cpp lib/Sema/SemaTyp

[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

martong updated this revision to Diff 175647. martong added a comment. - Use ExtInfo in structural equivalency Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53699/new/ https://reviews.llvm.org/D53699 Files: lib/AST/ASTStructuralEquivalence.cpp unittests/AST/

[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

martong added a comment. Hi @a_sidorin , I have updated the patch as you suggested, to check the equivalence based on `ASTContext::mergeFunctionTypes()`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53699/new/ https://reviews.llvm.org/D53699 ___

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske updated this revision to Diff 175649. balazske added a comment. Rebase to newest master. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53818/new/ https://reviews.llvm.org/D53818 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp Index:

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

On Wed, 28 Nov 2018 at 11:16, Mikael Holmén wrote: > > > > On 11/28/18 11:09 AM, Jan Korous wrote: > > Thanks for the notice and sorry for the delay! I somehow missed the > > failure mails before I went offline yesterday. > > > > I am just running tests on my fix now and hopefully pushing shortly.

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

On Wed, 28 Nov 2018 at 12:28, Yvan Roux wrote: > > On Wed, 28 Nov 2018 at 11:16, Mikael Holmén > wrote: > > > > > > > > On 11/28/18 11:09 AM, Jan Korous wrote: > > > Thanks for the notice and sorry for the delay! I somehow missed the > > > failure mails before I went offline yesterday. > > > > >

[PATCH] D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast

Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3972 + // we don't want to perform address space cast for it, since that + // leads to casting __private * (default addr space in OpenCL) to + // __global * which is not valid. Create m

[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

yvvan created this revision. yvvan added reviewers: nik, marcobubke. Herald added a subscriber: arphaman. Use the same logic as in TypePrinter::printTag to determine that the tag is anonymous and the separate check for namespaces. https://reviews.llvm.org/D54996 Files: test/Index/print-type.

Re: [PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

I’m afraid this is going to be too severe a performance regression if we change the default. So I don’t think this should be an LLVM-wide default On Wed, Nov 28, 2018 at 1:38 AM Ivan Donchevskii via Phabricator < revi...@reviews.llvm.org> wrote: > yvvan added a comment. > > @ilya-biryukov > > I ha

[PATCH] D54961: [AArch64] Add command-line option for SSBS

samparker accepted this revision. samparker added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54961/new/ https://reviews.llvm.org/D54961 ___ cfe-comm

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

thanks for the fix! TomW On Wed, 28 Nov 2018 at 11:33, Yvan Roux via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, 28 Nov 2018 at 12:28, Yvan Roux wrote: > > > > On Wed, 28 Nov 2018 at 11:16, Mikael Holmén > wrote: > > > > > > > > > > > > On 11/28/18 11:09 AM, Jan Korous wrote: >

[clang-tools-extra] r347745 - Fix a false-positive with cert-err58-cpp.

Author: aaronballman Date: Wed Nov 28 03:57:13 2018 New Revision: 347745 URL: http://llvm.org/viewvc/llvm-project?rev=347745&view=rev Log: Fix a false-positive with cert-err58-cpp. If a variable is declared constexpr then its initializer needs to be a constant expression, and thus, cannot throw.

[PATCH] D54998: [clangd] Build and test IndexBenchmark in check-clangd

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, mgorny. Include IndexBenchmark in check-clangd to make sure we won't forget to update it when doing breaking changes; also fix an out-of-date test input.

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

You are very welcome. Sorry for the trouble! Jan > On 28 Nov 2018, at 11:47, Tom Weaver via cfe-commits > wrote: > > thanks for the fix! > > TomW > > On Wed, 28 Nov 2018 at 11:33, Yvan Roux via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > On Wed, 28 Nov 2018 at 12:28, Yvan Rou

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, mgorny. This is the second part for introducing include hierarchy into index files produced by clangd. You can see the base patch that introduces st

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kristina commandeered this revision. kristina edited reviewers, added: return; removed: kristina. kristina added a comment. New revision in D54901 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53696/new/ https://reviews.llvm.org

[PATCH] D54901: [Haiku] Support __float128 for Haiku x86 and x86_64

kristina accepted this revision. kristina added a comment. This revision is now accepted and ready to land. LGTM. (Revision of D53696 ) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54901/new/ https://reviews.llvm.org/D54901 __

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

Anastasia updated this revision to Diff 175665. Anastasia added a comment. - Changing qualifiers while rebuilding types in TreeTransform is incorrect -> prevent deducing address space instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54858/new/ https://reviews.llvm.org/D54858 Fil

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:4241 + if (SemaRef.getLangOpts().OpenCL && T.getType()->isTemplateTypeParmType()) +Quals.removeAddressSpace(); + Anastasia wrote: > rjmccall wro

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

ilya-biryukov added a comment. In D54995#1311010 , @yvvan wrote: > @ilya-biryukov > > I have the reported evidence but didn't yet have time to investigate myself. > This is probably caused by our upgrade to Clang-7 which shows that we can't > rely on the

[PATCH] D54998: [clangd] Build and test IndexBenchmark in check-clangd

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54998/new/ https://reviews.llvm.org/D54998 __

[PATCH] D54901: [Haiku] Support __float128 for Haiku x86 and x86_64

kristina added a comment. Let me know if you need this committed. Comment at: lib/Basic/Targets/OSTargets.h:260 DefineStd(Builder, "unix", Opts); +if (this->HasFloat128) { + Builder.defineMacro("__FLOAT128__"); One tiny style-related nitpick, no n

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

aaron.ballman added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3076 +return false; + const RecordDecl * Record = NNS->getAsRecordDecl(); + // In namespace "::std". Formatting is incorrect here; you should run the patch through clang-format. Can

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175667. courbet added a comment. clang-formant patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Index: test/S

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175668. courbet marked 2 inline comments as done. courbet added a comment. harden against null getAsRecordDecl(). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/Sem

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3076 +return false; + const RecordDecl * Record = NNS->getAsRecordDecl(); + // In namespace "::std". aaron.ballman wrote: > Formatting is incorrect here; you should run the patch through c

[PATCH] D52879: Derive builtin return type from its definition

riccibruno added a comment. And moreover I believe this change is subtly incorrect for the following reason: The type that is passed into the constructor of the call expression is the type of the call expression, and not the return type. The difference between the return type and the type of the

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175669. courbet added a comment. fix variable name in comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Inde

LLVM Compiler Social, Towards Lean 4 -- An Optimized Object Model for an Interactive Theorem Prover (Wednesday 12th)

Dear all, WEDNESDAY 12th Dec, 19:00, we will have Sebastian Ullrich presenting on the Zurich LLVM Compiler Social: === Towards Lean 4: An Optimized Object Model for an Interactive Theorem Prover Lean 4, the next

r347752 - [ASTImporter] Changed use of Import to Import_New in ASTImporter.

Author: balazske Date: Wed Nov 28 05:21:26 2018 New Revision: 347752 URL: http://llvm.org/viewvc/llvm-project?rev=347752&view=rev Log: [ASTImporter] Changed use of Import to Import_New in ASTImporter. Reviewers: a.sidorin, shafik, a_sidorin Reviewed By: a_sidorin Subscribers: gamesh411, a_sidor

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347752: [ASTImporter] Changed use of Import to Import_New in ASTImporter. (authored by balazske, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

Quuxplusone added inline comments. Comment at: test/SemaCXX/static-assert.cpp:111 +static_assert(std::is_same::value, "message"); // expected-error{{static_assert failed due to requirement 'std::is_same::value' "message"}} +static_assert(std::is_const::value, "message");

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

ilya-biryukov added inline comments. Comment at: clangd/index/IndexAction.cpp:23 +// Collects the nodes and edges of include graph during indexing action. +struct IncludeGraphCollector : public PPCallbacks { +public: Could we add an assertion that the final graph

[clang-tools-extra] r347753 - [clangd] Build and test IndexBenchmark in check-clangd

Author: hokein Date: Wed Nov 28 05:31:05 2018 New Revision: 347753 URL: http://llvm.org/viewvc/llvm-project?rev=347753&view=rev Log: [clangd] Build and test IndexBenchmark in check-clangd Summary: Include IndexBenchmark in check-clangd to make sure we won't forget to update it when doing breaking

[PATCH] D54998: [clangd] Build and test IndexBenchmark in check-clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347753: [clangd] Build and test IndexBenchmark in check-clangd (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D54998?vs=175659&id=175672#toc Repository: rCTE

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet marked an inline comment as done. courbet added inline comments. Comment at: test/SemaCXX/static-assert.cpp:111 +static_assert(std::is_same::value, "message"); // expected-error{{static_assert failed due to requirement 'std::is_same::value' "message"}} +static_assert(st

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan added a comment. I've realized that this patch covers too much stuff outside of clang and I have no idea how bad is to not memory map it. "My hope is that we can get rid of this flag some day" - i'm not sure it's possible. For that we need some concept of user and system files in llvm si

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

Quuxplusone added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3061 +#define TYPE_TRAIT_N(Spelling, Name, Key) RecordName == (#Spelling + 2) || +#include "clang/Basic/TokenKinds.def" +#undef TYPE_TRAIT_1 Why do you bother to check a whitelist of "known"

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175673. courbet added a comment. Add unit test with dependent types. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cp

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan added a comment. Hm, probably FileManager can be that adapter since it's in clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54995/new/ https://reviews.llvm.org/D54995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[clang-tools-extra] r347754 - [clangd] Less penalty for cross-namespace completions.

Author: ioeric Date: Wed Nov 28 05:45:25 2018 New Revision: 347754 URL: http://llvm.org/viewvc/llvm-project?rev=347754&view=rev Log: [clangd] Less penalty for cross-namespace completions. Modified: clang-tools-extra/trunk/clangd/Quality.cpp Modified: clang-tools-extra/trunk/clangd/Quality.cp

[PATCH] D54952: [clangd] DO NOT SUBMIT. Draft interfaces for build system integration.

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. Thanks for taking a look and sorry for the confusion with naming. I should've renamed `Integration` before sending this patch. Comment at: clangd/BuildSystem.h:29 +/// Default compilation database u

[clang-tools-extra] r347755 - [clangd] Fix test broken in r347754.

Author: ioeric Date: Wed Nov 28 06:00:09 2018 New Revision: 347755 URL: http://llvm.org/viewvc/llvm-project?rev=347755&view=rev Log: [clangd] Fix test broken in r347754. Modified: clang-tools-extra/trunk/clangd/Quality.cpp Modified: clang-tools-extra/trunk/clangd/Quality.cpp URL: http://llv

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske updated this revision to Diff 175675. balazske added a comment. Herald added a reviewer: shafik. Herald added a subscriber: gamesh411. Rebase to master. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53757/new/ https://reviews.llvm.org/D53757 Files: li

r347756 - Re-commit r347417 "Re-Reinstate 347294 with a fix for the failures."

Author: hans Date: Wed Nov 28 06:04:12 2018 New Revision: 347756 URL: http://llvm.org/viewvc/llvm-project?rev=347756&view=rev Log: Re-commit r347417 "Re-Reinstate 347294 with a fix for the failures." This was reverted in r347656 due to me thinking it caused a miscompile of Chromium. Turns out it

[clang-tools-extra] r347757 - Re-commit r347419 "Update call to EvaluateAsInt() to the new syntax."

Author: hans Date: Wed Nov 28 06:04:26 2018 New Revision: 347757 URL: http://llvm.org/viewvc/llvm-project?rev=347757&view=rev Log: Re-commit r347419 "Update call to EvaluateAsInt() to the new syntax." Modified: clang-tools-extra/trunk/clang-tidy/bugprone/MisplacedWideningCastCheck.cpp cla

Re: r347417 - Re-Reinstate 347294 with a fix for the failures.

There's more details on http://crbug.com/908372, but my conclusion is that there wasn't anything wrong with your commit, it just triggered a bug in Chromium's code that had been hiding there for six years without anyone noticing. I've re-committed your change in r347756. Sorry for the hassle. On

[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

ilya-biryukov added a comment. In D54781#1311038 , @hokein wrote: > Just made a new release v0.0.7, please try to use it (it works on my machine). Many thanks! Works for me Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175679. courbet added a comment. Replace custom printing code with clang helper. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/stat

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

ilya-biryukov added a subscriber: zturner. ilya-biryukov added a comment. cross-posting @zturner's comment from the mailing thread for the record: > I’m afraid this is going to be too severe a performance regression if we > change the default. So I don’t think this should be an LLVM-wide default

[clang-tools-extra] r347760 - [clang-tidy] Added a test -export-fixes with relative paths.

Author: ibiryukov Date: Wed Nov 28 06:43:26 2018 New Revision: 347760 URL: http://llvm.org/viewvc/llvm-project?rev=347760&view=rev Log: [clang-tidy] Added a test -export-fixes with relative paths. Summary: A test for D51864. Reviewers: ioeric, steveire Reviewed By: steveire Subscribers: xazax.

[PATCH] D51865: [clang-tidy] Added a test -export-fixes with relative paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347760: [clang-tidy] Added a test -export-fixes with relative paths. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51865?vs=164688&id=175682#toc Repositor

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan added a comment. "could we figure out the exact cause of the issue?" I'm pretty sure we can. Currently the issue is mentioned in our bugreports (https://bugreports.qt.io/secure/attachment/78582/clang-locks.png) and i plan to reproduce it and track the exact issue. And this review was not

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet added inline comments. Comment at: clangd/index/IndexAction.cpp:45 +auto &Node = I->getValue(); +if (auto Digest = digestFile(SM, FileID)) + Node.Digest = std::move(*Digest); ilya-biryukov wrote: > What happens if we can't compute a digest f

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet updated this revision to Diff 175684. kadircet marked 11 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 Files: clangd/index/

[clang-tools-extra] r347761 - Fix false positive with lambda assignments in cert-err58-cpp.

Author: aaronballman Date: Wed Nov 28 07:04:38 2018 New Revision: 347761 URL: http://llvm.org/viewvc/llvm-project?rev=347761&view=rev Log: Fix false positive with lambda assignments in cert-err58-cpp. This check is about preventing exceptions from being thrown before main() executes, and assigni

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan added a comment. @ilya-biryukov According to https://stackoverflow.com/a/7414798 (if it's true) we can't prevent locks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54995/new/ https://reviews.llvm.org/D54995 ___ cfe-commits mailing

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar created this revision. grimar added reviewers: dblaikie, JonasToth. This is an updated version of the D54576 , which was reverted. Problem was that `SplitDebugName` calls the `InputInfo::getFilename` which asserts if `InputInfo` given is not of type `File

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar added a comment. With that the original issue mentioned in the following comment is fixed for me: https://reviews.llvm.org/rL347035#299232 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006 ___ c

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

dblaikie added a comment. Cool - thanks! Any chance/way to add a test for this that'd show up sooner than the breakage caused by the previous version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006 ___

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

JonasToth added a comment. Thank you for the fix! I will try this version as soon as I am at home (~2 hours from now) and report back if the issues I had are gone. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006 __

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar added a comment. In D55006#1311391 , @dblaikie wrote: > Cool - thanks! Any chance/way to add a test for this that'd show up sooner > than the breakage caused by the previous version? Maybe, I am not sure. I was not able to trigger this without us

Re: [PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

Do you all have Windows machines? The easiest thing to do is just write a sample program that mmaps a file and then tries to delete it, iterating over every possible set of flags. On Wed, Nov 28, 2018 at 7:25 AM Ivan Donchevskii via Phabricator < revi...@reviews.llvm.org> wrote: > yvvan added a co

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

ilya-biryukov added a comment. In D54995#1311303 , @yvvan wrote: > "could we figure out the exact cause of the issue?" > And this review was not meant to proceed immediately but rather state the > intention and get some feedback because I still don't kno

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

dblaikie added a comment. In D55006#1311398 , @grimar wrote: > In D55006#1311391 , @dblaikie wrote: > > > Cool - thanks! Any chance/way to add a test for this that'd show up sooner > > than the breakage caused by t

Re: [PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

I don't have a Windows machine, but I tried it on the VM and couldn't come up with a combination of flags that breaks it. Which is weird because the linked stackoverflow question mentions Windows locks all files on mmap, but that's not what I was seeing. I'll repeat the experiment. On Wed, Nov 2

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar added a comment. In D55006#1311400 , @dblaikie wrote: > In D55006#1311398 , @grimar wrote: > > > In D55006#1311391 , @dblaikie > > wrote: > > > > > Cool - thanks! Any

[PATCH] D55007: [Analyzer] Constraint Manager - Calculate Effective Range for Differences

baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: NoQ. baloghadamsoftware added a project: clang. Herald added subscribers: donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a reviewer: george.karpenkov. Since rL335814 , if

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan added a comment. @ilya-biryukov https://bugreports.qt.io/browse/QTCREATORBUG-15449 I was able to lock files last time with mmap. The Windows API calls are CreateFileMappingW (it's in the Path.inc, line 794) and MapViewOfFile (further down). As far as I remember the second call actually c

Re: [PATCH] D54998: [clangd] Build and test IndexBenchmark in check-clangd

Hiya Haojian, I've been looking over the build bots recently and believe r347753 may have caused the following test: clangd/index-tools.test to start failing. You can see the failing test in the logs of the following build bot: http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/20851/st

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

ilya-biryukov added inline comments. Comment at: clangd/index/IndexAction.cpp:45 +auto &Node = I->getValue(); +if (auto Digest = digestFile(SM, FileID)) + Node.Digest = std::move(*Digest); kadircet wrote: > ilya-biryukov wrote: > > What happens if we

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

zturner added a comment. In D54995#1311399 , @ilya-biryukov wrote: > In D54995#1311303 , @yvvan wrote: > > > "could we figure out the exact cause of the issue?" > > And this review was not meant to proceed immedia

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

bader added inline comments. Comment at: lib/Sema/TreeTransform.h:5276 +// Return type cann't be qualified with an address space. +if (ResultType.getAddressSpace() != LangAS::Default) { "cann't" - typo? cann't - > can't or cannot. Com

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

donat.nagy updated this revision to Diff 175697. donat.nagy marked 5 inline comments as done. donat.nagy added a comment. Minor simplifications, add tests for macro handling Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54757/new/ https://reviews.ll

  1   2   >