Re: r345099 - [analyzer] Trust summaries for OSObject::retain and OSObject::release

Hi again, Do you have any opinion about the below valgrind complaint that starts appearing with this patch? valgrind still complains on it on current trunk. I see it when compiling with clang 3.6.0. I've also tried gcc 5.4.0 but then I don't get it. Regards, Mikael On 11/21/18 8:33 AM, Mikae

[PATCH] D53754: [Analyzer] Skip symbolic regions based on conjured symbols in comparison of the containers of iterators

baloghadamsoftware added a comment. Herald added a subscriber: gamesh411. In D53754#1277253 , @Szelethus wrote: > I wonder whether a method in `MemRegion` called `isSameRegion` or > `isSurelySameRegion` would be better. I think it's likely that there are

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet updated this revision to Diff 175203. gchatelet marked 16 inline comments as done. gchatelet added a comment. - Addressing comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53488/new/ https://reviews.llvm.org/D53488 Files: clang-ti

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet added a comment. Thank you for bearing with me @aaron.ballman. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:259-263 +void NarrowingConversionsCheck::handleIntegralToBoolean( +const ASTContext &Context, SourceLocation SourceLoc, const Exp

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet updated this revision to Diff 175204. gchatelet added a comment. - Fixing documentation. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53488/new/ https://reviews.llvm.org/D53488 Files: clang-tidy/cppcoreguidelines/NarrowingConversionsC

[PATCH] D54865: [clangd] Auto-index watches global CDB for changes.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, seems to share a lot of context with what I am preparing for loading shards. Interfaces looks compatible with what I had before, only difference is it was more `tooling::CompileComma

[PATCH] D54745: [clang-tidy] Don't generate incorrect fixes for class with deleted copy/move constructor in smart_ptr check.

hokein updated this revision to Diff 175205. hokein marked 3 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54745/new/ https://reviews.llvm.org/D54745 Files: clang-tidy/mode

[clang-tools-extra] r347537 - [clang-tidy] Don't generate incorrect fixes for class with deleted copy constructor in smart_ptr check.

Author: hokein Date: Mon Nov 26 01:33:08 2018 New Revision: 347537 URL: http://llvm.org/viewvc/llvm-project?rev=347537&view=rev Log: [clang-tidy] Don't generate incorrect fixes for class with deleted copy constructor in smart_ptr check. Summary: The fix for aggregate initialization (`std::make_u

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

balazske updated this revision to Diff 175207. balazske added a comment. - Split long lines. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53751/new/ https://reviews.llvm.org/D53751 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp Index: lib/A

[PATCH] D54745: [clang-tidy] Don't generate incorrect fixes for class with deleted copy/move constructor in smart_ptr check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347537: [clang-tidy] Don't generate incorrect fixes for class with deleted copy… (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACT

[PATCH] D54865: [clangd] Auto-index watches global CDB for changes.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clangd/index/Background.cpp:130 + if (auto Cmd = CDB.getCompileCommand(File, &Project)) { +auto *Storage = IndexStorageFactory(Project.SourceRoot); +enqueueTask(Bind( ---

[PATCH] D54865: [clangd] Auto-index watches global CDB for changes.

sammccall updated this revision to Diff 175208. sammccall marked an inline comment as done. sammccall added a comment. If the CDB dir is unknown, don't try to write shards to disk. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54865/new/ https://rev

[PATCH] D54865: [clangd] Auto-index watches global CDB for changes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347538: [clangd] Auto-index watches global CDB for changes. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://revi

[clang-tools-extra] r347538 - [clangd] Auto-index watches global CDB for changes.

Author: sammccall Date: Mon Nov 26 01:51:50 2018 New Revision: 347538 URL: http://llvm.org/viewvc/llvm-project?rev=347538&view=rev Log: [clangd] Auto-index watches global CDB for changes. Summary: Instead of receiving compilation commands, auto-index is triggered by just filenames to reindex, and

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik updated this revision to Diff 175210. nik added a comment. > Maybe produce a **fatal** error in the preprocessor? That seems to be the > simplest option: the preprocessor is aware it's building the preamble and > there's definitely some logic to produce fatal errors in other cases (include

[clang-tools-extra] r347539 - [clangd] Cleanup after landing documentSymbol. NFC

Author: ibiryukov Date: Mon Nov 26 01:57:41 2018 New Revision: 347539 URL: http://llvm.org/viewvc/llvm-project?rev=347539&view=rev Log: [clangd] Cleanup after landing documentSymbol. NFC - fix compile error on older gcc in Protocol.cpp, - remove redundant 'llvm::' qualifiers from Protocol.cpp, -

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

balazske updated this revision to Diff 175212. balazske marked an inline comment as done. balazske added a comment. - Split long lines (ASTImporter.cpp). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53751/new/ https://reviews.llvm.org/D53751 Files: include/cl

[PATCH] D54832: [clang-tidy] No fixes for auto new expression in smart check

hokein updated this revision to Diff 175216. hokein marked 3 inline comments as done. hokein added a comment. No diagnose this case as well. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54832/new/ https://reviews.llvm.org/D54832 Files: clang-tid

[PATCH] D54832: [clang-tidy] No fixes for auto new expression in smart check

hokein added inline comments. Comment at: test/clang-tidy/modernize-make-unique.cpp:288 + // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use std::make_unique instead + // CHECK-FIXES: PE1.reset(new auto(E())); + aaron.ballman wrote: > It seems like we could also g

[PATCH] D54878: [clangd] NFC: Eliminate the unused variable warning.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. Ah, sorry, landed a cleanup fixing the warnings (rL347539 ) before seeing this change. But given that `isa<>` are still better than `dyn_cast<>`, this change might still be worth landing. R

[PATCH] D54253: [OpenCL] Launch opencl-types.cl test only on x86

asavonic added a comment. >> FWIW, I'd vote for the first revision of this patch. From my >> >> understanding, the test verifies that libclang is able to parse OpenCL >> code correctly. It doesn't do anything specific to x86: target for x86 just >> happens to support a set of OpenCL extensi

[clang-tools-extra] r347546 - [clang-tidy] PrintStackTraceOnErrorSignal

Author: alexfh Date: Mon Nov 26 03:11:52 2018 New Revision: 347546 URL: http://llvm.org/viewvc/llvm-project?rev=347546&view=rev Log: [clang-tidy] PrintStackTraceOnErrorSignal Modified: clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp Modified: clang-tools-extra/trunk/clang-tidy/tool

[PATCH] D52276: [clangd] Add type boosting in code completion

ilya-biryukov marked 4 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/Quality.h:98 + /// Whether the item matches the type expected in the completion context. + bool TypeMatchesPreferred = false; /// FIXME: unify with index proximity score -

[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

hokein added a comment. @malaperle, do you want a new release of `vscode-clangd` extension for this? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54781/new/ https://reviews.llvm.org/D54781 ___ cfe-commits mailing lis

[clang-tools-extra] r347547 - [clangd] Use testPath in the test.

Author: hokein Date: Mon Nov 26 03:18:16 2018 New Revision: 347547 URL: http://llvm.org/viewvc/llvm-project?rev=347547&view=rev Log: [clangd] Use testPath in the test. Modified: clang-tools-extra/trunk/unittests/clangd/FindSymbolsTests.cpp Modified: clang-tools-extra/trunk/unittests/clangd/F

[PATCH] D52276: [clangd] Add type boosting in code completion

ilya-biryukov updated this revision to Diff 175223. ilya-biryukov added a comment. - Address comments, add more flags to signals Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52276/new/ https://reviews.llvm.org/D52276 Files: clangd/CodeComplete.c

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D54796: [clangd] C++ API for emitting file status

jkorous added a comment. Hi @hokein, I am just keeping up to date with changes. Comment at: clangd/ClangdServer.h:39 +// FIXME: find a better name. class DiagnosticsConsumer { It would be unfortunate to have this name clashing with `clang::DiagnosticsConsum

[PATCH] D54796: [clangd] C++ API for emitting file status

ilya-biryukov added a comment. In D54796#1306960 , @hokein wrote: > There is one thing I'm not certain: should we stop emitting the file status > when the file is removed (similar to the behavior of diagnostics)? For > example, the file is removed while

Re: [clang-tools-extra] r347498 - [clangd] Add support for hierarchical documentSymbol

Sorry about that, should be fixed in r347539. On Mon, Nov 26, 2018 at 8:10 AM Mikael Holmén wrote: > Hi Ilya, > > This patch doesn't compile for me with clang 3.6.0. I get: > > ../tools/clang/tools/extra/clangd/Protocol.cpp:474:10: error: no viable > conversion from 'json::Object' to 'llvm::json

[PATCH] D54872: [clangd] Add ability to not use -resource-dir at all

ilya-biryukov added a comment. We have to point clangd into the resource dir, corresponding to the version of the headers it was built with. It's important we pick the exact version of the built-in headers that clangd was built for. Note that resource-dir should **only** be used for the built-in

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[clang-tools-extra] r347548 - [clangd] Tune down scope boost for global scope

Author: ioeric Date: Mon Nov 26 04:12:01 2018 New Revision: 347548 URL: http://llvm.org/viewvc/llvm-project?rev=347548&view=rev Log: [clangd] Tune down scope boost for global scope Summary: This improves cross-namespace completions and has ignorable impact on other completion types. Metrics ```

[PATCH] D54851: [clangd] Tune down scope boost for global scope

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347548: [clangd] Tune down scope boost for global scope (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D54851?vs=175106&id=175226#toc Repository: rCTE Clang

Re: [clang-tools-extra] r347498 - [clangd] Add support for hierarchical documentSymbol

On 11/26/18 12:41 PM, Ilya Biryukov wrote: > Sorry about that, should be fixed in r347539. > Yep, thanks! /Mikael > On Mon, Nov 26, 2018 at 8:10 AM Mikael Holmén > mailto:mikael.hol...@ericsson.com>> wrote: > > Hi Ilya, > > This patch doesn't compile for me with clang 3.6.0. I get:

[PATCH] D54832: [clang-tidy] No fixes for auto new expression in smart check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor typo to correct. Comment at: test/clang-tidy/modernize-make-unique.cpp:285 + // No warninags for `auto` new expression. + PE1.reset(new au

[PATCH] D54832: [clang-tidy] No fixes for auto new expression in smart check

hokein updated this revision to Diff 175227. hokein marked 2 inline comments as done. hokein added a comment. Fix a typo. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54832/new/ https://reviews.llvm.org/D54832 Files: clang-tidy/modernize/MakeSma

[PATCH] D54832: [clang-tidy] No fixes for auto new expression in smart check

hokein added a comment. Thanks for the quick review. Comment at: test/clang-tidy/modernize-make-unique.cpp:285 + // No warninags for `auto` new expression. + PE1.reset(new auto(E())); aaron.ballman wrote: > warninags -> warnings oops... Repository: rCTE

[clang-tools-extra] r347551 - [clang-tidy] No warning for auto new expression in smart check

Author: hokein Date: Mon Nov 26 04:42:08 2018 New Revision: 347551 URL: http://llvm.org/viewvc/llvm-project?rev=347551&view=rev Log: [clang-tidy] No warning for auto new expression in smart check Summary: The fix for `auto` new expression is illegal. Reviewers: aaron.ballman Subscribers: xazax.

[PATCH] D54832: [clang-tidy] No fixes for auto new expression in smart check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347551: [clang-tidy] No warning for auto new expression in smart check (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D54832?vs=175227&id=175228#toc Repository

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

aaron.ballman added a comment. I think we're almost there -- I had a few outstanding questions about the config options in the tests and making sure we cover all the cases. Comment at: test/clang-tidy/cppcoreguidelines-narrowing-conversions-castingliterals-option.cpp:3 +// RU

[PATCH] D54799: [clangd][WIP] textDocument/CursorInfo method

jkorous marked 8 inline comments as done. jkorous added a comment. Thank you very much for the review Sam! I am going to write proper unit tests and then just wait for Alex and Ben to take a look. Comment at: clangd/XRefs.cpp:785 +} +Results.emplace_back(std::move(New

[PATCH] D54799: [clangd][WIP] textDocument/CursorInfo method

jkorous updated this revision to Diff 175229. jkorous marked an inline comment as done. jkorous added a comment. Addressed comments from the reivew. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 Files: clangd/CMakeLists.txt clangd/ClangdLS

[PATCH] D54799: [clangd][WIP] textDocument/CursorInfo method

jkorous updated this revision to Diff 175230. jkorous added a comment. Removed empty line noise and fixed doxygen annotation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/Cl

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet updated this revision to Diff 175231. gchatelet marked 4 inline comments as done. gchatelet added a comment. - Removed redundant options in regression tests Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53488/new/ https://reviews.llvm.org/

[PATCH] D54799: [clangd][WIP] textDocument/SymbolInfo method

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG from my side. If you have unit tests in the next couple of days, happy to take a look, otherwise go ahead once Alex/Ben are happy. (I'm at work today/tomorrow and then I'm going to be

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53488/new/ https://reviews.llvm.org/D53488 ___ cfe-commits mailing list cfe-commi

[PATCH] D54878: [clangd] NFC: Eliminate the unused variable warning.

MTC updated this revision to Diff 175232. MTC added a comment. Use more concise form. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54878/new/ https://reviews.llvm.org/D54878 Files: clangd/AST.cpp Index: clangd/AST.cpp =

[clang-tools-extra] r347554 - [clangd] Fix missing include from r347538 - fix windows buildbots

Author: sammccall Date: Mon Nov 26 05:35:02 2018 New Revision: 347554 URL: http://llvm.org/viewvc/llvm-project?rev=347554&view=rev Log: [clangd] Fix missing include from r347538 - fix windows buildbots Modified: clang-tools-extra/trunk/clangd/index/Background.cpp Modified: clang-tools-extra/

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen added a comment. Just to double check before committing, @aaron.ballman are you happy with the tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54425/new/ https://reviews.llvm.org/D54425 ___ cfe-commits mailing list cfe-commi

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet added a comment. In D53488#1307834 , @aaron.ballman wrote: > LGTM! Thx ! \O/ Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53488/new/ https://reviews.llvm.org/D53488 _

[PATCH] D54878: [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking.

MTC added a comment. In D54878#1307726 , @ilya-biryukov wrote: > But given that `isa<>` are still better than `dyn_cast<>`, this change might > still be worth landing. We can land this change this time or do the cleaning job in other patches in the fu

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

aaron.ballman added a comment. In D54425#1307838 , @sdesmalen wrote: > Just to double check before committing, @aaron.ballman are you happy with the > tests? The tests LGTM, but there are still some unresolved comments from @rjmccall that should be han

[PATCH] D54300: [clangd] Respect shouldIndexFile when collecting symbols.

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.cpp:386 const Symbol *BasicSymbol = Symbols.find(*ID); - if (!BasicSymbol) // Regardless of role, ND is the canonical declaration. -BasicSymbol = addDeclaration(*ND, std::move(*ID)); - else if (isPref

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Ownership and configuration: The auto-index (background index) is maintained by ClangdServer, like Dynamic. (This means ClangdServer wil

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen updated this revision to Diff 175236. sdesmalen added a comment. - resolved editorial comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54425/new/ https://reviews.llvm.org/D54425 Files: include/clang-c/Index.h include/clang/Basic/Attr.td include/clang/Basic/AttrDo

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

erichkeane added a comment. This looks right to me. Note the PTH removal is still waiting approval. Comment at: include/clang/Basic/IdentifierTable.h:119 + IdentifierInfo() + : TokenID(tok::identifier), ObjCOrBuiltinID(0), HasMacro(false), Instead of p

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/Basic/IdentifierTable.h:119 + IdentifierInfo() + : TokenID(tok::identifier), ObjCOrBuiltinID(0), HasMacro(false), erichkeane wrote: > Instead of putti

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

ioeric added a comment. lgtm (will let @kadircet stamp ) Comment at: test/clangd/background-index.test:19 +# Test the index is read from disk: delete code and restart clangd. +# This test currently fails as we don't read the index yet. +# RUN: rm %t/foo.cpp May

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

erichkeane added inline comments. Comment at: include/clang/Basic/IdentifierTable.h:119 + IdentifierInfo() + : TokenID(tok::identifier), ObjCOrBuiltinID(0), HasMacro(false), riccibruno wrote: > erichkeane wrote: > > Instead of putting these in an initiali

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/Basic/IdentifierTable.h:119 + IdentifierInfo() + : TokenID(tok::identifier), ObjCOrBuiltinID(0), HasMacro(false), erichkeane wrote: > riccibruno wrote

r347555 - Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror

Author: sylvestre Date: Mon Nov 26 06:29:48 2018 New Revision: 347555 URL: http://llvm.org/viewvc/llvm-project?rev=347555&view=rev Log: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror Summary: Patch by Arnaud

[PATCH] D53697: [ASTImporter][Structural Eq] Check for isBeingDefined

martong updated this revision to Diff 175241. martong added a comment. - Get data of CXXRecordDecl only if set Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53697/new/ https://reviews.llvm.org/D53697 Files: lib/AST/ASTImporter.cpp lib/AST/ASTStructuralEquiva

[PATCH] D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror

This revision was automatically updated to reflect the committed changes. Closed by commit rC347555: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ct… (authored by sylvestre, committed by ). Changed prior to commit: https://reviews.llvm.org/D53807?vs=171502&id=17

[PATCH] D53697: [ASTImporter][Structural Eq] Check for isBeingDefined

martong added a comment. I have reproduced the issue on MacOS, fixed it and updated the patch accordingly. Soon I will commit and will monitor if any build bots are being broken. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53697/new/ https://reviews.llvm.org/D

[PATCH] D54878: [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking.

ilya-biryukov added a comment. In D54878#1307845 , @MTC wrote: > We can land this change this time or do the cleaning job in other patches in > the future, it's all up to you guys, the active clangd contributors :). Please land this, it's a useful clean

[PATCH] D52274: [clangd] Collect and store expected types in the index

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Index.h:283 + /// Type of the symbol, used for scoring purposes. + llvm::StringRef Type; either call this OpaqueType o

r347556 - [PowerPC] Vector load/store builtins overstate alignment of pointers

Author: nemanjai Date: Mon Nov 26 06:35:38 2018 New Revision: 347556 URL: http://llvm.org/viewvc/llvm-project?rev=347556&view=rev Log: [PowerPC] Vector load/store builtins overstate alignment of pointers A number of builtins in altivec.h load/store vectors from pointers to scalar types. Currently

[PATCH] D54787: [PowerPC] Vector load/store builtins overstate alignment of pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rL347556: [PowerPC] Vector load/store builtins overstate alignment of pointers (authored by nemanjai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D54547: PTH-- Remove feature entirely-

erichkeane marked 2 inline comments as done. erichkeane added inline comments. Comment at: include/clang/Lex/Preprocessor.h:396 + /// This is an alias for CurLexer. PreprocessorLexer *CurPPLexer = nullptr; riccibruno wrote: > Would it make sense to remove t

[PATCH] D52276: [clangd] Add type boosting in code completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. You may want to add a FIXME in SymbolIndex to include opaque type in fuzzyfind request. Comment at: clangd/CodeComplete.cpp:1504 +if (PreferredType) + Relevan

[PATCH] D54547: PTH-- Remove feature entirely-

riccibruno added inline comments. Comment at: include/clang/Lex/Preprocessor.h:396 + /// This is an alias for CurLexer. PreprocessorLexer *CurPPLexer = nullptr; erichkeane wrote: > riccibruno wrote: > > Would it make sense to remove this alias now that it >

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Sorry for the bugs, thanks for the fixes :D Comment at: clangd/ClangdServer.cpp:515 +if (BackgroundIdx) + BackgroundIdx->blockUntilIdleForTest(); +return tru

[PATCH] D52274: [clangd] Collect and store expected types in the index

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/index/Index.h:283 + /// Type of the symbol, used for scoring purposes. + llvm::StringRef Type; sammccall wrote: > either call this OpaqueType or point at i

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

kadircet added inline comments. Comment at: test/clangd/background-index.test:16 +# Test that the index is writing files in the expected location. +# RUN: ls %t/.clangd-index/foo.cpp.*.idx + kadircet wrote: > and this also I suppose we might wanna delete this fil

[PATCH] D52274: [clangd] Collect and store expected types in the index

ilya-biryukov updated this revision to Diff 175246. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Bump the RIFF version number - Place the Type field after the ReturnType - Address other comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

kadircet added inline comments. Comment at: test/clangd/background-index.test:13 +# The background index should allow us to go-to-definition on foo(). +# RUN: clangd -background-index -lit-test < %t/definition.jsonrpc | FileCheck %t/definition.jsonrpc + kadircet

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

sammccall updated this revision to Diff 175249. sammccall marked an inline comment as done. sammccall added a comment. Make blockUntilIdleForTest() accept a timeout, update comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54894/new/ https://re

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Bump! Thanks again for your consideration CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

ilya-biryukov abandoned this revision. ilya-biryukov added a comment. Herald added subscribers: kadircet, arphaman. This landed as a different change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45478/new/ https://reviews.llvm.org/D45478 __

r347558 - [Index] Expose USR generation for types

Author: ibiryukov Date: Mon Nov 26 07:24:48 2018 New Revision: 347558 URL: http://llvm.org/viewvc/llvm-project?rev=347558&view=rev Log: [Index] Expose USR generation for types Summary: Used in clangd. Reviewers: sammccall, ioeric Reviewed By: sammccall Subscribers: kadircet, cfe-commits Diffe

[PATCH] D52275: [Index] Expose USR generation for types

This revision was automatically updated to reflect the committed changes. Closed by commit rC347558: [Index] Expose USR generation for types (authored by ibiryukov, committed by ). Herald added a subscriber: arphaman. Changed prior to commit: https://reviews.llvm.org/D52275?vs=166167&id=175252#

[clang-tools-extra] r347559 - [clangd] Initial implementation of expected types

Author: ibiryukov Date: Mon Nov 26 07:25:20 2018 New Revision: 347559 URL: http://llvm.org/viewvc/llvm-project?rev=347559&view=rev Log: [clangd] Initial implementation of expected types Summary: Provides facilities to model the C++ conversion rules without the AST. The introduced representation c

[PATCH] D52273: [clangd] Initial implementation of expected types

This revision was automatically updated to reflect the committed changes. Closed by commit rL347559: [clangd] Initial implementation of expected types (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://review

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

teemperor created this revision. teemperor added reviewers: martong, a.sidorin. teemperor added a project: LLDB. Herald added subscribers: cfe-commits, rnkovacs. `MustBuildLookupTable` must always be called on a primary context as we otherwise trigger an assert, but we don't ensure that this will

[PATCH] D52274: [clangd] Collect and store expected types in the index

ilya-biryukov updated this revision to Diff 175254. ilya-biryukov added a comment. - Remove unused #include Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52274/new/ https://reviews.llvm.org/D52274 Files: clangd/index/Index.h clangd/index/Serial

[clang-tools-extra] r347560 - [clangd] Collect and store expected types in the index

Author: ibiryukov Date: Mon Nov 26 07:29:14 2018 New Revision: 347560 URL: http://llvm.org/viewvc/llvm-project?rev=347560&view=rev Log: [clangd] Collect and store expected types in the index Summary: And add a hidden option to control whether the types are collected. For experiments, will be remo

[PATCH] D52274: [clangd] Collect and store expected types in the index

This revision was automatically updated to reflect the committed changes. Closed by commit rL347560: [clangd] Collect and store expected types in the index (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[PATCH] D52276: [clangd] Add type boosting in code completion

ilya-biryukov updated this revision to Diff 175257. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52276/new/ https://reviews.llvm.org/D52276 Files:

[PATCH] D54900: [Sema] Avoid CallExpr::setNumArgs in Sema::BuildCallToObjectOfClassType

riccibruno created this revision. riccibruno added reviewers: rsmith, aaron.ballman. riccibruno added a project: clang. Herald added subscribers: cfe-commits, dexonsmith, inglorion, mehdi_amini. `CallExpr::setNumArgs` is the only thing that prevents storing the arguments of a call expression in a

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: test/clangd/background-index.test:16 +# Test that the index is writing files in the expected location. +# RUN: ls %t/.clangd-index/foo.cpp.*.idx + kadircet wrote: > kadircet

[PATCH] D52276: [clangd] Add type boosting in code completion

ilya-biryukov updated this revision to Diff 175258. ilya-biryukov added a comment. - Add a FIXME to FuzzyFindRequest Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52276/new/ https://reviews.llvm.org/D52276 Files: clangd/CodeComplete.cpp clangd/

[clang-tools-extra] r347562 - [clangd] Add type boosting in code completion

Author: ibiryukov Date: Mon Nov 26 07:38:01 2018 New Revision: 347562 URL: http://llvm.org/viewvc/llvm-project?rev=347562&view=rev Log: [clangd] Add type boosting in code completion Reviewers: sammccall, ioeric Reviewed By: sammccall Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commit

[PATCH] D52276: [clangd] Add type boosting in code completion

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347562: [clangd] Add type boosting in code completion (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D52276?vs=175258&id=175260#toc Repository: rCTE Clang

[clang-tools-extra] r347563 - [clangd] Fix use-after-free with expected types in indexing

Author: ibiryukov Date: Mon Nov 26 07:52:16 2018 New Revision: 347563 URL: http://llvm.org/viewvc/llvm-project?rev=347563&view=rev Log: [clangd] Fix use-after-free with expected types in indexing Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified: clang-tools-extra/t

r347564 - [ASTImporter][Structural Eq] Check for isBeingDefined

Author: martong Date: Mon Nov 26 07:54:08 2018 New Revision: 347564 URL: http://llvm.org/viewvc/llvm-project?rev=347564&view=rev Log: [ASTImporter][Structural Eq] Check for isBeingDefined Summary: If one definition is currently being defined, we do not compare for equality and we assume that the

[PATCH] D53697: [ASTImporter][Structural Eq] Check for isBeingDefined

This revision was automatically updated to reflect the committed changes. Closed by commit rL347564: [ASTImporter][Structural Eq] Check for isBeingDefined (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://revi

[clang-tools-extra] r347566 - [clangd] Fix compilation of IndexBenchmark

Author: ibiryukov Date: Mon Nov 26 07:58:29 2018 New Revision: 347566 URL: http://llvm.org/viewvc/llvm-project?rev=347566&view=rev Log: [clangd] Fix compilation of IndexBenchmark Modified: clang-tools-extra/trunk/clangd/benchmarks/IndexBenchmark.cpp Modified: clang-tools-extra/trunk/clangd/b

[PATCH] D54901: [Haiku] Support __float128 for Haiku x86 and x86_64

kallisti5 created this revision. kallisti5 added reviewers: chandlerc, joerg, compnerd, kristina, js. kallisti5 added a project: clang. Herald added a subscriber: cfe-commits. A revision on https://reviews.llvm.org/D53696 from another user. Repository: rC Clang https://reviews.llvm.org/D54901

[clang-tools-extra] r347567 - [clangd] Enable auto-index behind a flag.

Author: sammccall Date: Mon Nov 26 08:00:11 2018 New Revision: 347567 URL: http://llvm.org/viewvc/llvm-project?rev=347567&view=rev Log: [clangd] Enable auto-index behind a flag. Summary: Ownership and configuration: The auto-index (background index) is maintained by ClangdServer, like Dynamic. (T

  1   2   >