[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. I'll re-review when I'm up, from a quick glance it looks much better but I'll have to patch it over my fork and try out a few things (Mostly x86_64 Linux and Darwin test suites). I think the test is lacking a bit, there's a lot of stuff that isn't covered, and there's

r347152 - cmake: z3: Remove EXACT from 4.7.1 after being compatible with 4.8.1

Author: jankratochvil Date: Sun Nov 18 01:36:36 2018 New Revision: 347152 URL: http://llvm.org/viewvc/llvm-project?rev=347152&view=rev Log: cmake: z3: Remove EXACT from 4.7.1 after being compatible with 4.8.1 After check-in of D54391 a comment there by @mikhail.ramalho says: Since we're supportin

[PATCH] D54535: cmake: z3: Remove EXACT from 4.7.1 after being compatible with 4.8.1

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC347152: cmake: z3: Remove EXACT from 4.7.1 after being compatible with 4.8.1 (authored by jankratochvil, committed by ).

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

void added a comment. Ping? I really don't want this review to go on forever. Repository: rC Clang https://reviews.llvm.org/D54355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

void updated this revision to Diff 174529. void added a comment. Don't re-wrap a ConstExpr. Repository: rC Clang https://reviews.llvm.org/D54355 Files: include/clang/AST/Expr.h lib/AST/ASTImporter.cpp lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGBuiltin.cpp lib/Sema/Se

[PATCH] D51531: [analyzer][UninitializedObjectChecker] Uninit regions are only reported once

This revision was automatically updated to reflect the committed changes. Closed by commit rC347153: [analyzer][UninitializedObjectChecker] Uninit regions are only reported once (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D51531?vs=163542&id=174530#

r347153 - [analyzer][UninitializedObjectChecker] Uninit regions are only reported once

Author: szelethus Date: Sun Nov 18 03:34:10 2018 New Revision: 347153 URL: http://llvm.org/viewvc/llvm-project?rev=347153&view=rev Log: [analyzer][UninitializedObjectChecker] Uninit regions are only reported once Especially with pointees, a lot of meaningless reports came from uninitialized regio

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

Szelethus abandoned this revision. Szelethus added a comment. Herald added subscribers: gamesh411, baloghadamsoftware. In https://reviews.llvm.org/D53069#1274554, @george.karpenkov wrote: > If we want to be serious about this page, it really has to be auto-generated > (like clang-tidy one), but

[PATCH] D54641: [compiler-rt] [cmake] Fix detecting terminfo library

mgorny updated this revision to Diff 174534. mgorny edited the summary of this revision. mgorny added a comment. Updated for check order change in master. https://reviews.llvm.org/D54641 Files: cmake/config-ix.cmake Index: cmake/config-ix.cmake ==

[PATCH] D54397: [analyzer][NFC] Move CheckerOptInfo to CheckerRegistry.cpp, and make it local

This revision was automatically updated to reflect the committed changes. Closed by commit rL347157: [analyzer][NFC] Move CheckerOptInfo to CheckerRegistry.cpp, and make it local (authored by Szelethus, committed by ). Herald added subscribers: llvm-commits, gamesh411, baloghadamsoftware. Changed

r347157 - [analyzer][NFC] Move CheckerOptInfo to CheckerRegistry.cpp, and make it local

Author: szelethus Date: Sun Nov 18 04:47:03 2018 New Revision: 347157 URL: http://llvm.org/viewvc/llvm-project?rev=347157&view=rev Log: [analyzer][NFC] Move CheckerOptInfo to CheckerRegistry.cpp, and make it local CheckerOptInfo feels very much out of place in CheckerRegistration.cpp, so I moved

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul updated this revision to Diff 174536. sthibaul added a comment. I have added a few checks (the ld.so dynamic linker specification, the ../lib32 paths, and /usr/lib/i386-gnu) About negative tests, what kind of invalid input are you thinking about? Repository: rC Clang https://revie

[PATCH] D54675: [AST] Store the expressions in ParenListExpr in a trailing array

riccibruno created this revision. riccibruno added a reviewer: rjmccall. riccibruno added a project: clang. Herald added a reviewer: shafik. Herald added a subscriber: cfe-commits. Use the newly available space in the bit-fields of `Stmt` and store the expressions in a trailing array. This saves

[PATCH] D54676: [AST] Pack CallExpr

riccibruno created this revision. riccibruno added a reviewer: rjmccall. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Use the newly available space in the bit-fields of `Stmt` to store some data from `CallExpr`. This saves 8 bytes per `CallExpr`. This is a straightfo

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

aaron.ballman added a comment. It looks like you removed a considerable amount of testing coverage; why? Comment at: lib/Sema/SemaChecking.cpp:10920-10921 +if (E->EvaluateAsInt(IntValue, S.Context, Expr::SE_AllowSideEffects)) { + if (S.SourceMgr.isInSystemMacro(CC)) +

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

hfinkel added a comment. In https://reviews.llvm.org/D53157#1302159, @cameron.mcinally wrote: > In https://reviews.llvm.org/D53157#1301992, @hfinkel wrote: > > > > Just because FENV_ACCESS can be toggled on that granularity doesn't mean > > > we have to represent it that way. We've previously ag

[PATCH] D54404: Exclude matchers which can have multiple results

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:624 + "hasAnyDeclaration", + "hasAnyName", + "hasAnyParameter", sbenza wrote: > I'm not sure what goes in this list. > `hasAnyName` is here but not `hasName`. > What i

[clang-tools-extra] r347163 - Add the abseil-duration-factory-scale check.

Author: aaronballman Date: Sun Nov 18 08:41:06 2018 New Revision: 347163 URL: http://llvm.org/viewvc/llvm-project?rev=347163&view=rev Log: Add the abseil-duration-factory-scale check. This check removes unneeded scaling of arguments when calling Abseil Time factory functions. Patch by Hyrum Wri

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r347163. Thank you for the patch! https://reviews.llvm.org/D54246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

xbolva00 added a comment. I removed _Float16 related tests since some bots may fall with it, i dont know much about this custom type. Anyway, It is fine on linux x86 64. I will restore them. System macro - I will fix it. https://reviews.llvm.org/D52835 _

[PATCH] D54404: Exclude matchers which can have multiple results

aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:624 + "hasAnyDeclaration", + "hasAnyName", + "hasAnyParameter", steveire wrote: > sbenza wrote: > > I'm not sure what goes in this list. > > `hasAnyName` is here

r347178 - Replace the UTF-8 characters in the error message.

Author: brad Date: Sun Nov 18 14:30:58 2018 New Revision: 347178 URL: http://llvm.org/viewvc/llvm-project?rev=347178&view=rev Log: Replace the UTF-8 characters in the error message. Modified: cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td cfe/trunk/test/Driver/mips-abicalls-error.

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

a_sidorin updated this revision to Diff 174545. a_sidorin added a comment. Hi @davide and @shafik, Could you please check the updated version of the patch? Repository: rC Clang https://reviews.llvm.org/D44100 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unitte

[PATCH] D54675: [AST] Store the expressions in ParenListExpr in a trailing array

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D54675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

r347179 - [PowerPC] Set the default PLT mode on OpenBSD/powerpc to Secure PLT.

Author: brad Date: Sun Nov 18 16:21:06 2018 New Revision: 347179 URL: http://llvm.org/viewvc/llvm-project?rev=347179&view=rev Log: [PowerPC] Set the default PLT mode on OpenBSD/powerpc to Secure PLT. OpenBSD/powerpc only supports Secure PLT. Modified: cfe/trunk/lib/Driver/ToolChains/Arch/PPC

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

davide added a comment. Alexsei, I'm afraid I'm not qualified to review this patch. I would really recommend you to find somebody who's familiar with clang to review it, as it already seems to have broken lldb in the past. Repository: rC Clang https://reviews.llvm.org/D44100

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

void updated this revision to Diff 174551. void added a comment. No function pointers Repository: rC Clang https://reviews.llvm.org/D54355 Files: include/clang/AST/Expr.h lib/AST/ASTImporter.cpp lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaDecl

[PATCH] D54681: [Driver] Avoid including -lm on the link line with -nostdlib++

phosek created this revision. Herald added a subscriber: cfe-commits. Drivers include -lm because standard C++ libraries such as libc++ and libstdc++ depend on libmath and when statically linking C++ library, this dependency is needed. However, when -nostdlib++ is used, there's no reason to includ

[PATCH] D53231: [Sema] Fix PR38987: keep end location of a direct initializer list

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. The history seems complicated. I think it'd be really useful to sort out why getParenOrBraceRange() couldn't give the right result, but I'd be happy to see this land first to address the crash. Re

[PATCH] D53244: [Coverage] Fix PR39258: support coverage regions that start deeper than they end

vsk added a comment. Friendly ping -- @orivej were you still looking for more feedback? If not, do you still need someone to land this patch on your behalf? Repository: rC Clang https://reviews.llvm.org/D53244 ___ cfe-commits mailing list cfe-co

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

a_sidorin added a comment. Hi Davide, I don't mean only review. As I guess, you guys have MacOS machines so you can check if the problem is still present in the updated version. There is no need to remind me about the problem with LLDB since I tried to resolve it. Repository: rC Clang http

[PATCH] D54676: [AST] Pack CallExpr

rjmccall added a comment. I don't think we should be reducing the number of call arguments we can support, sorry, even if 16K is a fairly absurd number that would probably trip stack overflow protections if you actually executed it. Let's try to keep it at least 64K-ish. Repository: rC Cla