void updated this revision to Diff 173922.
void marked an inline comment as done.
void added a comment.
Remove some extraneous checks.
Repository:
rC Clang
https://reviews.llvm.org/D54355
Files:
include/clang/AST/Expr.h
lib/AST/ASTImporter.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.cp
void added inline comments.
Comment at: include/clang/AST/Expr.h:908-912
+ static ConstantExpr *Create(const ASTContext &Context, Expr *E) {
+if (ConstantExpr *CE = dyn_cast(E))
+ return CE;
+return new (Context) ConstantExpr(E);
+ }
rsmith wrote:
Szelethus added a comment.
Thanks you so much! One of the reasons why I love working on this is because
the great feedback I get. I don't wanna seem annoyingly grateful, but it's been
a very enjoyable experience so far.
> This should not cause a warnings because it should be fine to compile
>
riccibruno abandoned this revision.
riccibruno added a comment.
Herald added a reviewer: shafik.
Let's close it for now. I agree that the complexity is probably not worth it.
We can always
resurrect it in the future. I will submit a patch doing the move into a new
`StmtBase.h/.cpp`
after I am do
patricklyster created this revision.
patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice,
kkwli0, hfinkel, gtbercea.
patricklyster added projects: OpenMP, clang.
Herald added subscribers: cfe-commits, guansong, jholewinski.
Restriction on `unified_shared_memory` clause o
NoQ added a comment.
Hmm, makes sense. Maybe `static bool BlahBlahChecker::isApplicable(const
LangOpts &LO)` or something like that.
Btw, maybe instead of default constructor and `->setup(Args)` method we could
stuff all of the `setup(Args)`'s arguments into the one-and-only constructor
for th
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D54463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
NoQ updated this revision to Diff 173932.
NoQ added a comment.
In https://reviews.llvm.org/D18860#1284805, @NoQ wrote:
> `RetainCountChecker` is affected, as demonstrated by the newly added test.
`RetainCountChecker` is affected due to temporary insanity in the checker that
was induced by trus
Author: brunoricci
Date: Tue Nov 13 13:33:22 2018
New Revision: 346801
URL: http://llvm.org/viewvc/llvm-project?rev=346801&view=rev
Log:
[AST] Revert r346793 and r346781
This somehow breaks the msan bots. Revert while I figure it out.
Modified:
cfe/trunk/include/clang/AST/Expr.h
cfe/tru
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346802: [Driver] Support g++ headers in include/g++
(authored by greened, committed by ).
Herald added a subscriber: llvm-
Author: greened
Date: Tue Nov 13 13:38:45 2018
New Revision: 346802
URL: http://llvm.org/viewvc/llvm-project?rev=346802&view=rev
Log:
[Driver] Support g++ headers in include/g++
ray's gcc installation puts C++ headers in PREFIX/include/g++ without
indicating a gcc version at all. Typically this i
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D54493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
greened added a comment.
Oops, I didn't realize this hadn't been formally accepted yet. Still learning
the Phab process. Let me know if you want it reverted for a formal accept.
Repository:
rL LLVM
https://reviews.llvm.org/D53770
___
cfe-commi
stephanemoore updated this revision to Diff 173936.
stephanemoore added a comment.
Reworded "upper camel case" to "Pascal case".
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51575
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/FunctionNamingCheck.cpp
clang-ti
stephanemoore added a comment.
Thanks for the review everyone!
Let me know if there are any further changes that you want me to make or any
further action required on my part to land this 😁
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51575
___
yaxunl created this revision.
yaxunl added a reviewer: tra.
Fix a bug causing host code being compiled when `--cude-device-only` is set.
https://reviews.llvm.org/D54496
Files:
lib/Driver/Driver.cpp
test/Driver/cuda-phases.cu
Index: test/Driver/cuda-phases.cu
===
richardmembarth added a comment.
> In https://reviews.llvm.org/D54258#1297191, @Anastasia wrote:
>
> I agree with the change itself... but it's quite annoying that such things
> can't be tested. :(
Yes, that's a pity :(
Is there anything missing so that this can be merged?
Repository:
rC C
Author: arsenm
Date: Tue Nov 13 14:30:35 2018
New Revision: 346806
URL: http://llvm.org/viewvc/llvm-project?rev=346806&view=rev
Log:
OpenCL: Don't warn on v printf modifier
This avoids spurious warnings, but could use
a lot of work. For example the number of vector
elements is not verified, and t
arsenm closed this revision.
arsenm added a comment.
r346806
https://reviews.llvm.org/D54162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Quuxplusone added inline comments.
Comment at: docs/LanguageExtensions.rst:1096
+ equivalent to copying the underlying bytes and then dropping the source
object
+ on the floor.
* ``__is_destructible`` (MSVC 2013)
rjmccall wrote:
> Quuxplusone wrote:
> > rjmcc
void marked an inline comment as not done.
void added inline comments.
Comment at: lib/AST/Expr.cpp:2915-2916
+ case ConstantExprClass: {
+const Expr *Exp = cast(this)->getSubExpr();
+return Exp->isConstantInitializer(Ctx, false, Culprit);
+ }
void wrot
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Do I understand it correctly that the bug appears to affect HIP compilation
only?
https://reviews.llvm.org/D54496
___
cfe-commits mailing list
cfe-com
jfb updated this revision to Diff 173945.
jfb added a comment.
Herald added subscribers: nhaehnle, jvesely.
- As discussed on the review, change the constant generation to name the
synthesized constant using '__const.' + function_name + '.' variable_name. The
previous code wasn't generally corre
jfb added a comment.
In https://reviews.llvm.org/D54055#1286523, @rjmccall wrote:
> Pfft, if I'm going to be held responsible for my own work, I'm in a lot of
> trouble. :)
>
> Function name + local variable name WFM.
Your wish is my command (in this specific instance anyways).
Repository:
NoQ added a comment.
Nope, unit tests aren't quite useful here. I can't unit-test the behavior of
API that i'm about to //remove//... right?
https://reviews.llvm.org/D18860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
jfb updated this revision to Diff 173946.
jfb added a comment.
- clang-format
Repository:
rC Clang
https://reviews.llvm.org/D54055
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/decl.c
test/CodeGen/dump-struct-builtin.c
test/CodeGenCXX/amdgcn-string-literal.cpp
test/CodeGenCXX/const-in
rjmccall added inline comments.
Comment at: docs/LanguageExtensions.rst:1096
+ equivalent to copying the underlying bytes and then dropping the source
object
+ on the floor.
* ``__is_destructible`` (MSVC 2013)
Quuxplusone wrote:
> rjmccall wrote:
> > Quuxplus
rsmith added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:1930-1931
+if (CGM.getCodeGenOpts().OptimizationLevel == 0)
+ // At -O0, we don't perform inlining, so we don't need to delay the
+ // processing.
+ return RValue::get(ConstantInt::get(Int32Ty,
yaxunl added a comment.
In https://reviews.llvm.org/D54496#1297710, @tra wrote:
> Do I understand it correctly that the bug appears to affect HIP compilation
> only?
Yes. Only HIP.
https://reviews.llvm.org/D54496
___
cfe-commits mailing list
cfe
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Seems reasonable to me.
Repository:
rC Clang
https://reviews.llvm.org/D54055
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: phosek
Date: Tue Nov 13 16:09:26 2018
New Revision: 346820
URL: http://llvm.org/viewvc/llvm-project?rev=346820&view=rev
Log:
[CMake] Passthrough CFLAGS when checking the compiler-rt path
This is needed when cross-compiling for a different target since
CFLAGS may contain additional flags l
arphaman created this revision.
arphaman added a reviewer: bruno.
Herald added a subscriber: dexonsmith.
Include search paths can be relative paths. The `loadSubdirectoryModuleMaps`
function should account for that and respect the `-working-directory` parameter
given to Clang.
Repository:
rC
Author: tkrasnukha
Date: Tue Nov 13 15:59:25 2018
New Revision: 346818
URL: http://llvm.org/viewvc/llvm-project?rev=346818&view=rev
Log:
Complete reverting r346191
Removed:
cfe/trunk/clang/
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Author: tkrasnukha
Date: Tue Nov 13 16:08:34 2018
New Revision: 346819
URL: http://llvm.org/viewvc/llvm-project?rev=346819&view=rev
Log:
Complete reverting r346191
Removed:
cfe/trunk/CodeGen/
cfe/trunk/Headers/
___
cfe-commits mailing list
cfe-
leonardchan updated this revision to Diff 173961.
leonardchan marked 11 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D53738
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/Basic/FixedPoint.h
clang/lib/AST/ASTContext.cpp
clang/lib/Basic/FixedPoi
leonardchan added a comment.
Sorry for the delay in responding to this. Been working on a few other patches.
A couple of the bigger changes so far:
- Added `getCommonSemantics` to `FixedPointSemantics` for finding a common full
precision semantic.
- `getFixedPointSemantics` accepts an int type.
rjmccall added a comment.
In https://reviews.llvm.org/D54489#1297509, @scott.linder wrote:
> In https://reviews.llvm.org/D54489#1297504, @troyj wrote:
>
> > I realize that you're probably striving for option compatibility with gcc,
> > but continuing to name it -frecord-gcc-switches when it actu
leonardchan added a comment.
For the integer conversion though, I was going to add that in a separate
fixed-point-to-int and int-to-fixed-point patch.
Repository:
rC Clang
https://reviews.llvm.org/D53738
___
cfe-commits mailing list
cfe-commits@
smeenai updated this revision to Diff 173965.
smeenai added a comment.
Stateful approach
Repository:
rC Clang
https://reviews.llvm.org/D52674
Files:
lib/AST/MicrosoftMangle.cpp
test/CodeGenObjCXX/msabi-objc-exceptions-gnustep.mm
Index: test/CodeGenObjCXX/msabi-objc-exceptions-gnustep.mm
smeenai added a comment.
@rnk pointed out on IRC that the MicrosoftCXXNameMangler is actually
specifically designed to manage the mangling of only a single name, in which
case adding state to it for handling RTTI seems like a natural approach.
@rjmccall, what do you think? I think this is much
rjmccall added a comment.
I'm not worried about the mangler being re-used for multiple declarations, I'm
worried about a global flag changing how we mangle all components of a type
when we only mean to change it at the top level.
Repository:
rC Clang
https://reviews.llvm.org/D52674
_
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
NoQ added a comment.
> I marked this patch as WIP because I could not create a test-case for it.
> However in real projects this patch seems to reduce false positives
> significantly.
False positives are hard to reduce via delta-debugging because they can be
accidentally reduced into true posi
Author: arphaman
Date: Tue Nov 13 17:08:03 2018
New Revision: 346822
URL: http://llvm.org/viewvc/llvm-project?rev=346822&view=rev
Log:
[HeaderSearch] loadSubdirectoryModuleMaps should respect -working-directory
Include search paths can be relative paths. The loadSubdirectoryModuleMaps
function
s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346822: [HeaderSearch] loadSubdirectoryModuleMaps should
respect -working-directory (authored by arphaman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
smeenai added a comment.
In https://reviews.llvm.org/D52674#1297879, @rjmccall wrote:
> I'm not worried about the mangler being re-used for multiple declarations,
> I'm worried about a global flag changing how we mangle all components of a
> type when we only mean to change it at the top level.
Quuxplusone added inline comments.
Comment at: docs/LanguageExtensions.rst:1096
+ equivalent to copying the underlying bytes and then dropping the source
object
+ on the floor.
* ``__is_destructible`` (MSVC 2013)
rjmccall wrote:
> Quuxplusone wrote:
> > rjmcc
phosek created this revision.
phosek added reviewers: mcgrathr, juliehockett.
Herald added subscribers: cfe-commits, mgorny.
This is needed for run-clang-tidy.py.
Repository:
rC Clang
https://reviews.llvm.org/D54505
Files:
clang/cmake/caches/Fuchsia-stage2.cmake
Index: clang/cmake/caches
void updated this revision to Diff 173970.
void marked an inline comment as not done.
void added a comment.
Updated to address comments.
Repository:
rC Clang
https://reviews.llvm.org/D54355
Files:
include/clang/AST/Expr.h
lib/AST/ASTImporter.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.
void added a comment.
I think this is ready now. PTAL.
Comment at: lib/CodeGen/CGBuiltin.cpp:1930-1931
+if (CGM.getCodeGenOpts().OptimizationLevel == 0)
+ // At -O0, we don't perform inlining, so we don't need to delay the
+ // processing.
+ return RValue::ge
void updated this revision to Diff 173974.
void added a comment.
Fix overflow flag.
Repository:
rC Clang
https://reviews.llvm.org/D54355
Files:
include/clang/AST/Expr.h
lib/AST/ASTImporter.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaDeclCX
Author: phosek
Date: Tue Nov 13 20:06:47 2018
New Revision: 346827
URL: http://llvm.org/viewvc/llvm-project?rev=346827&view=rev
Log:
[CMake] Include clang-apply-replacements in Fuchsia toolchain
This is needed for run-clang-tidy.py.
Differential Revision: https://reviews.llvm.org/D54505
Modifie
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346827: [CMake] Include clang-apply-replacements in Fuchsia
toolchain (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54505?vs=173969&id=173980#toc
Repository:
Author: yaxunl
Date: Tue Nov 13 20:47:31 2018
New Revision: 346828
URL: http://llvm.org/viewvc/llvm-project?rev=346828&view=rev
Log:
[HIP] Fix device only compilation
Fix a bug causing host code being compiled when --cude-device-only is set.
Differential Revision: https://reviews.llvm.org/D54496
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346828: [HIP] Fix device only compilation (authored by
yaxunl, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D54496
Files:
lib/Driver/Driver.cpp
test/Driver/cuda-phases.cu
Index:
wuzish updated this revision to Diff 173981.
wuzish added a comment.
Use return type to distinguish which overload candidate is chosen because
different candidate has different pointer return type which can not be
converted implicitly without reporting error.
https://reviews.llvm.org/D53417
F
wuzish marked an inline comment as done.
wuzish added inline comments.
Comment at: clang/test/SemaCXX/vector.cpp:26
float &fr1 = f1(ll16);
- f1(c16e); // expected-error{{call to 'f1' is ambiguous}}
- f1(ll16e); // expected-error{{call to 'f1' is ambiguous}}
+ f1(c16e);
+ f
void updated this revision to Diff 173986.
void added a comment.
ImpCast.
Repository:
rC Clang
https://reviews.llvm.org/D54355
Files:
include/clang/AST/Expr.h
lib/AST/ASTImporter.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaDeclCXX.cpp
li
101 - 158 of 158 matches
Mail list logo
