[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

smeenai added a comment. Sorry, had a leftover draft which I forgot to clean up. Edited in Phabricator now. Repository: rC Clang https://reviews.llvm.org/D52674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D53522: [Frontend] Include module map header declaration in dependency file output

vsapsai added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:1198-1203 +// If the header in the module map refers to a symlink, Header.Entry +// refers to the actual file. The callback should be notified of both. +if (!FullPathAsWritten.empty() && +!

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 173119. tlively added a comment. - Use automatic expansion instead of patterns Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp test/CodeGen/WebAssembly/simd-select.ll test/CodeGen/WebAss

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively added a comment. In https://reviews.llvm.org/D53675#1290660, @aheejin wrote: > I tried to add `ISD::SELECT` in the expansion list, like > > for (auto Op : {ISD::VSELECT, ISD::SELECT_CC, ISD::SELECT}) { > ... > } > > > And the code generation apparently works for current test `s

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 173120. tlively added a comment. - Update comment Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp test/CodeGen/WebAssembly/simd-select.ll test/CodeGen/WebAssembly/simd-vselect.ll Index:

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

rjmccall added a comment. In https://reviews.llvm.org/D53153#1289380, @scott.linder wrote: > I don't believe that is currently the case (the unrestricted linking of OCL > code to OCL code via a dynamic linker), but we do have the notion of a static > link step, followed by dynamic linking at ru

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

sylvestre.ledru added a comment. Can be done in a new commit but I think this should be mentioned in the clang release notes. Repository: rC Clang https://reviews.llvm.org/D52034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

<    1   2