yaxunl created this revision.
yaxunl added a reviewer: tra.
The default optimization level of nvcc is -O3. There are HIP applications which
expect
the default optimization level to be -O3. Most HIP applications use -O3,
therefore
making it default.
https://reviews.llvm.org/D54183
Files:
lib
tra added a comment.
I'm not convinced that nvcc's behavior is a good guide for clang's defaults.
Considering that clang is not compatible with nvcc when it comes to command
line options, whoever is using clang to compile CUDA already has to adjust
command line options. Explicitly adding `-O3`
Szelethus marked 2 inline comments as done.
Szelethus added inline comments.
Comment at: test/Analysis/analyzer-config.c:4-12
void bar() {}
void foo() {
// Call bar 33 times so max-times-inline-large is met and
// min-blocks-for-inline-large is checked
for (int i = 0;
Szelethus updated this revision to Diff 172856.
Szelethus set the repository for this revision to rC Clang.
Szelethus added a comment.
- Moved initializer functions to `CompilerInvocation.cpp`, like every other
Options-like class.
- The fields for options are no longer `Optional`
- Fixed the test
Author: vedantk
Date: Tue Nov 6 14:25:00 2018
New Revision: 346276
URL: http://llvm.org/viewvc/llvm-project?rev=346276&view=rev
Log:
[Darwin] Export new weak external symbols when compiling with coverage
Some weak external symbols were added to the profile runtime in D49953,
and on Darwin, these
juliehockett added a comment.
In https://reviews.llvm.org/D54168#1289128, @JonasToth wrote:
> I think this check is ok in the current form, but does it really need to be
> in upstream clang-tidy? You said its for migration only, so it is not
> valuable for you for a long time either?
So yes,
rnk created this revision.
rnk added reviewers: aprantl, zturner.
Herald added subscribers: JDevlieghere, mgorny.
This is an initial prototype of how we can run debugger integration tests on
Windows. cdb and windbg share a command language and debugger engine. Visual
Studio has its own, but we sho
yonghong-song added a comment.
@dblaikie This is not blocking me yet since the main BTF support is not in llvm
yet. I will be in a conference next week. I will dig into this issue the week
after, to have a smaller test case and try to root cause a little further. Will
update here as soon as I g
aprantl added a comment.
It would be nice if instead of having a set of windows-only tests, we could
wrap cdb similar to llgdb.py wraps LLDB, so these tests run on all platforms.
If the Windows debugger is just too different for this to make sense, let me
know.
https://reviews.llvm.org/D54187
rnk added a comment.
In https://reviews.llvm.org/D54187#1289607, @aprantl wrote:
> It would be nice if instead of having a set of windows-only tests, we could
> wrap cdb similar to llgdb.py wraps LLDB, so these tests run on all platforms.
> If the Windows debugger is just too different for this
nickdesaulniers created this revision.
nickdesaulniers added a reviewer: rsmith.
Herald added subscribers: cfe-commits, erik.pilkington.
Prevents -Wunneeded-internal-delcaration warnings when the target has no
other references. This occurs frequently in device drivers in the Linux
kernel.
Sema wo
zturner added a comment.
I think the only way to realistically make this work for all platforms would be
to separate the source file from the input/output. The source file would be
the test case, and if you wanted to support a different debugger you would need
to supply a different input/outpu
vsapsai added a comment.
OK. Good to know you are still working on it.
In https://reviews.llvm.org/D47687#1271880, @Higuoxing wrote:
> In https://reviews.llvm.org/D47687#1266893, @vsapsai wrote:
>
> > Sorry about the delay. The change seems to be correct but `ninja
> > check-clang` reveals the
juliehockett updated this revision to Diff 172889.
juliehockett marked 4 inline comments as done.
https://reviews.llvm.org/D54168
Files:
clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
clang-tools-extra/clang-tidy/zircon/FblMoveCheck.cpp
clang-tools-extra/clang-tidy/zircon/FblMoveCheck.h
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:188
+
+ Suggests converting uses of ``fbl::move`` to
+ ``std::move``, and suggests inserting the header.
Please try to fill as much as possible to 80 characters.
==
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47
+SrcMgr::CharacteristicKind FileType) {
+ if (FileName == "fbl/limits.h") {
+unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1;
aa
juliehockett updated this revision to Diff 172892.
juliehockett marked 2 inline comments as done.
https://reviews.llvm.org/D54168
Files:
clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
clang-tools-extra/clang-tidy/zircon/FblMoveCheck.cpp
clang-tools-extra/clang-tidy/zircon/FblMoveCheck.h
juliehockett updated this revision to Diff 172891.
juliehockett marked 5 inline comments as done.
https://reviews.llvm.org/D54169
Files:
clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp
clang-tools-extra/clang-tidy/zircon/FblLimitsChe
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47
+SrcMgr::CharacteristicKind FileType) {
+ if (FileName == "fbl/limits.h") {
+unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1;
j
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47
+SrcMgr::CharacteristicKind FileType) {
+ if (FileName == "fbl/limits.h") {
+unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1;
aa
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47
+SrcMgr::CharacteristicKind FileType) {
+ if (FileName == "fbl/limits.h") {
+unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1;
j
jessicah created this revision.
Herald added a subscriber: cfe-commits.
Linux toolchain accidentally added "-u__llvm_runtime_variable" when
"-fprofile-arcs -ftest-coverage", this is not added when "--coverage" option is
used.
Using "-u__llvm_runtime_variable" generates an empty default.profraw f
101 - 122 of 122 matches
Mail list logo
