lebedev.ri added a comment.
In https://reviews.llvm.org/D50050#1287780, @george.karpenkov wrote:
> @lebedev.ri @erichkeane The test fails for me on macOS whenever asan and
> ubsan are both enabled.
> The failure is stack overflow at stack frame 943
> (? maybe asan usage enforces lower stack
george.karpenkov added a subscriber: vsapsai.
george.karpenkov added a comment.
@lebedev.ri yeah ASAN is making stack frame size larger.
It seems @vsapsai is working on disabling this test under ASAN.
Repository:
rC Clang
https://reviews.llvm.org/D50050
___
Author: danalbert
Date: Mon Nov 5 12:57:46 2018
New Revision: 346167
URL: http://llvm.org/viewvc/llvm-project?rev=346167&view=rev
Log:
[Driver] Reland again again: Default Android toolchains to libc++.
Landed more fixes to the compiler-rt Android tests.
Original review was https://reviews.llvm.
jstasiak created this revision.
jstasiak added reviewers: mgorny, jbcoe.
Herald added a subscriber: arphaman.
Python 3.6 introduced a file system path protocol (PEP 519[1]). The standard
library APIs accepting file system paths now accept path objects too. It could
be useful to add this here as
scott.linder added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D53768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scott.linder added a comment.
Ping
https://reviews.llvm.org/D53153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
LGTM
Summary needs updating as now only being done for kernels and not namespace
scope variables.
https://reviews.llvm.org/D53153
___
cfe-commits
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2369
ProgramStateRef state = C.getState();
- RegionStateTy RS = state->get();
+ RegionStateTy OldRS = state->get();
RegionStateTy::Factory &F = state->get_context();
---
ztamas added inline comments.
Comment at: clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp:142
+ if (LoopVar->getType() != LoopIncrement->getType())
+return; // We matched the loop variable incorrectly
+
ztamas wrote:
> JonasToth wrote:
> > Does this try to
NoQ updated this revision to Diff 172645.
NoQ marked 3 inline comments as done.
NoQ added a comment.
Fix comments, update comments.
Before i forget - also add invariant violation markers to the exploded graph,
which helped me a lot with debugging this bug.
https://reviews.llvm.org/D54017
File
NoQ added inline comments.
Comment at: test/Analysis/nullability.mm:3-4
// RUN: %clang_analyze_cc1 -fblocks
-analyzer-checker=core,nullability.NullPassedToNonnull,nullability.NullReturnedFromNonnull,nullability.NullablePassedToNonnull,nullability.NullableReturnedFromNonnull,nul
aaron.ballman added reviewers: mclow.lists, EricWF, ldionne.
aaron.ballman added a comment.
Another option that @rsmith and I discussed today is perhaps using `__clang` or
`clang__` as the identifier, but perhaps this will cause more confusion about
where to put underscores than `_Clang` would.
Szelethus added a comment.
I have no other objections, looks great!
Comment at: test/Analysis/nullability.mm:3-4
// RUN: %clang_analyze_cc1 -fblocks
-analyzer-checker=core,nullability.NullPassedToNonnull,nullability.NullReturnedFromNonnull,nullability.NullablePassedToNonnull,
JonasToth added a comment.
last nits from my side (for now :)).
If the other reviews could take a look at it as well, would be great.
I am uncertain about the english in some comments @aaron.ballman finds all
these language bugs ;)
Comment at: clang-tidy/bugprone/TooSmallLoopV
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/bugprone-too-small-loop-variable.rst:10
+
+ .. code-block:: c++
+
JonasToth wrote:
> ztamas wrote:
> > JonasToth wrote:
> > > the `.. code-block:: c++` is usually not indended, only the cod
rnk added inline comments.
Comment at: include/clang/Basic/BuiltinsARM.def:270
+TARGET_HEADER_BUILTIN(_InterlockedCompareExchange64_nf, "LLiLLiD*LLiLLi",
"nh", "intrin.h", ALL_MS_LANGUAGES, "")
+TARGET_HEADER_BUILTIN(_InterlockedCompareExchange64_rel, "LLiLLiD*LLiLLi",
"nh", "
Author: jonastoth
Date: Mon Nov 5 14:21:27 2018
New Revision: 346173
URL: http://llvm.org/viewvc/llvm-project?rev=346173&view=rev
Log:
[clang-tidy] doc removew hitespace in front of code-block-line
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/boost-use-to-string.rst
clang-to
JonasToth added inline comments.
Comment at: docs/clang-tidy/checks/bugprone-too-small-loop-variable.rst:10
+
+ .. code-block:: c++
+
Eugene.Zelenko wrote:
> JonasToth wrote:
> > ztamas wrote:
> > > JonasToth wrote:
> > > > the `.. code-block:: c++` is usually n
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D53522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jonastoth
Date: Mon Nov 5 14:30:17 2018
New Revision: 346176
URL: http://llvm.org/viewvc/llvm-project?rev=346176&view=rev
Log:
[clang-tidy] fix example code-blocks indendation
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst
Author: kzhuravl
Date: Mon Nov 5 14:44:59 2018
New Revision: 346178
URL: http://llvm.org/viewvc/llvm-project?rev=346178&view=rev
Log:
AMDGPU: Add sram-ecc feature options
Differential Revision: https://reviews.llvm.org/D53223
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346178: AMDGPU: Add sram-ecc feature options (authored by
kzhuravl, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D53223
Files:
include/clang/Driver/Options.td
test/Driver/amdgpu-fe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346178: AMDGPU: Add sram-ecc feature options (authored by
kzhuravl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53223?vs=169499&id=172665#toc
Repository:
rL LLVM
https://revie
david-salinas updated this revision to Diff 172671.
david-salinas added a comment.
using CreateElementBitCast instead
Repository:
rC Clang
https://reviews.llvm.org/D53780
Files:
lib/CodeGen/CGCall.cpp
test/CodeGenCXX/address-space-cast-coerce.cpp
Index: test/CodeGenCXX/address-space-ca
david-salinas updated this revision to Diff 172673.
david-salinas added a comment.
fix missing ;
Repository:
rC Clang
https://reviews.llvm.org/D53780
Files:
lib/CodeGen/CGCall.cpp
test/CodeGenCXX/address-space-cast-coerce.cpp
Index: test/CodeGenCXX/address-space-cast-coerce.cpp
===
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
efriedma added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:233
+static Value *EmitAtomicCmpXchgValue(CodeGenFunction &CGF, const CallExpr *E,
+AtomicOrdering SuccessOrdering = AtomicOrdering::SequentiallyConsistent) {
Please rename this function;
mgrang updated this revision to Diff 172675.
https://reviews.llvm.org/D54062
Files:
include/clang/Basic/BuiltinsAArch64.def
include/clang/Basic/BuiltinsARM.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics.c
Index: test/CodeGen/ms-intrinsics.c
==
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D54062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: mgrang
Date: Mon Nov 5 16:36:48 2018
New Revision: 346189
URL: http://llvm.org/viewvc/llvm-project?rev=346189&view=rev
Log:
[COFF, ARM64] Implement InterlockedCompareExchange*_* builtins
Summary: This is third in a series of patches to move intrinsic definitions out
of intrin.h.
Review
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346189: [COFF, ARM64] Implement
InterlockedCompareExchange*_* builtins (authored by mgrang, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D54062
Files:
include/clang/Basic/BuiltinsAA
dblaikie added a comment.
In https://reviews.llvm.org/D53334#1273877, @whisperity wrote:
> @dblaikie I have created a test, but unfortunately `%clang_cpp` in LIT
> invokes `clang --driver-mode=cpp` which is not the same as if `clang++` is
> called. I'm trying to construct the following command-
rjmccall added a comment.
I agree with Richard that I'm not sure what the point of supporting frontend
visibility settings in OpenCL is. If you want the "everything is internal to
the image" optimization, presumably you can just infer visibility on everything
in a pass over the IR.
Hello everyone,
Below are some buildbot numbers for the last week of 10/28/2018 -
11/03/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Hello everyone,
Below are some buildbot numbers for the week of 10/21/2018 - 10/27/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
mcgrathr requested changes to this revision.
mcgrathr added a comment.
This revision now requires changes to proceed.
This breaks the semantics we want. The `-Bdynamic` is there to apply to `-lm`,
which is also what `--as-needed` is there for in this case (it appears earlier
because of the cond
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
arsenm added a comment.
In https://reviews.llvm.org/D53153#1288059, @rjmccall wrote:
> I agree with Richard that I'm not sure what the point of supporting frontend
> visibility settings in OpenCL is. If you want the "everything is internal to
> the image" optimization, presumably you can just
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: mgrang
Date: Mon Nov 5 17:11:25 2018
New Revision: 346190
URL: http://llvm.org/viewvc/llvm-project?rev=346190&view=rev
Log:
[COFF, ARM64] Implement InterlockedOr*_* builtins
This is fourth in a series of patches to move intrinsic definitions out of
intrin.h.
Modified:
cfe/trunk/inc
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346191: [COFF, ARM64] Implement InterlockedXor*_* builtins
(authored by mgrang, committed by ).
Herald added subscribers: aheejin, dschuff.
Changed prior to commit:
https://reviews.llvm.org/D54065?vs=17
rjmccall added a comment.
In https://reviews.llvm.org/D53153#1288083, @arsenm wrote:
> In https://reviews.llvm.org/D53153#1288059, @rjmccall wrote:
>
> > I agree with Richard that I'm not sure what the point of supporting
> > frontend visibility settings in OpenCL is. If you want the "everythin
rjmccall added a comment.
In https://reviews.llvm.org/D53153#1288112, @rjmccall wrote:
> But do you want to support *dynamically* linking object files? Because
> that's what visibility is about.
To be specific, if you don't have multiple levels of linking — doing a slower
and relatively more
vsapsai created this revision.
vsapsai added reviewers: george.karpenkov, lebedev.ri.
Herald added a subscriber: dexonsmith.
The test hits stack overflow trying to instantiate recursive templates.
It is observed with ASAN and not with a regular build because ASAN
increases stack frame size.
rdar:
vsapsai added a comment.
Disabling test in https://reviews.llvm.org/D54132.
Repository:
rC Clang
https://reviews.llvm.org/D50050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov added inline comments.
Comment at: clang/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp:8
+// recursive template instantiation limit.
+// XFAIL: darwin && asan
+
Do we actually want UNSUPPORTED here? We don't want to fail if ASAN stack usage
leonardchan added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:102-104
+ Actions.PushExpressionEvaluationContext(
+ Actions.ExprEvalContexts.back().Context);
ParenBraceBracketBalancer BalancerRAIIObj(*this);
leonardchan wrote:
> rsmith wrote:
> >
leonardchan updated this revision to Diff 172695.
leonardchan marked 5 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D49511
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrDocs.td
clang/include/clang/Basic/DiagnosticGroups.td
clang/includ
vsapsai added inline comments.
Comment at: clang/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp:8
+// recursive template instantiation limit.
+// XFAIL: darwin && asan
+
george.karpenkov wrote:
> Do we actually want UNSUPPORTED here? We don't want to fail if
george.karpenkov accepted this revision.
george.karpenkov added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp:8
+// recursive template instantiation limit.
+// XFAIL: darwin && asan
+
--
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346200: [CodeGenCXX] XFAIL test for ASAN on Darwin.
(authored by vsapsai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54132?vs=172692&id=172699#toc
Repository:
rC Clang
https:
Author: vsapsai
Date: Mon Nov 5 18:16:28 2018
New Revision: 346200
URL: http://llvm.org/viewvc/llvm-project?rev=346200&view=rev
Log:
[CodeGenCXX] XFAIL test for ASAN on Darwin.
The test hits stack overflow trying to instantiate recursive templates.
It is observed with ASAN and not with a regular
NoQ added inline comments.
Comment at: test/Analysis/analyzer-config.c:4-12
void bar() {}
void foo() {
// Call bar 33 times so max-times-inline-large is met and
// min-blocks-for-inline-large is checked
for (int i = 0; i < 34; ++i) {
bar();
}
T
phosek added a comment.
@rsmith does this look reasonable to you?
Repository:
rC Clang
https://reviews.llvm.org/D53787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
In https://reviews.llvm.org/D53701#1287007, @baloghadamsoftware wrote:
> ...on iterator-adapters inlining ensures that we handle the comparison of the
> underlying iterator correctly. Without inlining, `evalCall()` only works on
> the outermost iterator which is not always
vsapsai added a comment.
Sorry, you've decided to abandon the patch, it took a lot of good work. Xing,
are you sure you don't want to see this change finished? I agree that delays in
code review can be frustrating and I think it is something we can improve.
https://reviews.llvm.org/D47687
_
t-tye added a comment.
In https://reviews.llvm.org/D53153#1288127, @rjmccall wrote:
> In https://reviews.llvm.org/D53153#1288112, @rjmccall wrote:
>
> > But do you want to support *dynamically* linking object files? Because
> > that's what visibility is about.
>
>
> To be specific, if you don't
rjmccall added a comment.
Okay, that's interesting. And that dynamic linking step includes fairly
unrestricted linking of OpenCL code to other OpenCL code, rather than just e.g.
loading a single block of OpenCL code that exports a small, fixed interface?
If so, then I accept that you need sym
Higuoxing reclaimed this revision.
Higuoxing added a comment.
In https://reviews.llvm.org/D47687#1288272, @vsapsai wrote:
> Sorry, you've decided to abandon the patch, it took a lot of good work. Xing,
> are you sure you don't want to see this change finished?
No, I am working on this :)
> I
tlively updated this revision to Diff 172708.
tlively added a dependency: D53630: [WebAssembly] Lower vselect.
tlively added a comment.
- Rebase onto SIMD reorganization
Repository:
rL LLVM
https://reviews.llvm.org/D53675
Files:
lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
lib/Targ
Author: mgrang
Date: Mon Nov 5 20:55:20 2018
New Revision: 346205
URL: http://llvm.org/viewvc/llvm-project?rev=346205&view=rev
Log:
[COFF, ARM64] Implement InterlockedXor*_* builtins
This is fifth in a series of patches to move intrinsic definitions out of
intrin.h.
Note: This was reviewed and
Author: mgrang
Date: Mon Nov 5 21:03:13 2018
New Revision: 346206
URL: http://llvm.org/viewvc/llvm-project?rev=346206&view=rev
Log:
[COFF, ARM64] Implement InterlockedAnd*_* builtins
This is sixth in a series of patches to move intrinsic definitions out of
intrin.h.
Differential: https://revie
Author: mgrang
Date: Mon Nov 5 21:05:32 2018
New Revision: 346207
URL: http://llvm.org/viewvc/llvm-project?rev=346207&view=rev
Log:
[COFF, ARM64] Implement InterlockedIncrement*_* builtins
This is seventh in a series of patches to move intrinsic definitions out of
intrin.h.
Differential: https
Author: mgrang
Date: Mon Nov 5 21:07:43 2018
New Revision: 346208
URL: http://llvm.org/viewvc/llvm-project?rev=346208&view=rev
Log:
[COFF, ARM64] Implement InterlockedDecrement*_* builtins
This is eight in a series of patches to move intrinsic definitions out of
intrin.h.
Differential: https:/
Author: ahatanak
Date: Mon Nov 5 21:41:33 2018
New Revision: 346209
URL: http://llvm.org/viewvc/llvm-project?rev=346209&view=rev
Log:
os_log: Minor code cleanups. NFC.
Also, add a new test case and fix an incorrect comment.
Modified:
cfe/trunk/include/clang/AST/OSLog.h
cfe/trunk/lib/AST
Author: ahatanak
Date: Mon Nov 5 22:26:17 2018
New Revision: 346210
URL: http://llvm.org/viewvc/llvm-project?rev=346210&view=rev
Log:
os_log: Add a new privacy annotation "sensitive".
This is a stricter privacy annotation than "private", which will be used
for data that shouldn’t be logged to di
rjmccall added a comment.
In https://reviews.llvm.org/D53738#1287123, @ebevhan wrote:
> In https://reviews.llvm.org/D53738#1284213, @rjmccall wrote:
>
> > Not out of line with other features that significantly break with what's
> > expressible. But the easy alternative to storing the intermedia
Author: ahatanak
Date: Mon Nov 5 23:05:14 2018
New Revision: 346211
URL: http://llvm.org/viewvc/llvm-project?rev=346211&view=rev
Log:
os_log: Allow specifying mask type in format string.
A mask type is a 1 to 8-byte string that follows the "mask." annotation
in the format string. This enables ob
Author: ahatanak
Date: Mon Nov 5 23:12:28 2018
New Revision: 346212
URL: http://llvm.org/viewvc/llvm-project?rev=346212&view=rev
Log:
Cast to uint64_t instead of to unsigned.
This is a follow-up to r346211.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBui
sammccall added a comment.
In https://reviews.llvm.org/D51729#1287421, @Lekensteyn wrote:
> Before this patch, missing compilation database entries resulted in "Skipping
> Compile command not found." which is assumed by the tests in this
> clang-query patch: https://reviews.llvm.org/D54109
101 - 173 of 173 matches
Mail list logo
