phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: cfe-commits, mgorny.
We set lld as the default linker on non-Darwin platforms, but we still
need to set -fuse-ld=lld explicitly in to support cross-compiling Linux
runtimes on Darwin.
Repository:
rC Clan
void updated this revision to Diff 172313.
Repository:
rC Clang
https://reviews.llvm.org/D53921
Files:
include/clang/AST/Expr.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTImporter.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/ASTMatchers/ASTMatchersInternal.cpp
lib/AS
takuto.ikuta updated this revision to Diff 172317.
takuto.ikuta added a comment.
Added cl driver flag test
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Driv
takuto.ikuta marked an inline comment as done.
takuto.ikuta added a comment.
I missed the comment about driver flag test.
https://reviews.llvm.org/D51340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
kbobyrev added a comment.
In https://reviews.llvm.org/D52998#1284312, @eandrews wrote:
> > Upstreaming it first might be better, especially since the change seems to
> > be trivial. Is this line addition the only change proposed for the
> > benchmark library?
>
> Yes this line is the only chang
Szelethus added a comment.
Also, thank you so much for the feedback on this, and almost every single other
patch I made!
https://reviews.llvm.org/D53692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Szelethus added a comment.
In https://reviews.llvm.org/D53692#1285091, @NoQ wrote:
> I guess i'm running out of steam for today :)
>
> > `Opts.shouldDoThat()` -> `Opts.ShouldDoThat.getValue()`
>
> Is this really unavoidable? Like, what makes them optional when they're
> always non-optional? Mayb
wuzish added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
hubert.reinterpretcast wrote:
> wuzish wr
hans added a comment.
Thanks! I don't think the new isThisDeclarationADefinition() and
isImplicitlyInstantiable() checks are right. Besides that, I only have a few
more comments about the test.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5715
+ (MD->isThisDeclarationA
hokein accepted this revision.
hokein added a comment.
> There is a test that asserts clang-tidy exits with 0 when processing a
> nonexistent file (test added in https://reviews.llvm.org/D17335 which you
> wrote/reviewed).
This seems like a bug to me, do I need to preserve this behavior? (See p
sammccall marked an inline comment as done.
sammccall added a comment.
In https://reviews.llvm.org/D53953#1285244, @hokein wrote:
> I think this is a bug, we should return non-zero code when processing a
> non-existing file. The new behavior seems better to me, though we need to
> polish the er
sammccall updated this revision to Diff 172326.
sammccall added a comment.
Address comment, rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53953
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidy
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345961: [clang-tidy] Get ClangTidyContext out of the
business of storing diagnostics. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53953?vs=172326&id=1723
Author: sammccall
Date: Fri Nov 2 03:01:59 2018
New Revision: 345961
URL: http://llvm.org/viewvc/llvm-project?rev=345961&view=rev
Log:
[clang-tidy] Get ClangTidyContext out of the business of storing diagnostics.
NFC
Summary:
Currently ClangTidyContext::diag() sends the diagnostics to a
Diagnos
takuto.ikuta updated this revision to Diff 172330.
takuto.ikuta marked 10 inline comments as done.
takuto.ikuta added a comment.
Address comment
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
clang/include/clang/Driver/CC
takuto.ikuta updated this revision to Diff 172331.
takuto.ikuta added a comment.
added a few more check
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Driver/
takuto.ikuta added a comment.
Thank you for quick review!
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5715
+ (MD->isThisDeclarationADefinition() ||
+ MD->isImplicitlyInstantiable()) &&
+ TSK != TSK_ExplicitInstantiationDeclaration &&
takuto.ikuta updated this revision to Diff 172332.
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Driver/CLCompatOptions.td
clang/lib/Driver/ToolChains/Clang.
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Assuming the test still passes when you put the EXPORTINLINE filecheck prefix
back, looks good to me!
Comment at: clang/test/CodeGenCXX/dllexport-no-dllexport-inlines.cpp:9
+//
lebedev.ri updated this revision to Diff 172335.
lebedev.ri added a comment.
And finish the test coverage.
(sidenote: will these follow-ups again be stuck for two months? let's see!)
Repository:
rC Clang
https://reviews.llvm.org/D53949
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGen/ca
Author: ibiryukov
Date: Fri Nov 2 03:50:26 2018
New Revision: 345963
URL: http://llvm.org/viewvc/llvm-project?rev=345963&view=rev
Log:
Revert "Fix regression in behavior of clang -x c++-header -fmodule-name=XXX"
This reverts commit r345803 and r345915 (a follow-up fix to r345803).
Reason: r3458
grimar added a comment.
In https://reviews.llvm.org/D52296#1284130, @probinson wrote:
> In https://reviews.llvm.org/D52296#1283691, @grimar wrote:
>
> > Nice :)
> > So seems the last unresolved question left is the naming of the new option?
> > If we do not want to go with `-gsingle-file-split
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and initializ
Author: xazax
Date: Fri Nov 2 04:22:22 2018
New Revision: 345965
URL: http://llvm.org/viewvc/llvm-project?rev=345965&view=rev
Log:
[analyzer][CTU] Correctly signal in the function index generation tool if there
was an error
Differential Revision: https://reviews.llvm.org/D53979
Modified:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345965: [analyzer][CTU] Correctly signal in the function
index generation tool if there… (authored by xazax, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:227
-CTUDir = getStringOption("ctu-dir", "");
-if (!llvm::sys::fs::is_directory(*CTUDir))
- CTUDir = "";
Szelethus wrote:
> This check should and will be moved t
xazax.hun accepted this revision.
xazax.hun added a comment.
One question and one nit otherwise looks good. Feel free to commit once those
are resolved without another round of reviews.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:805
+// macro.
+if (const
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:685
const MacroInfo *MI = nullptr;
+ llvm::Optional Args;
I wonder if the optional gives us any value here. An empty map could be just as
great to represent that ther
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, xazax.hun.
Clang's hierarchy is CompilerInstance -> DiagnosticsEngine ->
DiagnosticConsumer.
(Ownership is optional/shared, but this structure is fairly clear).
Currently ClangTidyDiagnost
xazax.hun accepted this revision.
xazax.hun added a comment.
One question otherwise looks good.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:884
+ // even if we lex a tok::comma and ParanthesesDepth == 1.
+ const IdentifierInfo *__VA_ARGS__II = PP.getIdentifierInf
Hiya Sam,
are you aware that r345961 caused a test failure on the following bot and
build
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/21169
is there any chance you could take a look please?
thanks
Tom
On Fri, 2 Nov 2018 at 10:04, Sam McCall via cfe
xazax.hun added a comment.
I also would like to see in a tool how this would look like as an event before
committing :) Just a sanity check to make sure this feature makes sense. Could
you post a screenshot of CodeChecker or any other tool using this feature?
https://reviews.llvm.org/D52790
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM, but let's wait for @NoQ before committing.
Repository:
rC Clang
https://reviews.llvm.org/D53995
___
cfe-commits mailing list
cfe-
Author: plyster
Date: Fri Nov 2 05:18:11 2018
New Revision: 345967
URL: http://llvm.org/viewvc/llvm-project?rev=345967&view=rev
Log:
Add support for 'atomic_default_mem_order' clause on 'requires' directive. Also
renamed test files relating to 'requires'. Differntial review:
https://reviews.llv
Author: sammccall
Date: Fri Nov 2 05:51:26 2018
New Revision: 345968
URL: http://llvm.org/viewvc/llvm-project?rev=345968&view=rev
Log:
[clangd] Only log ignored diagnostics with -log=verbose.
Reviewers: ilya-biryukov
Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Differ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345968: [clangd] Only log ignored diagnostics with
-log=verbose. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53648
Fi
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
This looks clearer!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: sammccall
Date: Fri Nov 2 06:06:55 2018
New Revision: 345969
URL: http://llvm.org/viewvc/llvm-project?rev=345969&view=rev
Log:
[clangd] Remove didOpen extraFlags extension.
Summary:
This was added in D34947 to support YCM, but YCM actually provides *all* args,
and this was never actually
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345970: [clangd] Make in-memory CDB always available as an
overlay, refactor. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53687?vs=171098&id=172342#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345969: [clangd] Remove didOpen extraFlags extension.
(authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53641?vs=170858&id=172341#toc
Repository:
rCTE Clang
Author: sammccall
Date: Fri Nov 2 06:09:36 2018
New Revision: 345970
URL: http://llvm.org/viewvc/llvm-project?rev=345970&view=rev
Log:
[clangd] Make in-memory CDB always available as an overlay, refactor.
Summary:
The new implementation is a GlobalCompilationDatabase that overlays a base.
Normal
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345970: [clangd] Make in-memory CDB always available as an
overlay, refactor. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
Author: tnorthover
Date: Fri Nov 2 06:14:11 2018
New Revision: 345971
URL: http://llvm.org/viewvc/llvm-project?rev=345971&view=rev
Log:
Reapply Logging: make os_log buffer size an integer constant expression.
The size of an os_log buffer is known at any stage of compilation, so making it
a const
rnkovacs added a comment.
In https://reviews.llvm.org/D53856#1280408, @Szelethus wrote:
> In https://reviews.llvm.org/D53856#1279887, @NoQ wrote:
>
> > This might be also covered by @rnkovacs's string buffer escape checker -
> > either already or eventually, it'll become just yet another string
takuto.ikuta updated this revision to Diff 172348.
takuto.ikuta marked an inline comment as done.
takuto.ikuta added a comment.
Fix check-prefix
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
clang/include/clang/Driver/CC
takuto.ikuta added a comment.
Thank you! I'll submit this if other people does not have other comments.
Comment at: clang/test/CodeGenCXX/dllexport-no-dllexport-inlines.cpp:9
+// RUN: -emit-llvm -O1 -o - | \
+// RUN: FileCheck --che
ABataev abandoned this revision.
ABataev added a comment.
The patch is not required anymore as it is implemented in the different way
Repository:
rC Clang
https://reviews.llvm.org/D45783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: sammccall
Date: Fri Nov 2 07:07:51 2018
New Revision: 345973
URL: http://llvm.org/viewvc/llvm-project?rev=345973&view=rev
Log:
[clangd] Add fallbackFlags initialization extension.
Summary:
This allows customizing the flags used when no compile database is
available. It addresses some use
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345973: [clangd] Add fallbackFlags initialization
extension. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53688?vs=171036&id=172351#toc
Repository:
rCT
xazax.hun updated this revision to Diff 172354.
xazax.hun added a comment.
This new version based on the bullets by NoQ. I also included some additional
ones from other lists and added some new ones, e.g. the NamedDecl::getName will
fail if the name of the decl is not a single token. I also reor
AlexeySotkin added inline comments.
Herald added a reviewer: shafik.
Comment at: lib/Sema/SemaInit.cpp:8073
+ assert((Step->Type->isEventT() || Step->Type->isQueueT() ||
+ Step->Type->isOCLIntelSubgroupAVCType) &&
"Wrong type for initialization of
Author: abataev
Date: Fri Nov 2 07:54:07 2018
New Revision: 345978
URL: http://llvm.org/viewvc/llvm-project?rev=345978&view=rev
Log:
[OPENMP][NVPTX]Improve emission of the globalized variables for
target/teams/distribute regions.
Target/teams/distribute regions exist for all the time the kernel
Hi Sam,
On 2 Nov 2018, at 13:31, Sam McCall wrote:
> The move of OSLog.h and FormatString.h to AST doesn't look obviously correct.
> Do these really belong in this layer? I think this patch needs review from
> someone who knows AST/ better than myself... was there a review?
Eli reviewed the cha
Author: alexfh
Date: Fri Nov 2 08:03:43 2018
New Revision: 345979
URL: http://llvm.org/viewvc/llvm-project?rev=345979&view=rev
Log:
[clang-tidy] .reset(new X) -> make_unique() in a comment. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/utils/IncludeInserter.h
Modified: clang-tools-extra/
> On 2 Nov 2018, at 15:03, Tim Northover wrote:
>> (If the do belong here: the namespaces and comments don't seem to have been
>> updated)
>
> Good point, I’ll get onto fixing that.
Actually, do you have any particular ones in mind? After going in to make
changes, they still look pretty good
TWeaver created this revision.
TWeaver added a reviewer: sammccall.
Herald added subscribers: llvm-commits, xazax.hun.
r345961 introduced a path check in
.\tools\clang\tools\extra\test\clang-tidy\clang-tidy-run-with-database.cpp.
r345961 added a check line for a path that only handled / on unix
Author: abataev
Date: Fri Nov 2 08:25:06 2018
New Revision: 345982
URL: http://llvm.org/viewvc/llvm-project?rev=345982&view=rev
Log:
[OPENMP]Change the mapping type for lambda captures.
The previously used combination `PTR_AND_OBJ | PRIVATE` could be used for
mapping of some data in Fortran. Ch
On Fri, Nov 2, 2018 at 4:08 PM Tim Northover wrote:
> After that it was discovered OSLog depends on the other format helpers so
> there was still a circular dependency; I decided adding the others was a
> minor enough change to just go ahead.
>
Thanks - I missed the review.
> On 2 Nov 2018, at 1
TWeaver added a comment.
The test failed on the following build bot:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/21169
Repository:
rL LLVM
https://reviews.llvm.org/D54036
___
cfe-commits mailing list
Hi Tom, Sorry for missing this (too many email accounts).
And thank you for the fix!
On Fri, Nov 2, 2018 at 1:04 PM Tom Weaver wrote:
> Hiya Sam,
>
> are you aware that r345961 caused a test failure on the following bot and
> build
>
>
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-sc
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thank you!
`{{.*}}not-exist` also seems fine, up to you.
Repository:
rL LLVM
https://reviews.llvm.org/D54036
___
cfe-commits mailing li
Author: alexfh
Date: Fri Nov 2 08:29:37 2018
New Revision: 345984
URL: http://llvm.org/viewvc/llvm-project?rev=345984&view=rev
Log:
[clang-tidy] Fixed code sample in a comment. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/utils/IncludeInserter.h
Modified: clang-tools-extra/trunk/clang-t
TWeaver added a comment.
I'm happy as is.
thanks for the review.
Repository:
rL LLVM
https://reviews.llvm.org/D54036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D54010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
TWeaver added a comment.
Oh, I don't have commit access, are you able to commit for me Sam?
Thanks
Repository:
rL LLVM
https://reviews.llvm.org/D54036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: szelethus
Date: Fri Nov 2 08:48:10 2018
New Revision: 345985
URL: http://llvm.org/viewvc/llvm-project?rev=345985&view=rev
Log:
[analyzer][NFC] Fix some incorrect uses of -analyzer-config options
I'm in the process of refactoring AnalyzerOptions. The main motivation behind
here is to emit
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345985: [analyzer][NFC] Fix some incorrect uses of
-analyzer-config options (authored by Szelethus, committed by ).
Chang
Author: szelethus
Date: Fri Nov 2 08:50:44 2018
New Revision: 345986
URL: http://llvm.org/viewvc/llvm-project?rev=345986&view=rev
Log:
[analyzer][NFC] Collect all -analyzer-config options in a .def file
I'm in the process of refactoring AnalyzerOptions. The main motivation behind
here is to emit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345986: [analyzer][NFC] Collect all -analyzer-config options
in a .def file (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
filcab updated this revision to Diff 172376.
filcab added a comment.
Reworded with feedback from the review.
Repository:
rC Clang
https://reviews.llvm.org/D52615
Files:
docs/ClangCommandLineReference.rst
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Driver/Saniti
Author: szelethus
Date: Fri Nov 2 08:59:37 2018
New Revision: 345989
URL: http://llvm.org/viewvc/llvm-project?rev=345989&view=rev
Log:
[analyzer] New flag to print all -analyzer-config options
A new -cc1 flag is avaible for the said purpose: -analyzer-config-help
Differential Revision: https://
This revision was automatically updated to reflect the committed changes.
Szelethus marked an inline comment as done.
Closed by commit rC345989: [analyzer] New flag to print all -analyzer-config
options (authored by Szelethus, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D5
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345989: [analyzer] New flag to print all -analyzer-config
options (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5329
Author: szelethus
Date: Fri Nov 2 09:02:10 2018
New Revision: 345990
URL: http://llvm.org/viewvc/llvm-project?rev=345990&view=rev
Log:
[analyzer] Put llvm.Conventions back in alpha
Interestingly, this many year old (when I last looked I remember 2010ish)
checker was committed without any tests,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345990: [analyzer] Put llvm.Conventions back in alpha
(authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53856?vs=172253&
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345990: [analyzer] Put llvm.Conventions back in alpha
(authored by Szelethus, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53856?vs=172253&id=172380#toc
Repository:
rC Clang
ht
Author: abataev
Date: Fri Nov 2 09:08:31 2018
New Revision: 345991
URL: http://llvm.org/viewvc/llvm-project?rev=345991&view=rev
Log:
[OPENMP][NVPTX]Use __kmpc_data_sharing_coalesced_push_stack function.
Coalesced memory access requires use of the new function
`__kmpc_data_sharing_coalesced_push_
Author: maskray
Date: Fri Nov 2 09:23:37 2018
New Revision: 345992
URL: http://llvm.org/viewvc/llvm-project?rev=345992&view=rev
Log:
[analyzer] Fix diagnostics/explicit-suppression.cpp
*OI++ = *II++ is on line 670, not 668
Modified:
cfe/trunk/test/Analysis/diagnostics/explicit-suppression.c
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
The patch is good to go!
Please add the commit reference to `utils/benchmark/README.LLVM`
(https://github.com/google/benchmark/commit/a9b31c51b1ee7ec7b31438c647123c2cbac5d956)
and the pat
Author: szelethus
Date: Fri Nov 2 09:32:15 2018
New Revision: 345993
URL: http://llvm.org/viewvc/llvm-project?rev=345993&view=rev
Log:
Didn't -> didnt, because #errors complains about untermianted '
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
Modified: cfe/trun
Author: jonastoth
Date: Fri Nov 2 09:36:21 2018
New Revision: 345995
URL: http://llvm.org/viewvc/llvm-project?rev=345995&view=rev
Log:
[fix][clang-tidy] fix for r345961 that introduced a test failure on Windows
builds
r345961 introduced a path check in
.\tools\clang\tools\extra\test\clang-tidy\
JonasToth closed this revision.
JonasToth added a comment.
Thank you very much for the patch!
Committed in r345995.
Repository:
rL LLVM
https://reviews.llvm.org/D54036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
On 2 Nov 2018, at 15:28, Sam McCall wrote:
> In that case, I don't think it makes sense to think of the format string
> parser as part of the analyzer - as the build deps suggest, it's now part of
> AST and gets reused by analyzer. (Similar to how the analyzer uses other bits
> of AST/clang). I
ztamas added a comment.
Just to make it clear. I think this check is in a good shape now. I mean it
catches usefull issues and also does not produce too many false positives, as I
see.
So my intention here is to get it in as it is now (of course after I fixed
things reviewers find) and later it
Author: szelethus
Date: Fri Nov 2 10:00:07 2018
New Revision: 345997
URL: http://llvm.org/viewvc/llvm-project?rev=345997&view=rev
Log:
Remove the duplicated definition of size_t
So hopefully windows won't complain.
Modified:
cfe/trunk/test/Analysis/llvm-conventions.cpp
Modified: cfe/trunk/
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D52615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
On Fri, Nov 2, 2018 at 12:34 PM Kristof Umann via cfe-commits
wrote:
>
> Author: szelethus
> Date: Fri Nov 2 09:32:15 2018
> New Revision: 345993
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345993&view=rev
> Log:
> Didn't -> didnt, because #errors complains about untermianted '
Why not quot
eandrews added a comment.
Thanks!
https://reviews.llvm.org/D52998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: filcab
Date: Fri Nov 2 10:29:04 2018
New Revision: 346001
URL: http://llvm.org/viewvc/llvm-project?rev=346001&view=rev
Log:
Change -fsanitize-address-poison-class-member-array-new-cookie to
-fsanitize-address-poison-custom-array-cookie
Handle it in the driver and propagate it to cc1
Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346001: Change
-fsanitize-address-poison-class-member-array-new-cookie to -fsanitize…
(authored by filcab, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52615?vs=172376&id=172392#t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346001: Change
-fsanitize-address-poison-class-member-array-new-cookie to -fsanitize…
(authored by filcab, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
filcab added a comment.
Thanks for the review.
Unfortunately, I forgot to edit the commit message. Let's hope no one gets too
confused (phab reviews will be up anyway, so should be easy to figure out).
Filipe
Repository:
rL LLVM
https://reviews.llvm.org/D52615
Author: epilk
Date: Fri Nov 2 10:36:58 2018
New Revision: 346004
URL: http://llvm.org/viewvc/llvm-project?rev=346004&view=rev
Log:
[CodeGen] Fix a crash when updating a designated initializer
We need to handle the ConstantAggregateZero case here too.
rdar://45691981
Differential revision: http
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346004: [CodeGen] Fix a crash when updating a designated
initializer (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54010?vs=172306&id=172396#toc
Repository:
r
whisperity added inline comments.
Comment at: docs/clang-tidy/checks/bugprone-too-small-loop-variable.rst:18
+This for loop is an infinite loop because the short type can't represent all
+values in the [0..size] interval.
+
Format the interval as code (monospace)
Author: tstellar
Date: Fri Nov 2 11:09:42 2018
New Revision: 346022
URL: http://llvm.org/viewvc/llvm-project?rev=346022&view=rev
Log:
Creating release candidate rc2 from release_701 branch
Added:
libunwind/tags/RELEASE_701/rc2/ (props changed)
- copied from r346021, libunwind/branche
mgrang accepted this revision.
mgrang added a comment.
This revision is now accepted and ready to land.
Since this is the same as https://reviews.llvm.org/D53684, we can go ahead and
close this.
Repository:
rC Clang
https://reviews.llvm.org/D53998
_
Author: mgrang
Date: Fri Nov 2 11:10:07 2018
New Revision: 346024
URL: http://llvm.org/viewvc/llvm-project?rev=346024&view=rev
Log:
[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry
Summary: ARM64 setjmp expects sp on entry instead of framepointer.
Patch by: Yin Ma (yi.
astrelni updated this revision to Diff 172402.
astrelni added a comment.
Herald added a subscriber: mgrang.
Updated filtering of template instantiations to not use potentially costly
hasDescendent matcher.
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-
1 - 100 of 177 matches
Mail list logo
