phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: cfe-commits, mgorny.
This allows building Linux runtimes on any platform if the correct
sysroot is provided via CMake option.
Repository:
rC Clang
https://reviews.llvm.org/D53970
Files:
clang/cmake/c
hans added a comment.
Thank you Takuto! I think the functionality looks great now: it's not too
complicated :-)
I only have comments about the test.
Comment at: clang/test/CodeGenCXX/dllexport-no-dllexport-inlines.cpp:3
+// RUN: -fno-dllexport-inlines -emit-llvm -O0 -o -
Author: lebedevri
Date: Thu Nov 1 01:56:51 2018
New Revision: 345816
URL: http://llvm.org/viewvc/llvm-project?rev=345816&view=rev
Log:
[clang][CodeGen] ImplicitIntegerSignChangeSanitizer: actually ignore NOP casts.
I fully expected for that to be handled by the canonical type check,
but it clear
On Thu, Nov 1, 2018 at 9:39 AM Roman Lebedev wrote:
>
> On Thu, Nov 1, 2018 at 3:03 AM Friedman, Eli wrote:
> >
> > On 10/30/2018 2:58 PM, Roman Lebedev via cfe-commits wrote:
> > > Author: lebedevri
> > > Date: Tue Oct 30 14:58:56 2018
> > > New Revision: 345660
> > >
> > > URL: http://llvm.org/
nik added a comment.
I've only the minimal example at hand right know - I'm waiting for feedback
about the real world case.
Repository:
rC Clang
https://reviews.llvm.org/D53866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
steveire added inline comments.
Comment at: clang-tidy/ClangTidy.h:11
+//
+// It should remain as stable as possible, as many out-of-tree checks exist.
+//===--===//
alexfh wrote:
> sammccall wro
lebedev.ri added inline comments.
Comment at: clang-tidy/ClangTidy.h:11
+//
+// It should remain as stable as possible, as many out-of-tree checks exist.
+//===--===//
steveire wrote:
> alexfh wr
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D52998#1258962, @eandrews wrote:
> Yes. I understand. At the moment, exception handling flags are generated
> based on `BENCHMARK_ENABLE_EXCEPTIONS` in `utils/
mantognini accepted this revision.
mantognini added a comment.
This revision is now accepted and ready to land.
LGTM, but please add a comment in the test file.
Comment at: test/SemaOpenCL/clk_event_t.cl:3
+#define CLK_NULL_EVENT (__builtin_astype(((void*)(__SIZE_MAX__)), clk
martong added a comment.
Herald added a reviewer: shafik.
Shafik,
Sorry for the inconvenience.
Seems like the libcxx tests of lldb are automatically skipped on Linux, so it
slipped through my test execution.
Also, I did not receive any email from this build server about the build
failure. Never
MTC added a comment.
Sorry for the long delay for this patch! The implementation is fine for me.
However, I'm the newbie on clang diagnostics and have no further insight into
this checker. @aaron.ballman may have more valuable insights into this checker.
Comment at: test/Sema
kadircet added inline comments.
Comment at: clangd/index/Background.cpp:194
- // FIXME: partition the symbols by file rather than TU, to avoid duplication.
- IndexedSymbols.update(AbsolutePath,
-llvm::make_unique(std::move(Symbols)),
sam
sylvestre.ledru added a comment.
@johannes Someone asked for that in Debian:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907269
Repository:
rL LLVM
https://reviews.llvm.org/D34329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
grimar added a comment.
Nice :)
So seems the last unresolved question left is the naming of the new option?
If we do not want to go with `-gsingle-file-split-dwarf` then what it should be?
What about `-fdebug-fission` as an alias for `-gsplit-dwarf`.
And `-fsingle-file-debug-fission` for the new
Author: aaronballman
Date: Thu Nov 1 04:52:07 2018
New Revision: 345823
URL: http://llvm.org/viewvc/llvm-project?rev=345823&view=rev
Log:
Update to the 10-10 SARIF spec.
This removes the Step property (which can be calculated by consumers
trivially), and updates the schema and version numbers a
Anastasia updated this revision to Diff 172109.
Anastasia added a comment.
Addressed comments from John.
https://reviews.llvm.org/D53764
Files:
include/clang/Sema/Sema.h
lib/AST/Expr.cpp
lib/CodeGen/CGExpr.cpp
lib/Sema/DeclSpec.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExprCXX.cpp
li
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345825: Allow clk_event_t comparisons (authored by svenvh,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53871?vs=171711&id=172110#toc
Repository:
rC Clang
https://reviews.llvm.
Author: svenvh
Date: Thu Nov 1 05:43:00 2018
New Revision: 345825
URL: http://llvm.org/viewvc/llvm-project?rev=345825&view=rev
Log:
Allow clk_event_t comparisons
Also rename `invalid-clk-events-cl2.0.cl` to `clk_event_t.cl` and
repurpose it to include both positive and negative clk_event_t tests
Author: erichkeane
Date: Thu Nov 1 05:50:37 2018
New Revision: 345826
URL: http://llvm.org/viewvc/llvm-project?rev=345826&view=rev
Log:
CPU-Dispatch-- Fix conflict between 'generic' and 'pentium'
When a dispatch function was being emitted that had both a generic and a
pentium configuration liste
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:147
def : DiagGroup<"div-by-zero", [DivZero]>;
+def DivSizeofPtr : DiagGroup<"sizeof-pointer-div">;
Do you really need the explicit diagnostic group? Given that there's on
ztamas created this revision.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
The new checker searches for those for loops which has a loop variable
with a "too small" type which means this type can't represent all values
which are part of the iteration range.
For example:
int main() {
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
wuzish wrote:
> hubert.re
sammccall added inline comments.
Comment at: clangd/index/Background.cpp:194
- // FIXME: partition the symbols by file rather than TU, to avoid duplication.
- IndexedSymbols.update(AbsolutePath,
-llvm::make_unique(std::move(Symbols)),
ka
ztamas updated this revision to Diff 172113.
ztamas added a comment.
Add a description of the checker with examples to the documentation
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53974
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
ztamas added a comment.
Just a note. I run the new checker on LibreOffice project. I found ~25 false
positives, which seems small enough to me. This false positives can be
supressed easily.
Since the LibreOffice project has a similar check as a compiler plugin the code
was already cleaned up, h
lebedev.ri updated this revision to Diff 172115.
lebedev.ri edited the summary of this revision.
lebedev.ri added a subscriber: mclow.lists.
lebedev.ri added a comment.
Added test coverage.
Please review :)
Repository:
rC Clang
https://reviews.llvm.org/D53949
Files:
lib/CodeGen/CGExprScala
xbolva00 updated this revision to Diff 172117.
xbolva00 marked 5 inline comments as done.
https://reviews.llvm.org/D52949
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/div-sizeof-ptr.cpp
Index: test/Sema/div-sizeof-ptr.cpp
===
xbolva00 added a comment.
- Addressed review comments.
We match the GCC behaviour here, except the case:
int b1 = sizeof(int *) / sizeof(int);
But I think it is ok now.
Comment at: lib/Sema/SemaExpr.cpp:8729
+static void DiagnoseDivisionSizeofPointer(Sema &S, Expr *LHS, Exp
Author: tnorthover
Date: Thu Nov 1 06:49:54 2018
New Revision: 345828
URL: http://llvm.org/viewvc/llvm-project?rev=345828&view=rev
Log:
Logging: make os_log buffer size an integer constant expression.
The size of an os_log buffer is known at any stage of compilation, so making it
a constant expr
ZaMaZaN4iK added a comment.
Hmm, i thought Clang has some warning for this, but I was wrong... Did you
think to implement this check as Clang warning?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53974
___
cfe-commits mailing lis
ZaMaZaN4iK added a comment.
Which other changes and/or approvals are required for merging into trunk?
https://reviews.llvm.org/D33672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tnorthover
Date: Thu Nov 1 07:22:20 2018
New Revision: 345833
URL: http://llvm.org/viewvc/llvm-project?rev=345833&view=rev
Log:
Logging: add CMake dependency so libAST can use OSLog analysis.
Should fix bots on platforms with slightly different symbol resolution
semantics.
Modified:
aaron.ballman added a comment.
In https://reviews.llvm.org/D33672#1283778, @ZaMaZaN4iK wrote:
> Which other changes and/or approvals are required for merging into trunk?
There's one unresolved comment from earlier and a few very minor nits that I
found, but I think this is ready to land otherw
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp:26
+
+
+/// \brief The matcher for loops with suspicious integer loop variable.
Please remove unnecessary empty line.
Comment at: clang-tidy/bug
xbolva00 added a comment.
maybe @aaron.ballman wants to take a look too
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added inline comments.
Comment at: clang/include/clang/Driver/CLCompatOptions.td:336
HelpText<"Disable precompiled headers, overrides /Yc and /Yu">;
+def _SLASH_Zc_dllexportInlines : CLFlag<"Zc:dllexportInlines">;
+def _SLASH_Zc_dllexportInlines_ : CLFlag<"Zc:dllexportInl
joey updated this revision to Diff 172122.
joey added a comment.
I re-worked where the builtins are actually inserted, now it's in a similar
place to the "normal" clang builtins.
I addressed the issue of putting the return type also into the args type (could
rename this to signature/proto table
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a minor formatting nit.
Comment at: lib/Sema/SemaExpr.cpp:8729
+static void DiagnoseDivisionSizeofPointer(Sema &S, Expr *LHS, Expr *RHS,
+
Author: tnorthover
Date: Thu Nov 1 07:43:35 2018
New Revision: 345835
URL: http://llvm.org/viewvc/llvm-project?rev=345835&view=rev
Log:
Logging: put link against libclangAnalysis rather than libLLVMAnalysis for
os_log
Modified:
cfe/trunk/lib/AST/CMakeLists.txt
Modified: cfe/trunk/lib/AST/C
sberg added a comment.
> I run the new checker on LibreOffice project. I found ~25 false positives,
> which seems small enough to me. This false positives can be supressed easily.
Do you have a link to such a false positive and how it got suppressed in the
LibreOffice code base? (If those are
ztamas added a comment.
In https://reviews.llvm.org/D53974#1283833, @sberg wrote:
> > I run the new checker on LibreOffice project. I found ~25 false positives,
> > which seems small enough to me. This false positives can be supressed
> > easily.
>
> Do you have a link to such a false positive
ABataev accepted this revision.
ABataev added a comment.
LG
Repository:
rOMP OpenMP
https://reviews.llvm.org/D53141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jrmuizel added a comment.
Review ping
Repository:
rC Clang
https://reviews.llvm.org/D50318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erichkeane
Date: Thu Nov 1 08:11:43 2018
New Revision: 345839
URL: http://llvm.org/viewvc/llvm-project?rev=345839&view=rev
Log:
Multiversioning- Ensure all MV functions are emitted.
Multiverson function versions are always used (by the resolver), so ensure that
they are always emitted.
Author: erichkeane
Date: Thu Nov 1 08:11:41 2018
New Revision: 345838
URL: http://llvm.org/viewvc/llvm-project?rev=345838&view=rev
Log:
CPU-Dispatch- Fix type of a member function, prevent deferrals
The member type creation for a cpu-dispatch function was not correctly
including the 'this' param
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a few small nits.
Comment at: lib/Parse/ParseDecl.cpp:1005
+if (Keyword == Ident_deprecated && Platform->Ident &&
+Platform->Ident->
ebevhan added a comment.
In https://reviews.llvm.org/D53738#1283459, @rjmccall wrote:
> Well, it could be passed around through most code as some sort of
> abstractly-represented intermediate "type" which could be either a QualType
> or a fixed-point semantics.
Sounds to me like you're descri
ztamas added a comment.
In https://reviews.llvm.org/D53974#1283759, @ZaMaZaN4iK wrote:
> Hmm, i thought Clang has some warning for this, but I was wrong... Did you
> think to implement this check as Clang warning?
It did not come in my mind to do that. It might be good idea, I guess. This
ver
regehr added a comment.
Regarding ++ and --, I think for now it's fine to just document that these
aren't instrumented.
Repository:
rC Clang
https://reviews.llvm.org/D53949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
xazax.hun created this revision.
xazax.hun added reviewers: NoQ, george.karpenkov, Szelethus, martong.
Herald added subscribers: dkrupp, donat.nagy, arphaman, mikhail.ramalho,
a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity, mgorny.
Do not always return 0 to the OS. This will make it
xazax.hun updated this revision to Diff 172134.
xazax.hun added a reviewer: a.sidorin.
xazax.hun added a comment.
- Remove yet another dependency from the tool that is no longer used.
https://reviews.llvm.org/D53979
Files:
tools/clang-func-mapping/CMakeLists.txt
tools/clang-func-mapping/Cla
t.p.northover closed this revision.
t.p.northover added a comment.
Thanks Eli. I committed it as r345828, and then had to fixup some linker
dependencies on other platforms, which took me a couple of tries (r345833 and
r345835).
Repository:
rC Clang
https://reviews.llvm.org/D53514
___
ztamas added a comment.
In https://reviews.llvm.org/D53974#1283833, @sberg wrote:
> > I run the new checker on LibreOffice project. I found ~25 false positives,
> > which seems small enough to me. This false positives can be supressed
> > easily.
>
> Do you have a link to such a false positive
aaron.ballman added a comment.
@rsmith -- any thoughts on this before I commit?
https://reviews.llvm.org/D52421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Ping
https://reviews.llvm.org/D53700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345844: [clang] Improve ctor initializer completions.
(authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53654?vs=171926&id=172140#toc
Repository:
rC Clang
htt
Author: kadircet
Date: Thu Nov 1 08:54:18 2018
New Revision: 345844
URL: http://llvm.org/viewvc/llvm-project?rev=345844&view=rev
Log:
[clang] Improve ctor initializer completions.
Summary:
Instead of providing generic "args" for member and base class
initializers, tries to fetch relevant constru
mclow.lists added a comment.
I hate this chunk of code. :-(
`TEST_HAS_C11_FEATURES` basically means that we can use C11 library features
like `aligned_alloc`, and `timespec` etc.
Repository:
rCXX libc++
https://reviews.llvm.org/D53956
___
cfe-co
This doesn't work. AST cannot depend on Analysis because Analysis already
depends on AST.
On Thu, Nov 1, 2018 at 3:24 PM Tim Northover via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: tnorthover
> Date: Thu Nov 1 07:22:20 2018
> New Revision: 345833
>
> URL: http://llvm.org/viewvc/
kadircet added inline comments.
Comment at: clangd/index/Background.cpp:235
+IndexedFileDigests[Path] = FilesToUpdate.lookup(Path);
+IndexedSymbols.update(Path,
+ make_unique(std::move(Syms).build()),
This call is already thread-s
Rakete updated this revision to Diff 172146.
Rakete marked 6 inline comments as done.
Rakete added a comment.
Addressed review comments! :)
Repository:
rC Clang
https://reviews.llvm.org/D53847
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Parse/Parser.h
in
Author: tnorthover
Date: Thu Nov 1 09:15:24 2018
New Revision: 345846
URL: http://llvm.org/viewvc/llvm-project?rev=345846&view=rev
Log:
Revert "Logging: make os_log buffer size an integer constant expression.
This also reverts a couple of follow-up commits trying to fix the
dependency issues. La
Oh bother, I vaguely remember that means I’ll have broken .so builds now?
Either way, I’ve reverted the sequence in r345846. I’ll work on putting the
os_log machinery into AST and update the review.
Thanks for looking out!
Tim.
> On 1 Nov 2018, at 16:05, Benjamin Kramer wrote:
>
> This doesn
Rakete marked 7 inline comments as done.
Rakete added inline comments.
Comment at: lib/Parse/Parser.cpp:1778
+/*IsClassTemplateDeductionContext*/true,
+/*AllowImplicitTypename*/false)) {
SourceLocation BeginLoc = Tok.getLocation();
-
Rakete updated this revision to Diff 172147.
Rakete marked an inline comment as done.
Rakete added a comment.
Remove spaces to be consistent.
Repository:
rC Clang
https://reviews.llvm.org/D53847
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Parse/Parser.h
rjmccall added a comment.
In https://reviews.llvm.org/D53738#1283861, @ebevhan wrote:
> In https://reviews.llvm.org/D53738#1283459, @rjmccall wrote:
>
> > Well, it could be passed around through most code as some sort of
> > abstractly-represented intermediate "type" which could be either a Qual
Author: xbolva00
Date: Thu Nov 1 09:26:10 2018
New Revision: 345847
URL: http://llvm.org/viewvc/llvm-project?rev=345847&view=rev
Log:
[Diagnostics] Implement -Wsizeof-pointer-div
Summary:
void test(int *arr) {
int arr_len = sizeof(arr) / sizeof(*arr); // warn, incorrect way to
compute num
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345847: [Diagnostics] Implement -Wsizeof-pointer-div
(authored by xbolva00, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52949?vs=172117&i
aaron.ballman created this revision.
aaron.ballman added reviewers: george.karpenkov, dcoughlin, zaks.anna.
SARIF allows you to export descriptions about rules that are present in the
SARIF log. This patch exposes the help text table generated into Checkers.inc
as the rule's "full description" a
rjmccall added inline comments.
Comment at: lib/AST/Expr.cpp:1609
case CK_AddressSpaceConversion:
-assert(getType()->isPointerType() || getType()->isBlockPointerType());
-assert(getSubExpr()->getType()->isPointerType() ||
- getSubExpr()->getType()->isBlockPoi
filcab updated this revision to Diff 172149.
filcab added a comment.
Expanded a bit more on the documentation, mentioning that user code might be
technically allowed to access those array cookies, but that users might not
want to allow it.
Repository:
rC Clang
https://reviews.llvm.org/D5261
JonasToth added a comment.
For general understanding: Couldn't this check be generalized to comparing
integers of different sizes? We tried a 'dont-mix-int-types' check for
arithmetic already, its complicated :)
But this as a specialization of the category could be done easier (i think).
What d
t.p.northover reopened this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Turns out I neglected the layering between libclangAST and libclangAnalysis so
I've reverted for now. For this to work I think we need to move the OSLog
helpers into libclangAST.
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Looks good to me. It is great to see that we can get rid of so many header and
lib dependencies.
https://reviews.llvm.org/D53979
___
cfe-commi
xbolva00 added a comment.
Since I don't think we have any false positives here, maybe it would be useful
to add it to -Wall or -Wextra?
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Minor nit: let's create a custom substitution for your diff command, like
`diff_plist`.
Otherwise LGTM.
Comment at: test/Analysis/diagnostics/s
t.p.northover updated this revision to Diff 172155.
t.p.northover added a comment.
Herald added a subscriber: mgorny.
Same as previous patch except the OSLog helpers are moved to libclangAST to
respect dependencies.
Repository:
rC Clang
https://reviews.llvm.org/D53514
Files:
clang/include
ztamas added a comment.
In https://reviews.llvm.org/D53974#1284000, @JonasToth wrote:
> For general understanding: Couldn't this check be generalized to comparing
> integers of different sizes? We tried a 'dont-mix-int-types' check for
> arithmetic already, its complicated :)
> But this as a s
abeserminji created this revision.
abeserminji added reviewers: atanasyan, smaksimovic, petarj, mstojanovic.
Herald added subscribers: jrtc27, arichardson.
Test //builtins-mips-msa-error.c// wasn't reporting errors.
This patch fixes the test, so further test cases can be added.
Repository:
rC
ebevhan added a comment.
In https://reviews.llvm.org/D53738#1283983, @rjmccall wrote:
> In https://reviews.llvm.org/D53738#1283861, @ebevhan wrote:
>
> > In https://reviews.llvm.org/D53738#1283459, @rjmccall wrote:
> >
> > > Well, it could be passed around through most code as some sort of
> > >
Szelethus accepted this revision.
Szelethus added a comment.
Makes sense!
https://reviews.llvm.org/D53979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shafik added a comment.
@martong Hello, if I look at the specific test that was failing
`TestDataFormatterLibcxxVector.py` it only has the following decorator
`@add_test_categories(["libc++"])` so that should not prevent it from running
on Linux if you are also building libc++. If you do a loca
probinson added a comment.
In https://reviews.llvm.org/D52296#1283691, @grimar wrote:
> Nice :)
> So seems the last unresolved question left is the naming of the new option?
> If we do not want to go with `-gsingle-file-split-dwarf` then what it should
> be?
>
> What about `-fdebug-fission` a
Wizard updated this revision to Diff 172169.
Wizard added a comment.
Format code.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53955
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
test/clang-tidy/objc-property-declaration.m
Index: test/clang-tidy/objc-property-decla
Wizard updated this revision to Diff 172172.
Wizard added a comment.
format change
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53955
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
test/clang-tidy/objc-property-declaration.m
Index: test/clang-tidy/objc-property-dec
eandrews updated this revision to Diff 172171.
eandrews added a comment.
@kbobyrev I apologize if I was unclear in the comments. I was asking if the
changes proposed in the comments are alright with you since they would involve
modifying `benchmark/CMakelists.txt` (instead of `llvm/CMakeLists.t
Author: wizard
Date: Thu Nov 1 10:36:18 2018
New Revision: 345858
URL: http://llvm.org/viewvc/llvm-project?rev=345858&view=rev
Log:
Fix the issue that not recognizing single acronym with prefix as ObjC property
name.
Summary: This will make clang-tidy accept property names like xyz_URL (URL is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345858: Fix the issue that not recognizing single acronym
with prefix as ObjC property… (authored by Wizard, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews
rnk created this revision.
rnk added reviewers: EricWF, ldionne.
Herald added subscribers: erik.pilkington, christof.
This silences the two -Wimplicit-fallthrough warnings clang finds in
ItaniumDemangle.h in libc++abi.
Clang does not have a GNU attribute spelling for this attribute, so this
is ne
efriedma accepted this revision.
efriedma added a comment.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Would it make sense to add the GNU spelling to the attribute in Clang?
https://reviews.llvm.org/D53985
___
cfe-commits mailing list
cfe-commits
Author: rnk
Date: Thu Nov 1 10:51:48 2018
New Revision: 345862
URL: http://llvm.org/viewvc/llvm-project?rev=345862&view=rev
Log:
Replace two fallthrough annotations after covered switch with unreachable
Both preceding switches handle all possible enumerators, so the
fallthrough is actually unrea
keryell added a comment.
In https://reviews.llvm.org/D53705#1281743, @rjmccall wrote:
>
> New versions of C++ have semi-regularly added keywords like `static_assert`
> and `thread_local` that are not in the reserved space for identifiers. When
> C adopted these, it spelled them `_Static_as
kbobyrev requested changes to this revision.
kbobyrev added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D52998#1284146, @eandrews wrote:
> @kbobyrev I apologize if I was unclear in the comments. I was asking if the
> changes proposed in the comments are
filcab updated this revision to Diff 172179.
filcab added a comment.
Expand yet a bit more.
Repository:
rC Clang
https://reviews.llvm.org/D52615
Files:
docs/ClangCommandLineReference.rst
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
inclu
rjmccall added a comment.
>> 1. You would have an inconsistency in either case, since e.g. numeric +
>> otherwise always returns the same type as its operands, but this would not.
>
> True, but the CompoundAssignOperator already has that inconsistency with
> ComputationResultType.
Right, but i
tejohnson updated this revision to Diff 172181.
tejohnson added a comment.
Address comments:
Promote -flto-unit to clang driver option (and test it)
Adjust LTOVisibility.rst to reflect change of default and new option.
Repository:
rC Clang
https://reviews.llvm.org/D53524
Files:
docs/LTOVis
Author: tnorthover
Date: Thu Nov 1 11:04:49 2018
New Revision: 345866
URL: http://llvm.org/viewvc/llvm-project?rev=345866&view=rev
Log:
Reapply Logging: make os_log buffer size an integer constant expression.
The size of an os_log buffer is known at any stage of compilation, so making it
a const
This revision was automatically updated to reflect the committed changes.
Closed by commit rOMP345867: [OpenMP][libomptarget] Add runtime function for
pushing coalesced global records (authored by gbercea, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53141?vs=172007&id=172
rsmith added inline comments.
Comment at: test/SemaCXX/unknown-type-name.cpp:50
template
-void f(T::type) { } // expected-error{{missing 'typename'}}
+void f(T::type) { } // expected-warning {{implicit 'typename' is a C++2a
extension}}
Rakete wrote:
> rsm
1 - 100 of 192 matches
Mail list logo
