lebedev.ri added a comment.
In https://reviews.llvm.org/D53949#1282861, @regehr wrote:
> I can test this and write a few test cases.
I'll write the tests tomorrow, i just wanted to post the initial code diff.
(it is a shame that there isn't any working analog of
llvm/utils/update_test_checks.p
regehr added a comment.
This patch doesn't appear to yet fix the "x++" or "x--" cases.
Repository:
rC Clang
https://reviews.llvm.org/D53949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
lebedev.ri added a comment.
In https://reviews.llvm.org/D53949#1282866, @regehr wrote:
> This patch doesn't appear to yet fix the "x++" or "x--" cases.
It won't, the increment/decrement happens on the original type, there is no
cast there. https://godbolt.org/z/WuWA62
Those cases are for norma
lebedev.ri added a comment.
In https://reviews.llvm.org/D53949#1282870, @lebedev.ri wrote:
> In https://reviews.llvm.org/D53949#1282866, @regehr wrote:
>
> > This patch doesn't appear to yet fix the "x++" or "x--" cases.
>
>
> It won't, the increment/decrement happens on the original type, there
regehr added a comment.
I do not agree that ++ is performed on the original type. The C99 standard
(6.5.3.1.2) appears to be very clear on this point: "The expression ++E is
equivalent to (E+=1)."
Repository:
rC Clang
https://reviews.llvm.org/D53949
__
lebedev.ri added a comment.
In https://reviews.llvm.org/D53949#1282884, @regehr wrote:
> I do not agree that ++ is performed on the original type.
I was only talking about the IR.
In https://reviews.llvm.org/D53949#1282884, @regehr wrote:
> The C99 standard (6.5.3.1.2) appears to be very clea
rnk added a comment.
In https://reviews.llvm.org/D53541#1282764, @mgrang wrote:
> Updated the patch with the following changes:
>
> 1. Emit llvm.x86.seh.recoverfp only for non-aarch64 targets. For aarch64
> windows, the parent fp is always passed in x1. So we don't need a separate
> instrinsic
Author: efriedma
Date: Wed Oct 31 14:31:09 2018
New Revision: 345779
URL: http://llvm.org/viewvc/llvm-project?rev=345779&view=rev
Log:
[ARM64] [Windows] Implement _InterlockedExchangeAdd*_* builtins.
These apparently need to be proper builtins to handle the Windows
SDK.
Differential Revision: ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345779: [ARM64] [Windows] Implement
_InterlockedExchangeAdd*_* builtins. (authored by efriedma, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53916
Files:
include/clang/Basic/Builti
rsmith added a comment.
> In https://reviews.llvm.org/D53949#1282884, @regehr wrote:
>
>> The C99 standard (6.5.3.1.2) appears to be very clear on this point: "The
>> expression ++E is equivalent to (E+=1)."
>
>
> That is clearly not what clang is doing here.
How so? E += 1 is equivalent to E
Author: efriedma
Date: Wed Oct 31 14:39:41 2018
New Revision: 345781
URL: http://llvm.org/viewvc/llvm-project?rev=345781&view=rev
Log:
[AArch64] [Windows] Emit unwind tables by default.
Unwind tables are necessary even in code that doesn't support
exceptions. The tables are used for setjmp(), an
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345781: [AArch64] [Windows] Emit unwind tables by default.
(authored by efriedma, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53618?vs=170767&id=172024#toc
Repository:
rC Clang
rnk added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:9552
+// overwrite linkage of explicit template instantiation
+// definition/declaration.
+return GVA_DiscardableODR;
takuto.ikuta wrote:
> hans wrote:
> > takuto.ikuta wrote:
> > > h
mcgrathr added a comment.
In https://reviews.llvm.org/D53787#1279899, @rsmith wrote:
> Replacing the global new and delete is supposed to be a whole-program
> operation (you only get one global allocator). Otherwise you couldn't
> allocate memory in one DSO and deallocate it in another. (And no
rnk added inline comments.
Comment at: clang/include/clang/Basic/LangOptions.h:246
+ /// If set, dllexported classes dllexport their inline methods.
+ bool DllExportInlines = true;
+
We should define this in the LangOptions.def file.
https://reviews.llvm.org/
rupprecht created this revision.
rupprecht added a reviewer: krasimir.
Herald added subscribers: cfe-commits, mgorny.
Herald added a reviewer: alexshap.
clang-format can get confused by string literals in TableGen -- e.g. try
`clang-format tools/llvm-objcopy/ObjcopyOpts.td`; the multiline string
efriedma added a comment.
With both 3.3 and trunk (I don't have a 7.0 handy; I can build it if it would
be helpful):
movaps .LCPI0_0(%rip), %xmm0 # xmm0 = [48,49,50,51]
movaps .LCPI0_1(%rip), %xmm1 # xmm1 = [52,53,54,55]
movaps .LCPI0_2(%rip), %xmm2 # xmm2 = [56,57,97,98]
movaps
shafik added a comment.
I reverted this commit since it caused a regression in the lldb test suite,
specifically TestDataFormatterLibcxxVector.py.
See the logs here
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/12003/
Please monitor the lldb built bots when modifying ASTImporter.
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, xazax.hun.
Currently ClangTidyContext::diag() sends the diagnostics to a
DiagnosticsEngine, which probably delegates to a ClangTidyDiagnosticsConsumer,
which is supposed to go back and popul
yinma updated this revision to Diff 172033.
https://reviews.llvm.org/D53684
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-setjmp.c
Index: test/CodeGen/ms-setjmp.c
===
--- test/CodeGen/ms-setjmp.c
+++ test/CodeGen/ms-setjmp.c
rsmith added a comment.
In https://reviews.llvm.org/D53787#1282930, @mcgrathr wrote:
> In https://reviews.llvm.org/D53787#1279899, @rsmith wrote:
>
> > Replacing the global new and delete is supposed to be a whole-program
> > operation (you only get one global allocator). Otherwise you couldn't
sammccall added a comment.
@hokein @alexfh There is a test that asserts clang-tidy exits with 0 when
processing a nonexistent file (test added in https://reviews.llvm.org/D17335
which you wrote/reviewed).
This seems like a bug to me, do I need to preserve this behavior? (See patch
description f
hjl.tools added a comment.
In https://reviews.llvm.org/D53919#1282952, @efriedma wrote:
> With both 3.3 and trunk (I don't have a 7.0 handy; I can build it if it would
> be helpful):
Please try clang 2.6 on both testcases.
Repository:
rC Clang
https://reviews.llvm.org/D53919
__
mcgrathr added a comment.
In https://reviews.llvm.org/D53787#1282975, @rsmith wrote:
> These symbols really are special. Other symbols are introduced explicitly by
> a declaration, whereas these are declared implicitly by the compiler.
The implicit declaration is the only difference that actua
astrelni added inline comments.
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:151-152
+ const auto *ArgExpr = Result.Nodes.getNodeAs("arg");
+ llvm::StringRef Message = "perform explicit cast on expression getting "
+"implicitly c
alexfh added a comment.
LG in general.
> The most natural implementation (ClangTidyDiagnosticsConsumer::take()
> finalizes diagnostics) causes a test failure:
> clang-tidy-run-with-database.cpp
> asserts that clang-tidy exits successfully when trying to process a file
> that doesn't exist.
>
sammccall added inline comments.
Comment at: unittests/clangd/ClangdTests.cpp:1037
+TEST(ClangdTests, AddDocumentTracksDiagnostics) {
+ // We have clients relying on the fact that the Context passed to addDocument
this tests a lot of things, and after 10 minut
Wizard created this revision.
Herald added subscribers: cfe-commits, jfb.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53955
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
test/clang-tidy/objc-property-declaration.m
Index: test/clang-tidy/objc-property-declaration.m
danalbert created this revision.
danalbert added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, ldionne, christof.
This fixes an regression when using bionic introduced in r345173.
I need to follow up and figure out what exactly is implied by
TEST_HAS_C11_FEATURES and see what the
alexfh added a comment.
> error: unable to handle compilation, expected exactly one compiler job in ''
> [clang-diagnostic-error]
> Suppressed 1 warnings (1 with check filters).
> Found compiler error(s).
That's preferred to the current behavior, but from a user perspective a more
descriptive
Author: shafik
Date: Wed Oct 31 14:53:15 2018
New Revision: 345784
URL: http://llvm.org/viewvc/llvm-project?rev=345784&view=rev
Log:
Revert "[ASTImporter][Structural Eq] Check for isBeingDefined"
This reverts commit r345760
because it caused an assertion in the lldb test suite. This is the log f
sammccall updated this revision to Diff 172039.
sammccall added a comment.
Remove backwards-compat behavior around ClangdDiagnosticConsumer::finish(),
it's presumably a bug
Update test to verify we fail but don't crash in that case.
auto -> real type
Repository:
rCTE Clang Tools Extra
https:
rsmith added a comment.
In https://reviews.llvm.org/D53787#1282995, @mcgrathr wrote:
> In https://reviews.llvm.org/D53787#1282975, @rsmith wrote:
>
> > Other symbols must have exactly one definition (modulo the permission for
> > duplicate identical definitions for some cases), but these ones ha
sammccall marked an inline comment as done.
sammccall added a comment.
Thanks Alex. @hokein, let me know if any concerns.
In https://reviews.llvm.org/D53953#1283044, @alexfh wrote:
> > error: unable to handle compilation, expected exactly one compiler job in
> > '' [clang-diagnostic-error]
> >
orivej updated this revision to Diff 172041.
orivej added a comment.
Herald added a subscriber: mgorny.
Use relative line offset.
Repository:
rC Clang
https://reviews.llvm.org/D53244
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/macros.c
tools/CMakeLists.txt
Index: to
orivej updated this revision to Diff 172042.
orivej added a comment.
Remove unrelated change.
Repository:
rC Clang
https://reviews.llvm.org/D53244
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/macros.c
Index: test/CoverageMapping/macros.c
===
alexfh added inline comments.
Comment at: clang-tidy/ClangTidy.h:11
+//
+// It should remain as stable as possible, as many out-of-tree checks exist.
+//===--===//
sammccall wrote:
> steveire wro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345792: [COFF, ARM64] Change setjmp for AArch64 Windows to
use Intrinsic.sponentry (authored by mgrang, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
Author: mgrang
Date: Wed Oct 31 16:17:36 2018
New Revision: 345792
URL: http://llvm.org/viewvc/llvm-project?rev=345792&view=rev
Log:
[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry
Summary: ARM64 setjmp expects sp on entry instead of framepointer.
Reviewers: mgrang, rn
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:259
+ std::vector Errors;
+ std::vector FinalizedErrors;
std::unique_ptr HeaderFilter;
--
vsapsai updated this revision to Diff 172046.
vsapsai added a comment.
- Switch to camelCase.
https://reviews.llvm.org/D53725
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/lib/CodeGen/CGExprScalar.cpp
clang/lib/CodeGen/CodeGenFunction.h
Index: clang/lib/CodeGen/CodeGenFunction.h
===
orivej added a comment.
https://reviews.llvm.org/D41921 was the last big change necessary to fix clang
crashes on code coverage, but without the fixup in this review clang crashes on
about 1.5 times more projects that I maintain than before. It seems useful to
include this in the 7.0.1 release.
rjmccall accepted this revision.
rjmccall added a comment.
Thanks. Still LGTM. :)
https://reviews.llvm.org/D53725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall updated this revision to Diff 172047.
sammccall added a comment.
Removed unused var
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53953
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagn
phosek updated this revision to Diff 172048.
phosek retitled this revision from "[Sema] Use proper visibility for global new
and delete declarations" to "[Sema] Provide
-fvisibility-global-new-delete-hidden option".
phosek edited the summary of this revision.
phosek added a comment.
Following th
sammccall marked an inline comment as done.
sammccall added a comment.
BTW, the missing "X doesn't exist" is because Tooling.cpp turns off driver
diagnostics for nonexistent files, because clang/driver wasn't VFS-aware... in
2011.
I'll send patches to fix this if there isn't too much fallout (Dr
vsapsai updated this revision to Diff 172049.
vsapsai added a comment.
- Rename `EmitConstant` to `emitScalarConstant`.
- Tweak comment to be explicitly about intended IR code, not about Obj-C++ code.
https://reviews.llvm.org/D53674
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/lib/CodeGen/CGEx
vsapsai updated this revision to Diff 172051.
vsapsai added a comment.
Exclude commits tracked in a different review.
https://reviews.llvm.org/D53674
Files:
clang/lib/CodeGen/CGObjC.cpp
clang/test/CodeGenObjCXX/arc-constexpr.mm
Index: clang/test/CodeGenObjCXX/arc-constexpr.mm
=
vsapsai added a comment.
Can you please check https://reviews.llvm.org/D53674 ? It builds on top of this
change and I plan to commit them together.
https://reviews.llvm.org/D53725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added a subscriber: cfe-commits.
This was disabled way back in 2011, in the dark times before Driver was
VFS-aware.
Also, make driver more VFS-aware :-)
This breaks one ClangTidy test (we improved the error message), wi
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Yay, thanks!
Comment at: clangd/index/Index.h:463
/// The global scope is "", a top level scope is "foo::", etc.
- /// FIXME: drop the special case for empty list,
alexfh added inline comments.
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:33-36
+ anyOf(hasAncestor(
+functionTemplateDecl(HasMatchingDependentDescendant)),
+hasAncestor(
+class
sammccall accepted this revision.
sammccall added inline comments.
Comment at: clangd/index/Background.cpp:194
- // FIXME: partition the symbols by file rather than TU, to avoid duplication.
- IndexedSymbols.update(AbsolutePath,
-llvm::make_unique(std::m
alexfh accepted this revision.
alexfh added a comment.
LG
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 10/30/2018 2:58 PM, Roman Lebedev via cfe-commits wrote:
Author: lebedevri
Date: Tue Oct 30 14:58:56 2018
New Revision: 345660
URL: http://llvm.org/viewvc/llvm-project?rev=345660&view=rev
Log:
[clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part
This is the second
sammccall updated this revision to Diff 172058.
sammccall added a comment.
Rethink comment about public API stability.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53936
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
mcgrathr added a comment.
In https://reviews.llvm.org/D53787#1283051, @rsmith wrote:
> In https://reviews.llvm.org/D53787#1282995, @mcgrathr wrote:
>
> > In https://reviews.llvm.org/D53787#1282975, @rsmith wrote:
> >
> > > Other symbols must have exactly one definition (modulo the permission for
sammccall added a comment.
Fair enough.
I think it's worth saying *something* here, as the stability of these API has
value and churning them has costs that far exceed (2 of magnitude?) the other
C++ APIs in clang-tidy. And out-of-tree dependencies are something I usually
want to be aware of wh
tlively updated this revision to Diff 172060.
tlively added a comment.
Herald added a subscriber: cfe-commits.
- Restore return types in names
Repository:
rC Clang
https://reviews.llvm.org/D53675
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/
tlively updated this revision to Diff 172061.
tlively added a comment.
- Restore return types in names
Repository:
rC Clang
https://reviews.llvm.org/D53724
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-wasm.c
Index: test/CodeGen/bu
mgrang created this revision.
mgrang added reviewers: rnk, mstorsjo, efriedma, TomTan.
Herald added subscribers: chrib, kristof.beyls, javed.absar.
Repository:
rC Clang
https://reviews.llvm.org/D53960
Files:
include/clang/Basic/BuiltinsAArch64.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/m
aheejin added a comment.
The commit here looks like replaced with that of
https://reviews.llvm.org/D53724.
Repository:
rC Clang
https://reviews.llvm.org/D53675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: dergachev
Date: Wed Oct 31 17:43:35 2018
New Revision: 345802
URL: http://llvm.org/viewvc/llvm-project?rev=345802&view=rev
Log:
[analyzer] pr39348: MallocChecker: Realize that sized delete isn't custom
delete.
MallocChecker no longer thinks that operator delete() that accepts the size of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345802: [analyzer] pr39348: MallocChecker: Realize that
sized delete isn't custom… (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Author: rsmith
Date: Wed Oct 31 17:46:54 2018
New Revision: 345803
URL: http://llvm.org/viewvc/llvm-project?rev=345803&view=rev
Log:
Fix regression in behavior of clang -x c++-header -fmodule-name=XXX
-fsyntax-only.
The driver accidentally stopped passing the input filenames on to -cc1
in this mo
tlively added inline comments.
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:587
+multiclass SIMDSelectPat {
aheejin wrote:
> Why do we need this pattern? Can't we also expand `SELECT` as we did for
> `SELECT_CC` and `VSELECT`?
It looks like the e
tlively updated this revision to Diff 172072.
tlively added a comment.
- Wrap comments at col 80. Restore proper revision contents.
Repository:
rL LLVM
https://reviews.llvm.org/D53675
Files:
lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53960
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Comment inline (Outlook handles quoting terribly, so I'm not sure how much
it'll end up standing out, but I believe you typo'd "preprocessor" as "
prepreocssor").
From: cfe-commits on behalf of Richard
Smith via cfe-commits
Reply-To: Richard Smith
Date: Wednesday, October 31, 2018 at 5:49 PM
Author: tlively
Date: Wed Oct 31 18:03:17 2018
New Revision: 345804
URL: http://llvm.org/viewvc/llvm-project?rev=345804&view=rev
Log:
[WebAssembly] Fix type names in truncation builtins
Summary: Use the same convention as all the other WebAssembly builtin names.
Reviewers: aheejin, dschuff
Subs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345804: [WebAssembly] Fix type names in truncation builtins
(authored by tlively, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53724
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345804: [WebAssembly] Fix type names in truncation builtins
(authored by tlively, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53724?vs=172061&id=172074#toc
Repository:
rL LLVM
On Wed, 31 Oct 2018 at 18:05, Shoaib Meenai via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Comment inline (Outlook handles quoting terribly, so I'm not sure how much
> it'll end up standing out, but I believe you typo'd "preprocessor" as "
> prepreocssor").
>
>
>
> *From: *cfe-commits on
Author: rsmith
Date: Wed Oct 31 18:05:00 2018
New Revision: 345805
URL: http://llvm.org/viewvc/llvm-project?rev=345805&view=rev
Log:
Fix typo in comment.
Modified:
cfe/trunk/lib/Frontend/CompilerInstance.cpp
Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp
URL:
http://llvm.org/viewvc/l
Author: dergachev
Date: Wed Oct 31 18:27:01 2018
New Revision: 345807
URL: http://llvm.org/viewvc/llvm-project?rev=345807&view=rev
Log:
[analyzer] SARIF: Suppress version testing in a more downstream-friendly manner.
No functional change intended.
Modified:
cfe/trunk/test/Analysis/diagnosti
Author: mgrang
Date: Wed Oct 31 18:35:34 2018
New Revision: 345808
URL: http://llvm.org/viewvc/llvm-project?rev=345808&view=rev
Log:
[COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAArch64.def
cfe/trunk/lib/CodeGen/CGBuiltin.cp
Author: helijia
Date: Wed Oct 31 19:32:49 2018
New Revision: 345809
URL: http://llvm.org/viewvc/llvm-project?rev=345809&view=rev
Log:
[Clang][PowerPC] Support constraint 'wi' in asm
From the gcc manual, we can see that the specific limit of wi inline asm is
“FP or VSX register to hold 64-bit in
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345809: [Clang][PowerPC] Support constraint 'wi'
in asm (authored by helijia, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D53265?vs=169645&i
void marked 3 inline comments as done.
void added inline comments.
Herald added a reviewer: shafik.
Comment at: lib/Sema/SemaDecl.cpp:16086-16094
CheckConvertedConstantExpression(Val, EltTy, EnumVal,
CCEK_Enumerator);
void updated this revision to Diff 172082.
Repository:
rC Clang
https://reviews.llvm.org/D53921
Files:
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/StmtDataCollectors.td
include/clang/Basic/StmtNodes.td
include/clang
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D53674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
rjmccall added a comment.
In https://reviews.llvm.org/D53738#1281894, @ebevhan wrote:
> In https://reviews.llvm.org/D53738#1281332, @rjmccall wrote:
>
> > Well, maybe the cleanest solution would be to actually fold
> > `CompoundAssignOperator` back into `BinaryOperator` and just allow
> > `Bina
wuzish added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
hubert.reinterpretcast wrote:
> hubert.re
lebedev.ri added a comment.
In https://reviews.llvm.org/D53949#1282884, @regehr wrote:
> I do not agree that ++ is performed on the original type. The C99 standard
> (6.5.3.1.2) appears to be very clear on this point: "The expression ++E is
> equivalent to (E+=1)."
In https://reviews.llvm.o
takuto.ikuta updated this revision to Diff 172090.
takuto.ikuta marked 2 inline comments as done.
takuto.ikuta added a comment.
Added option to LangOptions.def
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
clang/include/
On Thu, Nov 1, 2018 at 3:03 AM Friedman, Eli wrote:
>
> On 10/30/2018 2:58 PM, Roman Lebedev via cfe-commits wrote:
> > Author: lebedevri
> > Date: Tue Oct 30 14:58:56 2018
> > New Revision: 345660
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=345660&view=rev
> > Log:
> > [clang][ubsan] Imp
takuto.ikuta added a comment.
Thank you for review!
Comment at: clang/include/clang/Basic/LangOptions.h:246
+ /// If set, dllexported classes dllexport their inline methods.
+ bool DllExportInlines = true;
+
rnk wrote:
> We should define this in the LangOptio
201 - 287 of 287 matches
Mail list logo
