ebevhan added a comment.
In https://reviews.llvm.org/D53738#1278078, @rjmccall wrote:
> I don't think we should add *types* just for this, but if you need to make a
> different kind of `BinaryOperator` that represents that the semantics aren't
> quite the same (the same way that the compound as
Szelethus added a comment.
I think is good to go! Please wait on @xazax.hun or @NoQ to have the final say
(it's been a while since this revision was accepted by them), but for a
work-in-progress alpha checker, I like what I'm seeing.
Comment at: lib/StaticAnalyzer/Checkers/En
martong added a comment.
Hi Aleksei,
Thanks for the review. Yes, we encountered the issue during the analysis of
Xerces.
Repository:
rC Clang
https://reviews.llvm.org/D53704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
ilya-biryukov added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:767
+ /// When Kind == RK_Declaration and a FieldDecl has been passed as
+ /// Declaration, this will hold the identifiers name. To be used later on
when
+ /// generating constructors f
takuto.ikuta added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:9552
+// overwrite linkage of explicit template instantiation
+// definition/declaration.
+return GVA_DiscardableODR;
hans wrote:
> Can you give an example for why this is ne
takuto.ikuta updated this revision to Diff 171466.
takuto.ikuta marked an inline comment as done.
takuto.ikuta added a comment.
Added explanation comment for added attributes and rebased
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangO
ioeric updated this revision to Diff 171467.
ioeric added a comment.
- minor cleanup and a friendly ping.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53433
Files:
clangd/index/Background.cpp
clangd/index/Background.h
clangd/index/FileIndex.cpp
clangd/index/FileIndex.
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:84
"cppcoreguidelines-c-copy-assignment-signature");
+CheckFactories.registerCheck(
+"cppcoreguidelines-avoid-c-arrays");
please conserv
hans added a comment.
In https://reviews.llvm.org/D53457#1277950, @neerajksingh wrote:
> In https://reviews.llvm.org/D53457#1277315, @hans wrote:
>
> > One note about flag ordering: the /clang: flags are concatenated to the
> > end of
> > the argument list, so in cases where the last flag wi
ArnaudBienner created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D53807
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
Index: include/clang/Basic/DiagnosticSemaKinds.td
==
sylvestre.ledru added a comment.
Please add some tests
Repository:
rC Clang
https://reviews.llvm.org/D53807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: martong
Date: Mon Oct 29 03:18:28 2018
New Revision: 345496
URL: http://llvm.org/viewvc/llvm-project?rev=345496&view=rev
Log:
[ASTImporter] Import overrides before importing the rest of the chain
Summary:
During method import we check for structural eq of two methods.
In the structural eq
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345496: [ASTImporter] Import overrides before importing the
rest of the chain (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53704?vs=171097&id=171471#toc
Repo
ZaMaZaN4iK updated this revision to Diff 171472.
ZaMaZaN4iK added a comment.
Add the reference to CERT page
https://reviews.llvm.org/D33672
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChe
ZaMaZaN4iK marked 3 inline comments as done.
ZaMaZaN4iK added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:19
+// of casting an integer value that is out of range
+//===---
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
With this patch, we only collect refs for canonical headers (headers
with header guards). As non-canonical headers are usually generated, and
no
vmaksimo created this revision.
vmaksimo added reviewers: Anastasia, yaxunl, AlexeySotkin.
Herald added a subscriber: cfe-commits.
Addrspace(32) was generated when putting 0 in clk_event_t * event_ret parameter
for enqueue_kernel function.
Repository:
rC Clang
https://reviews.llvm.org/D53809
lebedev.ri added a comment.
Please add a test with `#pragma once`, which should still be counted as a
header guard.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
martong updated this revision to Diff 171478.
martong marked 2 inline comments as done.
martong added a comment.
- Move FromUT upper, add break
Repository:
rC Clang
https://reviews.llvm.org/D53693
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/AST
grimar updated this revision to Diff 171480.
grimar added a comment.
Ping.
- Rebased.
https://reviews.llvm.org/D52296
Files:
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/BackendUtil.cpp
lib/Driver/ToolChains/Cl
Szelethus created this revision.
Szelethus added reviewers: xazax.hun, rnkovacs, george.karpenkov, NoQ.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, szepet, whisperity.
This has been a long time coming. Note the usage of `AnalyzerOptions`: I'll
need it f
Author: asavonic
Date: Mon Oct 29 04:14:01 2018
New Revision: 345497
URL: http://llvm.org/viewvc/llvm-project?rev=345497&view=rev
Log:
[OpenCL] Fix serialization of OpenCLExtensionDecls
Summary:
I recently discovered that adding the following code into `opencl-c.h` causes
failure of `test/Headers
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345497: [OpenCL] Fix serialization of OpenCLExtensionDecls
(authored by asavonic, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53200
Files:
lib/Serialization/ASTWriter.cpp
test/S
Szelethus added a comment.
Makes sense!
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:39
//currently treated as an lvalue.
// * type-IIc, type-IIIc: compound values of iterator-typed objects, when the
//iterator o
aaron.ballman added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:19
+// of casting an integer value that is out of range
+//===--===//
+
ZaMaZaN4iK wro
baloghadamsoftware created this revision.
baloghadamsoftware added a reviewer: NoQ.
baloghadamsoftware added a project: clang.
Herald added subscribers: donat.nagy, Szelethus, mikhail.ramalho, a.sidorin,
rnkovacs, szepet, whisperity.
Herald added a reviewer: george.karpenkov.
Previously, the iter
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with some minor fixes.
At some point (not necessarily as part of this patch), you should also update
`docs\ReleaseNotes.rst` to broadly list the new features you've been add
t.p.northover added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D53514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added inline comments.
Comment at: clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:67
+
+ diag(MD->getLocation(), DiagnosticMessage);
+}
And once again, i'm going to bitch about useless diagnostic messages:
```
[1/357] Building CXX object
src/CMakeF
devnexen added a comment.
ping working-set on FreeBSD does not seem doable.
Repository:
rC Clang
https://reviews.llvm.org/D52610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman created this revision.
aaron.ballman added reviewers: dcoughlin, zaks.anna.
Herald added subscribers: dkrupp, donat.nagy, Szelethus, a.sidorin, mgorny.
Herald added a reviewer: george.karpenkov.
SARIF (https://github.com/oasis-tcs/sarif-spec) is a new draft standard
interchange form
ilya-biryukov added a comment.
Update from the offline meeting: decided to start with `llvm::ThreadPool` for
background tasks and lower thread priorities for background tasks.
Comment at: clangd/index/Background.cpp:89
}
- QueueCV.notify_all();
+ QueueCV.notify_one();
}
jranieri-grammatech added a comment.
I do.
Repository:
rC Clang
https://reviews.llvm.org/D53781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Mon Oct 29 06:47:56 2018
New Revision: 345502
URL: http://llvm.org/viewvc/llvm-project?rev=345502&view=rev
Log:
Add the isStaticLocal() AST matcher for matching on local static variables.
Patch by Joe Ranieri.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
aaron.ballman closed this revision.
aaron.ballman added a comment.
Committed in r345502, thank you for the patch!
Repository:
rC Clang
https://reviews.llvm.org/D53781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
hans added a comment.
I've been thinking more about your example with static locals in lambda and how
this works with regular dllexport.
It got me thinking more about the problem of exposing inline functions from a
library. For example:
`lib.h`:
#ifndef LIB_H
#define LIB_H
int foo();
lebedev.ri created this revision.
lebedev.ri added reviewers: JonasToth, aaron.ballman, hokein, xazax.hun, alexfh.
lebedev.ri added a project: clang-tools-extra.
Herald added subscribers: rnkovacs, kbarton, nemanjai.
The macro may not have location (or more generally, the location may not exist),
greened added inline comments.
Comment at: lib/Driver/ToolChains/Linux.cpp:927-928
LibDir.str() + "/../include/c++",
+ // Some gcc installations put headers under "g++" without a
+ // version suffix.
+ LibDir.str() + "/../include/g++",
rsmit
hans added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5719
+ TSK != TSK_ExplicitInstantiationDeclaration &&
+ TSK != TSK_ExplicitInstantiationDefinition) {
+if (ClassExported) {
takuto.ikuta wrote:
> takuto.ikuta wrote:
gtbercea updated this revision to Diff 171499.
gtbercea added a comment.
Fix comment.
Repository:
rC Clang
https://reviews.llvm.org/D53448
Files:
include/clang/AST/StmtOpenMP.h
lib/AST/StmtOpenMP.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMP
gtbercea added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D53443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D53443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: abataev
Date: Mon Oct 29 08:01:58 2018
New Revision: 345505
URL: http://llvm.org/viewvc/llvm-project?rev=345505&view=rev
Log:
[OPENMP] Do not capture private loop counters.
If the loop counter is not declared in the context of the loop and it is
private, such loop counters should not be c
ArnaudBienner updated this revision to Diff 171502.
ArnaudBienner added a comment.
Update tests
Repository:
rC Clang
https://reviews.llvm.org/D53807
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
test/Misc/warning-flags.c
test/SemaCXX/warn-p
ZaMaZaN4iK updated this revision to Diff 171503.
ZaMaZaN4iK added a comment.
Add new test for enum bit field
https://reviews.llvm.org/D33672
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeCh
Author: brunoricci
Date: Mon Oct 29 08:04:19 2018
New Revision: 345506
URL: http://llvm.org/viewvc/llvm-project?rev=345506&view=rev
Log:
[AST] Check that GNU range case statements are correctly imported.
The test for case statements did not cover GNU range case statements.
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345506: [AST] Check that GNU range case statements are
correctly imported. (authored by brunoricci, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53610
Files:
test/Import/switch-stm
Szelethus updated this revision to Diff 171505.
https://reviews.llvm.org/D53810
Files:
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
Index: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
===
--- lib/StaticAnalyzer/Core/PlistDiagnosti
ArnaudBienner added a reviewer: davide.
ArnaudBienner added a comment.
Hi Davide,
I see you the last person who updated the test file related to this feature.
Would you feel comfortable reviewing my patch?
This is my first clang patch, so I apologize in advance if I missed obvious
things :)
R
davide added a comment.
While it's true that I implemented this warning, I don't feel qualified enough
to approve the introduction of a new flag to clang. Probably @rsmith should
sign this off.
Repository:
rC Clang
https://reviews.llvm.org/D53807
_
ZaMaZaN4iK updated this revision to Diff 171506.
ZaMaZaN4iK marked 2 inline comments as done.
ZaMaZaN4iK added a comment.
Fix typedef -> using
https://reviews.llvm.org/D33672
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnal
ZaMaZaN4iK added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:36
+ const ProgramStateRef PS;
+ SValBuilder &SVB;
+
Szelethus wrote:
> You can acquire `SValBuilder` from `ProgramState`:
> `PS->getStateManager()->getSvalB
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:82
-static void EmitRanges(raw_ostream &o,
- const ArrayRef Ranges,
- const FIDMap& FM,
- const Preprocessor &PP,
-
Author: gbercea
Date: Mon Oct 29 08:23:23 2018
New Revision: 345507
URL: http://llvm.org/viewvc/llvm-project?rev=345507&view=rev
Log:
[OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.
Summary: This patch enables the choosing of the default schedule for parallel
for lo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345507: [OpenMP][NVPTX] Enable default scheduling for
parallel for in non-SPMD cases. (authored by gbercea, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
balazske created this revision.
Herald added subscribers: cfe-commits, Szelethus, martong, dkrupp.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D53818
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
===
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:82
-static void EmitRanges(raw_ostream &o,
- const ArrayRef Ranges,
- const FIDMap& FM,
- const Preprocessor &PP,
-
Author: gbercea
Date: Mon Oct 29 08:45:47 2018
New Revision: 345509
URL: http://llvm.org/viewvc/llvm-project?rev=345509&view=rev
Log:
[OpenMP][NVPTX] Use single loops when generating code for distribute parallel
for
Summary: This patch adds a new code generation path for bound sharing
directive
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345509: [OpenMP][NVPTX] Use single loops when generating
code for distribute parallel… (authored by gbercea, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
JonasToth added a comment.
How does this patch change the behaviour for macros without location? They will
be diagnosed at the beginning of the TU?
It is probably better to ignore these kind of macros, as there is no way around
them (compile time configuration can only be done with macros?!) an
kadircet updated this revision to Diff 171516.
kadircet marked 5 inline comments as done.
kadircet added a comment.
- Address comments & offline discussions.
Repository:
rC Clang
https://reviews.llvm.org/D53654
Files:
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletion/ctor-initializer.cpp
balazske added a comment.
The Import functions are replaced by Import_New and error handling is added.
This is done in the implementation of the Import_New functions itself, and in
importInto. (Code of old Import functions is moved to the Import_New and
updated to use Import_New.) Some other fu
ZaMaZaN4iK added inline comments.
Comment at: StaticAnalyzer/Core/CMakeLists.txt:43
PlistDiagnostics.cpp
+ SarifDiagnostics.cpp
ProgramState.cpp
Sort alphabetically
Comment at: StaticAnalyzer/Core/SarifDiagnostics.cpp:88
+
Author: brunoricci
Date: Mon Oct 29 09:12:37 2018
New Revision: 345510
URL: http://llvm.org/viewvc/llvm-project?rev=345510&view=rev
Log:
[AST] Only store the needed data in SwitchStmt
Don't store the data for the init statement and condition variable
if not needed. This cuts the size of SwitchStm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345510: [AST] Only store the needed data in SwitchStmt
(authored by brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53714?vs=17133
lebedev.ri added a comment.
In https://reviews.llvm.org/D53817#1278916, @JonasToth wrote:
> How does this patch change the behaviour for macros without location?
It doesn't.
> They will be diagnosed at the beginning of the TU?
> It is probably better to ignore these kind of macros, as there
george.karpenkov added a comment.
Patch context is missing.
Comment at: Analysis/diagnostics/sarif-check.py:22
+passes = 0
+with open(testfile) as testfh:
+lineno = 0
Wow, this is super neat!
Since you are quite active in LLVM community, would you think it'
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Minor style notes + context missing.
I think using `diff` would be better than a custom python tool.
https://reviews.llvm.org/D53814
_
balazske updated this revision to Diff 171519.
balazske added a comment.
Reformatted code.
Repository:
rC Clang
https://reviews.llvm.org/D53818
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
=
JonasToth added a comment.
>> They will be diagnosed at the beginning of the TU?
>> It is probably better to ignore these kind of macros, as there is no way
>> around them (compile time configuration can only be done with macros?!) and
>> therefore warnings for theses macros are false positives
aaron.ballman added a comment.
In https://reviews.llvm.org/D53817#1278933, @lebedev.ri wrote:
> In https://reviews.llvm.org/D53817#1278916, @JonasToth wrote:
>
> > How does this patch change the behaviour for macros without location?
>
>
> It doesn't.
>
> > They will be diagnosed at the beginning
ZaMaZaN4iK added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:5135
+ };
+ auto AddDefaultCtorInit = [&](const char *TypedName,
+const char *TypeName,
Is it good idea to capture ALL by reference? Probably will be bet
kadircet updated this revision to Diff 171527.
kadircet added a comment.
- Use notify_all.
- Use priorities.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53651
Files:
clangd/Threading.cpp
clangd/Threading.h
clangd/index/Background.cpp
clangd/index/Background.h
Index:
aaron.ballman added inline comments.
Comment at: Analysis/diagnostics/sarif-check.py:22
+passes = 0
+with open(testfile) as testfh:
+lineno = 0
george.karpenkov wrote:
> Wow, this is super neat!
> Since you are quite active in LLVM community, would you think
Szelethus updated this revision to Diff 171532.
Szelethus added a comment.
This revision is now accepted and ready to land.
Changes according to my last comment.
https://reviews.llvm.org/D52742
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOption
Szelethus updated this revision to Diff 171533.
https://reviews.llvm.org/D52742
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/BugReporter.cpp
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
test/Analysis/Input
lebedev.ri added a comment.
In https://reviews.llvm.org/D53817#1278970, @aaron.ballman wrote:
> In https://reviews.llvm.org/D53817#1278933, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D53817#1278916, @JonasToth wrote:
> >
> > > How does this patch change the behaviour for macros without
Typz added a comment.
In https://reviews.llvm.org/D50147#1272742, @sammccall wrote:
> The idea here does seem to be a natural extension of -style, at least for the
> case when the arg is a filename directly. I'm not opposed, happy to review
> this.
>
> I do want to probe the use case a bit thou
JonasToth added a comment.
> I personally haven't yet seen this check firing on *predefined* macros.
I did specifically check the compiler defined macros I could see in the AST and
they were not diagnosed from the beginning.
I would guess, only the compiler-flag macros are passed in the PPCallba
sammccall added a comment.
In https://reviews.llvm.org/D50147#1279056, @Typz wrote:
> In https://reviews.llvm.org/D50147#1272742, @sammccall wrote:
>
> > The idea here does seem to be a natural extension of -style, at least for
> > the case when the arg is a filename directly. I'm not opposed, h
aaron.ballman added a comment.
In https://reviews.llvm.org/D53817#1279053, @JonasToth wrote:
> > I personally haven't yet seen this check firing on *predefined* macros.
>
> I did specifically check the compiler defined macros I could see in the AST
> and they were not diagnosed from the beginnin
Author: epilk
Date: Mon Oct 29 10:38:42 2018
New Revision: 345517
URL: http://llvm.org/viewvc/llvm-project?rev=345517&view=rev
Log:
Revert "Revert "Support for groups of attributes in #pragma clang attribute""
This reverts commit r345487, which reverted r345486. I think the crashes were
caused by
Typz added a comment.
In https://reviews.llvm.org/D50147#1272742, @sammccall wrote:
> Being able to discover the right style from the filesystem is powerful, and
> if I was going to use this flag, I'd consider symlinking the style-file to
> `subproject/.clang_format` instead. That way the setti
svenvh added a comment.
Unlikely, since address spaces are provided in a different way in OpenCL C++ vs
OpenCL C.
OpenCL C provides qualifiers such as `global` as part of the language. OpenCL
C++ provides template classes such as `cl::global` through a header file.
Repository:
rC Clang
ht
rjmccall added a comment.
In https://reviews.llvm.org/D53738#1278528, @ebevhan wrote:
> In https://reviews.llvm.org/D53738#1278078, @rjmccall wrote:
>
> > I don't think we should add *types* just for this, but if you need to make
> > a different kind of `BinaryOperator` that represents that the
rjmccall added a comment.
In https://reviews.llvm.org/D53705#1279068, @svenvh wrote:
> Unlikely, since address spaces are provided in a different way in OpenCL C++
> vs OpenCL C.
>
> OpenCL C provides qualifiers such as `global` as part of the language.
> OpenCL C++ provides template classes s
JonasToth updated this revision to Diff 171538.
JonasToth added a comment.
- Merge branch 'master' into experiment_isolate_decl
- adjust doc slighty to comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/reada
rupprecht resigned from this revision.
rupprecht added a comment.
I'm not familiar with this code or anything windows related, and it looks like
@rnk is, so I'll remove myself and let him approve
Repository:
rL LLVM
https://reviews.llvm.org/D53066
_
Szelethus added a comment.
@NoQ did you have time to ping Devin about this? (Sorry for the early ping, but
this patch is blocking a lot of my other patches.)
https://reviews.llvm.org/D53276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
twoh added a comment.
@rsmith @dblaikie Thank you for the comments! It seems that this is not the
appropriate way to handle the issue. I'll find different way to resolve the
problem.
Repository:
rC Clang
https://reviews.llvm.org/D38061
___
cfe-
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:787-791
+ // Acquire the macro's name.
+ Token TheTok;
+ RawLexer.LexFromRawLexer(TheTok);
+
+ std::string MacroName = PP.getSpelling(TheTok);
NoQ wrote:
> Not sure, ran
Does this match GCC's approach here?
(I ask this sort of as throwaway/conversation starter - because the
linkage/behavior around multiversion functions and their inlining is full
of sharp corners/risks of code moving out of the areas appropriately
restricted based on the cpu features)
On Mon, Oct
Is this a workaround for now with the intent to fix this to allow such
implicit specializations to have their debug info modularized? I believe
this does work correctly in modular debug info with expliict modules, would
probably be sort of nice to have these things be consistent/similar?
On Tue, O
GCC actually doesn’t support function multiversioning in C mode, so this fix is
part of our extension to support C with multiversioning. I perhaps wonder if
this is part of the reason GCC only supports it in C++ mode...
From: David Blaikie [mailto:dblai...@gmail.com]
Sent: Monday, October 29, 2
aaron.ballman updated this revision to Diff 171545.
aaron.ballman marked 3 inline comments as done.
aaron.ballman added a comment.
Updated based on initial review feedback, and added more context to the patch.
https://reviews.llvm.org/D53814
Files:
Analysis/diagnostics/sarif-check.py
Analys
On Mon, Oct 29, 2018 at 11:30 AM Keane, Erich wrote:
> GCC actually doesn’t support function multiversioning in C mode, so this
> fix is part of our extension to support C with multiversioning.
>
Ah, what's the motivation for that?
> I perhaps wonder if this is part of the reason GCC only su
From: David Blaikie [mailto:dblai...@gmail.com]
Sent: Monday, October 29, 2018 11:41 AM
To: Keane, Erich
Cc: Eric Christopher ; cfe-commits@lists.llvm.org
Subject: Re: r344957 - Give Multiversion-inline functions linkonce linkage
On Mon, Oct 29, 2018 at 11:30 AM Keane, Erich
mailto:erich.ke..
On Mon, Oct 29, 2018 at 11:46 AM Keane, Erich wrote:
>
>
>
>
> *From:* David Blaikie [mailto:dblai...@gmail.com]
> *Sent:* Monday, October 29, 2018 11:41 AM
> *To:* Keane, Erich
> *Cc:* Eric Christopher ; cfe-commits@lists.llvm.org
>
>
> *Subject:* Re: r344957 - Give Multiversion-inline function
Author: steveire
Date: Mon Oct 29 11:59:56 2018
New Revision: 345522
URL: http://llvm.org/viewvc/llvm-project?rev=345522&view=rev
Log:
[clang-query] Add non-exclusive output API
Summary:
Add granular options for AST dumping, text printing and diagnostics.
This makes it possible to
* Have both d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345522: [clang-query] Add non-exclusive output API (authored
by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52857?vs=171046&id=1
1 - 100 of 177 matches
Mail list logo
