Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:142
+
+ Diagnoses local variable declarations declaring more than one variable and
+ tries to refactor the code to one statement per declaration.
May be Finds or Detects like other checks?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345431: [VFS] Add property 'fallthrough' that
controls fallback to real file system. (authored by vsapsai, committed by ).
Herald added subscribers: llvm-commits, kristina.
Changed prior to commit:
http
Author: vsapsai
Date: Fri Oct 26 15:16:24 2018
New Revision: 345432
URL: http://llvm.org/viewvc/llvm-project?rev=345432&view=rev
Log:
[VFS] Add property 'fallthrough' that controls fallback to real file system.
Default property value 'true' preserves current behavior. Value 'false' can be
used to
jranieri-grammatech created this revision.
jranieri-grammatech added reviewers: aaron.ballman, klimek, sbenza.
Herald added a subscriber: cfe-commits.
This adds a matcher, isStaticLocal, that matches local static variables (i.e.
VarDecl::isStaticLocal).
Repository:
rC Clang
https://reviews.l
a_sidorin added a comment.
Hi Gabor,
I wonder if it is possible to get into situation where non-equivalent decls are
marked equivalent with this patch? If yes, we can create a mapping between
decls being imported and original decls as an alternative solution. However, I
cannot find any counte
david-salinas updated this revision to Diff 171367.
david-salinas added a comment.
remove __attribute__((cpu)) __attribute__((hc)) from test
Repository:
rC Clang
https://reviews.llvm.org/D53780
Files:
lib/CodeGen/CGCall.cpp
test/CodeGenCXX/address-space-cast-coerce.cpp
Index: test/Code
Author: leonardchan
Date: Fri Oct 26 15:51:51 2018
New Revision: 345433
URL: http://llvm.org/viewvc/llvm-project?rev=345433&view=rev
Log:
Revert "[PassManager/Sanitizer] Enable usage of ported AddressSanitizer passes
with -fsanitize=address"
This reverts commit 8d6af840396f2da2e4ed6aab669214ae25
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
neerajksingh added a comment.
In https://reviews.llvm.org/D53457#1277315, @hans wrote:
> One note about flag ordering: the /clang: flags are concatenated to the end
> of
> the argument list, so in cases where the last flag wins, the /clang: flags
> will be chosen regardless of their order
Hello everyone,
Below are some buildbot numbers for the week of 10/7/018 - 10/13/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to r
Hello everyone,
Below are some buildbot numbers for the last week of 10/14/2018 -
10/20/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Author: brad
Date: Fri Oct 26 17:23:28 2018
New Revision: 345439
URL: http://llvm.org/viewvc/llvm-project?rev=345439&view=rev
Log:
Pass the nopie flag to the linker when linking with -pg.
Modified:
cfe/trunk/lib/Driver/ToolChains/OpenBSD.cpp
cfe/trunk/test/Driver/openbsd.c
Modified: cfe/
phosek created this revision.
phosek added reviewers: rsmith, rnk.
Herald added a subscriber: cfe-commits.
When the global new and delete operators aren't declared, Clang
provides and implicit declaration, but this declaration currently
always uses the default visibility. This is a problem when th
rjmccall added a comment.
So, three points:
- That's not class-member-specific; you can have a placement `operator new[]`
at global scope that isn't the special `void*` placement operator and therefore
still has a cookie, and it would have just as much flexibility as a
class-member override wo
Author: brad
Date: Fri Oct 26 17:46:12 2018
New Revision: 345440
URL: http://llvm.org/viewvc/llvm-project?rev=345440&view=rev
Log:
Update the other test.
Modified:
cfe/trunk/test/Driver/openbsd.c
Modified: cfe/trunk/test/Driver/openbsd.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/te
neerajksingh updated this revision to Diff 171382.
neerajksingh added a comment.
Fix hans' comments.
https://reviews.llvm.org/D53457
Files:
docs/UsersManual.rst
include/clang/Driver/CLCompatOptions.td
include/clang/Driver/Driver.h
lib/Driver/Driver.cpp
test/Driver/cl-options.c
Index:
Author: brad
Date: Fri Oct 26 18:14:22 2018
New Revision: 345443
URL: http://llvm.org/viewvc/llvm-project?rev=345443&view=rev
Log:
Revert "Pass the nopie flag to the linker when linking with -pg." until
one of the tests can be fixed on !OpenBSD hosts.
Modified:
cfe/trunk/lib/Driver/ToolChains
rjmccall added a comment.
I don't suppose there's any chance you can just tell Khronos to fix their
stuff. It's a little funny to be more conservative about keywords in C++ when
the C++ committee is actually much more aggressive about adding keywords in the
non-reserved space than C is.
Repo
rjmccall added a comment.
This should at least be named `emitScalarConstant`.
https://reviews.llvm.org/D53725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGObjC.cpp:2480
+ SuppressResultRetain);
}
vsapsai wrote:
> rjmccall wrote:
> > This switch is just checking what you already computed as
> > `SuppressResultRetain`. Plea
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: include/clang/AST/Stmt.h:279
+/// in PredefinedExpr::IdentType.
+unsigned Type : 4;
+
rjmccall wrote:
> Since you're changing t
rjmccall added inline comments.
Comment at: lib/AST/Expr.cpp:1609
case CK_AddressSpaceConversion:
-assert(getType()->isPointerType() || getType()->isBlockPointerType());
-assert(getSubExpr()->getType()->isPointerType() ||
- getSubExpr()->getType()->isBlockPoi
rjmccall added a comment.
In https://reviews.llvm.org/D53738#1277172, @ebevhan wrote:
> I want to float the idea again of adding an AST type to encapsulate an
> arbitrary fixed-point semantic and using that as the 'common type' for binary
> operations involving fixed-point types. This would ena
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: compnerd
Date: Fri Oct 26 23:12:52 2018
New Revision: 345449
URL: http://llvm.org/viewvc/llvm-project?rev=345449&view=rev
Log:
AST: fix a typo in a comment (NFC)
Fix a typo spotted by Akira! NFC
Modified:
cfe/trunk/lib/AST/ASTContext.cpp
Modified: cfe/trunk/lib/AST/ASTContext.cpp
U
101 - 125 of 125 matches
Mail list logo
