EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting. This is a good candidate for post-commit review.
Repository:
rC Clang
https://reviews.llvm.org/D53508
___
cfe-commits mailing list
Author: ericwf
Date: Wed Oct 24 15:38:49 2018
New Revision: 345211
URL: http://llvm.org/viewvc/llvm-project?rev=345211&view=rev
Log:
[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03
Summary:
When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t
as an
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345211: [SemaCXX] Unconfuse Clang when std::align_val_t is
unscoped in C++03 (authored by EricWF, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53508
Files:
lib/Sema/SemaExprCXX.cpp
Author: vsapsai
Date: Wed Oct 24 15:39:38 2018
New Revision: 345212
URL: http://llvm.org/viewvc/llvm-project?rev=345212&view=rev
Log:
[VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.
'ignore-non-existent-contents' stopped working after r342232 in a way
that the actual att
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345212: [VFS] Remove
'ignore-non-existent-contents' attribute for YAML-based VFS.
(authored by vsapsai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53228?vs=169520&id=171010#toc
vsapsai added a comment.
Thanks for the review.
Repository:
rC Clang
https://reviews.llvm.org/D53228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, 24 Oct 2018 at 15:40, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Wed Oct 24 15:38:49 2018
> New Revision: 345211
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345211&view=rev
> Log:
> [SemaCXX] Unconfuse Clang when std::align_val_t is uns
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/Environment.cpp:180
- for (; SI != SE; ++SI)
-SymReaper.maybeDead(*SI);
}
zaks.anna wrote:
> We are removing this because the maybeDead is no longer used, correct?
Yup.
===
NoQ updated this revision to Diff 171006.
NoQ marked 2 inline comments as done.
NoQ added a comment.
Herald added subscribers: dkrupp, donat.nagy, Szelethus, mikhail.ramalho.
Rebase!
Changes on large codebase runs still look mild and reasonable, with much less
slowdown than before. Even if there
george.karpenkov accepted this revision.
george.karpenkov added inline comments.
This revision is now accepted and ready to land.
Comment at: test/Analysis/self-assign.cpp:42
str = rhs.str;
- rhs.str = nullptr; // FIXME: An improved leak checker should warn here
+ rhs.str =
NoQ added inline comments.
Comment at: test/Analysis/simple-stream-checks.c:96
+ fp = 0;
+} // expected-warning {{Opened file is never closed; potential resource leak}}
george.karpenkov wrote:
> Woo-hoo, were we losing this case before?
Yes, this is the whole po
aaronpuchert updated this revision to Diff 171019.
aaronpuchert added a comment.
Introduced helper functions to clarify lock handling.
The previous version was too tightly coupled, and the introduction of AddCp and
RemoveCp didn't help readability.
Repository:
rC Clang
https://reviews.llvm.
Author: compnerd
Date: Wed Oct 24 16:28:28 2018
New Revision: 345222
URL: http://llvm.org/viewvc/llvm-project?rev=345222&view=rev
Log:
Driver,CodeGen: introduce support for Swift CFString layout
Add a new driver level flag `-fcf-runtime-abi=` that allows one to specify the
runtime ABI for CoreFou
rnk added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:2395
+
+ llvm::CallInst *Result = Builder.CreateCall(FuncToReturn, Args);
+
rnk wrote:
> erichkeane wrote:
> > erichkeane wrote:
> > > rnk wrote:
> > > > This approach is... not going to work
Author: ericwf
Date: Wed Oct 24 16:47:04 2018
New Revision: 345225
URL: http://llvm.org/viewvc/llvm-project?rev=345225&view=rev
Log:
Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"
This reverts commit 6f47cdd51341344c0e32630e19e72c94cd25f34e.
Removed:
cfe/trunk/
aaronpuchert updated this revision to Diff 171026.
aaronpuchert added a comment.
Negative capabilities don't need a LockKind.
Repository:
rC Clang
https://reviews.llvm.org/D52578
Files:
lib/Analysis/ThreadSafety.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/warn-t
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
rjmccall added inline comments.
Comment at: include/clang/AST/Expr.h:1687
+ // "Stmt *" for the predefined identifier. It is present if and only if
+ // hasFunctionName() is true and is in fact a "StringLiteral *".
+
"always" would be clearer than "in fact".
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
rjmccall added a comment.
Yeah, I agree that changing child order is problematic.
Repository:
rC Clang
https://reviews.llvm.org/D53607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGObjC.cpp:2480
+ SuppressResultRetain);
}
This switch is just checking what you already computed as
`SuppressResultRetain`. Please just assert in the second case that th
yinma created this revision.
Herald added subscribers: cfe-commits, chrib, kristof.beyls, javed.absar.
ARM64 setjmp expects sp on entry instead of framepointer.
Repository:
rC Clang
https://reviews.llvm.org/D53684
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-setjmp.c
Index: test/Co
Author: rtrieu
Date: Wed Oct 24 18:08:00 2018
New Revision: 345228
URL: http://llvm.org/viewvc/llvm-project?rev=345228&view=rev
Log:
[Sema] Fix -Wcomma for C89
There is a small difference in the scope flags for C89 versus the other C/C++
dialects. This change ensures that the -Wcomma warning won
rjmccall added inline comments.
Comment at: include/clang/AST/Stmt.h:956
+ // with a range. Present if and only if caseStmtIsGNURange() is true.
+ enum { LHS, SUBSTMT, RHS, ELLIPSISLOC };
+ enum { NumMandatoryStmtPtr = 2 };
ELLIPSISLOC is dead.
Much like th
Author: dyung
Date: Wed Oct 24 18:21:08 2018
New Revision: 345229
URL: http://llvm.org/viewvc/llvm-project?rev=345229&view=rev
Log:
Fix test to work on Windows.
Modified:
clang-tools-extra/trunk/unittests/clangd/ClangdUnitTests.cpp
Modified: clang-tools-extra/trunk/unittests/clangd/ClangdUni
tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100.
Repository:
rC Clang
https://reviews.llvm.org/D53685
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeG
Author: sammccall
Date: Wed Oct 24 19:04:30 2018
New Revision: 345231
URL: http://llvm.org/viewvc/llvm-project?rev=345231&view=rev
Log:
[clangd] Don't invalidate LSP-set compile commands when closing a file.
Summary:
It doesn't make much sense: setting them is not coupled to opening the file,
it'
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345231: [clangd] Don't invalidate LSP-set compile
commands when closing a file. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53642?vs=170861&id=171033#toc
Author: sammccall
Date: Wed Oct 24 19:22:53 2018
New Revision: 345232
URL: http://llvm.org/viewvc/llvm-project?rev=345232&view=rev
Log:
[clangd] Fix -compile-commands-dir flag, broken in r345031
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra/trunk/clangd/Cl
Author: sammccall
Date: Wed Oct 24 19:25:44 2018
New Revision: 345233
URL: http://llvm.org/viewvc/llvm-project?rev=345233&view=rev
Log:
[clangd] Remove unused CDB function. NFC
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
clang-tools-extra/trunk/clangd/GlobalComp
aheejin added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:85
+BUILTIN(__builtin_wasm_bitselect, "V4iV4iV4iV4i", "nc")
+
Do you think we need to provide this builtin also for other vector types?
Repository:
rC Clang
https://revi
tlively added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:85
+BUILTIN(__builtin_wasm_bitselect, "V4iV4iV4iV4i", "nc")
+
aheejin wrote:
> Do you think we need to provide this builtin also for other vector types?
This builtin is inter
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
The new implementation is a GlobalCompilationDatabase that overlays a base.
Normally this is the directory-based CDB.
To preserve the be
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
This allows customizing the flags used when no compile database is
available. It addresses some uses of the old extraFlags extension.
Author: sammccall
Date: Wed Oct 24 21:22:52 2018
New Revision: 345235
URL: http://llvm.org/viewvc/llvm-project?rev=345235&view=rev
Log:
[clangd] Clean up LSP structs around configuration. NFC, no protocol changes.
- align struct names/comments with LSP, remove redundant "clangd" prefixes.
- don
Charusso added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:202
+ void finalizeConstraints() {
+Constraints.clear();
+ }
george.karpenkov wrote:
> These constraints are conceptually part of the visitor, n
Author: ctopper
Date: Wed Oct 24 22:04:35 2018
New Revision: 345237
URL: http://llvm.org/viewvc/llvm-project?rev=345237&view=rev
Log:
[CodeGen] Always emit the 'min-legal-vector-width' attribute even when the
value is 0.
The X86 backend will need to see the attribute to make decisions. If it isn
sammccall added a comment.
BTW I'm holding off submitting this until we decide the fate of
https://reviews.llvm.org/D53688.
If we're going to add that extension, I'd like to land the two patches together
so the former user of this extension can rely on *one* of them being available.
Repository
201 - 238 of 238 matches
Mail list logo
