sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clangd/index/Serialization.cpp:303
// A refs section has data grouped by Symbol. Each symbol has:
-// - SymbolID: 20 bytes
+// - SymbolID: 16 bytes
// - NumRefs: varint
Author: sammccall
Date: Tue Oct 23 23:58:42 2018
New Revision: 345113
URL: http://llvm.org/viewvc/llvm-project?rev=345113&view=rev
Log:
[clangd] Truncate SymbolID to 16 bytes.
Summary:
The goal is 8 bytes, which has a nonzero risk of collisions with huge indexes.
This patch should shake out any i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345113: [clangd] Truncate SymbolID to 16 bytes. (authored by
sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53587?vs=170684&id=170
mstorsjo added inline comments.
Comment at: lib/Driver/Driver.cpp:1013-1014
}
+ for (auto *Str : {&Dir, &InstalledDir, &SysRoot, &DyldPrefix, &ResourceDir})
+*Str = llvm::sys::path::convert_to_slash(*Str);
rnk wrote:
> zturner wrote:
> > Is this going t
Author: sammccall
Date: Wed Oct 24 00:59:38 2018
New Revision: 345119
URL: http://llvm.org/viewvc/llvm-project?rev=345119&view=rev
Log:
[clangd] Embed fixes as CodeAction, instead of clangd_fixes. Clean up
serialization.
Summary:
CodeAction provides us with a standard way of representing fixes i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345119: [clangd] Embed fixes as CodeAction, instead of
clangd_fixes. Clean up… (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
kadircet marked 2 inline comments as done.
kadircet added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:277
+
+/// Code completion occurred where an existing name is expected.
+CCC_ExistingName,
sammccall wrote:
> It's not obvious
whisperity added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:238
+ /// message on that constraint being changed.
+ bool isChangedOrInsertConstraint(ConstraintMap &Constraints, const Stmt
*Cond,
+
Author: yamaguchi
Date: Wed Oct 24 01:24:16 2018
New Revision: 345121
URL: http://llvm.org/viewvc/llvm-project?rev=345121&view=rev
Log:
[bash-autocompletion] Fix bug when a flag ends with '='
There was a bug that when a flag ends with '=' and no value was suggested,
clang autocompletes the flag i
sammccall added a comment.
Logic looks good. Any way we can exercise it with a test via c-index-test?
Comment at: include/clang/Sema/CodeCompleteConsumer.h:281
+
+/// Code completion occurred where an existing symbol is expected.
+CCC_Symbol,
nit: try t
Author: ibiryukov
Date: Wed Oct 24 01:29:24 2018
New Revision: 345122
URL: http://llvm.org/viewvc/llvm-project?rev=345122&view=rev
Log:
[Sema] Do not show unused parameter warnings when body is skipped
Summary: Without the function body, we cannot determine is parameter was used.
Reviewers: ioer
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345122: [Sema] Do not show unused parameter warnings when
body is skipped (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53456?vs=170268&id=170827#toc
Reposi
Rakete updated this revision to Diff 170828.
Rakete added a comment.
Addresed review comments :)
I updated the dr status file but a lot of unrelated changes made it in. Is this
okay?
Repository:
rC Clang
https://reviews.llvm.org/D53595
Files:
include/clang/Basic/DiagnosticSemaKin
Author: ibiryukov
Date: Wed Oct 24 02:00:30 2018
New Revision: 345125
URL: http://llvm.org/viewvc/llvm-project?rev=345125&view=rev
Log:
[clangd] Fix a link in documentation. NFC
Modified:
clang-tools-extra/trunk/docs/clangd.rst
Modified: clang-tools-extra/trunk/docs/clangd.rst
URL:
http://l
kadircet updated this revision to Diff 170829.
kadircet marked an inline comment as done.
kadircet added a comment.
- Update comment.
Repository:
rC Clang
https://reviews.llvm.org/D53191
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Frontend/ASTUnit.cpp
lib/Sema/CodeCompleteCons
kadircet added a comment.
Since it doesn't change any CXCompletionContext's in CIndex it doesn't seem
possible. There are tests being added to
clangd(https://reviews.llvm.org/D53192), since it uses context provided by sema
to decide whether query the index or not, we can check the behavior.
R
hokein added a comment.
looks good, just a few nits.
Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:32
+CheckFactories.registerCheck(
+"abseil-duration-factory-float");
CheckFactories.registerCheck(
Maybe drop the `factory`? we already have
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:700
+ unsigned DiagLoc = Loc.second;
+ if (DiagLoc < StartOfLine || DiagLoc > Offset)
+ return;
kadircet wrote:
> There are also a lot of cases where we can't find an include f
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/ContinuationIndenter.cpp:1594
StartColumn + NewPrefixSize - Style.ColumnLimit : 0;
- return Fixes.second + PrefixExcessCharacters * S
whisperity added a comment.
@dblaikie I have created a test, but unfortunately `%clang_cpp` in LIT invokes
`clang --driver-mode=cpp` which is not the same as if `clang++` is called. I'm
trying to construct the following command-line
`clang++ -fmodules-ts -fprebuilt-module-path=%t/mods --precomp
sammccall added a comment.
All these things are good ideas - I'm not addressing comments yet because I'm
waiting for feedback from the team that's trying this out - maybe this needs
patches, or maybe it'll never work.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53406
___
Author: ibiryukov
Date: Wed Oct 24 02:47:24 2018
New Revision: 345126
URL: http://llvm.org/viewvc/llvm-project?rev=345126&view=rev
Log:
[clangd] Remove outdated comment-out code. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.h
Modified: clang-tools-extra/trunk/clangd/ClangdLSP
whisperity updated this revision to Diff 170832.
whisperity retitled this revision from "[Frontend] Show diagnostics on prebuilt
module configuration mismatch too" to "[Frontend/Modules] Show diagnostics on
prebuilt module configuration mismatch too".
whisperity added a comment.
Herald added a su
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added a subscriber: cfe-commits.
No new tests as the existing tests for result priority should give us
coverage. Also as the new flag is trivial enough, I'm reluctant to plumb the
flag to c-index-test output.
Repository
gchatelet added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:58
+ const QualType Rhs) {
+ assert(Lhs->isRealType()); // Either integer or floating point.
+ assert(Rhs->isFloatingType()); // Floating point only
ilya-biryukov added a comment.
LG, but could we add a test for the new flag it by printing it in
`PrintingCodeCompleteConsumer::ProcessCodeCompleteResults()` and adding
corresponding tests to `clang/test/CodeCompletion`?
Repository:
rC Clang
https://reviews.llvm.org/D53635
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345128: [clangd] Simplify auto hover (authored by ibiryukov,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53347?vs=170273&id=170835#toc
Re
Author: ibiryukov
Date: Wed Oct 24 03:09:34 2018
New Revision: 345128
URL: http://llvm.org/viewvc/llvm-project?rev=345128&view=rev
Log:
[clangd] Simplify auto hover
Summary:
Use helper from clang. Also fixes some weird corner cases, e.g.
auto (*foo)() = bar;
Reviewers: kadircet, hokein
Revi
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:58
+ const QualType Rhs) {
+ assert(Lhs->isRealType()); // Either integer or floating point.
+ assert(Rhs->isFloatingType()); // Floating point only
ioeric added a comment.
In https://reviews.llvm.org/D53635#1273904, @ilya-biryukov wrote:
> LG, but could we add a test for the new flag it by printing it in
> `PrintingCodeCompleteConsumer::ProcessCodeCompleteResults()` and adding
> corresponding tests to `clang/test/CodeCompletion`?
>
> Simil
ioeric updated this revision to Diff 170838.
ioeric added a comment.
- Add tests for the new flag.
Repository:
rC Clang
https://reviews.llvm.org/D53635
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/CodeCompleteConsumer.cpp
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletion
smateo created this revision.
smateo added a reviewer: ABataev.
Herald added a subscriber: cfe-commits.
For the following code:
int i;
#pragma omp taskloop
for (i = 0; i < 100; ++i)
{}
#pragma omp taskloop nogroup
for (i = 0; i < 100; ++i)
{}
Clang emits the following LLVM IR:
ioeric created this revision.
ioeric added reviewers: sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
ioeric added a dependency: D53635: [CodeComplete] Expose InBaseClass signal in
code completion results..
Repository:
rCTE Clang Tools Extr
yamaguchi created this revision.
yamaguchi added reviewers: teemperor, ruiu.
Distinguish "--autocomplete=-someflag" and "--autocomplete=-someflag,"
because the latter indicates that the user put space before pushing tab
which should end up in a file completion.
https://reviews.llvm.org/D53639
F
gchatelet updated this revision to Diff 170846.
gchatelet added a comment.
- Update documentation, makes returning code path more explicit.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
Files:
clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp
clang-tidy/cppc
gchatelet added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:58
+ const QualType Rhs) {
+ assert(Lhs->isRealType()); // Either integer or floating point.
+ assert(Rhs->isFloatingType()); // Floating point only
teemperor requested changes to this revision.
teemperor added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Driver/Driver.cpp:1514
+ // which should end up in a file completion.
+ bool HasSpace = false;
+ if (PassedFlags.endswith(","))
-
huntergr abandoned this revision.
huntergr added a comment.
Abandoning this. At the devmeeting it was agreed that 'getPrimitiveSizeInBits'
should continue to work as-is for fixed-length vectors and only behave
differently for scalable vectors.
https://reviews.llvm.org/D53138
___
hwright updated this revision to Diff 170847.
hwright marked 2 inline comments as done.
hwright added a comment.
Update diagnostic text
https://reviews.llvm.org/D53339
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/DurationFactoryFloatChec
JonasToth added a comment.
Please add a short notice in the release notes for this change.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
yamaguchi updated this revision to Diff 170849.
yamaguchi added a comment.
Updated HasSpace, added comments, fixed typo in the commit message
https://reviews.llvm.org/D53639
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
riccibruno added a comment.
To add on the issue of changing the order of the children. The more I think
about
it the less it seems to be a good idea. Every test passes but I strongly suspect
that a lot of code subtly rely on this.
Repository:
rC Clang
https://reviews.llvm.org/D53607
_
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D53639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
donat.nagy added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:163
+
+switch (FloatingSize) {
+ case 64:
NoQ wrote:
> Continuing the float semantics discussion on the new revision - Did you
> consider `llvm::APFloat`? (h
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:727
- // Skip all operator new/delete methods.
- if (isa(FD))
-return false;
-
- // Return true if tested operator is a standard placement nothrow operator.
- if (FD->getNumParams
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a NIT
Comment at: lib/Sema/CodeCompleteConsumer.cpp:557
+ if (!Tags.empty())
+OS << " (" << llvm::join(Tags, ",") << ")";
+ if (Code
ilya-biryukov added inline comments.
Comment at: unittests/clangd/QualityTests.cpp:187
Relevance.merge(CodeCompletionResult(&findDecl(AST, "S::S"), 42));
- EXPECT_EQ(Relevance.Scope, SymbolRelevanceSignals::GlobalScope);
}
The test case was (accidentally?) r
gchatelet updated this revision to Diff 170851.
gchatelet added a comment.
- Add documentation to ReleaseNotes
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
Files:
clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp
clang-tidy/cppcoreguidelines/NarrowingConver
ilya-biryukov added a comment.
And another NIT :-)
Comment at: lib/Sema/CodeCompleteConsumer.cpp:548
OS << "COMPLETION: ";
+std::vector Tags;
switch (Results[I].Kind) {
NIT: maybe move Tags into the corresponding case handler?
Would require putti
Author: aaronballman
Date: Wed Oct 24 05:26:23 2018
New Revision: 345132
URL: http://llvm.org/viewvc/llvm-project?rev=345132&view=rev
Log:
Support accepting __gnu__ as a scoped attribute namespace that aliases to gnu.
This is useful in libstdc++ to avoid clashes with identifiers in the user's
na
aaron.ballman closed this revision.
aaron.ballman added a comment.
In https://reviews.llvm.org/D53591#1273689, @rsmith wrote:
> Looks good.
Thanks! I've commit in r345132.
> We should provide some reserved-name way of naming clang attributes too, but
> I'm not sure what would be best (`__clan
JonasToth added inline comments.
Comment at: docs/ReleaseNotes.rst:166
+- The :doc:`cppcoreguidelines-narrowing-conversions
+` check.
please concat the two parts, similar to the one above.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D5
gchatelet added a comment.
In https://reviews.llvm.org/D53488#1273986, @JonasToth wrote:
> Please add a short notice in the release notes for this change.
Sorry I keep on missing to update doc/release notes.
Do you see anything else to add to the Patch?
Repository:
rCTE Clang Tools Extra
h
ioeric updated this revision to Diff 170854.
ioeric marked an inline comment as done.
ioeric added a comment.
- move tags into case.
Repository:
rC Clang
https://reviews.llvm.org/D53635
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/CodeCompleteConsumer.cpp
lib/Sema/SemaCode
Author: yamaguchi
Date: Wed Oct 24 05:43:25 2018
New Revision: 345133
URL: http://llvm.org/viewvc/llvm-project?rev=345133&view=rev
Log:
[autocompletion] Handle the space before pressing tab
Summary:
Distinguish "--autocomplete=-someflag" and "--autocomplete=-someflag,"
because the latter indicate
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345133: [autocompletion] Handle the space before pressing
tab (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53639?vs
ioeric updated this revision to Diff 170855.
ioeric added a comment.
- Rebase
Repository:
rC Clang
https://reviews.llvm.org/D53635
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/CodeCompleteConsumer.cpp
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletion/member-access.cpp
ioeric added inline comments.
Comment at: lib/Sema/CodeCompleteConsumer.cpp:557
+ if (!Tags.empty())
+OS << " (" << llvm::join(Tags, ",") << ")";
+ if (CodeCompletionString *CCS = Results[I].CreateCodeCompletionString(
ilya-biryukov wrote:
> NIT
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345133: [autocompletion] Handle the space before pressing
tab (authored by yamaguchi, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53639?vs=170849&id=170856#toc
Repository:
rL L
yamaguchi closed this revision.
yamaguchi added a comment.
Landed in https://reviews.llvm.org/rL345121
https://reviews.llvm.org/D53589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
This was added in https://reviews.llvm.org/D34947 to support YCM, but YCM
actually provides *all* args,
and this was never actually use
hwright added inline comments.
Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:32
+CheckFactories.registerCheck(
+"abseil-duration-factory-float");
CheckFactories.registerCheck(
hokein wrote:
> Maybe drop the `factory`? we already have a durat
Author: hokein
Date: Wed Oct 24 05:56:41 2018
New Revision: 345134
URL: http://llvm.org/viewvc/llvm-project?rev=345134&view=rev
Log:
[clangd] Hide position line and column fields.
Reviewers: sammccall
Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet,
cfe-commits
Differe
Author: ioeric
Date: Wed Oct 24 05:57:27 2018
New Revision: 345135
URL: http://llvm.org/viewvc/llvm-project?rev=345135&view=rev
Log:
[CodeComplete] Expose InBaseClass signal in code completion results.
Summary:
No new tests as the existing tests for result priority should give us
coverage. Also a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345134: [clangd] Hide position line and column fields.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53577
Files:
clang-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345135: [CodeComplete] Expose InBaseClass signal in code
completion results. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D
hokein accepted this revision.
hokein added a comment.
LGTM.
Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:94
+ diag(MatchedCall->getBeginLoc(),
+ (llvm::Twine("Use integer version of absl::") +
+MatchedCall->getDirectCallee()->getName()
ioeric added a comment.
> Keep required quailifier machinery around though, for cross-ns completion.
Do we have cross-ns completion in sema?
Comment at: clangd/CodeComplete.cpp:732
+ // Class members that are shadowed by subclasses are usually noise.
+ if (Result.Hid
JonasToth added a comment.
ping :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
It doesn't make much sense: setting them is not coupled to opening the file,
it's an asynchronous notification.
I don't think this is a
ioeric added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:112
+SPAN_ATTACH(Tracer, "Params", Params);
+ReplyOnce Reply(ID, Method, &Server, Tracer.Args);
log("<-- {0}({1})", Method, ID);
Do we have guarantee that `Tracer.Args` outlives `Re
sammccall added a comment.
In https://reviews.llvm.org/D53571#1274082, @ioeric wrote:
> > Keep required quailifier machinery around though, for cross-ns completion.
>
> Do we have cross-ns completion in sema?
No, I don't think so. I meant RequiredQualifier etc.
Unfortunately I've got no idea wh
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: unittests/clangd/QualityTests.cpp:187
Relevance.merge(CodeCompletionResult(&findDecl(AST, "S::S"), 42));
- EXPECT_EQ(Relevance.Scope, SymbolRelevanceSignals::GlobalScope);
}
i
ioeric updated this revision to Diff 170862.
ioeric marked an inline comment as done.
ioeric added a comment.
- restore accidentally removed test.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53638
Files:
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/QualityTests
sammccall updated this revision to Diff 170863.
sammccall added a comment.
Remove misleading change to test.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53571
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/CodeComplete.cpp
clangd/GlobalCompilationD
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Quality.cpp:380
+ if (InBaseClass)
+Score *= 0.7;
+
This seems like a pretty light penalty to me, I'd consider 0.5...
Rep
erichkeane marked 2 inline comments as done.
erichkeane added a comment.
In https://reviews.llvm.org/D53586#1273546, @rnk wrote:
> Seems reasonable. Should the resolver still be called `?foo@.resolver`, or
> should it get a new name, since it is quite functionally different now?
I'm not attach
sammccall updated this revision to Diff 170866.
sammccall added a comment.
Clarify Span::Args lifetime.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53399
Files:
clangd/ClangdLSPServer.cpp
clangd/Trace.h
Index: clangd/Trace.h
=
sammccall added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:112
+SPAN_ATTACH(Tracer, "Params", Params);
+ReplyOnce Reply(ID, Method, &Server, Tracer.Args);
log("<-- {0}({1})", Method, ID);
ioeric wrote:
> Do we have guarantee that `Tracer
ABataev added inline comments.
Comment at: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu:389
unsigned WID = getWarpId();
+ // void * volatile FramePointer = 0;
void *&FrameP = DataSharingState.FramePtr[WID];
This must be removed
Comm
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
The diff seems to be wrong. Please rebase.
Comment at: clangd/CodeComplete.cpp:732
+ // Class members that are shadowed by subclasses are usually noise.
+ if (Resul
LukeCheeseman updated this revision to Diff 170869.
https://reviews.llvm.org/D51429
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/CodeGenOptions.h
ABataev added a comment.
What about tests?
Repository:
rC Clang
https://reviews.llvm.org/D53443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 170870.
ioeric marked an inline comment as done.
ioeric added a comment.
- adjust parameter
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53638
Files:
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/QualityTests.cpp
Index: unit
ioeric added inline comments.
Comment at: clangd/Quality.cpp:380
+ if (InBaseClass)
+Score *= 0.7;
+
sammccall wrote:
> This seems like a pretty light penalty to me, I'd consider 0.5...
0.5 sounds reasonable. I think we should penalize the non-instance membe
sammccall added inline comments.
Comment at: clangd/Quality.cpp:380
+ if (InBaseClass)
+Score *= 0.7;
+
ioeric wrote:
> sammccall wrote:
> > This seems like a pretty light penalty to me, I'd consider 0.5...
> 0.5 sounds reasonable. I think we should penalize
wuzish marked 8 inline comments as done.
wuzish added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3941
+ return ImplicitConversionSequence::Better;
+ }
+
hubert.reinterpretcast wrote:
> This seems to duplicate the bug described here in
> h
Author: ioeric
Date: Wed Oct 24 06:45:17 2018
New Revision: 345140
URL: http://llvm.org/viewvc/llvm-project?rev=345140&view=rev
Log:
[clangd] Downrank members from base class
Reviewers: sammccall, ilya-biryukov
Reviewed By: sammccall
Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345140: [clangd] Downrank members from base class (authored
by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53638
Files:
clang-tools
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, jfb, arphaman, jkorous,
MaskRay, ioeric, javed.absar.
To enable this, TUScheduler has to provide a way to run async tasks without
needing a preamble or AST!
Repository:
wuzish updated this revision to Diff 170871.
wuzish marked 2 inline comments as done.
wuzish added a comment.
Updated the diff.
fix some points from comments.
https://reviews.llvm.org/D53417
Files:
clang/lib/Sema/SemaOverload.cpp
clang/test/Sema/altivec-generic-overload.c
Index: clang/tes
sammccall updated this revision to Diff 170875.
sammccall added a comment.
Rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53571
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345141: [clangd] Don't show base class versions of
members as completions. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53571?vs=170875&id=170876#toc
Rep
Author: sammccall
Date: Wed Oct 24 06:51:44 2018
New Revision: 345141
URL: http://llvm.org/viewvc/llvm-project?rev=345141&view=rev
Log:
[clangd] Don't show base class versions of members as completions.
Summary:
These are available via qualifiers, but signal to noise level is low.
Keep required q
gchatelet updated this revision to Diff 170878.
gchatelet marked an inline comment as done.
gchatelet added a comment.
- Join the two parts of the ReleaseNotes update
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
Files:
clang-tidy/cppcoreguidelines/NarrowingConversions
JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
Did you run this code over a real-world code-base and did you find new stuff
and/or false positives or the like?
From my side LGTM unless other reviewers see outstanding issues.
Reposi
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:56-57
-void NarrowingConversionsCheck::check(const MatchFinder::MatchResult &Result) {
- if (const auto *Op = Result.Nodes.getNodeAs("op")) {
-if (Op->getBeginLoc().
Author: sammccall
Date: Wed Oct 24 07:26:26 2018
New Revision: 345144
URL: http://llvm.org/viewvc/llvm-project?rev=345144&view=rev
Log:
[clangd] Ensure that we reply to each call exactly once. NFC (I think!)
Summary:
In debug builds, getting this wrong will trigger asserts.
In production builds,
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:904
+ ///
+ virtual bool isStaticChunked(OpenMPDistScheduleClauseKind ScheduleKind,
+ bool Chunked) const;
I'd rename this into `isDistStaticChunked`
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345144: [clangd] Ensure that we reply to each call exactly
once. NFC (I think!) (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53399?vs=170866&id=170881#toc
1 - 100 of 238 matches
Mail list logo
