[PATCH] D52750: [Diagnostics] Check for integer overflow in array size expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL344759: [Diagnostics] Check for integer overflow in array size expressions (authored by xbolva00, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D53072: [clang-format] Introduce the flag which allows not to shrink lines

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. In general there's a high bar for adding new style options to clang-format: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options https://revie

[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. OK, so this is not a real bug in the sense of non-working current features, it's more like a feature request. As per https://clang.llvm.org/docs/ClangFormatStyleOptions.html#addi

[PATCH] D53410: Add missing PATH_MAX for GNU Hurd support

rsmith added inline comments. Comment at: lib/Basic/FileManager.cpp:514-519 +// For GNU Hurd +#if defined(__GNU__) && !defined(PATH_MAX) +# define PATH_MAX 4096 +#endif + + This doesn't appear to be necessary: the identifier PATH_MAX does not appear later in thi

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. As per https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options, could you please provide more info about the need for this option first? https:

[clang-tools-extra] r344760 - [clang-tidy] readability-uppercase-literal-suffix: specify target for opencl test

Author: lebedevri Date: Thu Oct 18 13:59:03 2018 New Revision: 344760 URL: http://llvm.org/viewvc/llvm-project?rev=344760&view=rev Log: [clang-tidy] readability-uppercase-literal-suffix: specify target for opencl test I'm not sure if it will actually help or not. ppc64be-clang-lnt-test bot is fa

r344761 - [Diagnostics] Add missing expected warning to test file

Author: xbolva00 Date: Thu Oct 18 14:06:14 2018 New Revision: 344761 URL: http://llvm.org/viewvc/llvm-project?rev=344761&view=rev Log: [Diagnostics] Add missing expected warning to test file Modified: cfe/trunk/test/SemaCXX/enum.cpp Modified: cfe/trunk/test/SemaCXX/enum.cpp URL: http://llvm

r344762 - [Test] Fix test file for C++98 mode

Author: xbolva00 Date: Thu Oct 18 14:26:01 2018 New Revision: 344762 URL: http://llvm.org/viewvc/llvm-project?rev=344762&view=rev Log: [Test] Fix test file for C++98 mode Modified: cfe/trunk/test/SemaCXX/enum.cpp Modified: cfe/trunk/test/SemaCXX/enum.cpp URL: http://llvm.org/viewvc/llvm-pro

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

djasper added a comment. Ok, I think I agree with both of you to a certain extent, but I also think this change as is, is not yet right. First, it does too much. The original very first example in this CL is actually not produced by clang-format (or if it is, I don't know with which flag combi

[PATCH] D51633: [ASTImporter] Added error handling for AST import.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Balasz, I cannot find any problems with the latest changes. I suggest you to commit the patch to make further reviews easier. Comment at: lib/AST/ASTImporter.cpp:81

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. In https://reviews.llvm.org/D52676#1268706, @djasper wrote: > Ok, I think I agree with both of you to a certain extent, but I also think > this change as is, is not yet right. > > First, it does too much. The original very first example in this CL is > actually not

[PATCH] D53354: [WIP][NOT FOR COMMIT][PROTOTYPE] clang-scan-deps: dependency scanning tool rough prototype

arphaman added a comment. In https://reviews.llvm.org/D53354#1267376, @whisperity wrote: > With regards to https://reviews.llvm.org/D53352: you can change the diff > related to a patch whilst keeping discuccion and metadata of the diff. Good point, thanks! > Please add a generic description t

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

mgrang updated this revision to Diff 170133. https://reviews.llvm.org/D53115 Files: include/clang/Basic/BuiltinsAArch64.def lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h lib/Sema/SemaChecking.cpp test/CodeGen/arm64-microsoft-status-reg.cpp test/Sema/builtins-microsoft-arm64.c Index:

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Bump! Thanks for your time! https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D53115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

r344765 - [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

Author: mgrang Date: Thu Oct 18 16:35:35 2018 New Revision: 344765 URL: http://llvm.org/viewvc/llvm-project?rev=344765&view=rev Log: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics Reviewers: rnk, compnerd, mstorsjo, efriedma, TomTan, haripul, javed.absar Reviewed By: efriedma Su

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC344765: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics (authored by mgrang, committed by ). Repository: rC Clang https://reviews.llvm.org/D53115 Files: include/clang/Basic/BuiltinsAA

[PATCH] D53238: [Driver] Add -static-{rtlib, stdlib} and make -static-{libgcc, libstdc++} their aliases

MaskRay added a comment. Greeting from a dev meeting attendee :) Repository: rC Clang https://reviews.llvm.org/D53238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r344767 - [COFF, ARM64] Enable unit test arm64-microsoft-status-reg.cpp only for aarch64 target

Author: mgrang Date: Thu Oct 18 17:05:26 2018 New Revision: 344767 URL: http://llvm.org/viewvc/llvm-project?rev=344767&view=rev Log: [COFF, ARM64] Enable unit test arm64-microsoft-status-reg.cpp only for aarch64 target This should unbreak bots broken here: http://lab.llvm.org:8011/builders/clang

[PATCH] D53263: [CodeGen] Fix places where the return type of a FunctionDecl was being used in place of the function type

bobsayshilol updated this revision to Diff 170136. bobsayshilol edited the summary of this revision. bobsayshilol added a comment. Fixed the added assert to do the right thing. Clang can now build with a debug Clang built from this patch, and all unittests I could find pass in that built version

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

alexshap added a comment. I talked to David @dblaikie offline about this diff yesterday, if I understood correctly this change is reasonable in general, @echristo Eric, would you mind having a look at this diff ? https://reviews.llvm.org/D52296 _

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

alexshap added a comment. Ping https://reviews.llvm.org/D52296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53354: [WIP][NOT FOR COMMIT][PROTOTYPE] clang-scan-deps: dependency scanning tool rough prototype

dexonsmith added inline comments. Comment at: lib/Lex/FilterToIncludes.cpp:628 + First = Id.Last; + auto Kind = llvm::StringSwitch(Id.Name) + .Case("include", pp_include) arphaman wrote: > arphaman wrote: > > arphaman wrote: > > > ddunbar wrote

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

djasper added a comment. In https://reviews.llvm.org/D52676#1268748, @oleg.smolsky wrote: > In https://reviews.llvm.org/D52676#1268706, @djasper wrote: > > > Ok, I think I agree with both of you to a certain extent, but I also think > > this change as is, is not yet right. > > > > First, it do

[PATCH] D53135: Remove top-level using declaration from header files, as these aliases leak.

rnk added inline comments. Comment at: cfe/trunk/include/clang/Serialization/GlobalModuleIndex.h:147 static std::pair - readIndex(StringRef Path); + readIndex(llvm::StringRef Path); It's preferred to include clang/Basic/LLVM.h instead and use the StringRef

[clang-tools-extra] r344772 - [clang-tidy] readability-uppercase-literal-suffix: specify target for ms test too

Author: lebedevri Date: Thu Oct 18 23:04:07 2018 New Revision: 344772 URL: http://llvm.org/viewvc/llvm-project?rev=344772&view=rev Log: [clang-tidy] readability-uppercase-literal-suffix: specify target for ms test too Apparently the bots were still failing with this. Sadly, i did not see *this*

[clang-tools-extra] r344773 - [clangd] Fix msan failure after r344735 by initializing bitfields

Author: krasimir Date: Thu Oct 18 23:05:32 2018 New Revision: 344773 URL: http://llvm.org/viewvc/llvm-project?rev=344773&view=rev Log: [clangd] Fix msan failure after r344735 by initializing bitfields That revision changed integer members to bitfields; the integers were default initialized before

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh updated this revision to Diff 170148. twoh added a comment. Herald added a subscriber: jfb. Rebase. Sorry I somehow missed the recent comments. I addresses @davidxl's comment on documentation. Thanks! Repository: rC Clang https://reviews.llvm.org/D34796 Files: docs/ClangCommandLineRe

<    1   2