$ bin/clang -target wasm32-unknown-unknown -fuse-ld=wasm-ld -o test.wasm
test.cc
clang: error: invalid linker name in argument '-fuse-ld=wasm-ld'
This here http://llvm-cs.pcc.me.uk/tools/clang/lib/Driver/ToolChain.cpp#453
makes clang look for "ld.wasm-ld", but the wasm lld symlink is called
"wasm-
ebevhan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1032
+ // them.
+ return Builder.CreateIsNotNull(Src);
+}
Is this comment true? I don't think EmitFixedPointConversion does this.
Maybe I'm misinterpreting what it means.
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
This is useful for symbo scope proximity, where down traversals from
the global scope if not desired. The limitation in the current impleme
takuto.ikuta updated this revision to Diff 169791.
takuto.ikuta added a comment.
Fix linkage for inline function of explicit template instantiation declaration
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.h
clang/include/cl
peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.
Looks good to me. REQUIRES: x86-registered-target is used in the same directory
for tests that depend on specific targets.
Repository:
rC Clang
https://reviews.llvm.org/D53272
takuto.ikuta updated this revision to Diff 169792.
takuto.ikuta added a comment.
remove comment out code
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Driver/C
sammccall added a comment.
The slightly weird down-traversals semantics are indeed slightly weird. I'm
happy to move forward with this approach though if we document it.
I did think of one alternative:
- instead of `unsigned Source::MaxDownTraversals`, have `bool
Source::AllowDownTraversals` (
Author: yroux
Date: Tue Oct 16 01:47:36 2018
New Revision: 344593
URL: http://llvm.org/viewvc/llvm-project?rev=344593&view=rev
Log:
Add target requirement to profile remap test.
Fix bots which don't have x86_64 target built (ARM/AArch64).
Differential Revision: https://reviews.llvm.org/D53272
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jfb, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov.
One relatively boring bug: forgot to notify the CV after enqueue.
One much more fun bug: the thread member could access instance v
Author: sammccall
Date: Tue Oct 16 01:53:52 2018
New Revision: 344594
URL: http://llvm.org/viewvc/llvm-project?rev=344594&view=rev
Log:
[clangd] Optionally use dex for the preamble parts of the dynamic index.
Summary:
Reuse the old -use-dex-index experiment flag for this.
To avoid breaking the t
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rL344594: [clangd] Optionally use dex for the preamble parts
of the dynamic index. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Author: sammccall
Date: Tue Oct 16 02:05:13 2018
New Revision: 344595
URL: http://llvm.org/viewvc/llvm-project?rev=344595&view=rev
Log:
[clangd] Fix threading bugs in (not-yet-used) BackgroundIndex, re-enable test.
Summary:
One relatively boring bug: forgot to notify the CV after enqueue.
One mu
Sorry Douglas. It was indeed a flaky test. Disabled in r344586 and then
fixed in r344595.
On Tue, Oct 16, 2018 at 3:57 AM wrote:
> Hi Sam,
>
> The test you added in this commit is timing out when run on the PS4
> Windows bot:
>
>
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344595: [clangd] Fix threading bugs in (not-yet-used)
BackgroundIndex, re-enable test. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://revie
Author: psmith
Date: Tue Oct 16 02:21:17 2018
New Revision: 344597
URL: http://llvm.org/viewvc/llvm-project?rev=344597&view=rev
Log:
[ARM][AArch64] Pass through endian flags to assembler and linker.
The big-endian arm32 Linux builds are currently failing when the
-mbig-endian flag is used but the
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344597: [ARM][AArch64] Pass through endian flags to
assembler and linker. (authored by psmith, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52784?vs=169689&id=169799#toc
Repositor
Author: rksimon
Date: Tue Oct 16 02:21:58 2018
New Revision: 344598
URL: http://llvm.org/viewvc/llvm-project?rev=344598&view=rev
Log:
Fix buildbots - update clang-interpreter to use Legacy ORC classes introduced
in rL344572.
Modified:
cfe/trunk/examples/clang-interpreter/main.cpp
Modified:
wzssyqa added a comment.
In https://reviews.llvm.org/D50850#1250313, @atanasyan wrote:
> In https://reviews.llvm.org/D50850#1250285, @wzssyqa wrote:
>
> > This is really for Clang. I guess you mean that compiler-rt directory also
> > need to be patched.
>
>
> If you take a look at the previous v
Szelethus added a comment.
Why d
Comment at: clang/www/analyzer/open_projects.html:153
+ problem still remains open.
+
+ (Difficulty: Hard)
Did you mean to have this newline here? Difficulty seems to have a weird
placement when viewed in a browser.
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
This is useful for symbo scope proximity, where down traversals from
the global scope if not desired.
Repository:
rCTE Clang Tools Extr
ioeric abandoned this revision.
ioeric added a comment.
As discussed offline, the semantics is getting a bit complicated. As what we
really want for scope proximity is just disallow down traversals from root, we
can go with special-casing the root path for now:
https://reviews.llvm.org/D53317
Author: atanasyan
Date: Tue Oct 16 03:19:06 2018
New Revision: 344603
URL: http://llvm.org/viewvc/llvm-project?rev=344603&view=rev
Log:
[driver][mips] Adjust target triple's environment accordingly to provided ABI
name
For MIPS we need to adjust not only architecture name accordingly to ABI
prov
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Works for me! I think the code can be simplified slightly.
Comment at: clangd/FileDistance.cpp:135
}
+ if ((KnownNode == RootHash) && !Opts.AllowDownTraversalFromRo
sberg added a comment.
doesnt this make -Wshadow more aggressive for enumerators than for other
entities?
~ cat test17.cc
struct S1;
struct S2;
struct S3 {
void S1();
enum { S2 };
};
~ llvm/inst/bin/clang++ -fsyntax-only -Wshadow test17.cc
test17.cc:5:10: warning: decla
ioeric updated this revision to Diff 169804.
ioeric marked an inline comment as done.
ioeric added a comment.
- Simplify according to review suggestion.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53317
Files:
clangd/FileDistance.cpp
clangd/FileDistance.h
unittests/cla
Author: ioeric
Date: Tue Oct 16 03:41:17 2018
New Revision: 344604
URL: http://llvm.org/viewvc/llvm-project?rev=344604&view=rev
Log:
[clangd] Allow disble down traversals from root.
Summary:
This is useful for symbo scope proximity, where down traversals from
the global scope if not desired.
Rev
takuto.ikuta added a comment.
Herald added a subscriber: nhaehnle.
Hans, I addressed all your comments.
How do you think about current implementation?
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5719
+ TSK != TSK_ExplicitInstantiationDeclaration &&
+ TSK != TSK
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344604: [clangd] Allow disble down traversals from root.
(authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53317?vs=169804&id=169805#toc
Repository:
rCTE Clang
filcab added a comment.
In https://reviews.llvm.org/D52615#1254567, @rsmith wrote:
> This seems like an unreasonably long flag name. Can you try to find a shorter
> name for it?
`-fsanitize-poison-extra-operator-new`?
Not as explicit, but maybe ok if documented?
Thank you,
Filipe
Repository
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1318
+CGM.getModule().getMDKindID("invariant.load"),
+llvm::MDNode::get(getLLVMContext(), None));
+
rjmccall wrote:
> OpenCL blocks are still potentially function-local, right? I
sammccall updated this revision to Diff 169807.
sammccall added a comment.
Add unit test for JSON transport.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53286
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/JSONRPCDispatcher.cp
aaron.ballman added a comment.
In https://reviews.llvm.org/D52400#1266307, @sberg wrote:
> doesnt this make -Wshadow more aggressive for enumerators than for other
> entities?
It does, but whether that's an issue with the enumerator shadow diagnosing or
with the other entities not diagnosing,
wzssyqa updated this revision to Diff 169810.
https://reviews.llvm.org/D50850
Files:
lib/Driver/ToolChains/Arch/Mips.cpp
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Linux.cpp
test/CodeGen/atomics-inlining.c
test/CodeGen/mips-zero-sized-struct.c
test/CodeGen/target-data.c
tes
ioeric updated this revision to Diff 169814.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- refactor to use FileDistance and address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53131
Files:
clangd/AST.cpp
clangd/AST.h
clangd/CodeCom
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Add a flag to SymbolCollector to collect refs fdrom headers.
Note that we collect refs from headers in static index, and we don't do it for
dyn
hokein added a comment.
For references, the binary-format index file (for whole llvm project) size:
| Before | WithRef |
| 50MB | 91MB|
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53322
___
cfe-commits mailing list
cfe-com
Hi Michal,
AArch64 bots are broken as well, logs are available at:
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/15717/steps/ninja%20check%201/logs/stdio
Cheers,
Yvan
On Mon, 15 Oct 2018 at 20:39, Ulrich Weigand via Phabricator via
cfe-commits wrote:
>
> uweigand added a com
kparzysz added a comment.
Hexagon clang builder has been failing since around the time of this commit as
well:
http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/20617/steps/ninja%20check%201/logs/stdio
Repository:
rC Clang
https://reviews.llvm.org/D52840
_
sammccall added inline comments.
Comment at: clangd/AST.cpp:77
+ for (const auto *Ctx = &DC; Ctx != nullptr; Ctx = Ctx->getParent())
+if (const auto *NS = dyn_cast(Ctx))
+ if (!NS->isAnonymousNamespace() && !NS->isInlineNamespace())
It would be nice to
Author: atanasyan
Date: Tue Oct 16 07:29:27 2018
New Revision: 344608
URL: http://llvm.org/viewvc/llvm-project?rev=344608&view=rev
Log:
[driver][mips] Support MIPS R6 target triples
This change adds support for the following MIPS target triples:
mipsisa32r6-linux-gnu
mipsisa32r6el-linux-gnu
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the patch.
https://reviews.llvm.org/D50850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344608: [driver][mips] Support MIPS R6 target triples
(authored by atanasyan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50850?vs=169810&
sammccall added a comment.
This looks reasonable. +80% to index size is a shame, but not disastrous, and
we have ways to shave it.
Can you check:
- how much we're increasing the in-memory size (Dex)
- that we're not outputting duplicate refs when preambles overlap between TUs
===
Author: uweigand
Date: Tue Oct 16 07:57:20 2018
New Revision: 344611
URL: http://llvm.org/viewvc/llvm-project?rev=344611&view=rev
Log:
[SystemZ] Actually enable -mzvector keywords
It appears when initially committing the support for the IBM Z vector
extension language, one critical line was lost,
simark marked 7 inline comments as done.
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:433
reparseOpenedFiles();
}
sammccall wrote:
> sammccall wrote:
> > This isn't needed, the compilation database can only be set during
> > ini
simark updated this revision to Diff 169828.
simark marked 3 inline comments as done.
simark added a comment.
Address comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53220
Files:
clangd/ClangdLSPServer.cpp
clangd/Protocol.cpp
clangd/Protocol.h
test/clangd/compil
ioeric added a comment.
Nice! The code looks much clearer. Just some nits
Comment at: clangd/ClangdLSPServer.cpp:156
+void ClangdLSPServer::onExit(ExitParams &Params) {
+ // XXX handler should return true.
+}
?
Comment at: clangd/ClangdLSPSe
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
(please do check there are no duplicates in the output)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53322
___
cfe-commi
sammccall accepted this revision.
sammccall added a comment.
Still LG!
Comment at: clangd/Protocol.h:422
+struct ClangdInitializationOptions : public ClangdConfigurationParamsChange {
+ llvm::Optional compilationDatabasePath;
+};
simark wrote:
> sammccall wrot
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: clangd/ClangdLSPServer.cpp:338
+ Command Cmd;
+ if (Action.command && Action.edit)
+return llvm::None;
sammccall wrote:
>
yaxunl created this revision.
yaxunl added a reviewer: kzhuravl.
Herald added a subscriber: tpr.
AMDGPU backend will switch to code object version 3 by default.
Since HIP runtime is not ready, disable it until the runtime is ready.
https://reviews.llvm.org/D53325
Files:
lib/Driver/ToolChains/
mgorny created this revision.
mgorny added reviewers: uweigand, yroux, kparzysz, steveire, aaron.ballman.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
Disable the Python binding tests on AArch64, Hexagon and SystemZ
following reports on test failures. The first
mgorny added a comment.
Thanks for all your reports. I have filed https://reviews.llvm.org/D53326 to
disable the tests on all three known-broken arches.
Repository:
rC Clang
https://reviews.llvm.org/D52840
___
cfe-commits mailing list
cfe-commit
Author: simark
Date: Tue Oct 16 08:55:03 2018
New Revision: 344614
URL: http://llvm.org/viewvc/llvm-project?rev=344614&view=rev
Log:
Remove possibility to change compile database path at runtime
Summary:
This patch removes the possibility to change the compilation database
path at runtime using t
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344614: Remove possibility to change compile database path
at runtime (authored by simark, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53220?vs=169828&id=169833#toc
Repository:
sidneym created this revision.
sidneym added reviewers: phosek, rsmith, kparzysz, bcain.
Herald added a subscriber: cfe-commits.
Use -fuse-ld to explicitly name the linker. Replace checks for hexagon-link |
ld to just "hexagon-link", the name of the explicitly chosen linker.
Repository:
rC C
sammccall marked 9 inline comments as done.
sammccall added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:156
+void ClangdLSPServer::onExit(ExitParams &Params) {
+ // XXX handler should return true.
+}
ioeric wrote:
> ?
Fixed this comment.
I'm not tota
sammccall updated this revision to Diff 169835.
sammccall marked 9 inline comments as done.
sammccall added a comment.
Addressed review comments.
Also inverted the sense of the boolean return from `onNotify` etc, was "should
exit" and is now "should continue", which I think is slightly clearer.
sammccall updated this revision to Diff 169837.
sammccall added a comment.
rebase only
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53213
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Protocol.cpp
clangd/Protocol.h
test/clangd/fixits-codeaction.t
Author: sammccall
Date: Tue Oct 16 09:29:41 2018
New Revision: 344617
URL: http://llvm.org/viewvc/llvm-project?rev=344617&view=rev
Log:
[clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8)
Summary:
I don't bother mirroring the full capabilities struct, just parse the
bits we ca
sammccall added inline comments.
Comment at: clangd/Protocol.h:390
+ /// Flattened from codeAction.codeActionLiteralSupport.
+ // FIXME: flatten other properties in this way.
+ bool codeActionLiteralSupport = false;
kadircet wrote:
> sammccall wrote:
> > kadir
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344617: [clangd] Send CodeAction responses to
textDocument/codeAction (LSP 3.8) (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/JSONRPCDispatcher.h:70
/// A handler responds to requests for a particular method name.
+ /// It returns true if the server should now shut down.
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D53325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
sammccall updated this revision to Diff 169839.
sammccall added a comment.
Rebase to include CodeAction literal support
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53266
Files:
clangd/ClangdLSPServer.cpp
clangd/Protocol.cpp
clangd/Protocol.h
Index: clangd/Protocol.h
=
Author: sammccall
Date: Tue Oct 16 09:48:06 2018
New Revision: 344620
URL: http://llvm.org/viewvc/llvm-project?rev=344620&view=rev
Log:
[clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction.
Summary:
This paves the way for alternative transports (mac XPC, maybe messagepack?),
a
This revision was automatically updated to reflect the committed changes.
sammccall marked 5 inline comments as done.
Closed by commit rL344620: [clangd] Refactor JSON-over-stdin/stdout code into
Transport abstraction. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits
yonghong-song created this revision.
yonghong-song added reviewers: vsk, HsiangKai, ABataev.
yonghong-song added a project: debug-info.
Herald added subscribers: cfe-commits, JDevlieghere, aprantl.
A llvm segfault happens when I tried to add "-g -gdwarf-5 -gembed-source"
in bcc in order to get sor
yonghong-song added a comment.
Hi, @vsk @HsiangKai @ABataev I found a bug in clang when trying to use "-g
-gdwarf-5 -gembed-source" for
bcc MCJIT based clang/llvm compilation. This patch fixed the issue but I am not
sure whether this is the
correct fix or not. Please help take a look and advise
aprantl added a comment.
Couldn't you just pass `-main-file-name` to cc1 instead?
Repository:
rC Clang
https://reviews.llvm.org/D53329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
b-sumner added a comment.
Ping. There's quite a bit of interest in getting this exposed by clang.
https://reviews.llvm.org/D52320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yonghong-song added a comment.
We already have `-main-file-name` in cc1.
`clang -cc1 -triple x86_64-unknown-linux-gnu ... -main-file-name main.c ... -o
main.bc -x c /virtual/main.c -faddrsig`
Is this expected?
BTW, we just pass the normal C flags to the driver like
vector flags_cstr({"-O0", "
yonghong-song added a comment.
In the above `/virtual/main.c` is a memory mapped file. The
`invocation0.getPreprocessorOpts().addRemappedFile(...)` adds the mapping
for the compilation.
Repository:
rC Clang
https://reviews.llvm.org/D53329
___
cf
vsapsai updated this revision to Diff 169849.
vsapsai added a comment.
Herald added a subscriber: hiraditya.
- Rebase on top of the latest changes in trunk.
- Address review comments.
I expect diff between diffs to be noisy due to rebase.
https://reviews.llvm.org/D50539
Files:
clang/lib/Fron
AlexeySachkov updated this revision to Diff 169851.
AlexeySachkov added a comment.
Added test
https://reviews.llvm.org/D53200
Files:
lib/Serialization/ASTWriter.cpp
test/Headers/opencl-pragma-extension-begin.cl
test/Headers/opencl-pragma-extension-begin.h
Index: test/Headers/opencl-prag
Author: yaxunl
Date: Tue Oct 16 10:36:23 2018
New Revision: 344630
URL: http://llvm.org/viewvc/llvm-project?rev=344630&view=rev
Log:
Disable code object version 3 for HIP toolchain
AMDGPU backend will switch to code object version 3 by default.
Since HIP runtime is not ready, disable it until the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344630: Disable code object version 3 for HIP toolchain
(authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53325?vs=169831&i
leonardchan added a comment.
@philip.pfaffe @fedor.sergeev Do you have any more comments on this patch?
Repository:
rC Clang
https://reviews.llvm.org/D52814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
vsapsai marked 5 inline comments as done.
vsapsai added inline comments.
Comment at: clang/lib/Basic/VirtualFileSystem.cpp:934
RedirectingFileSystem &FS;
RedirectingDirectoryEntry::iterator Current, End;
+ bool IsExternalFSCurrent;
bruno wrote:
> Can you a
vsapsai marked 3 inline comments as done.
vsapsai added a comment.
In https://reviews.llvm.org/D50539#1241034, @bruno wrote:
> > - Current way of working with modules in VFS "root" is clunky and
> > error-prone.
>
> Why?
Mostly because when you approach it in a straightforward way, you cannot
Szelethus updated this revision to Diff 169858.
Szelethus added a comment.
Removed the version entry from the plist file.
https://reviews.llvm.org/D52742
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/BugRepor
Szelethus updated this revision to Diff 169862.
Szelethus added a comment.
Herald added a subscriber: donat.nagy.
- Removed the version entry from the plist file,
- Now using `TokenConcatenation` to print spaces only when needed (this needed
for https://reviews.llvm.org/D52988),
- A bit more doc,
whisperity created this revision.
whisperity added reviewers: rsmith, doug.gregor.
whisperity added a project: clang.
Herald added subscribers: Szelethus, dkrupp, rnkovacs.
The current version only emits the below error for a module (attempted to be
loaded) from the `prebuilt-module-path`:
er
leonardchan updated this revision to Diff 169863.
leonardchan marked 3 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D53308
Files:
clang/include/clang/AST/OperationKinds.def
clang/lib/AST/Expr.cpp
clang/lib/AST/ExprConstant.cpp
clang/lib/CodeGen/CGExpr.cpp
cl
leonardchan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1032
+ // them.
+ return Builder.CreateIsNotNull(Src);
+}
ebevhan wrote:
> Is this comment true? I don't think EmitFixedPointConversion does this.
>
> Maybe I'm misin
yaxunl updated this revision to Diff 169864.
yaxunl retitled this revision from "[OpenCL] Mark load of block invoke function
as invariant" to "Mark store and load of block invoke function as
invariant.group".
yaxunl edited the summary of this revision.
yaxunl added a comment.
Herald added a subsc
whisperity accepted this revision.
whisperity added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: donat.nagy.
Remove the custom file paths and URLs but other than that this is pretty
trivial.
https://reviews.llvm.org/D52790
___
Szelethus updated this revision to Diff 169869.
Szelethus added a comment.
Herald added a subscriber: dkrupp.
Rebased to part 3.
https://reviews.llvm.org/D52986
Files:
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist
t
george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:677
+/// need to expanded further when it is nested inside another macro.
+class Ma
george.karpenkov added inline comments.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6
clang_version
-clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang
80e1678b9f598ca78bb3b71cf546a63414a37b11) (https://github.com/llv
Szelethus updated this revision to Diff 169871.
Szelethus added a comment.
Herald added a subscriber: dkrupp.
This patch didn't really work, sometimes it printed extra spaces, sometimes
printed the hash tokens, and so on, so I refactored the whole project to deal
with this issue almost out of th
Szelethus added inline comments.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6
clang_version
-clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang
80e1678b9f598ca78bb3b71cf546a63414a37b11) (https://github.com/llvm-mirro
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:677
+/// need to expanded further when it is nested inside another macro.
+class MacroArgMap : public std::map {
+public:
george.karpenkov wrote:
> Please don't do this, inh
Author: krasimir
Date: Tue Oct 16 11:44:41 2018
New Revision: 344637
URL: http://llvm.org/viewvc/llvm-project?rev=344637&view=rev
Log:
Revert "[clangd] Refactor JSON-over-stdin/stdout code into Transport
abstraction."
This reverts commit r344620.
Breaks upstream bots.
Removed:
clang-tools-e
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:677
+/// need to expanded further when it is nested inside another macro.
+class MacroArgMap : public std::map {
+public:
Szelethus wrote:
> george.karpenkov wrote:
> > Plea
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the change!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53266
___
cfe-commits mailing list
cfe-commits@l
efriedma added a comment.
Herald added a subscriber: nhaehnle.
Looks like the latest update is missing a test file?
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
vsapsai added a comment.
Sorry about the delay. The change seems to be correct but `ninja check-clang`
reveals the test "Misc/caret-diags-macros.c" is failing. Can you please look
into that?
Appreciate your contribution, Xing, and thanks for verifying your change with
tests.
===
mate1214 abandoned this revision.
mate1214 marked 24 inline comments as done.
mate1214 added a comment.
Herald added subscribers: dkrupp, nhaehnle, donat.nagy.
Hi!
Sorry for the delay. After considering the amount of requested tests and
investigating the possibly reviewer friendly ways to split
mwasplund updated this revision to Diff 169879.
mwasplund marked 2 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D52973
Files:
include/clang/AST/ASTContext.h
lib/AST/ASTContext.cpp
lib/Sema/SemaDecl.cpp
test/Modules/msvc-compat-implitic-types.cpp
Index: test/
1 - 100 of 161 matches
Mail list logo
