orivej added a comment.
Thanks! Could you merge this (after a while to let others review)?
Comment at: test/CoverageMapping/macros.c:60
+// CHECK-NEXT: func6
+void func6(unsigned count) { // CHECK-NEXT: File 0, [[@LINE]]:28 ->
[[@LINE+4]]:2 = #0
vsk wrote:
>
yroux created this revision.
yroux added a reviewer: rsmith.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
Fix bots which don't have x86_64 target built (ARM/AArch64).
Repository:
rC Clang
https://reviews.llvm.org/D53272
Files:
test/CodeGenCXX/profile-rema
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Previously, SymbolCollector postfilters all references at the end to
find all references of interesting symbols.
It was incorrect when indxing m
sammccall added a comment.
Nice fix, just performance concerns.
(I do think this might be significant, but measuring dynamic index time
before/after for a big TU might show this to be unimportant)
Comment at: clangd/index/SymbolCollector.cpp:348
+ if (!shouldCollectSymbol(
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC, rnkovacs.
Herald added subscribers: cfe-commits, donat.nagy, mikhail.ramalho, a.sidorin,
szepet, whisperity.
I was a little unsure about the title, but it is what it is.
I'm in the process of refac
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC, rnkovacs.
Herald added subscribers: cfe-commits, donat.nagy, mikhail.ramalho, a.sidorin,
szepet, whisperity.
I'm in the process of refactoring AnalyzerOptions. The main motivation behind
here is to
hokein updated this revision to Diff 169668.
hokein marked 2 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53019
Files:
clangd/index/dex/dexp/CMakeLists.txt
clangd/index/dex/dexp/Dexp.cpp
Index: cla
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, MTC.
Herald added subscribers: cfe-commits, donat.nagy, mikhail.ramalho, a.sidorin,
szepet, whisperity.
I'm in the process of refactoring AnalyzerOptions. The main motivation behind
here is to
hokein added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:348
+ if (!shouldCollectSymbol(*ND, *ASTCtx, Opts))
+return true;
sammccall wrote:
> This seems better for the main-AST case, but substantially more expensive for
> indexing preamb
hokein updated this revision to Diff 169671.
hokein marked an inline comment as done.
hokein added a comment.
avoid calling shouldCollectSymbol every time during indexing.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53273
Files:
clangd/index/SymbolCollector.cpp
unittests
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/dex/dexp/Dexp.cpp:61
+ Request.Scopes.emplace_back();
+ std::tie(Request.Scopes.back(), Request.Query) =
+ clang::clangd::splitQuali
ebevhan added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1019
+ assert(!SrcType->isFixedPointType() && !DstType->isFixedPointType() &&
+ "Use the TargetCodeGenInfo::emitFixedPoint family functions for "
+ "handling conversions involving fixed point
lebedev.ri added a comment.
Ping.
The prerequisite "split truncation sanitizer into unsigned and signed cases"
has landed.
I believe i have replied/addressed all the points previously raised here.
Would be awesome to get this going at long last :)
Repository:
rC Clang
https://reviews.llvm.or
Szelethus added a comment.
Also, this patch does not contain checker options. That I would suspect be a
little more invasive, so I'll do that in a followup patch.
Repository:
rC Clang
https://reviews.llvm.org/D53277
___
cfe-commits mailing list
Author: chandlerc
Date: Mon Oct 15 03:42:50 2018
New Revision: 344504
URL: http://llvm.org/viewvc/llvm-project?rev=344504&view=rev
Log:
[TI removal] Make `getTerminator()` return a generic `Instruction`.
This removes the primary remaining API producing `TerminatorInst` which
will reduce the rate
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, MTC.
Herald added subscribers: cfe-commits, donat.nagy, mikhail.ramalho, a.sidorin,
szepet, whisperity.
I'm in the process of refactoring AnalyzerOptions. The main motivation behind
here is to
Szelethus added a comment.
@whisperity @xazax.hun A worry of mine is shared libraries, for example, we've
got an array of Ericsson-specific checkers that we load run-time. Do we support
(or should we) support acquiring non-checker `-analyzer-config` options?
Repository:
rC Clang
https://rev
balazske marked 9 inline comments as done.
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:2683
+continue;
+ } else if (isa(Found))
+continue;
a_sidorin wrote:
> Same here.
I do not know exactly why this was made, it looks
Author: hokein
Date: Mon Oct 15 04:46:26 2018
New Revision: 344507
URL: http://llvm.org/viewvc/llvm-project?rev=344507&view=rev
Log:
[clangd] Fix some references missing in dynamic index.
Summary:
Previously, SymbolCollector postfilters all references at the end to
find all references of interest
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344507: [clangd] Fix some references missing in dynamic
index. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53273
Files:
ioeric created this revision.
ioeric added reviewers: sammccall, hokein.
Herald added subscribers: cfe-commits, arphaman.
Repository:
rC Clang
https://reviews.llvm.org/D53284
Files:
lib/Sema/SemaCodeComplete.cpp
test/Index/complete-template-keywords.cpp
Index: test/Index/complete-templat
hokein updated this revision to Diff 169683.
hokein marked 3 inline comments as done.
hokein added a comment.
Fix global scope, and clang-format.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53019
Files:
clangd/index/dex/dexp/CMakeLists.txt
clangd/index/dex/dexp/Dexp.cpp
hokein added inline comments.
Comment at: clangd/index/dex/dexp/Dexp.cpp:61
+ Request.Scopes.emplace_back();
+ std::tie(Request.Scopes.back(), Request.Query) =
+ clang::clangd::splitQualifiedName(QualifiedName);
sammccall wrote:
> Are you sure you want bot
Author: hokein
Date: Mon Oct 15 05:32:49 2018
New Revision: 344508
URL: http://llvm.org/viewvc/llvm-project?rev=344508&view=rev
Log:
[clangd] dump xrefs information in dexp tool.
Reviewers: sammccall
Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet,
cfe-commits
Differen
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344508: [clangd] dump xrefs information in dexp tool.
(authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53019?vs=169683&id=169684#toc
Repository:
rCTE Clang To
Author: ioeric
Date: Mon Oct 15 05:37:23 2018
New Revision: 344509
URL: http://llvm.org/viewvc/llvm-project?rev=344509&view=rev
Log:
[CodeComplete] Make sure keyword 'template' is added even when code pattern is
disabled.
Reviewers: sammccall, hokein
Subscribers: arphaman, cfe-commits
Differen
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344509: [CodeComplete] Make sure keyword
'template' is added even when code pattern is… (authored by ioeric,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53284?vs=169681&id=169685
sammccall created this revision.
sammccall added reviewers: jkorous, ioeric, hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, MaskRay,
ilya-biryukov, mgorny.
This paves the way for alternative transports (mac XPC, maybe messagepack?),
and also generally improves layering: testin
Author: hokein
Date: Mon Oct 15 05:39:45 2018
New Revision: 344510
URL: http://llvm.org/viewvc/llvm-project?rev=344510&view=rev
Log:
[clangd] Remove an unused include header, NFC.
Modified:
clang-tools-extra/trunk/clangd/index/Merge.cpp
Modified: clang-tools-extra/trunk/clangd/index/Merge.cp
sammccall added inline comments.
Comment at: clangd/index/dex/dexp/Dexp.cpp:185
clang::clangd::LookupRequest Request;
-Request.IDs = {*SID};
+Request.IDs.insert(IDs.begin(), IDs.end());
bool FoundSymbol = false;
hokein wrote:
> sammccall wrote:
peter.smith marked 7 inline comments as done.
peter.smith added a comment.
Thanks very much for the comments. I'll post an update shortly.
Comment at: lib/Driver/ToolChains/Gnu.cpp:357-364
+const char* EndianFlag = "-EL";
+if (isArmBigEndian(Triple, Args)) {
+ Endi
Szelethus updated this revision to Diff 169688.
https://reviews.llvm.org/D53277
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/CoreEngine.cpp
Index: lib/S
peter.smith updated this revision to Diff 169689.
peter.smith marked 3 inline comments as done.
peter.smith added a comment.
Updated diff to reflect review comments. Main changes are:
- isArmBigEndian always returns false if the target architecture isn't Arm.
- Added tests to make sure "--be8" do
sammccall added a comment.
This patch is big and hard to navigate. I tried to keep it contained, but
JSONRPCDispatcher is pretty tangled.
The main parts are:
- `Transport.h` is the key new abstraction that should be understood first
- `JSONTransport.cpp` is its standard implementation. The raw
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:128-135
+/// Describes the kinds for high-level analyzer mode.
+enum UserModeKind {
+ /// Perform shallow but fast analyzes.
+ UMK_Shallow = 1,
+
+ /// Perform deep analyzes.
+ UM
Szelethus updated this revision to Diff 169693.
https://reviews.llvm.org/D53280
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/Frontend/CompilerInvocation.cpp
Index: lib/Frontend/CompilerInvocation.cpp
==
sammccall updated this revision to Diff 169694.
sammccall marked an inline comment as done.
sammccall added a comment.
Address comments, strip out of clangdlspserver for now.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53032
Files:
clangd/CMakeLists.txt
clangd/ClangdServ
sammccall added inline comments.
Comment at: unittests/clangd/BackgroundIndexTests.cpp:14
+
+TEST(BackgroundIndexTest, IndexesOneFile) {
+ MockFSProvider FS;
sammccall wrote:
> ioeric wrote:
> > sammccall wrote:
> > > ioeric wrote:
> > > > sammccall wrote:
> > >
ioeric accepted this revision.
ioeric added a comment.
still lgtm
Comment at: clangd/Compiler.cpp:83
+std::string getStandardResourceDir() {
+ static int Dummy; // Just an address in this process.
Maybe also revert this change?
Repository:
rCTE Clang Too
Author: sammccall
Date: Mon Oct 15 06:34:10 2018
New Revision: 344513
URL: http://llvm.org/viewvc/llvm-project?rev=344513&view=rev
Log:
[clangd] Minimal implementation of automatic static index (not enabled).
Summary:
See tinyurl.com/clangd-automatic-index for design and goals.
Lots of limitatio
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344513: [clangd] Minimal implementation of automatic
static index (not enabled). (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53032?vs=169694&id=169695#to
Szelethus updated this revision to Diff 169696.
https://reviews.llvm.org/D53277
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/CoreEngine.cpp
Index: lib/S
Szelethus updated this revision to Diff 169697.
https://reviews.llvm.org/D53277
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/CoreEngine.cpp
Index: lib/S
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
Reuse the old -use-dex-index experiment flag for this.
To avoid breaking the tests, make Dex deduplicate symbols, addressing an
Szelethus updated this revision to Diff 169703.
https://reviews.llvm.org/D53274
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/CoreEngine.cpp
Index: lib/StaticAnalyzer/Core/CoreEngine.cpp
==
jkorous created this revision.
jkorous added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, jfb, arphaman, dexonsmith,
MaskRay, ioeric, ilya-biryukov, mgorny.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53290
Files:
clangd/CMakeLists.txt
clangd/Cl
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clangd/ClangdServer.h:79
+/// Use a heavier and faster in-memory index implementation.
+/// FIXME: we should make this true if it isn't too slow!.
+
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
This would allow easily injecting our internal customization.
Also updates the stale "symbol-collection-file" flag.
Repository:
rCTE Clang
Author: sammccall
Date: Mon Oct 15 08:04:03 2018
New Revision: 344520
URL: http://llvm.org/viewvc/llvm-project?rev=344520&view=rev
Log:
[clangd] Use SyncAPI in more places in tests. NFC
Modified:
clang-tools-extra/trunk/clangd/index/Index.h
clang-tools-extra/trunk/unittests/clangd/FileInd
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/dex/dexp/Dexp.cpp:256
+std::unique_ptr createIndex(llvm::StringRef Index) {
+ return loadIndex(Index, /*URISchemes=*/{}, /*UseDex=*/true
hokein updated this revision to Diff 169712.
hokein marked 2 inline comments as done.
hokein added a comment.
createIndex => openIndex
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53292
Files:
clangd/index/dex/dexp/Dexp.cpp
Index: clangd/index/dex/dexp/Dexp.cpp
==
Author: hokein
Date: Mon Oct 15 08:12:40 2018
New Revision: 344521
URL: http://llvm.org/viewvc/llvm-project?rev=344521&view=rev
Log:
[clangd] Add createIndex in dexp
Summary:
This would allow easily injecting our internal customization.
Also updates the stale "symbol-collection-file" flag.
Revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344521: [clangd] Add createIndex in dexp (authored by
hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53292?vs=169712&id=169713#toc
Repository:
rCTE Clang Tools Extra
ht
phosek added inline comments.
Comment at: clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp:45
+ assert(!Err);
+ std::string Expected =
+ "---\n"
Nit: use raw strings here as well, the same here below.
https://reviews.llvm.org/D53084
___
xudaliang.pku created this revision.
xudaliang.pku added a reviewer: asb.
Herald added subscribers: cfe-commits, jocewei, PkmX, the_o, brucehoult,
MartinMosbeck, rogfer01, mgrang, edward-jones, zzheng, jrtc27, shiva0217,
kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar.
1. add op
sammccall added a comment.
For reference, @jkorous has a WIP in https://reviews.llvm.org/D53290.
It's scope is a superset, and I think everything in common is basically the
same (they were both based on a common prototype).
Jan is out at the moment, so I think it makes sense to move ahead with th
simark marked an inline comment as done.
simark added inline comments.
Comment at: clangd/ClangdLSPServer.h:90
void reparseOpenedFiles();
+ void applyConfiguration(const ClangdInitializationOptions &Settings);
void applyConfiguration(const ClangdConfigurationParamsChange &
leonardchan updated this revision to Diff 169714.
leonardchan marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D50616
Files:
include/clang/AST/OperationKinds.def
include/clang/AST/Type.h
include/clang/Basic/DiagnosticCommonKinds.td
lib/AST/Expr.cpp
lib/
Author: leonardchan
Date: Mon Oct 15 09:07:02 2018
New Revision: 344530
URL: http://llvm.org/viewvc/llvm-project?rev=344530&view=rev
Log:
[Fixed Point Arithmetic] FixedPointCast
This patch is a part of https://reviews.llvm.org/D48456 in an attempt to
split them up. This contains the code for cast
mclow.lists accepted this revision.
mclow.lists added a comment.
After discussions with @EricWF, I landed a modified version as revision 344529.
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344530: [Fixed Point Arithmetic] FixedPointCast (authored by
leonardchan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50616?vs=169714&id=1
ymandel added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:64
+
+ // Fix the definition.
+ llvm::Optional Loc = findConstToRemove(Def, Result);
JonasToth wrote:
> ymandel wrote:
> > JonasToth wrote:
> > > ymandel wrote:
> > > >
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
I think it'd be a good idea to separate out the on-initialization vs
dynamically-changing parameters more - I think they should probably be disjoint
in fact.
But we can discuss/implemen
Author: sammccall
Date: Mon Oct 15 09:47:45 2018
New Revision: 344533
URL: http://llvm.org/viewvc/llvm-project?rev=344533&view=rev
Log:
[clangd] Revert include path change in Dexp. NFC
Modified:
clang-tools-extra/trunk/clangd/index/dex/dexp/CMakeLists.txt
clang-tools-extra/trunk/clangd/in
uweigand added a comment.
This causes check-all to abort for me on SystemZ in Release mode (and never
actually run the lit tests):
[40/365] cd /home/uweigand/llvm/llvm-head/tools/clang/bindings/python &&
/usr/bin/cmake -E...BRARY_PATH=/home/uweigand/llvm/build/llvm-head/lib
/usr/bin/python2.
JDevlieghere added a comment.
Can you add a test case please?
Repository:
rC Clang
https://reviews.llvm.org/D53200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
The first one seems to indicate that your `libclang.so` is broken in release
mode (optimization error?). The second one is correct (some of the tests test
for errors, and apparently don't silence the messages).
Repository:
rC Clang
https://reviews.llvm.org/D52840
Author: nickdesaulniers
Date: Mon Oct 15 10:39:00 2018
New Revision: 344536
URL: http://llvm.org/viewvc/llvm-project?rev=344536&view=rev
Log:
Revert 344389 "Revert r344375 "[Driver] check for exit code from SIGPIPE""
Summary:
Add preprocessor guards for UNIX.
This reverts commit r344389.
Review
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344536: Revert 344389 "Revert r344375 "[Driver]
check for exit code from SIGPIPE"" (authored by nickdesaulniers,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53210?vs=169474&id=16
george.karpenkov added a comment.
> The main motivation behind here is to emit warnings if an invalid
I'm totally with you here, but IIRC (@NoQ might want to correct me here),
the design decision was made specifically to ignore incorrect options, so that
e.g. old versions of Xcode used with old
Author: dergachev
Date: Mon Oct 15 10:43:23 2018
New Revision: 344537
URL: http://llvm.org/viewvc/llvm-project?rev=344537&view=rev
Log:
[python] [tests] Disable python binding tests under LLVM_USE_SANITIZER=Address
They don't work yet.
Patch by Dan Liew!
rdar://problem/45242886
Differential Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344537: [python] [tests] Disable python binding tests under
LLVM_USE_SANITIZER=Address (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
george.karpenkov added a comment.
I'm not sure why you could get away with removing those llvm_unreachable cases?
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:373
- default:
-llvm_unreachable("Invalid mode.");
case UMK_Shallow:
Wh
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344538: [analyzer] NFC: RetainCountChecker: Don't
dump() symbols into program point… (authored by dergachev, committed by ).
Herald added a subscriber: donat.nagy.
Repository:
rC Clang
https://reviews.
Author: dergachev
Date: Mon Oct 15 10:47:56 2018
New Revision: 344538
URL: http://llvm.org/viewvc/llvm-project?rev=344538&view=rev
Log:
[analyzer] NFC: RetainCountChecker: Don't dump() symbols into program point
tags.
We don't need a separate node for every symbol, because whenever the first
sym
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344539: [analyzer] Teach CallEvent about C++17 aligned
operator new(). (authored by dergachev, committed by ).
Herald added subscribers: llvm-commits, donat.nagy.
Changed prior to commit:
https://review
thiagomacieira marked an inline comment as done.
thiagomacieira added inline comments.
Comment at: lib/Driver/Distro.cpp:148
+for (StringRef Line : Lines)
+ if (Version == Distro::UnknownDistro && Line.startswith("ID="))
+Version = llvm::StringSwitch(Line.substr(
Author: dergachev
Date: Mon Oct 15 10:53:18 2018
New Revision: 344539
URL: http://llvm.org/viewvc/llvm-project?rev=344539&view=rev
Log:
[analyzer] Teach CallEvent about C++17 aligned operator new().
In C++17, when class C has large alignment value, a special case of
overload resolution rule kicks
Author: dergachev
Date: Mon Oct 15 11:01:34 2018
New Revision: 344540
URL: http://llvm.org/viewvc/llvm-project?rev=344540&view=rev
Log:
[analyzer] Add doxygen comments for the new CXXAllocatorCall APIs.
Forgot to squeeze this into r344539.
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Cor
NoQ added a comment.
Whoops, almost forgot to doxygen-ize comments. Landed in
https://reviews.llvm.org/rC344540.
Repository:
rL LLVM
https://reviews.llvm.org/D52957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
yaxunl created this revision.
yaxunl added reviewers: rjmccall, Anastasia.
OpenCL v2.0 s6.12.5:
Block variable declarations are implicitly qualified with const.
Therefore all block variables must be initialized at declaration time and
may not be reassigned.
As such, load of block in
nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.
Thanks for this patch. With it I was able to link+boot a BE aarch64 Linux
kernel (and a LE aarch64 Linux kernel).
Comment at: lib/Driver/ToolChains/Gnu.cp
Szelethus updated this revision to Diff 169731.
Szelethus retitled this revision from "[analyzer][NFC][WIP] Collect all
-analyzer-config options in a .def file" to "[analyzer][NFC] Collect all
-analyzer-config options in a .def file".
Szelethus edited the summary of this revision.
Szelethus added
Szelethus added a comment.
In https://reviews.llvm.org/D53274#1265625, @george.karpenkov wrote:
> I'm not sure why you could get away with removing those llvm_unreachable
> cases?
Because I got a warning for using `default` when every enum value was handled
in the switch. Since whether the fl
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC, rnkovacs.
Herald added subscribers: cfe-commits, donat.nagy, mikhail.ramalho, dmgreen,
a.sidorin, mgrang, szepet, whisperity.
Title says it all, here's how it look like locally:
OVERVIEW: Clang S
uweigand added a comment.
In https://reviews.llvm.org/D52840#1265615, @mgorny wrote:
> The first one seems to indicate that your `libclang.so` is broken in release
> mode (optimization error?). The second one is correct (some of the tests test
> for errors, and apparently don't silence the mess
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1318
+CGM.getModule().getMDKindID("invariant.load"),
+llvm::MDNode::get(getLLVMContext(), None));
+
OpenCL blocks are still potentially function-local, right? I don't think
you
leonardchan created this revision.
leonardchan added a reviewer: bjope.
leonardchan added a project: clang-tools-extra.
Fix for warnings generated on unhandled enum value `STK_FixedPoint`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53299
Files:
clang-tools-extra/clang-tid
nickdesaulniers added a comment.
I think this is now breaking:
lld :: ELF/format-binary.test
lld :: ELF/relocatable-versioned.s
Repository:
rC Clang
https://reviews.llvm.org/D53210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.
Just some inline nit:s about whitespace.
LGTM, apart from that!
Comment at:
clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:63
InitType->getAs()
leonardchan updated this revision to Diff 169741.
leonardchan marked 2 inline comments as done.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53299
Files:
clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
Index: clang-tools-extra/clang-tidy/modernize/UseDe
Author: leonardchan
Date: Mon Oct 15 12:59:52 2018
New Revision: 344548
URL: http://llvm.org/viewvc/llvm-project?rev=344548&view=rev
Log:
added fix
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/Use
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344549: [Fixed Point Arithmetic] Fix for clang-tools-extra
warning (authored by leonardchan, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53299?vs=169741&id=169745#toc
Repositor
Author: leonardchan
Date: Mon Oct 15 13:00:03 2018
New Revision: 344549
URL: http://llvm.org/viewvc/llvm-project?rev=344549&view=rev
Log:
[Fixed Point Arithmetic] Fix for clang-tools-extra warning
Fix for warnings generated on unhandled enum value `STK_FixedPoint`.
Differential Revision: https:/
juliehockett updated this revision to Diff 169748.
juliehockett marked 2 inline comments as done.
https://reviews.llvm.org/D53081
Files:
clang-tools-extra/unittests/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/ClangDocTest.cpp
c
nickdesaulniers added a comment.
Nevermind, looks like flaky tests. Will try to repro and contact msan
maintainers.
Repository:
rC Clang
https://reviews.llvm.org/D53210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D53082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
phosek added inline comments.
Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:320
+ ExtractInfosFromCodeWithArgs(
+ "export module M;\n"
+ "int moduleFunction(int x);\n"
Can you use raw strings here (and elsewhere in this file) as w
juliehockett updated this revision to Diff 169751.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D53084
Files:
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp
Index: clang-tools-extra/unittests/clang-d
juliehockett updated this revision to Diff 169752.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D53085
Files:
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp
Index: clang-tools-extra/unittests/clang-doc
1 - 100 of 140 matches
Mail list logo
