kpn updated this revision to Diff 169266.
kpn added a comment.
Address review comments.
Add a test case. The test depends on https://reviews.llvm.org/D53157, but it
reads easily enough. Richard, does this work for you?
https://reviews.llvm.org/D52839
Files:
include/clang/AST/Expr.h
lib/AS
lebedev.ri added inline comments.
Comment at: include/clang/AST/Expr.h:1791
+ // otherwise.
+ unsigned FPFeatures : 3;
+
Why as the first one, and not after `CanOverflow` ...
Comment at: include/clang/AST/Expr.h:1809
+Opc(opc), CanOve
kpn added a comment.
I forgot to address the template question. I've spend the past 18 years doing
SystemZ backend work on multiple {,JIT} compilers. I'm not really in a position
to answer your question about how to handle getting these FP bits down into C++
templates. I hope that won't hold up
stryku marked an inline comment as done.
stryku added inline comments.
Comment at: test/SemaCXX/warn-unsequenced-cxx17.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++17 -Wno-unused %s
+
lebedev.ri wrote:
> Rakete wrote:
> > lebedev.ri wrote:
> > > On
stryku added a comment.
@rsmith Of course I would like. Not sure what's better: to submit one patch per
case or submit all of them in one patch (didn't deal much with them, not sure
how big will the change be)?
https://reviews.llvm.org/D50766
___
Author: aaronenyeshi
Date: Thu Oct 11 12:41:54 2018
New Revision: 344281
URL: http://llvm.org/viewvc/llvm-project?rev=344281&view=rev
Log:
[HIP] Replace irif library with hip.amdgcn.bc
No longer use irif amdgcn library, instead we will use the previous fence
functions from new hip.amdgcn.bc bitc
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10881-10882
+S.DiagRuntimeBehavior(
+E->getExprLoc(), E,
+S.PDiag(diag::warn_impcast_literal_float_to_integer)
+<< E->getType() << T << PrettySourceValue << Prett
ymandel updated this revision to Diff 169277.
ymandel added a comment.
Adusted code in respone to comments.
Major differences are:
- more warning in situations where a FixIt can't be suggested.
- more tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10881-10882
+S.DiagRuntimeBehavior(
+E->getExprLoc(), E,
+S.PDiag(diag::warn_impcast_literal_float_to_integer)
+<< E->getType() << T << PrettySourceValue << Prett
Author: aaronenyeshi
Date: Thu Oct 11 12:52:32 2018
New Revision: 344285
URL: http://llvm.org/viewvc/llvm-project?rev=344285&view=rev
Log:
[HIP] Remove unused irif bitcode from test
This is part of previous commit [HIP] Replace irif library with hip.amdgcn.bc
Reviewers: yaxunl
Differential Revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344285: [HIP] Remove unused irif bitcode from test (authored
by aaronenyeshi, committed by ).
Herald added subscribers: llvm-commits, jvesely.
Changed prior to commit:
https://reviews.llvm.org/D52673?vs
ymandel updated this revision to Diff 169280.
ymandel added a comment.
comment tweak
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
clang-tidy/readability/ConstValueReturnC
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/readability-const-value-return.rst:7
+Checks for functions with a ``const``-qualified return type and recommends
+removal of the ``const`` keyword. Such use of ``const`` is superfluous, and
+prevents valuab
ymandel updated this revision to Diff 169282.
ymandel added a comment.
Spacing fix.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
clang-tidy/readability/ConstValueReturnCh
rnk added a comment.
lgtm
The cmake builtin tools are pretty useful. =)
Repository:
rC Clang
https://reviews.llvm.org/D53151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
russellmcc updated this revision to Diff 169288.
russellmcc added a comment.
Added suggested for loops to the test
https://reviews.llvm.org/D40988
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
unittests/
ymandel updated this revision to Diff 169290.
ymandel marked 11 inline comments as done.
ymandel added a comment.
Comment fix.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck.cpp
ymandel added a comment.
Thank you for the detailed comments! They were quite helpful, especially as
this is my first llvm/clang review.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:25
+
+// Finds the location of the relevant "const" token in `Def`.
+llvm::Opt
philip.pfaffe added a comment.
You're right, my bad; I missed the fact that it's EP_OptimizerLast, which has
no equivalent in the new PM. Your implementation is actually correct here.
Did you run your test in a debug build?
Repository:
rC Clang
https://reviews.llvm.org/D52814
___
danalbert added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:360
+ unsigned ArchVersion;
+ if (ArchName.empty())
peter.smith wrote:
> Do you need to parse the arch version here? I would expect the -march=armv7
> to be reflected in getARMSu
danalbert updated this revision to Diff 169291.
danalbert added a comment.
Addressed review comments.
Repository:
rC Clang
https://reviews.llvm.org/D53121
Files:
lib/Driver/ToolChains/Arch/ARM.cpp
test/Driver/arm-mfpu.c
Index: test/Driver/arm-mfpu.c
rsmith added a comment.
In https://reviews.llvm.org/D50766#1262460, @stryku wrote:
> @rsmith Of course. Not sure what's better: to submit one patch per case or
> submit all of them in one patch (didn't deal much with them, not sure how big
> will the change be)?
It's really up to you. I don't
Author: mgorny
Date: Thu Oct 11 13:26:55 2018
New Revision: 344288
URL: http://llvm.org/viewvc/llvm-project?rev=344288&view=rev
Log:
[python] [tests] Fix calling tests on Windows
Fix passing arguments to the Python test command to use 'env' builtin
CMake command, in order to fix compatibility wit
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344288: [python] [tests] Fix calling tests on Windows
(authored by mgorny, committed by ).
Herald added a subscriber: llvm
russellmcc added a comment.
Sorry for dropping this for so long! Stuff got busy at work and I've been
happily using my fork with this change for some time. I would really like this
to get in, and promise to be responsive to feedback.
Comment at: lib/Format/ContinuationInden
Author: danalbert
Date: Thu Oct 11 13:39:32 2018
New Revision: 344293
URL: http://llvm.org/viewvc/llvm-project?rev=344293&view=rev
Log:
[Driver] Fix --hash-style choice for Android.
Summary:
Android supports GNU style hashes as of Marshmallow, so we should be
generating both styles for pre-M targ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344293: [Driver] Fix --hash-style choice for Android.
(authored by danalbert, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53118
Files:
cfe/
xbolva00 added a comment.
In https://reviews.llvm.org/D52750#1261746, @Rakete wrote:
> Nah, you don't even need to call `EvaluateForOverflow` I believe. :) Have a
> look overflow evaluation is done.
Well..
if (!getLangOpts().CPlusPlus11 && E->isIntegerConstantExpr(Context)) {
if (Re
Author: danalbert
Date: Thu Oct 11 13:57:54 2018
New Revision: 344295
URL: http://llvm.org/viewvc/llvm-project?rev=344295&view=rev
Log:
[Driver] Default to `-z now` and `-z relro` on Android.
Summary:
RTLD_LAZY is not supported on Android (though failing to use `-z now`
will work since it is assu
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344295: [Driver] Default to `-z now` and `-z relro` on
Android. (authored by danalbert, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53117?vs=169133&id=169300#toc
Repository:
rC
Author: danalbert
Date: Thu Oct 11 13:58:43 2018
New Revision: 344296
URL: http://llvm.org/viewvc/llvm-project?rev=344296&view=rev
Log:
[Driver] Default Android toolchains to libc++.
Reviewers: srhines, pirama, EricWF
Reviewed By: srhines
Subscribers: cfe-commits
Differential Revision: https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344296: [Driver] Default Android toolchains to libc++.
(authored by danalbert, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53109
Files:
cfe
juliehockett created this revision.
juliehockett added reviewers: ioeric, leonardchan, jakehehrlich, lebedev.ri,
phosek.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman.
Since we generally want to document a whole project, not just one file.
@ioeric,
leonardchan added inline comments.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:90-92
+static llvm::cl::opt
+ClangDocExecutorName("doc-executor", llvm::cl::desc("The name of the
executor to use in clang-doc."),
+ llvm::cl::init("all-TUs"));
-
juliehockett updated this revision to Diff 169304.
https://reviews.llvm.org/D53170
Files:
clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
Index: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
===
--- clang-tools-extra/clang-
Author: danalbert
Date: Thu Oct 11 14:28:42 2018
New Revision: 344297
URL: http://llvm.org/viewvc/llvm-project?rev=344297&view=rev
Log:
Revert "[Driver] Default Android toolchains to libc++."
Breaks some of the Android bots because they aren't expecting to need
to explicitly set -stdlib.
This re
nruslan added a comment.
@hans, @craig.topper : If everything is fine, can someone check in the clang
and llvm patches on my behalf? I do not have commit access.
https://reviews.llvm.org/D53102
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:205
+ llvm::cl::OptionCategory &Category) {
+ auto OptionsParser =
+ CommonOptionsParser::create(argc, argv, Category, llvm::cl::ZeroOrMore);
--
Author: eugenezelenko
Date: Thu Oct 11 14:40:32 2018
New Revision: 344299
URL: http://llvm.org/viewvc/llvm-project?rev=344299&view=rev
Log:
[Documentation] Rephrase modernize-deprecated-ios-base-aliases description. Add
clangd and clang-doc placeholders in Release Notes.
Modified:
clang-tool
NoQ added a comment.
> In addition 2018 Bay Area LLVM Developers' Meetings may bring some new open
> projects :)
Actually, let's commit this before the conference, even if it's not perfect, so
that people who suddenly get inspired to work on Static Analyzer already had an
updated list :)
==
rsmith added inline comments.
Comment at: lib/Sema/SemaType.cpp:2231
}
+
+ if (isa(ArraySize))
xbolva00 wrote:
> @rsmith what about this place for check?
This is still evaluating the expression twice. To avoid that, you need to
change the existing co
Author: george.karpenkov
Date: Thu Oct 11 15:59:16 2018
New Revision: 344311
URL: http://llvm.org/viewvc/llvm-project?rev=344311&view=rev
Log:
[analyzer] Retain count checker for OSObject: recognize OSDynamicCast
For now, tresting the cast as a no-op, and disregarding the case where
the output be
Author: george.karpenkov
Date: Thu Oct 11 15:59:59 2018
New Revision: 344313
URL: http://llvm.org/viewvc/llvm-project?rev=344313&view=rev
Log:
[analyzer] Experiment with an iteration order only based on location, and not
using the stack frame
Differential Revision: https://reviews.llvm.org/D5305
Author: george.karpenkov
Date: Thu Oct 11 15:59:38 2018
New Revision: 344312
URL: http://llvm.org/viewvc/llvm-project?rev=344312&view=rev
Log:
[analyzer] Avoid unneeded invalidation in RetainCountChecker
Differential Revision: https://reviews.llvm.org/D53168
Modified:
cfe/trunk/lib/StaticAn
rsmith abandoned this revision.
rsmith added a comment.
Herald added a subscriber: dang.
The constituent pieces have all landed.
https://reviews.llvm.org/D51240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Szelethus updated this revision to Diff 169342.
Szelethus edited the summary of this revision.
Szelethus added a comment.
- Removed osx.cocoa.Loops, will be placed in implicit_checks.html
I still didn't add more description to objc checkers for the reasons stated
above.
https://reviews.llvm.or
Author: rsmith
Date: Thu Oct 11 16:48:11 2018
New Revision: 344319
URL: http://llvm.org/viewvc/llvm-project?rev=344319&view=rev
Log:
Update user's manual documentation of profile remapping file to match
llvm-cxxmap documentation.
Add a hint as to how to perform off-line profile data remapping.
M
NoQ added a comment.
In https://reviews.llvm.org/D52984#1260761, @george.karpenkov wrote:
> @Szelethus @xazax.hun Since you guys are looking into the website, do you
> know why the top bar has disappeared from all pages? (E.g.
> http://clang-analyzer.llvm.org/available_checks.html )
The relev
Author: george.karpenkov
Date: Thu Oct 11 17:52:13 2018
New Revision: 344322
URL: http://llvm.org/viewvc/llvm-project?rev=344322&view=rev
Log:
[analyzer] Fix a bug in unexplored_first_location_queue iteration order.
Pointed out by Artem in post-commit review for https://reviews.llvm.org/D53058
M
george.karpenkov added a comment.
> inline the header into every page, which is horrible
is it though?
we probably also should be moving towards an auto-generated model anyway, if we
want to e.g. automatically build sections of a website from the code.
https://reviews.llvm.org/D52984
_
NoQ added a comment.
> we probably also should be moving towards an auto-generated model anyway, if
> we want to e.g. automatically build sections of a website from the code.
This too will most likely require server maintainers to intervene, so i think
fixing SSI is more realistic.
https://re
george.karpenkov added a comment.
> This too will most likely require server maintainers to intervene, so i think
> fixing SSI is more realistic.
Not really.
The way it is done e.g. for
http://clang.llvm.org/docs/LibASTMatchersReference.html is the HTML files are
in the repo, there is a script
NoQ added a comment.
> is it though?
If we simply add a new menu point, it'll require us to modify a huge number of
files. We might get away with good comments that explain the situation and
making sure that all changes are done with sed, but i guess we'll still be
stuck forever.
> HTML files
george.karpenkov added a comment.
@Szelethus I take it this is mostly formed from @NoQ email? Language could use
polishing in quite a few places, could I just commandeer this revision and try
to fix it?
Comment at: www/analyzer/open_projects.html:29
+Implement a dataflow
ahatanak added a comment.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Unless my bisect is mistaken, this broke Clang Python binding test:
https://github.com/llvm-mirror/clang/blob/master/bindings/python/tests/cindex/test_cdb.py#L34
The test apparently assumes that compilation database will not return anything
for a file that does not exist.
xbolva00 added a comment.
As noted, this in under LiteralConversion (-Wconversion). GCC has it too under
-Wconversion, so I think it is fine as is, or?
@rsmith
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Sorry about that. I wasn't familiar with the python bindings.
Your bisect is correct, we changed the behavior that test is testing: now
an approximate match will be returned.
I guess either:
- just remove that test (depending on how we feel about smoke-testing vs
exhaustively testing wrapperl lik
101 - 158 of 158 matches
Mail list logo
