[PATCH] D52811: [COFF, ARM64] Add _InterlockedAdd intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL343894: [COFF, ARM64] Add _InterlockedAdd intrinsic (authored by mgrang, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52811?vs=168518&id=16

[PATCH] D51388: [analyzer] NFC: Legalize state manager factory injection.

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h:33 /// introduce a type named \c NameTy. - /// The macro should not be used inside namespaces, or for traits that must - /// be accessible from more than one translati

[PATCH] D52905: CSA: fix accessing GDM data from shared libraries

NoQ added subscribers: george.karpenkov, dcoughlin, NoQ. NoQ added a comment. Hmmm, interesting. A checker doesn't usually need to access these specific static locals, at least not directly. These are usually accessed through functions in .cpp files that are supposed to be compiled with a pointe

[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

rupprecht added a comment. In https://reviews.llvm.org/D52398#1255290, @aaronpuchert wrote: > @hokein Please have a look at https://reviews.llvm.org/D52888, maybe you can > try it out already. The problem was that `?:` expressions are considered a > branch point and when merging both branches t

[PATCH] D52888: Thread safety analysis: Handle conditional expression in getTrylockCallExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D52888#1256625, @aaronpuchert wrote: > In https://reviews.llvm.org/D52888#1256395, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D52888#12558

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

andrewjcg created this revision. Herald added subscribers: cfe-commits, eraman. Undoes `-fvisibility-inlines-hidden`. Test Plan: added test Repository: rC Clang https://reviews.llvm.org/D52956 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp lib/Frontend/Compiler

[PATCH] D52920: Introduce code_model macros

MaskRay added inline comments. Comment at: lib/Basic/Targets/X86.cpp:865 + if (CodeModel == "default") +// When the user has not explicitly specified anything, +// the default code model to use is small. I'm not sure if the comment is useful here... or y

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, baloghadamsoftware. In C++17, when class `C` has large alignment value, a special case of overload resolution r

[PATCH] D52949: [Diagnostics] Implement -Wsizeof-pointer-div

thakis added a comment. It looks like you ran clang-format on all of lib/Sema/SemaExpr.cpp and changed many lines that are irrelevant to your patch. Can you undo that, please? https://reviews.llvm.org/D52949 ___ cfe-commits mailing list cfe-commits

r343902 - Thread safety analysis: Handle conditional expression in getTrylockCallExpr

Author: aaronpuchert Date: Fri Oct 5 18:09:28 2018 New Revision: 343902 URL: http://llvm.org/viewvc/llvm-project?rev=343902&view=rev Log: Thread safety analysis: Handle conditional expression in getTrylockCallExpr Summary: We unwrap conditional expressions containing try-lock functions. Additio

[PATCH] D52888: Thread safety analysis: Handle conditional expression in getTrylockCallExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL343902: Thread safety analysis: Handle conditional expression in getTrylockCallExpr (authored by aaronpuchert, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

LLVM Lab power outage

Hello everyone, PG&E experience a major power outage. LLVM Lab is affected. Buildbot is down. There is no ETA yet. I'll keep you posted. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

aaronpuchert added a comment. In https://reviews.llvm.org/D52398#1257092, @rupprecht wrote: > I patched the proposed fix-forward and it seems to have things building > again. Is there an ETA on landing that? If it's going to take a bit, is there > any chance we could revert this patch until the

[PATCH] D32906: [Analyzer] Iterator Checker - Part 10: Support for iterators passed as parameter

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Just add tests, i guess! Also i'll have a look at whether the checker is in a good shape to be enabled by default. I suspect that mismatched iterators might be very safe to enable. With all these s

[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

rupprecht added a comment. In https://reviews.llvm.org/D52398#1257133, @aaronpuchert wrote: > In https://reviews.llvm.org/D52398#1257092, @rupprecht wrote: > > > I patched the proposed fix-forward and it seems to have things building > > again. Is there an ETA on landing that? If it's going to t

Re: LLVM Lab power outage

Hello everyone, The Lab is back to normal. Thanks for you patience and understanding. Thanks Galina On 10/5/18, Galina Kistanova wrote: > Hello everyone, > > PG&E experience a major power outage. > LLVM Lab is affected. Buildbot is down. > There is no ETA yet. I'll keep you posted. > > Thank

<    1   2