[PATCH] D52809: [COFF, ARM64] Add _ReadWriteBarrier intrinsic

2018-10-02 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang created this revision. mgrang added reviewers: rnk, mstorsjo, compnerd, TomTan, haripul. Herald added a reviewer: javed.absar. Herald added subscribers: jfb, chrib, kristof.beyls. Repository: rC Clang https://reviews.llvm.org/D52809 Files: include/clang/Basic/BuiltinsAArch64.def lib

[PATCH] D52809: [COFF, ARM64] Add _ReadWriteBarrier intrinsic

2018-10-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D52809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D52811: [COFF, ARM64] Add _InterlockedAdd intrinsic

2018-10-02 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang created this revision. mgrang added reviewers: rnk, mstorsjo, compnerd, TomTan, haripul. Herald added subscribers: jfb, chrib, kristof.beyls. Repository: rC Clang https://reviews.llvm.org/D52811 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/ms-intr

[PATCH] D52814: [PassManager/Sanitizer] Enable usage of ported AddressSanitizer passes with -fsanitize=address

2018-10-02 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek, fedor.sergeev, philip.pfaffe, vitalybuka. leonardchan added projects: clang, Sanitizers. leonardchan added a dependency: D52739: [PassManager/Sanitizer] Port of AddresSanitizer pass from legacy to new PassManager.

[PATCH] D52811: [COFF, ARM64] Add _InterlockedAdd intrinsic

2018-10-02 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: test/CodeGen/ms-intrinsics.c:379 +// CHECK: [[RESULT:%[0-9]+]] = atomicrmw add i32* %value, i32 %mask seq_cst +// CHECK: ret i32 [[RESULT:%[0-9]+]] +// CHECK: } Missing "add" instruction. _InterlockedAdd is suppose

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

2018-10-02 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai planned changes to this revision. smeenai added a comment. In https://reviews.llvm.org/D52674#1251931, @rjmccall wrote: > In https://reviews.llvm.org/D52674#1251439, @smeenai wrote: > > > In https://reviews.llvm.org/D52674#1251419, @rjmccall wrote: > > > > > Conceptually this seems fine,

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

2018-10-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 168061. Herald added a subscriber: libcxx-commits. Repository: rCXX libc++ https://reviews.llvm.org/D52660 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D52660: [CMake][Fuchsia] Use unstable libc++ ABI for Fuchsia toolchain

2018-10-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 168064. Repository: rCXX libc++ https://reviews.llvm.org/D52660 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake === --- clang/cmake/caches/Fuch

r343652 - [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

2018-10-02 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Oct 2 18:27:00 2018 New Revision: 343652 URL: http://llvm.org/viewvc/llvm-project?rev=343652&view=rev Log: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain We don't need to provide stable ABI and hence we can use the v2. Differential Revision: https://reviews.llv

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

2018-10-02 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai requested review of this revision. smeenai added a comment. Actually, I take that back ... I just misread the stack trace. There are a bunch of hops between the `mangleCXXRTTI` call and the ultimate mangling function: MicrosoftMangleContextImpl::mangleCXXRTTI(QualType, raw_ostream &)

[PATCH] D52660: [CMake][Fuchsia] Use unstable libc++ ABI for Fuchsia toolchain

2018-10-02 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343652: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52660?vs=

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

2018-10-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D52674#1253401, @smeenai wrote: > Actually, I take that back ... I just misread the stack trace. > > There are a bunch of hops between the `mangleCXXRTTI` call and the ultimate > mangling function: > > MicrosoftMangleContextImpl::mangleCXXR

r343653 - OpenCL: Mark printf format string argument

2018-10-02 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Tue Oct 2 19:01:19 2018 New Revision: 343653 URL: http://llvm.org/viewvc/llvm-project?rev=343653&view=rev Log: OpenCL: Mark printf format string argument Fixes not warning on format string errors. Added: cfe/trunk/test/SemaOpenCL/printf-format-string-warnings.cl Modifie

[PATCH] D52412: OpenCL: Mark printf format string argument

2018-10-02 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. r343653 https://reviews.llvm.org/D52412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r343660 - [Frontend] Delete -print-decl-contexts

2018-10-02 Thread Fangrui Song via cfe-commits
Author: maskray Date: Tue Oct 2 20:50:44 2018 New Revision: 343660 URL: http://llvm.org/viewvc/llvm-project?rev=343660&view=rev Log: [Frontend] Delete -print-decl-contexts Summary: Its job is covered by -ast-dump. The option is rarely used and lacks many AST nodes which will lead to llvm_unreac

[PATCH] D52529: [Frontend] Delete -print-decl-contexts

2018-10-02 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343660: [Frontend] Delete -print-decl-contexts (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52529?vs=167842&id=168070

[clang-tools-extra] r343661 - Fix compilation warning by removing unused variable [NFC]

2018-10-02 Thread Mikael Holmen via cfe-commits
Author: uabelho Date: Tue Oct 2 22:41:14 2018 New Revision: 343661 URL: http://llvm.org/viewvc/llvm-project?rev=343661&view=rev Log: Fix compilation warning by removing unused variable [NFC] clang complained with ../tools/clang/tools/extra/clangd/FS.cpp:19:12: error: unused variable 'Err' [-We

Re: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

2018-10-02 Thread Mikael Holmén via cfe-commits
Hi Eric, I fixed a compilation warning introduced with this patch in r343661. Regards, Mikael On 10/02/2018 12:43 PM, Eric Liu via cfe-commits wrote: Author: ioeric Date: Tue Oct 2 03:43:55 2018 New Revision: 343576 URL: http://llvm.org/viewvc/llvm-project?rev=343576&view=rev Log: [clangd] C

<    1   2   3