krasimir accepted this revision.
krasimir added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/Format/FormatTestJS.cpp:2315
+ " never) extends((k: infer I) => void) ? I "
+ ": never;");
+}
--
Author: ctopper
Date: Wed Sep 26 10:01:44 2018
New Revision: 343126
URL: http://llvm.org/viewvc/llvm-project?rev=343126&view=rev
Log:
[X86] For lzcnt/tzcnt intrinsics use cttz/ctlz intrinsics with zero_undef flag
set to false.
Previously we used a select and the zero_undef=true intrinsic. In -O2
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343126: [X86] For lzcnt/tzcnt intrinsics use cttz/ctlz
intrinsics with zero_undef flag… (authored by ctopper, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52392?vs=166606&id=167159
Sounds great, thanks!
On Wed, Sep 26, 2018 at 8:33 AM Hans Wennborg via Phabricator via
cfe-commits wrote:
> hans added inline comments.
>
>
>
> Comment at: include/clang/Driver/CLCompatOptions.td:94
> +def : CLFlag<"Gs">, HelpText<"Use stack probes (default)">,
> + Alias, Alia
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:109
+- New :doc:`misc-class-inherit-from-struct
+ ` check.
Please use alphabetical order for new checks list.
Comment at: docs/clang-tidy/checks/misc-class-inherit-from-
george.karpenkov added a comment.
@jroelofs Thanks, but in general code owners would need to take a look as well.
@lebedev.ri The code looks great, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52530
___
cfe-commits mailing list
cfe-com
janosimas requested review of this revision.
janosimas added inline comments.
Comment at: clang-tidy/tool/clang-tidy-diff.py:123-130
if args.fix:
command.append('-fix')
if args.checks != '':
command.append('-checks=' + quote + args.checks + quote)
if args.quiet
janosimas added inline comments.
Comment at: clang-tidy/tool/clang-tidy-diff.py:123-130
if args.fix:
command.append('-fix')
if args.checks != '':
command.append('-checks=' + quote + args.checks + quote)
if args.quiet:
command.append('-quiet')
if args.bu
rnk added inline comments.
Comment at: lib/Driver/Driver.cpp:492
+ .Case("64", Target.get64BitArchVariant())
+ .Default(Target);
+
We should emit a diagnostic for invalid -mabi=values.
Repository:
rC Clang
https://reviews.llvm
Author: rsmith
Date: Wed Sep 26 12:00:16 2018
New Revision: 343131
URL: http://llvm.org/viewvc/llvm-project?rev=343131&view=rev
Log:
P1008R1 Classes with user-declared constructors are never aggregates in
C++20.
Added:
cfe/trunk/test/SemaCXX/cxx2a-compat.cpp
cfe/trunk/test/SemaCXX/cxx2a-i
lebedev.ri added inline comments.
Comment at: test/clang-tidy/misc-class-inherit-from-struct.cpp:13
+};
+
+class C
lebedev.ri wrote:
> Missing cases:
> * struct inheriting from struct
> * Different inheritance visibility:
> * You only check the default visibili
gtbercea updated this revision to Diff 167172.
gtbercea edited the summary of this revision.
gtbercea added a comment.
Only change default schedule for distribute directive.
Repository:
rC Clang
https://reviews.llvm.org/D52434
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRu
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9199
+ OpenMPDistScheduleClauseKind *ScheduleKind, llvm::Value *&Chunk) const {
+ return;
+}
Remove `return;`, it is not required
Comment at: lib/CodeGen/CGOpenMPR
Hahnfeld added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D51686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay added a comment.
In https://reviews.llvm.org/D50294#1245454, @emaste wrote:
> I'm using this change:
> https://github.com/emaste/freebsd/commit/1c3deab6d518feb1a7e88de5b342a139e4022a21
>
> In FreeBSD 12 and later we use Clang, lld, and ELF Tool Chain. (We still have
> gas and objdump fr
mstorsjo added a comment.
Also, I notice that ubsan also is built for windows, but in the MSVC toolchain,
only asan (and libfuzzer) can be enabled, not ubsan. Is there something else
missing for ubsan, or what's the matter with that one?
Repository:
rC Clang
https://reviews.llvm.org/D52538
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:515
+ if (Arg *A = Args.getLastArg(options::OPT_libomptarget_nvptx_path_EQ))
+CmdArgs.push_back(Args.MakeArgString(Twine("-L") + A->getValue()));
+
`const Arg *A`
Co
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:665
+// Add path to lib / lib64 folder.
+SmallString<256> DefaultLibPath =
ABataev wrote:
> You're changing the order of the lookup for the paths. Is this intended? If
> so, you
mstorsjo created this revision.
mstorsjo added reviewers: dmajor, mgrang, ssijaric, rnk, compnerd.
Herald added subscribers: chrib, kristof.beyls.
This fixes PR39090.
Repository:
rC Clang
https://reviews.llvm.org/D52571
Files:
lib/Sema/SemaChecking.cpp
test/SemaCXX/microsoft-varargs.cpp
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D52571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
atanasyan added inline comments.
Comment at: lib/Driver/Driver.cpp:492
+ .Case("64", Target.get64BitArchVariant())
+ .Default(Target);
+
rnk wrote:
> We should emit a diagnostic for invalid -mabi=values.
We already do that:
$ cl
erik.pilkington created this revision.
erik.pilkington added reviewers: xbolva00, kristina, asb.
Herald added subscribers: kadircet, jocewei, PkmX, dexonsmith, the_o,
brucehoult, MartinMosbeck, rogfer01, mgrang, edward-jones, zzheng, jrtc27,
ioeric, niosHD, sabuasal, apazos, simoncook, johnrusso,
I put a patch up to fix this here: https://reviews.llvm.org/D52574
Please take these warnings more seriously next time. It's the
committer's responsibility to fix these warnings [1], and they often
identify legitimate issues in the patch.
Thanks,
Erik
[1]: https://llvm.org/docs/DeveloperPoli
MaskRay created this revision.
MaskRay added a reviewer: rsmith.
Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang.
The convenience wrapper in STLExtras is available since
https://reviews.llvm.org/rL342102.
Repository:
rC Clang
https://reviews.llvm.org/D52576
Files:
lib/AS
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Lgtm, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
aaronpuchert created this revision.
aaronpuchert added reviewers: aaron.ballman, delesley.
Herald added a subscriber: cfe-commits.
The pattern is problematic with C++ exceptions, and not as widespread as
scoped locks, but it's still used by some, for example Chromium.
We are a bit stricter here a
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks for the cleanup! Maybe consider running `clang-format-diff` on this?
Comment at: lib/Sema/SemaOverload.cpp:10813-10814
- llvm::sort(Cands.begin(), Cands.end(),
+ l
aaronpuchert added a comment.
See the bug for further discussion. I'm not sure if we want to have this, but
if the pattern is used more widely it might make sense. It blows up the code a
bit, although I hope that https://reviews.llvm.org/D51187 might reduce it again.
Repository:
rC Clang
ht
MaskRay updated this revision to Diff 167206.
MaskRay added a comment.
Reflow nearby statements as rsmith@ requested:
git diff -U0 --no-color 'HEAD^' |
~/llvm/tools/clang/tools/clang-format/clang-format-diff.py -i -p1
Repository:
rC Clang
https://reviews.llvm.org/D52576
Files:
lib/AST/It
Author: maskray
Date: Wed Sep 26 15:16:28 2018
New Revision: 343147
URL: http://llvm.org/viewvc/llvm-project?rev=343147&view=rev
Log:
llvm::sort(C.begin(), C.end(), ...) -> llvm::sort(C, ...)
Summary: The convenience wrapper in STLExtras is available since rL342102.
Reviewers: rsmith, #clang, db
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343147: llvm::sort(C.begin(), C.end(), ...) ->
llvm::sort(C, ...) (authored by MaskRay, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52576
Fil
Author: hsiangkai
Date: Wed Sep 26 15:18:45 2018
New Revision: 343148
URL: http://llvm.org/viewvc/llvm-project?rev=343148&view=rev
Log:
[DebugInfo] Generate debug information for labels.
Generate DILabel metadata and call llvm.dbg.label after label
statement to associate the metadata with the lab
Author: vitalybuka
Date: Wed Sep 26 15:58:53 2018
New Revision: 343150
URL: http://llvm.org/viewvc/llvm-project?rev=343150&view=rev
Log:
Init LookupResult::AmbiguityKind
We don't expect useful value there unless it's "ambiguous".
However we use read it for copying and moving, so we need either in
Author: maskray
Date: Wed Sep 26 16:47:00 2018
New Revision: 343152
URL: http://llvm.org/viewvc/llvm-project?rev=343152&view=rev
Log:
Remove trailing space in rC343150
Modified:
cfe/trunk/include/clang/Sema/Lookup.h
Modified: cfe/trunk/include/clang/Sema/Lookup.h
URL:
http://llvm.org/viewvc
aaron.ballman added a comment.
This generally looks sensible to me.
Comment at: lib/Analysis/ThreadSafety.cpp:1970
+ // There can be default arguments, so we stop when one iterator is at end().
+ for (auto Arg = ArgBegin; Param != Params.end() && Arg != ArgEnd;
+ ++Para
smeenai created this revision.
smeenai added reviewers: compnerd, rjmccall, theraven, DHowett-MSFT.
As discussed in https://reviews.llvm.org/D50144, we want Obj-C classes
to have the same mangling as C++ structs, to support headers like the
following:
#ifdef __OBJC__
@class I;
#else
struc
vitalybuka added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:305
enum ImplicitConversionCheckKind : unsigned char {
-ICCK_IntegerTruncation = 0,
+ICCK_IntegerTruncation = 0, // Legacy, no longer used.
+ICCK_UnsignedIntegerTruncation = 1,
-
owenpan updated this revision to Diff 167225.
owenpan added a comment.
Updated ClangFormatStyleOptions.rst.
Repository:
rC Clang
https://reviews.llvm.org/D52527
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineParser.
Author: george.karpenkov
Date: Wed Sep 26 18:10:59 2018
New Revision: 343158
URL: http://llvm.org/viewvc/llvm-project?rev=343158&view=rev
Log:
[analyzer] [testing] Pass through an extra argument for specifying extra
analyzer options
Differential Revision: https://reviews.llvm.org/D52585
Modifie
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343158: [analyzer] [testing] Pass through an extra argument
for specifying extra… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://
craig.topper created this revision.
craig.topper added reviewers: spatel, RKSimon.
These intrinsics exist in icc. They can be found on the Intel Intrinsics Guide
website.
All the backend support is in place to pattern match a load+bswap or a
bswap+store pattern to the MOVBE instructions. So we
Author: george.karpenkov
Date: Wed Sep 26 18:45:57 2018
New Revision: 343159
URL: http://llvm.org/viewvc/llvm-project?rev=343159&view=rev
Log:
[analyzer] [NFC] Heavy refactoring of trackNullOrUndefValue
Differential Revision: https://reviews.llvm.org/D52519
Modified:
cfe/trunk/include/clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343159: [analyzer] [NFC] Heavy refactoring of
trackNullOrUndefValue (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343159: [analyzer] [NFC] Heavy refactoring of
trackNullOrUndefValue (authored by george.karpenkov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
Author: george.karpenkov
Date: Wed Sep 26 18:46:18 2018
New Revision: 343160
URL: http://llvm.org/viewvc/llvm-project?rev=343160&view=rev
Log:
[analyzer] [NFC] Move the code for dumping the program point to ProgramPoint
So we can dump them outside of viewing the exploded grpah.
Differential Revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343160: [analyzer] [NFC] Move the code for dumping the
program point to ProgramPoint (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https
Higuoxing added a comment.
Ping. Now, this patch could give fix-it note on parentheses in macros.
https://reviews.llvm.org/D47687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kent08ian added a comment.
Herald added a subscriber: dexonsmith.
In https://reviews.llvm.org/D10833#1109371, @kent08ian wrote:
> In https://reviews.llvm.org/D10833#970906, @milianw wrote:
>
> > still looks good to me. can someone else please review and commit this?
>
>
> Ping
Any updates on th
Author: maskray
Date: Wed Sep 26 21:19:29 2018
New Revision: 343166
URL: http://llvm.org/viewvc/llvm-project?rev=343166&view=rev
Log:
llvm::sort(C.begin(), C.end()) -> llvm::sort(C)
The convenience wrapper in STLExtras is available since rL342102.
Modified:
clang-tools-extra/trunk/clang-tidy
Author: maskray
Date: Wed Sep 26 21:23:24 2018
New Revision: 343168
URL: http://llvm.org/viewvc/llvm-project?rev=343168&view=rev
Log:
[clang-tidy] Add dependency to clangAnalysis after rC343160
Modified:
clang-tools-extra/trunk/clang-tidy/mpi/CMakeLists.txt
Modified: clang-tools-extra/trunk/
atanasyan added a comment.
Thanks for review.
Repository:
rC Clang
https://reviews.llvm.org/D52290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: atanasyan
Date: Wed Sep 26 22:04:50 2018
New Revision: 343169
URL: http://llvm.org/viewvc/llvm-project?rev=343169&view=rev
Log:
[driver][mips] Adjust target triple accordingly to provided ABI name
Explicitly selected MIPS ABI using the `-mabi` option implies
corresponding target triple. F
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343169: [driver][mips] Adjust target triple accordingly to
provided ABI name (authored by atanasyan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
mprobst updated this revision to Diff 167239.
mprobst added a comment.
- comment in test
Repository:
rC Clang
https://reviews.llvm.org/D52536
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
=
Author: mprobst
Date: Wed Sep 26 23:48:13 2018
New Revision: 343179
URL: http://llvm.org/viewvc/llvm-project?rev=343179&view=rev
Log:
clang-format: [JS] conditional types.
Summary:
This change adds some rudimentary support for conditional types.
Specifically it avoids breaking before `extends` an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343179: clang-format: [JS] conditional types. (authored by
mprobst, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52536
Files:
cfe/trunk/lib/
101 - 156 of 156 matches
Mail list logo
