ldionne added a comment.
Was this true pre-C11 too? If not, then this needs to be guarded by `#if
_LIBCPP_STD_VER >= 17`, because C++ is only on top of C11 in C++17 and above
(Marshall can double-check this).
Repository:
rCXX libc++
https://reviews.llvm.org/D52401
___
MaskRay added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:275
+os << "sizeof(" << DstName << ")";
+ else
+os << "sizeof()";
devnexen wrote:
> MaskRay wrote:
> > Why can't this `else if` case be folded int
devnexen added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:275
+os << "sizeof(" << DstName << ")";
+ else
+os << "sizeof()";
MaskRay wrote:
> devnexen wrote:
> > MaskRay wrote:
> > > Why can't this `else
devnexen updated this revision to Diff 166628.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
--- test/Analysi
MaskRay updated this revision to Diff 166629.
MaskRay edited the summary of this revision.
MaskRay added a comment.
Also remove the check for _aligned_free
Repository:
rCXX libc++
https://reviews.llvm.org/D52401
Files:
src/new.cpp
Index: src/new.cpp
==
devnexen accepted this revision.
devnexen added a comment.
This revision is now accepted and ready to land.
LGTM to me
Repository:
rC Clang
https://reviews.llvm.org/D52331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich.
Herald added subscribers: cfe-commits, mgorny.
Herald added a reviewer: EricWF.
This is a workaround for PR39053 which was uncovered by
https://reviews.llvm.org/D50652 when
the default attribute has been changed from in
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm as long as we revert when the underlying bugs are resovled
Repository:
rC Clang
https://reviews.llvm.org/D52402
___
cfe-commits maili
MaskRay accepted this revision.
MaskRay added a comment.
LG
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: maskray
Date: Sun Sep 23 01:23:48 2018
New Revision: 342831
URL: http://llvm.org/viewvc/llvm-project?rev=342831&view=rev
Log:
[Index] Report specialization bases as references when
IndexImplicitInstantiation is true
Summary:
template struct B {};
template struct D : B {}; // `B
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342831: [Index] Report specialization bases as references
when… (authored by MaskRay, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52331
Files
MaskRay updated this revision to Diff 166632.
MaskRay edited the summary of this revision.
MaskRay added a comment.
Quote C89: "If ptr is a null pointer, no action occurs."
Repository:
rCXX libc++
https://reviews.llvm.org/D52401
Files:
src/new.cpp
Index: src/new.cpp
=
Author: devnexen
Date: Sun Sep 23 01:30:17 2018
New Revision: 342832
URL: http://llvm.org/viewvc/llvm-project?rev=342832&view=rev
Log:
[CStringSyntaxChecker] Check strlcat sizeof check
Assuming strlcat is used with strlcpy we check as we can if the last argument
does not equal os not larger tha
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342832: [CStringSyntaxChecker] Check strlcat sizeof check
(authored by devnexen, committed by ).
Repository:
rC Clang
MaskRay added a comment.
In https://reviews.llvm.org/D52401#1243054, @ldionne wrote:
> Was this true pre-C11 too? If not, then this needs to be guarded by `#if
> _LIBCPP_STD_VER >= 17`, because C++ is only on top of C11 in C++17 and above
> (Marshall can double-check this).
Thanks for the not
Author: phosek
Date: Sun Sep 23 01:46:31 2018
New Revision: 342833
URL: http://llvm.org/viewvc/llvm-project?rev=342833&view=rev
Log:
[CMake] Use internal_linkage rather than always_inline for libc++
This is a workaround for PR39053 which was uncovered by D50652 when
the default attribute has been
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342833: [CMake] Use internal_linkage rather than
always_inline for libc++ (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52402?vs=166630&id=166634#toc
Repositor
Author: szelethus
Date: Sun Sep 23 02:16:27 2018
New Revision: 342834
URL: http://llvm.org/viewvc/llvm-project?rev=342834&view=rev
Log:
[analyzer][UninitializedObjectChecker] Using the new const methods of
ImmutableList
Differential Revision: https://reviews.llvm.org/D51886
Modified:
cfe/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342834: [analyzer][UninitializedObjectChecker] Using the new
const methods of… (authored by Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51886
Files:
lib/StaticAnalyzer/
theraven added a comment.
In https://reviews.llvm.org/D52344#1242530, @rjmccall wrote:
> In https://reviews.llvm.org/D52344#1242451, @kristina wrote:
>
> > Would you be okay with me renaming `cfstring` to `.cfstring` for ELF so
> > it's in line with ELF section naming conventions (I'm not entire
JonasToth added a comment.
Friendly ping :)
Can i land all the test changes, or do you want to review them? The pattern
will be the same, I just want them in different commits to revert better if
something changes on different platforms.
Repository:
rCTE Clang Tools Extra
https://reviews.ll
RKSimon added a comment.
Are there other targets that would benefit from this and if so should we
provide a more generic intrinsic?
Repository:
rC Clang
https://reviews.llvm.org/D52392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
On Sun, Sep 23, 2018 at 5:39 AM David Chisnall via Phabricator <
revi...@reviews.llvm.org> wrote:
> theraven added a comment.
>
> In https://reviews.llvm.org/D52344#1242530, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D52344#1242451, @kristina wrote:
> >
> > > Would you be okay with me rena
Author: meinersbur
Date: Sun Sep 23 23:31:37 2018
New Revision: 342861
URL: http://llvm.org/viewvc/llvm-project?rev=342861&view=rev
Log:
Add inherited attributes before parsed attributes.
Currently, attributes from previous declarations ('inherited attributes')
are added to the end of a declarati
24 matches
Mail list logo
