[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

This revision was automatically updated to reflect the committed changes. Closed by commit rC342409: [analyzer] Treat std::{move,forward} as casts in ExprMutationAnalyzer. (authored by shuaiwang, committed by ). Changed prior to commit: https://reviews.llvm.org/D52120?vs=165801&id=165813#toc R

[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342409: [analyzer] Treat std::{move,forward} as casts in ExprMutationAnalyzer. (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

george.karpenkov added a comment. @NoQ Actually I agree with @baloghadamsoftware that it makes sense to have a separate test, as this functionality should be tested regardless of svalbuilder-rearrange-comparisons existence. https://reviews.llvm.org/D52133 ___

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

NoQ marked an inline comment as done. NoQ added a comment. In https://reviews.llvm.org/D52133#1237312, @george.karpenkov wrote: > @NoQ Actually I agree with @baloghadamsoftware that it makes sense to have a > separate test, as this functionality should be tested regardless of > svalbuilder-rear

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

NoQ added a comment. Mm, i mean, that reason as good as well. https://reviews.llvm.org/D52133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

george.karpenkov accepted this revision. george.karpenkov added inline comments. This revision is now accepted and ready to land. Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:273 + + for (auto I : State->get()) { +SymbolRef Sym = I.first; ---

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:388 &NamingStyles) { + assert(D->getIdentifier() && !D->getName().empty() && !D->isImplicit() && + "Decl must be an explicit identifier with a na

[PATCH] D52189: [analyzer] Fix a crash regression on casting opaque symbolic pointers from unrelated base classes to derived classes.

NoQ updated this revision to Diff 165821. NoQ added a comment. Add a bit more discussion into the comments. https://reviews.llvm.org/D52189 Files: lib/StaticAnalyzer/Core/Store.cpp test/Analysis/casts.cpp Index: test/Analysis/casts.cpp =

[PATCH] D52189: [analyzer] Fix a crash regression on casting opaque symbolic pointers from unrelated base classes to derived classes.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, baloghadamsoftware. Commit https://reviews.llvm.org/D51191 causes a crash when a pointer to a completely unrela

[PATCH] D51886: [analyzer][UninitializedObjectChecker] Using the new const methods of ImmutableList

Szelethus added a comment. Ping :) Repository: rC Clang https://reviews.llvm.org/D51886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51866: [analyzer][UninitializedObjectChecker][WIP] New flag to ignore guarded uninitialized fields

Szelethus added a comment. @george.karpenkov @xazax.hun, is this how you imagined checking whether an access is guarded? Repository: rC Clang https://reviews.llvm.org/D51866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

r342413 - [analyzer] ExplodedGraph printing fixes

Author: george.karpenkov Date: Mon Sep 17 13:46:53 2018 New Revision: 342413 URL: http://llvm.org/viewvc/llvm-project?rev=342413&view=rev Log: [analyzer] ExplodedGraph printing fixes Fixes a number of issues: - Global variables are not used for communication - Trait should be defined on a grap

[PATCH] D51886: [analyzer][UninitializedObjectChecker] Using the new const methods of ImmutableList

NoQ accepted this revision. NoQ added a comment. Hmm, how did i miss it? Repository: rC Clang https://reviews.llvm.org/D51886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52183: [analyzer] ExplodedGraph printing fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rC342413: [analyzer] ExplodedGraph printing fixes (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D52183?vs=165818&

[PATCH] D51866: [analyzer][UninitializedObjectChecker][WIP] New flag to ignore guarded uninitialized fields

george.karpenkov added a comment. Thanks! The usual question: would it be easier to implement using AST matchers? Repository: rC Clang https://reviews.llvm.org/D51866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

srhines created this revision. srhines added a reviewer: dblaikie. Herald added a subscriber: cfe-commits. As part of r342165, I rewrote the logic to check whether -fno-omit-frame-pointer was passed after a -fomit-frame-pointer argument. This CL switches that logic to use the consolidated shouldUs

[PATCH] D51866: [analyzer][UninitializedObjectChecker][WIP] New flag to ignore guarded uninitialized fields

Szelethus added a comment. I played around with it, and this seemed a bit cleaner. Since I would only match against the definition of the record (and the definition of its methods), the matcher would need to look like this: `stmt(hasDescendant(blahBlah(...)))`, and I'd only be able to retrieve

[clang-tools-extra] r342417 - [clang-tidy] Fix tests for performance-for-range-copy

Author: shuaiwang Date: Mon Sep 17 14:28:08 2018 New Revision: 342417 URL: http://llvm.org/viewvc/llvm-project?rev=342417&view=rev Log: [clang-tidy] Fix tests for performance-for-range-copy Test failed as D52120 made ExprMutationAnalyzer smarter, fixed by: - Add move-ctor for `Mutable` to make it

[PATCH] D52141: Thread safety analysis: Run more tests with capability attributes [NFC]

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Makes sense to me. Thanks for the review! Repository: rC Clang https://reviews.llvm.org/D52141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea created this revision. aganea added reviewers: rnk, hans, zturner. Herald added a reviewer: JDevlieghere. Herald added a subscriber: cfe-commits. This is very preliminary change which adds support for (`clang-cl`) `/MP` (Build with multiple processes). Doc for `/MP` is here

r342418 - Thread safety analysis: Run more tests with capability attributes [NFC]

Author: aaronpuchert Date: Mon Sep 17 14:37:22 2018 New Revision: 342418 URL: http://llvm.org/viewvc/llvm-project?rev=342418&view=rev Log: Thread safety analysis: Run more tests with capability attributes [NFC] Summary: We run the tests for -Wthread-safety-{negative,verbose} with the new attribut

[PATCH] D52141: Thread safety analysis: Run more tests with capability attributes [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rC342418: Thread safety analysis: Run more tests with capability attributes [NFC] (authored by aaronpuchert, committed by ). Changed prior to commit: https://reviews.llvm.org/D52141?vs=165662&id=165835#to

[PATCH] D51910: [Modules] Add platform feature to requires clause

bruno added inline comments. Comment at: docs/Modules.rst:476-477 + +*platform-environment* + A platform-environment variant (e.g. ``linux-gnueabi``, ``windows-msvc``) is available. rsmith wrote: > What is the reason to allow these to be combined into a singl

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

vsapsai added a comment. @dexonsmith, does my change address your concerns? https://reviews.llvm.org/D30882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM too. https://reviews.llvm.org/D30882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

zturner added a reviewer: rsmith. zturner added a comment. What about the timings of clang-cl without /MP? Repository: rC Clang https://reviews.llvm.org/D52193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

tra updated this revision to Diff 165841. tra added a comment. - Check that D is non-null https://reviews.llvm.org/D52179 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp Index: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp =

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

tra marked an inline comment as done. tra added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:551-552 if (Decl->isMain() || !Decl->isUserProvided() || -Decl->isUsualDeallocationFunction() || -Decl->isCopyAssi

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

tra added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:388 &NamingStyles) { + assert(D && D->getIdentifier() && !D->getName().empty() && !D->isImplicit() && + "Decl must be an explicit identifier with a name."

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley, lukasza. Herald added a subscriber: cfe-commits. This imitates the code for MemberExpr. I hope it is right, for I have absolutely no understanding of ObjC++. Fixes 38896. Repository: rC Clang https://r

[PATCH] D52189: [analyzer] Fix a crash regression on casting opaque symbolic pointers from unrelated base classes to derived classes.

NoQ updated this revision to Diff 165854. NoQ added a comment. Add a defensive check that prevents more crashes if the source type is not a class at all. https://reviews.llvm.org/D52189 Files: lib/StaticAnalyzer/Core/Store.cpp test/Analysis/casts.cpp Index: test/Analysis/casts.cpp ==

[PATCH] D51910: [Modules] Add platform feature to requires clause

bruno updated this revision to Diff 165861. bruno added a comment. Update patch after review. https://reviews.llvm.org/D51910 Files: docs/Modules.rst lib/Basic/Module.cpp test/Modules/target-platform-features.m Index: test/Modules/target-platform-features.m ==

[PATCH] D52218: Warn on self-initializations

rtrieu created this revision. Improve some diagnostics around self-initialization. The uninitialized checker does not warn on self-initialization, but does warn later if the variable is used. GCC also has a -Winit-self which will enable a -Wuninitialized warning for self-initialized. -Winit-

[PATCH] D51910: [Modules] Add platform feature to requires clause

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Basic/Module.cpp:81 + // 2, Environment + // 3. Platform-Environment + if (Platform == Feature || Target.getTriple().getOSName() == Feature ||

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

shuaiwang created this revision. shuaiwang added reviewers: JonasToth, aaron.ballman. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin, szepet, xazax.hun. Herald added a reviewer: george.karpenkov. We handle pointee mutation for native pointers & pointer-like types (lo

[clang-tools-extra] r342445 - [pp-trace] Remove unused using directives

Author: maskray Date: Mon Sep 17 23:57:58 2018 New Revision: 342445 URL: http://llvm.org/viewvc/llvm-project?rev=342445&view=rev Log: [pp-trace] Remove unused using directives Modified: clang-tools-extra/trunk/pp-trace/PPTrace.cpp Modified: clang-tools-extra/trunk/pp-trace/PPTrace.cpp URL:

<    1   2